)]}'
{"id":"openocd~master~Iea6e5910ee17f2b3635c7fc67c4eaa8add5d1b4e","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"last_update":"2026-08-21 16:29:21.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}}},"hashtags":[],"change_id":"Iea6e5910ee17f2b3635c7fc67c4eaa8add5d1b4e","subject":"jtag/drivers/cmsis_dap: fix possible buffer overflow","status":"MERGED","created":"2026-08-21 09:44:08.000000000","updated":"2026-09-14 08:02:58.000000000","submitted":"2026-09-14 08:02:58.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9856","meta_rev_id":"2d161fabd3ffda008b1c1254d61ea70cb0ce469b","_number":9856,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-09-14 08:02:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-09-14 08:02:58.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-09-14 08:02:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-08-21 11:14:49.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-08-21 11:36:00.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-08-21 15:43:25.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"8d9e177aff8fd4e44c802524980c3961be540df4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-08-21 09:44:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6f7c939ca9e7d6a38a38dd9d456e6f6bf3b3efda","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-08-21 11:36:00.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/23770/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/22858/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"ffa6690842b13c40a660bea7837f1d500ee31caa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-08-21 12:49:01.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"c82b372007544715ae13a02b555206ca4cbe25dd","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-08-21 15:43:25.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"95599b7a6553fdf93e61b6276d42d271d29232d1","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-08-21 15:57:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/23785/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/22872/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"746cfba9c0a36753423e3a54eabe3f82ae9b158f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-08-21 16:29:21.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"bfdf6e887bd393f0f03d28ad7ef307f13c8e30f3","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-07 10:18:21.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2d161fabd3ffda008b1c1254d61ea70cb0ce469b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-14 08:02:58.000000000","message":"Change has been successfully cherry-picked as 1f3f5831d25f58dbeed8de4ad6627c75e774bd2c","accounts_in_message":[],"_revision_number":3}],"current_revision":"1f3f5831d25f58dbeed8de4ad6627c75e774bd2c","revisions":{"1f3f5831d25f58dbeed8de4ad6627c75e774bd2c":{"kind":"REWORK","_number":3,"created":"2026-09-14 08:02:58.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/56/9856/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/9856/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/9856/3 \u0026\u0026 git checkout -b change-9856 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/9856/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/9856/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/9856/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/9856/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/9856/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"54a33aeab039b7eaad7a9ee5856ed2235800e0b1","subject":"flash/nor: drop some exit() calls"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-08-21 07:54:15.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-14 08:02:58.000000000","tz":0},"subject":"jtag/drivers/cmsis_dap: fix possible buffer overflow","message":"jtag/drivers/cmsis_dap: fix possible buffer overflow\n\nThe adapter response of CMD_SWO_Data command relied on well behaved\nadapter firmware. In case of malicious modification of adapter firmware\nor accidentally getting the response of another CMSIS-DAP command,\ncmsis_dap_cmd_dap_swo_data() could copy more data than max_trace_count.\n\nLimit the returned trace_data with max_trace_count.\nAlso check if trace_count (trace data size) fits into the adapter response.\n\nChange-Id: Iea6e5910ee17f2b3635c7fc67c4eaa8add5d1b4e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9856\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"97ecf830e45fd096601c4ca871011d0d21c5ac03":{"kind":"REWORK","_number":2,"created":"2026-08-21 12:49:01.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/56/9856/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/9856/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/9856/2 \u0026\u0026 git checkout -b change-9856 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/9856/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/9856/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/9856/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/9856/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/9856/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e6bfe3304ca3f2d23f9901744494ed858f073f08","subject":"jtag/drivers/cmsis_dap: add adapter response size checks"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-08-21 07:54:15.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-08-21 12:48:42.000000000","tz":120},"subject":"jtag/drivers/cmsis_dap: fix possible buffer overflow","message":"jtag/drivers/cmsis_dap: fix possible buffer overflow\n\nThe adapter response of CMD_SWO_Data command relied on well behaved\nadapter firmware. In case of malicious modification of adapter firmware\nor accidentally getting the response of another CMSIS-DAP command,\ncmsis_dap_cmd_dap_swo_data() could copy more data than max_trace_count.\n\nLimit the returned trace_data with max_trace_count.\nAlso check if trace_count (trace data size) fits into the adapter response.\n\nChange-Id: Iea6e5910ee17f2b3635c7fc67c4eaa8add5d1b4e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"02f9a6f0ae08e7fadc4e737c0fcaa54dd231d411":{"kind":"REWORK","_number":1,"created":"2026-08-21 09:44:08.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/56/9856/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/56/9856/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/56/9856/1 \u0026\u0026 git checkout -b change-9856 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/56/9856/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/56/9856/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/56/9856/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/56/9856/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/56/9856/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e6bfe3304ca3f2d23f9901744494ed858f073f08","subject":"jtag/drivers/cmsis_dap: add adapter response size checks"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-08-21 07:54:15.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-08-21 09:20:53.000000000","tz":120},"subject":"jtag/drivers/cmsis_dap: fix possible buffer overflow","message":"jtag/drivers/cmsis_dap: fix possible buffer overflow\n\nThe adapter response of CMD_SWO_Data command relied on well behaved\nadapter firmware. In case of malicious modification of adapter firmware\nor accidentally getting the response of another CMSIS-DAP command,\ncmsis_dap_cmd_dap_swo_data() could copy more data than max_trace_count.\n\nLimit the returned trace_data with max_trace_count.\nAlso check if trace_count (trace data size) fits into the adapter response.\n\nChange-Id: Iea6e5910ee17f2b3635c7fc67c4eaa8add5d1b4e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}