)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"8cda11750b2bfc473d464072de1ac474b97d9d83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eb97618f_732b5a9a","updated":"2026-08-31 23:04:09.000000000","message":"Thanks for the fix.  It looks reasonable, although it will only resolve Ax and ARx registers on windowed configs.  \n\nCall0 configs will not run this code path--do you happen to have any call0 options to test on (no worries if you don\u0027t)?  I\u0027m guessing probably not...IIRC all Espressif configs are windowed?","commit_id":"2993ffc66ce2094830919ec318252914c018cc1c"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"2cbd8616e9dfa36dbc238a0a09409e30eb333e37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"61b4f2e4_2e316260","updated":"2026-08-31 13:30:50.000000000","message":"Thanks! Looks good.","commit_id":"2993ffc66ce2094830919ec318252914c018cc1c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"235c5389bde919db441d1db58f6242067a884130","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8814f218_0d51c8be","in_reply_to":"4ceab619_740824ce","updated":"2026-09-01 14:47:34.000000000","message":"Ack","commit_id":"2993ffc66ce2094830919ec318252914c018cc1c"},{"author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"change_message_id":"3e3051e6d6fa7f3a7e842b8dd161214f40783877","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4ceab619_740824ce","in_reply_to":"eb97618f_732b5a9a","updated":"2026-09-01 09:55:42.000000000","message":"Thanks for checking Ian. Yes, I think you are right we only use windowed configs. If `xtensa-\u003ecore_config-\u003ewindowed \u003d\u003d false` though, it seems only `aX` are written, so this issue probably does not come up.\n\nFYI I was originally testing write_dirty+fetch_all approach in algo_start, which should be foolproof. But that was causing some random exceptions, I believe because debugcause register was getting updated. So chose more conservative approach with just write_dirty in the end.","commit_id":"2993ffc66ce2094830919ec318252914c018cc1c"},{"author":{"_account_id":1001982,"name":"Ian Thompson","email":"ianst@cadence.com","username":"ianstcdns"},"change_message_id":"235c5389bde919db441d1db58f6242067a884130","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6762b255_cec82179","updated":"2026-09-01 14:47:34.000000000","message":"Thank you for the cleanup as well","commit_id":"6c7d79adaba93c2ddbfa29e1c6d2053dd975f832"}],"src/target/xtensa/xtensa.c":[{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"105c7be77acb9a0173ef2d8a6ee8f13f84561cb4","unresolved":true,"context_lines":[{"line_number":2747,"context_line":""},{"line_number":2748,"context_line":"\tretval \u003d xtensa_write_dirty_registers(target);"},{"line_number":2749,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":2750,"context_line":"\t\tLOG_ERROR(\"Failed to write dirty regs (%d)!\", retval);"},{"line_number":2751,"context_line":"\t\treturn retval;"},{"line_number":2752,"context_line":"\t}"},{"line_number":2753,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"a825377c_817aeeb4","line":2750,"updated":"2026-09-01 06:32:14.000000000","message":"Remove the exclamation mark please, see https://openocd.org/doc/doxygen/html/stylec.html","commit_id":"2993ffc66ce2094830919ec318252914c018cc1c"},{"author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"change_message_id":"3e4e82aa7f4c11eba2259d81d2255e281a3c3d4f","unresolved":false,"context_lines":[{"line_number":2747,"context_line":""},{"line_number":2748,"context_line":"\tretval \u003d xtensa_write_dirty_registers(target);"},{"line_number":2749,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":2750,"context_line":"\t\tLOG_ERROR(\"Failed to write dirty regs (%d)!\", retval);"},{"line_number":2751,"context_line":"\t\treturn retval;"},{"line_number":2752,"context_line":"\t}"},{"line_number":2753,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8e655e1d_97543d4a","line":2750,"in_reply_to":"48dcbda8_b2d34476","updated":"2026-09-01 11:11:35.000000000","message":"done","commit_id":"2993ffc66ce2094830919ec318252914c018cc1c"},{"author":{"_account_id":1001803,"name":"Samuel Obuch","email":"samuel.obuch@espressif.com","username":"sobuch"},"change_message_id":"ab63e3e65e844a8c4da433751c91e74de9ddb8c6","unresolved":true,"context_lines":[{"line_number":2747,"context_line":""},{"line_number":2748,"context_line":"\tretval \u003d xtensa_write_dirty_registers(target);"},{"line_number":2749,"context_line":"\tif (retval !\u003d ERROR_OK) {"},{"line_number":2750,"context_line":"\t\tLOG_ERROR(\"Failed to write dirty regs (%d)!\", retval);"},{"line_number":2751,"context_line":"\t\treturn retval;"},{"line_number":2752,"context_line":"\t}"},{"line_number":2753,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":2,"id":"48dcbda8_b2d34476","line":2750,"in_reply_to":"a825377c_817aeeb4","updated":"2026-09-01 11:06:50.000000000","message":"Right, I will fix this one here. We can align the rest of these for xtensa target in https://review.openocd.org/c/openocd/+/9928","commit_id":"2993ffc66ce2094830919ec318252914c018cc1c"}]}
