)]}'
{"id":"openocd~master~I35a0d566c68ecc52ad89822efeb534e3e91ce628","project":"openocd","branch":"master","hashtags":[],"change_id":"I35a0d566c68ecc52ad89822efeb534e3e91ce628","subject":"jtag/drivers: initialize SRST before other signals","status":"MERGED","created":"2026-09-01 09:06:53.000000000","updated":"2026-10-01 20:07:57.000000000","submitted":"2026-10-01 20:07:57.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9927","meta_rev_id":"d2fe839474dd9c704e49a3340ba7b3a0797d8306","_number":9927,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-10-01 20:07:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-10-01 20:07:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-01 09:07:05.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-09-01 09:25:13.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"dcd27ea49940b5cb3032af27a14fc355ab0dc1b4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-01 09:06:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"58b462e250296622edc9929fce413acfe1858af9","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-09-01 09:25:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/23987/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23069/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d4655d1acbad7dfc420ebfdc8ea100598483c8eb","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-22 06:14:42.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d2fe839474dd9c704e49a3340ba7b3a0797d8306","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-01 20:07:57.000000000","message":"Change has been successfully cherry-picked as 221e8fe6c563d75855695581252ea369ce5e993c","accounts_in_message":[],"_revision_number":2}],"current_revision":"221e8fe6c563d75855695581252ea369ce5e993c","revisions":{"221e8fe6c563d75855695581252ea369ce5e993c":{"kind":"REWORK","_number":2,"created":"2026-10-01 20:07:57.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/27/9927/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/27/9927/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/27/9927/2 \u0026\u0026 git checkout -b change-9927 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/27/9927/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/27/9927/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/27/9927/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/27/9927/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/27/9927/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8ff92b68333ad285a034c0c2e7911183173b8065","subject":"jtag/adapter: honour connect_assert_srst in gpio init"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-01 08:52:01.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","date":"2026-10-01 20:07:57.000000000","tz":0},"subject":"jtag/drivers: initialize SRST before other signals","message":"jtag/drivers: initialize SRST before other signals\n\nIf reset is configured with option connect_assert_srst, SRST signal\nshould be asserted early, best before init of other JTAG/SWD signals\nto avoid conflict when both adapter and target device drive\nthe same wire.\n\nChange the order of GPIO initialization in 3 bitbang drivers.\n\nChange-Id: I35a0d566c68ecc52ad89822efeb534e3e91ce628\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9927\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003ctomas.vanek.oocd@gmail.com\u003e\n"}},"ac105ecc34d9d56d228367aabab2c41749441a3c":{"kind":"REWORK","_number":1,"created":"2026-09-01 09:06:53.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/27/9927/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/27/9927/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/27/9927/1 \u0026\u0026 git checkout -b change-9927 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/27/9927/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/27/9927/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/27/9927/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/27/9927/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/27/9927/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7b3f947b7882256631029b42e26eb5da79a4ec6b","subject":"jtag/adapter: honour connect_assert_srst in gpio init"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-01 08:52:01.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-01 09:02:45.000000000","tz":120},"subject":"jtag/drivers: initialize SRST before other signals","message":"jtag/drivers: initialize SRST before other signals\n\nIf reset is configured with option connect_assert_srst, SRST signal\nshould be asserted early, best before init of other JTAG/SWD signals\nto avoid conflict when both adapter and target device drive\nthe same wire.\n\nChange the order of GPIO initialization in 3 bitbang drivers.\n\nChange-Id: I35a0d566c68ecc52ad89822efeb534e3e91ce628\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}
