)]}'
{"id":"openocd~master~I1a53116093402c76afd7b3fc073a41e4a757c1a3","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-09-20 13:41:07.000000000","reason":"Change was submitted"},"1002437":{"account":{"_account_id":1002437,"name":"AlexandraKulyatskaya","email":"a.kulyatskaya@syntacore.com","username":"AlexandraKulyatskaya"},"last_update":"2026-09-20 13:41:07.000000000","reason":"Change was submitted"},"1000853":{"account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"last_update":"2026-09-03 08:55:14.000000000","reason":"\u003cGERRIT_ACCOUNT_1000853\u003e replied on the change","reason_account":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"last_update":"2026-09-03 10:09:24.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}}},"hashtags":[],"change_id":"I1a53116093402c76afd7b3fc073a41e4a757c1a3","subject":"target: deprecate \u0027fast_load\u0027 and \u0027fast_load_image\u0027 commands","status":"MERGED","created":"2026-09-03 08:50:29.000000000","updated":"2026-09-20 13:41:07.000000000","submitted":"2026-09-20 13:41:07.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9953","meta_rev_id":"5c7ec75517b7361565c34d7b8abf75dbc2d9c736","_number":9953,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-09-20 13:41:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-09-20 13:41:07.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-09-20 13:41:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-09-20 13:41:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1002437,"name":"AlexandraKulyatskaya","email":"a.kulyatskaya@syntacore.com","username":"AlexandraKulyatskaya"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},{"_account_id":1002437,"name":"AlexandraKulyatskaya","email":"a.kulyatskaya@syntacore.com","username":"AlexandraKulyatskaya"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-03 08:50:29.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1002437,"name":"AlexandraKulyatskaya","email":"a.kulyatskaya@syntacore.com","username":"AlexandraKulyatskaya"},"state":"REVIEWER"},{"updated":"2026-09-03 08:50:29.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"state":"REVIEWER"},{"updated":"2026-09-03 08:50:29.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"state":"REVIEWER"},{"updated":"2026-09-03 08:50:38.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-09-03 09:07:57.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e2ed1fc9a42202723a45d1e691bbb2f200462fad","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-09-03 08:50:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3e7e559c67e1134f2c09d019df0ebad2a229dce6","author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"real_author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"date":"2026-09-03 08:55:14.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d01b464d7439d1963ae6e4d7c5518bd2e085f065","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-09-03 09:07:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24011/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23093/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"79ed2445d1dafa062cc4d97dd0a95e5bfa6984be","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-09-03 09:09:20.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"099a78d4be74dc0cda0219e7a44f4ef27df606ae","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-03 10:09:24.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5c7ec75517b7361565c34d7b8abf75dbc2d9c736","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-09-20 13:41:07.000000000","message":"Change has been successfully cherry-picked as 95cd013e539fcfd0e223b06f08b5f5786fac5bc2","accounts_in_message":[],"_revision_number":2}],"current_revision":"95cd013e539fcfd0e223b06f08b5f5786fac5bc2","revisions":{"9bd65079910fae671825ec5d10a2c1f790e8a158":{"kind":"REWORK","_number":1,"created":"2026-09-03 08:50:29.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/53/9953/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/9953/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/9953/1 \u0026\u0026 git checkout -b change-9953 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/9953/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/9953/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/9953/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/9953/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/9953/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1adf0eed5e53d32eb7b1feda814037154028694a","subject":"jtag/drivers/angie: flush buffer before executing JTAG_SLEEP"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-09-03 08:24:39.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-09-03 08:24:39.000000000","tz":120},"subject":"target: deprecate \u0027fast_load\u0027 and \u0027fast_load_image\u0027 commands","message":"target: deprecate \u0027fast_load\u0027 and \u0027fast_load_image\u0027 commands\n\nThe pair of commands \u0027fast_load\u0027 and \u0027fast_load_image\u0027 where\nintroduced in 2008 with [1] inside the \u0027ecosboard.c\u0027 file, part of\nthe obsoleted Zylin zy1000 project, then moved to target with [2].\nThe \u0027ecosboard\u0027 code was then dropped in 2012 with [3].\n\nWhile the need to split the phases of file reading by OpenOCD from\ntarget writing was probably relevant in the embedded context of\nusing \u0027ecosboard\u0027, this is now less relevant because OpenOCD runs\nin an OS where file I/O is by far faster than the interactions\nwith the external probe (apart from slow remote filesystems, not\nsuitable for benchmarking).\nTo measure write performance, it\u0027s also much easier creating a Tcl\narray of data and measure the speed of \u0027write_memory\u0027 command.\n\nTo reduce the maintenance effort, deprecate the two commands.\nDrop the commands from the documentation.\n\n[1] commit fb7189761d49 (\"wip\")\n[2] commit 459d03e3bb51 (\"fast_load profiling tool moved to target.c\")\n[3] commit 39650e2273bc (\"ecosboard: delete bit-rotted eCos code\")\n\nChange-Id: I1a53116093402c76afd7b3fc073a41e4a757c1a3\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"95cd013e539fcfd0e223b06f08b5f5786fac5bc2":{"kind":"REWORK","_number":2,"created":"2026-09-20 13:41:07.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/53/9953/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/9953/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/9953/2 \u0026\u0026 git checkout -b change-9953 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/9953/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/9953/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/9953/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/9953/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/9953/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"db48769729840fdc6f3fbdd6cb75a3621e7c7f3a","subject":"server: gdb: add support for \u0027x\u0027 packet"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-09-03 08:24:39.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2026-09-20 13:41:07.000000000","tz":0},"subject":"target: deprecate \u0027fast_load\u0027 and \u0027fast_load_image\u0027 commands","message":"target: deprecate \u0027fast_load\u0027 and \u0027fast_load_image\u0027 commands\n\nThe pair of commands \u0027fast_load\u0027 and \u0027fast_load_image\u0027 where\nintroduced in 2008 with [1] inside the \u0027ecosboard.c\u0027 file, part of\nthe obsoleted Zylin zy1000 project, then moved to target with [2].\nThe \u0027ecosboard\u0027 code was then dropped in 2012 with [3].\n\nWhile the need to split the phases of file reading by OpenOCD from\ntarget writing was probably relevant in the embedded context of\nusing \u0027ecosboard\u0027, this is now less relevant because OpenOCD runs\nin an OS where file I/O is by far faster than the interactions\nwith the external probe (apart from slow remote filesystems, not\nsuitable for benchmarking).\nTo measure write performance, it\u0027s also much easier creating a Tcl\narray of data and measure the speed of \u0027write_memory\u0027 command.\n\nTo reduce the maintenance effort, deprecate the two commands.\nDrop the commands from the documentation.\n\n[1] commit fb7189761d49 (\"wip\")\n[2] commit 459d03e3bb51 (\"fast_load profiling tool moved to target.c\")\n[3] commit 39650e2273bc (\"ecosboard: delete bit-rotted eCos code\")\n\nChange-Id: I1a53116093402c76afd7b3fc073a41e4a757c1a3\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9953\nReviewed-by: zapb \u003cdev@zapb.de\u003e\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003ctomas.vanek.oocd@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}