)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"f948df9a27c0811150ce79622104ef721d80c21e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"flash/nor: make flash driver read method optional"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently more than 60 flash drivers define"},{"line_number":10,"context_line":"  .read \u003d default_flash_read"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Moreover two drivers (fm3 and dsp5680xx_flash) erroneously do not"},{"line_number":13,"context_line":"define .read at all and therefore flash read commands will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf0f223f_7adbfe32","line":10,"updated":"2026-09-06 12:48:20.000000000","message":"Do you plan to drop all the assignments\n`  .read \u003d default_flash_read,`\nand the other made obsoleted by this series?\nProbably the default functions would become local and don\u0027t need to be exposed in the file .h","commit_id":"c92f7f56193aafc470051f65d8a6c134223b4834"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2469c25fd943102381296f80ca60832ea97107ba","unresolved":true,"context_lines":[{"line_number":7,"context_line":"flash/nor: make flash driver read method optional"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently more than 60 flash drivers define"},{"line_number":10,"context_line":"  .read \u003d default_flash_read"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Moreover two drivers (fm3 and dsp5680xx_flash) erroneously do not"},{"line_number":13,"context_line":"define .read at all and therefore flash read commands will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"61e35b28_7ffd4948","line":10,"in_reply_to":"25894b72_1902f815","updated":"2026-09-08 13:09:51.000000000","message":"yes, not everything can be static.","commit_id":"c92f7f56193aafc470051f65d8a6c134223b4834"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"9563badd0097a7dde84932afffd29221f56aeaf4","unresolved":true,"context_lines":[{"line_number":7,"context_line":"flash/nor: make flash driver read method optional"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently more than 60 flash drivers define"},{"line_number":10,"context_line":"  .read \u003d default_flash_read"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Moreover two drivers (fm3 and dsp5680xx_flash) erroneously do not"},{"line_number":13,"context_line":"define .read at all and therefore flash read commands will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"25894b72_1902f815","line":10,"in_reply_to":"bf0f223f_7adbfe32","updated":"2026-09-08 09:20:28.000000000","message":"Yes I do, just waiting for currently pending flash drivers - as they gets merged I prepare the big drop.\n\nUnfortunately the default func is used in virtual.c so cannot be made local.\nOr we could introduce another function\n```\nint flash_driver_read_inner(...)\n{\n  if (bank-\u003edriver-\u003eread)\n    return bank-\u003edriver-\u003eread(...);\n\n  return default_flash_read(...);\n}\n```\nto use in both `flash_driver_read()` and `virtual_flash_read()`\nand then `default_flash_read()` could be local.","commit_id":"c92f7f56193aafc470051f65d8a6c134223b4834"}],"src/flash/nor/virtual.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7ff274dca3d86e142d2f129e984735d4a80bbb94","unresolved":true,"context_lines":[{"line_number":190,"context_line":"\t/* call master handler or default */"},{"line_number":191,"context_line":"\tif (master_bank-\u003edriver-\u003eread)"},{"line_number":192,"context_line":"\t\treturn master_bank-\u003edriver-\u003eread(master_bank, buffer, offset, count);"},{"line_number":193,"context_line":"\telse"},{"line_number":194,"context_line":"\t\treturn default_flash_read(master_bank, buffer, offset, count);"},{"line_number":195,"context_line":"}"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"123a3866_26a092bd","line":193,"updated":"2026-09-06 12:54:42.000000000","message":"No need for `else` after a `return`:\n```\n\tif (master_bank-\u003edriver-\u003eread)\n\t\treturn master_bank-\u003edriver-\u003eread(master_bank, buffer, offset, count);\n\n\treturn default_flash_read(master_bank, buffer, offset, count);\n}\n```","commit_id":"c92f7f56193aafc470051f65d8a6c134223b4834"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"9563badd0097a7dde84932afffd29221f56aeaf4","unresolved":false,"context_lines":[{"line_number":190,"context_line":"\t/* call master handler or default */"},{"line_number":191,"context_line":"\tif (master_bank-\u003edriver-\u003eread)"},{"line_number":192,"context_line":"\t\treturn master_bank-\u003edriver-\u003eread(master_bank, buffer, offset, count);"},{"line_number":193,"context_line":"\telse"},{"line_number":194,"context_line":"\t\treturn default_flash_read(master_bank, buffer, offset, count);"},{"line_number":195,"context_line":"}"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c8efe131_dfa569db","line":193,"in_reply_to":"123a3866_26a092bd","updated":"2026-09-08 09:20:28.000000000","message":"Done\n\nBTW I know it\u0027s required in linux kernel C style but not in ours","commit_id":"c92f7f56193aafc470051f65d8a6c134223b4834"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"371127ab44f1e1c6efa41357ee10f87297c48f7c","unresolved":false,"context_lines":[{"line_number":190,"context_line":"\t/* call master handler or default */"},{"line_number":191,"context_line":"\tif (master_bank-\u003edriver-\u003eread)"},{"line_number":192,"context_line":"\t\treturn master_bank-\u003edriver-\u003eread(master_bank, buffer, offset, count);"},{"line_number":193,"context_line":"\telse"},{"line_number":194,"context_line":"\t\treturn default_flash_read(master_bank, buffer, offset, count);"},{"line_number":195,"context_line":"}"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6dabf15d_dfb1b539","line":193,"in_reply_to":"93ad0910_89e90087","updated":"2026-09-12 16:35:29.000000000","message":"Nice to know it. I also see the v1 form little bit nicer for two similar function branches in opposite of the v2 form suitable for fail branch and no error continuation. So maybe next time 😊","commit_id":"c92f7f56193aafc470051f65d8a6c134223b4834"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"159aed6a751382def1cb0d99790f953b09399f40","unresolved":true,"context_lines":[{"line_number":190,"context_line":"\t/* call master handler or default */"},{"line_number":191,"context_line":"\tif (master_bank-\u003edriver-\u003eread)"},{"line_number":192,"context_line":"\t\treturn master_bank-\u003edriver-\u003eread(master_bank, buffer, offset, count);"},{"line_number":193,"context_line":"\telse"},{"line_number":194,"context_line":"\t\treturn default_flash_read(master_bank, buffer, offset, count);"},{"line_number":195,"context_line":"}"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"93ad0910_89e90087","line":193,"in_reply_to":"c8efe131_dfa569db","updated":"2026-09-08 13:06:24.000000000","message":"Humm...\nI went to check why checkpatch does not detect it, since we have `UNNECESSARY_ELSE` check enabled.\nWell, because this specific case is explicitly removed with this patch\nhttps://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id\u003d840080a08492\nSorry for the noise, then.\nFeel free to revert to v1 if you prefer it or proceed with this v2, I\u0027m ready for +2 in both cases","commit_id":"c92f7f56193aafc470051f65d8a6c134223b4834"}]}