)]}'
{"id":"openocd~master~If115a0a4325c738a5db0b383c7037a20a10f5f54","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2026-09-08 13:06:24.000000000","reason":"\u003cGERRIT_ACCOUNT_1000021\u003e replied on the change","reason_account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"last_update":"2026-09-12 16:35:29.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}}},"hashtags":[],"change_id":"If115a0a4325c738a5db0b383c7037a20a10f5f54","subject":"flash/nor: make flash driver read method optional","status":"MERGED","created":"2026-09-05 08:37:00.000000000","updated":"2026-09-16 19:48:35.000000000","submitted":"2026-09-16 19:48:35.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"total_comment_count":7,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"9959","meta_rev_id":"e1306f25b18383f665693dbbedef04a1701a3e56","_number":9959,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-09-16 19:48:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-09-16 19:48:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-05 08:37:11.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-09-05 09:15:54.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-09-06 12:48:20.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"5afd6f78b8cd668c45a15aa8c7334f5f4115d76d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-05 08:37:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0fe4a1315b573ca29e568fe88f3f61f02433ef19","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-09-05 09:15:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24041/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23123/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f948df9a27c0811150ce79622104ef721d80c21e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-09-06 12:48:20.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7ff274dca3d86e142d2f129e984735d4a80bbb94","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-09-06 12:54:42.000000000","message":"Patch Set 1: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"29f3fb013c6145ca0ff77064d9a883b5d8e7cee2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-08 09:05:35.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"9563badd0097a7dde84932afffd29221f56aeaf4","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-08 09:20:28.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"933b4c8b72b57daeafeda73a9b75c28115857a36","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-09-08 09:30:22.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24058/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23140/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"159aed6a751382def1cb0d99790f953b09399f40","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-09-08 13:06:24.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2469c25fd943102381296f80ca60832ea97107ba","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2026-09-08 13:09:51.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"371127ab44f1e1c6efa41357ee10f87297c48f7c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-12 16:35:29.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e1306f25b18383f665693dbbedef04a1701a3e56","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-16 19:48:35.000000000","message":"Change has been successfully cherry-picked as 339f088acdd706b3c6389755e677a47c1f15aa5b","accounts_in_message":[],"_revision_number":3}],"current_revision":"339f088acdd706b3c6389755e677a47c1f15aa5b","revisions":{"339f088acdd706b3c6389755e677a47c1f15aa5b":{"kind":"REWORK","_number":3,"created":"2026-09-16 19:48:35.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/59/9959/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/9959/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/9959/3 \u0026\u0026 git checkout -b change-9959 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/9959/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/9959/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/9959/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/9959/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/9959/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a6df9b87d55b1c1641259a97693f3da0f230f151","subject":"drivers/ch347: support SRST in SWD mode"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-03 19:01:07.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","date":"2026-09-16 19:48:35.000000000","tz":0},"subject":"flash/nor: make flash driver read method optional","message":"flash/nor: make flash driver read method optional\n\nCurrently more than 60 flash drivers define\n  .read \u003d default_flash_read\n\nMoreover two drivers (fm3 and dsp5680xx_flash) erroneously do not\ndefine .read at all and therefore flash read commands will\ncause OpenOCD segfault.\n\nFall back to default_flash_read() if the .read method is NULL\n\nChange-Id: If115a0a4325c738a5db0b383c7037a20a10f5f54\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9959\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"91a2f4e8d200fe86261f8158cb9a731fbeff59c4":{"kind":"REWORK","_number":2,"created":"2026-09-08 09:05:35.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/59/9959/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/9959/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/9959/2 \u0026\u0026 git checkout -b change-9959 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/9959/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/9959/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/9959/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/9959/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/9959/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ddb476bc90c83b3d7a64d35b93705adbd5ef2ed2","subject":"adapter/eud: Act on the whole SWD status word"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-03 19:01:07.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-08 09:01:42.000000000","tz":120},"subject":"flash/nor: make flash driver read method optional","message":"flash/nor: make flash driver read method optional\n\nCurrently more than 60 flash drivers define\n  .read \u003d default_flash_read\n\nMoreover two drivers (fm3 and dsp5680xx_flash) erroneously do not\ndefine .read at all and therefore flash read commands will\ncause OpenOCD segfault.\n\nFall back to default_flash_read() if the .read method is NULL\n\nChange-Id: If115a0a4325c738a5db0b383c7037a20a10f5f54\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"c92f7f56193aafc470051f65d8a6c134223b4834":{"kind":"REWORK","_number":1,"created":"2026-09-05 08:37:00.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/59/9959/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/59/9959/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/59/9959/1 \u0026\u0026 git checkout -b change-9959 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/59/9959/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/59/9959/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/59/9959/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/59/9959/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/59/9959/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ddb476bc90c83b3d7a64d35b93705adbd5ef2ed2","subject":"adapter/eud: Act on the whole SWD status word"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-03 19:01:07.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-05 08:30:09.000000000","tz":120},"subject":"flash/nor: make flash driver read method optional","message":"flash/nor: make flash driver read method optional\n\nCurrently more than 60 flash drivers define\n  .read \u003d default_flash_read\n\nMoreover two drivers (fm3 and dsp5680xx_flash) erroneously do not\ndefine .read at all and therefore flash read commands will\ncause OpenOCD segfault.\n\nFall back to default_flash_read() if the .read method is NULL\n\nChange-Id: If115a0a4325c738a5db0b383c7037a20a10f5f54\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}