)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"897cd4949db4c3440ef22e996bdc7791ba9d752f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"aa5ed753_18492e5c","updated":"2026-09-14 09:15:57.000000000","message":"The `JTAG_TLR_RESET` dispatch still drops the return value from `cmsis_dap_execute_tlr_reset()`, so a failed reset can be reported as `ERROR_OK`; see the inline comment. Suggested vote: -1. _This review was performed by an AI agent._","commit_id":"720ab01022526aefa8bbc5f3b0c2e67fe1a1df8f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"febca90d8df053b3d6b18aaab42ccd95257e13a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"65e1ffda_16c99d7c","updated":"2026-09-08 12:28:03.000000000","message":"looks correct","commit_id":"720ab01022526aefa8bbc5f3b0c2e67fe1a1df8f"}],"src/jtag/drivers/cmsis_dap.c":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"897cd4949db4c3440ef22e996bdc7791ba9d752f","unresolved":true,"context_lines":[{"line_number":2047,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":2048,"context_line":"\t\t\treturn retval;"},{"line_number":2049,"context_line":""},{"line_number":2050,"context_line":"\t\tcmsis_dap_execute_tlr_reset(cmd);"},{"line_number":2051,"context_line":"\t\treturn ERROR_OK;"},{"line_number":2052,"context_line":"\tcase JTAG_SCAN:"},{"line_number":2053,"context_line":"\t\treturn cmsis_dap_execute_scan(cmd);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fbae125f_bd193842","line":2050,"updated":"2026-09-14 09:15:57.000000000","message":"The `cmsis_dap_execute_tlr_reset()` call returns the result of `cmsis_dap_cmd_dap_swj_sequence()`, but this dispatch discards that return value and unconditionally returns `ERROR_OK`. A USB/JTAG reset failure is therefore still reported as success to the queue caller, which leaves the error path in this change incomplete. Please return `cmsis_dap_execute_tlr_reset(cmd)` here.","commit_id":"720ab01022526aefa8bbc5f3b0c2e67fe1a1df8f"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"15b3123c148718bc8eac422d4f9f399b49264e04","unresolved":false,"context_lines":[{"line_number":2047,"context_line":"\t\tif (retval !\u003d ERROR_OK)"},{"line_number":2048,"context_line":"\t\t\treturn retval;"},{"line_number":2049,"context_line":""},{"line_number":2050,"context_line":"\t\tcmsis_dap_execute_tlr_reset(cmd);"},{"line_number":2051,"context_line":"\t\treturn ERROR_OK;"},{"line_number":2052,"context_line":"\tcase JTAG_SCAN:"},{"line_number":2053,"context_line":"\t\treturn cmsis_dap_execute_scan(cmd);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"69d6bf2e_9e5e773c","line":2050,"in_reply_to":"fbae125f_bd193842","updated":"2026-09-14 09:24:26.000000000","message":"Done","commit_id":"720ab01022526aefa8bbc5f3b0c2e67fe1a1df8f"}]}