)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"8e6804ec7774ba60f02bef8086a05ed98e934c86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"137dffd0_ab2947a5","updated":"2026-09-24 08:39:59.000000000","message":"Tarek, could you please try AI review on this patch? I\u0027m curious what it\u0027ll say to the subsystem prefix in the commit msg","commit_id":"1fc9eac264ddca228f19d4ccf9164028710d3cec"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"3bccc70da7a6004ae163ce65c04748fc1fa88c61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b5243a3d_0473b95e","updated":"2026-09-28 07:35:11.000000000","message":"The changed behavior of `flash write_image erase` is not documented in `doc/openocd.texi`; erase-free NVM banks now succeed without an erase operation.\n\nSuggested vote: -1\n\n*This review was performed by an AI agent.*","commit_id":"1fc9eac264ddca228f19d4ccf9164028710d3cec"},{"author":{"_account_id":1000853,"name":"zapb","display_name":"Marc Schink","email":"dev@zapb.de","username":"zapb"},"change_message_id":"fccbce390ef87e74580743bbe69d28d3b99419ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ba4b527b_4e30bc10","updated":"2026-10-09 09:22:29.000000000","message":"@Tomas: I have no issues with GDB `load` command without this patch. Any idea why?\n\nTested on the nRF54L15 with gdb `load ...`, `flash write_image (erase) ...` and `program (erase) ...`. All commands work as expected.","commit_id":"81a96e2245808aecb0393cc274b27a2653b817cb"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"21c453a112afe29d58414ccdc18abcd45bf5450c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3baeaeee_843029e7","in_reply_to":"ba4b527b_4e30bc10","updated":"2026-10-09 09:51:41.000000000","message":"Expected as you already made `vFlashErase` tolerant to ERROR_FLASH_OPER_UNSUPPORTED:\nhttps://review.openocd.org/c/openocd/+/9289/3/src/server/gdb_server.c#3420\nThis is still necessary for banks translated over the virtual driver.","commit_id":"81a96e2245808aecb0393cc274b27a2653b817cb"}],"src/flash/nor/core.c":[{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"3bccc70da7a6004ae163ce65c04748fc1fa88c61","unresolved":true,"context_lines":[{"line_number":1043,"context_line":"\t\t\t\tretval \u003d flash_erase_address_range(target,"},{"line_number":1044,"context_line":"\t\t\t\t\t\t\t\t\t\t\ttrue /* pad */,"},{"line_number":1045,"context_line":"\t\t\t\t\t\t\t\t\t\t\trun_address, run_size,"},{"line_number":1046,"context_line":"\t\t\t\t\t\t\t\t\t\t\ttrue /* skip_banks_without_erase */);"},{"line_number":1047,"context_line":"\t\t\t}"},{"line_number":1048,"context_line":"\t\t}"},{"line_number":1049,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"7bacad1a_bd2b03e3","line":1046,"updated":"2026-09-28 07:35:11.000000000","message":"`flash write_image erase` now silently succeeds for banks whose driver omits `.erase`, but `doc/openocd.texi` still says that the relevant flash sectors are erased whenever `erase` is given. The project requires changed command behavior to be documented in the same commit; please explain that erase-free NVM banks are skipped because they do not require an erase operation.\n\n*This review was performed by an AI agent.*","commit_id":"1fc9eac264ddca228f19d4ccf9164028710d3cec"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"change_message_id":"1721906d7100fc4f62c9de18d18a0896ceda4cd0","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"\t\t\t\tretval \u003d flash_erase_address_range(target,"},{"line_number":1044,"context_line":"\t\t\t\t\t\t\t\t\t\t\ttrue /* pad */,"},{"line_number":1045,"context_line":"\t\t\t\t\t\t\t\t\t\t\trun_address, run_size,"},{"line_number":1046,"context_line":"\t\t\t\t\t\t\t\t\t\t\ttrue /* skip_banks_without_erase */);"},{"line_number":1047,"context_line":"\t\t\t}"},{"line_number":1048,"context_line":"\t\t}"},{"line_number":1049,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"44223be0_d2ef26d7","line":1046,"in_reply_to":"7bacad1a_bd2b03e3","updated":"2026-09-28 18:23:36.000000000","message":"Done","commit_id":"1fc9eac264ddca228f19d4ccf9164028710d3cec"}]}