)]}'
{"id":"openocd~master~I4dbd8377ac8a7587db0b3ceac32776b417cfba9b","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1002347":{"account":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"last_update":"2026-09-13 22:18:01.000000000","reason":"\u003cGERRIT_ACCOUNT_1002347\u003e replied on the change","reason_account":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"}},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"last_update":"2026-09-22 06:15:58.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I4dbd8377ac8a7587db0b3ceac32776b417cfba9b","subject":"jtag/drivers/linuxspidev: release resources if init fails","status":"MERGED","created":"2026-09-12 12:42:01.000000000","updated":"2026-10-01 20:08:11.000000000","submitted":"2026-10-01 20:08:11.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"9988","meta_rev_id":"32fe2f471099b3a3d38d54cd3ad62cf9f2b2c5f8","_number":9988,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-10-01 20:08:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2026-10-01 20:08:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2026-10-01 20:08:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-12 12:42:10.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2026-09-12 13:09:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-09-12 13:36:26.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"reviewer":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"state":"REVIEWER"}],"messages":[{"id":"08f6586c37c030a9ff2685703f4ab993d0b7a3d1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-12 12:42:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e55c7de660a3df41985a8fed23af6812b9e8abfd","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-09-12 13:09:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24178/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23249/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2993d6318795ef8af2f35cdfa6dd30770f02fc9a","author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"real_author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"date":"2026-09-12 14:01:02.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"01391e726f7cd04408a658421d699931f8e4ae33","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-12 14:40:19.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+1 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"14ad766e179b90d472d5b16a6563121983a6ff4c","author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"real_author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"date":"2026-09-12 14:42:29.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"cf31e818326a142705affc698fbe1bae1c52f435","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-12 15:15:07.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"84eae323271ab46f0376cbb34c13348a78ac051a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-09-12 19:17:11.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24184/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23255/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"54a412bb18b2be587e54a3c3836df23504e593b8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-13 19:31:52.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Code-Review+1, Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR is:MIN\")\n* Verified+1 (copy condition: \"changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"675e53cb674565bb454bd1a70d77d634a14b306a","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2026-09-13 20:07:20.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/24195/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/23266/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"459df15a96649c2f3869548661c631ac270783b1","author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"real_author":{"_account_id":1002347,"name":"Richard Pasek","email":"rpasek@google.com","username":"rpasek"},"date":"2026-09-13 22:18:01.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"756c9f8bb5be7757053df78fd5d6f41534e06c23","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-09-22 06:15:58.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"32fe2f471099b3a3d38d54cd3ad62cf9f2b2c5f8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"date":"2026-10-01 20:08:11.000000000","message":"Change has been successfully cherry-picked as 9ce48f20ba2c49646b9ad690ceb2b7a85c77cbd2","accounts_in_message":[],"_revision_number":4}],"current_revision":"9ce48f20ba2c49646b9ad690ceb2b7a85c77cbd2","revisions":{"eb04cb4fd694ab45da71be2ccea035bdcdf1e78d":{"kind":"REWORK","_number":1,"created":"2026-09-12 12:42:01.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/88/9988/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/88/9988/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/1 \u0026\u0026 git checkout -b change-9988 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/88/9988/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"579b915da2e9a37c3f61185995089f84361f0172","subject":"jtag/drivers/linuxspidev: add SRST handling"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-12 12:33:19.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-12 12:33:19.000000000","tz":120},"subject":"jtag/drivers/linuxspidev: release resources if init fails","message":"jtag/drivers/linuxspidev: release resources if init fails\n\nThe adapter driver leaked allocated memory and didn\u0027t close\nfd if some init call failed.\n\nCall spidev_quit() in such case, it is safe to call\nin any state including partial initialization.\n\nChange-Id: I4dbd8377ac8a7587db0b3ceac32776b417cfba9b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"a51552a3ea1f68ef4c7c7952722282561952ce42":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2026-09-13 19:31:52.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/88/9988/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/88/9988/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/3 \u0026\u0026 git checkout -b change-9988 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/88/9988/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7788f01c77017de6ce94151435c1de3a9f02fb8d","subject":"jtag/drivers/linuxgpiod: export functions for reset handling"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-12 12:33:19.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-12 15:48:35.000000000","tz":120},"subject":"jtag/drivers/linuxspidev: release resources if init fails","message":"jtag/drivers/linuxspidev: release resources if init fails\n\nThe adapter driver leaked allocated memory and didn\u0027t close\nfd if some init call failed.\n\nCall spidev_quit() in such case, it is safe to call\nin any state including partial initialization.\n\nChange-Id: I4dbd8377ac8a7587db0b3ceac32776b417cfba9b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"c1ccf740e1c7d80b69abe959e316daae085b05dc":{"kind":"REWORK","_number":2,"created":"2026-09-12 14:40:19.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/88/9988/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/88/9988/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/2 \u0026\u0026 git checkout -b change-9988 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/88/9988/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b93c13537ca2d0d5db5466bd1a53678bacaa62c0","subject":"jtag/drivers/linuxgpiod: export functions for reset handling"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-12 12:33:19.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-12 14:27:58.000000000","tz":120},"subject":"jtag/drivers/linuxspidev: release resources if init fails","message":"jtag/drivers/linuxspidev: release resources if init fails\n\nThe adapter driver leaked allocated memory and didn\u0027t close\nfd if some init call failed.\n\nCall spidev_quit() in such case, it is safe to call\nin any state including partial initialization.\n\nChange-Id: I4dbd8377ac8a7587db0b3ceac32776b417cfba9b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"9ce48f20ba2c49646b9ad690ceb2b7a85c77cbd2":{"kind":"REWORK","_number":4,"created":"2026-10-01 20:08:11.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"},"ref":"refs/changes/88/9988/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/88/9988/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/4 \u0026\u0026 git checkout -b change-9988 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/88/9988/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/88/9988/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"221e8fe6c563d75855695581252ea369ce5e993c","subject":"jtag/drivers: initialize SRST before other signals"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2026-09-12 12:33:19.000000000","tz":120},"committer":{"name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","date":"2026-10-01 20:08:11.000000000","tz":0},"subject":"jtag/drivers/linuxspidev: release resources if init fails","message":"jtag/drivers/linuxspidev: release resources if init fails\n\nThe adapter driver leaked allocated memory and didn\u0027t close\nfd if some init call failed.\n\nCall spidev_quit() in such case, it is safe to call\nin any state including partial initialization.\n\nChange-Id: I4dbd8377ac8a7587db0b3ceac32776b417cfba9b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/9988\nReviewed-by: Tomas Vanek \u003ctomas.vanek.oocd@gmail.com\u003e\nTested-by: jenkins\nReviewed-by: Richard Pasek \u003crpasek@google.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"tomas.vanek.oocd@gmail.com","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}