flash/nor/fespi: check target type
[openocd.git] / src / flash / nor / virtual.c
index c9525d179b2d86b938a7e43a2a95d176609cc106..212d53a4c6dc326802d39950668abd24844fa008 100644 (file)
@@ -1,19 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
 /***************************************************************************
  *   Copyright (C) 2010 by Spencer Oliver                                  *
  *   spen@spen-soft.co.uk                                                  *
- *                                                                         *
- *   This program is free software; you can redistribute it and/or modify  *
- *   it under the terms of the GNU General Public License as published by  *
- *   the Free Software Foundation; either version 2 of the License, or     *
- *   (at your option) any later version.                                   *
- *                                                                         *
- *   This program is distributed in the hope that it will be useful,       *
- *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
- *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
- *   GNU General Public License for more details.                          *
- *                                                                         *
- *   You should have received a copy of the GNU General Public License     *
- *   along with this program.  If not, see <http://www.gnu.org/licenses/>. *
  ***************************************************************************/
 
 #ifdef HAVE_CONFIG_H
@@ -27,7 +16,7 @@ static struct flash_bank *virtual_get_master_bank(struct flash_bank *bank)
        struct flash_bank *master_bank;
 
        master_bank = get_flash_bank_by_name_noprobe(bank->driver_priv);
-       if (master_bank == NULL)
+       if (!master_bank)
                LOG_ERROR("master flash bank '%s' does not exist", (char *)bank->driver_priv);
 
        return master_bank;
@@ -37,7 +26,7 @@ static void virtual_update_bank_info(struct flash_bank *bank)
 {
        struct flash_bank *master_bank = virtual_get_master_bank(bank);
 
-       if (master_bank == NULL)
+       if (!master_bank)
                return;
 
        /* update the info we do not have */
@@ -64,7 +53,7 @@ FLASH_BANK_COMMAND_HANDLER(virtual_flash_bank_command)
        const char *bank_name = CMD_ARGV[6];
        struct flash_bank *master_bank = get_flash_bank_by_name_noprobe(bank_name);
 
-       if (master_bank == NULL) {
+       if (!master_bank) {
                LOG_ERROR("master flash bank '%s' does not exist", bank_name);
                return ERROR_FLASH_OPERATION_FAILED;
        }
@@ -80,7 +69,7 @@ static int virtual_protect(struct flash_bank *bank, int set, unsigned int first,
 {
        struct flash_bank *master_bank = virtual_get_master_bank(bank);
 
-       if (master_bank == NULL)
+       if (!master_bank)
                return ERROR_FLASH_OPERATION_FAILED;
 
        return flash_driver_protect(master_bank, set, first, last);
@@ -90,10 +79,10 @@ static int virtual_protect_check(struct flash_bank *bank)
 {
        struct flash_bank *master_bank = virtual_get_master_bank(bank);
 
-       if (master_bank == NULL)
+       if (!master_bank)
                return ERROR_FLASH_OPERATION_FAILED;
 
-       if (master_bank->driver->protect_check == NULL)
+       if (!master_bank->driver->protect_check)
                return ERROR_FLASH_OPER_UNSUPPORTED;
 
        /* call master handler */
@@ -106,7 +95,7 @@ static int virtual_erase(struct flash_bank *bank, unsigned int first,
        struct flash_bank *master_bank = virtual_get_master_bank(bank);
        int retval;
 
-       if (master_bank == NULL)
+       if (!master_bank)
                return ERROR_FLASH_OPERATION_FAILED;
 
        /* call master handler */
@@ -123,7 +112,7 @@ static int virtual_write(struct flash_bank *bank, const uint8_t *buffer,
        struct flash_bank *master_bank = virtual_get_master_bank(bank);
        int retval;
 
-       if (master_bank == NULL)
+       if (!master_bank)
                return ERROR_FLASH_OPERATION_FAILED;
 
        /* call master handler */
@@ -139,7 +128,7 @@ static int virtual_probe(struct flash_bank *bank)
        struct flash_bank *master_bank = virtual_get_master_bank(bank);
        int retval;
 
-       if (master_bank == NULL)
+       if (!master_bank)
                return ERROR_FLASH_OPERATION_FAILED;
 
        /* call master handler */
@@ -158,7 +147,7 @@ static int virtual_auto_probe(struct flash_bank *bank)
        struct flash_bank *master_bank = virtual_get_master_bank(bank);
        int retval;
 
-       if (master_bank == NULL)
+       if (!master_bank)
                return ERROR_FLASH_OPERATION_FAILED;
 
        /* call master handler */
@@ -176,7 +165,7 @@ static int virtual_info(struct flash_bank *bank, struct command_invocation *cmd)
 {
        struct flash_bank *master_bank = virtual_get_master_bank(bank);
 
-       if (master_bank == NULL)
+       if (!master_bank)
                return ERROR_FLASH_OPERATION_FAILED;
 
        command_print_sameline(cmd, "%s driver for flash bank %s at " TARGET_ADDR_FMT,
@@ -190,7 +179,7 @@ static int virtual_blank_check(struct flash_bank *bank)
        struct flash_bank *master_bank = virtual_get_master_bank(bank);
        int retval;
 
-       if (master_bank == NULL)
+       if (!master_bank)
                return ERROR_FLASH_OPERATION_FAILED;
 
        /* call master handler */
@@ -207,7 +196,7 @@ static int virtual_flash_read(struct flash_bank *bank,
        struct flash_bank *master_bank = virtual_get_master_bank(bank);
        int retval;
 
-       if (master_bank == NULL)
+       if (!master_bank)
                return ERROR_FLASH_OPERATION_FAILED;
 
        /* call master handler */

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)