cortex_m: Restore fast register reads if no polling is needed

[openocd.git] / src / target / target_request.c

diff --git a/src/target/target_request.c b/src/target/target_request.c
index df2fc34ee1d66b90b3e7f3c5a856244d2068b9da..562b046aadb04ac773ee861f8c5715168e4ba1b1 100644 (file)
--- a/src/target/target_request.c
+++ b/src/target/target_request.c
@@ -19,9 +19,7 @@
  *   GNU General Public License for more details.                          *
  *                                                                         *
  *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.           *
+ *   along with this program.  If not, see <http://www.gnu.org/licenses/>. *
  ***************************************************************************/
 
 #ifdef HAVE_CONFIG_H
@@ -58,7 +56,7 @@ static int target_asciimsg(struct target *target, uint32_t length)
        LOG_DEBUG("%s", msg);
 
        while (c) {
-               command_print(c->cmd_ctx, "%s", msg);
+               command_output_text(c->cmd_ctx, msg);
                c = c->next;
        }
 
@@ -102,7 +100,7 @@ static int target_hexmsg(struct target *target, int size, uint32_t length)
                        LOG_DEBUG("%s", line);
 
                        while (c) {
-                               command_print(c->cmd_ctx, "%s", line);
+                               command_output_text(c->cmd_ctx, line);
                                c = c->next;
                        }
                        c = target->dbgmsg;
@@ -160,7 +158,7 @@ static int add_debug_msg_receiver(struct command_context *cmd_ctx, struct target
 {
        struct debug_msg_receiver **p = &target->dbgmsg;
 
-       if (target == NULL)
+       if (!target)
                return ERROR_COMMAND_SYNTAX_ERROR;
 
        /* see if there's already a list */
@@ -188,9 +186,9 @@ static struct debug_msg_receiver *find_debug_msg_receiver(struct command_context
        int do_all_targets = 0;
 
        /* if no target has been specified search all of them */
-       if (target == NULL) {
+       if (!target) {
                /* if no targets haven been specified */
-               if (all_targets == NULL)
+               if (!all_targets)
                        return NULL;
 
                target = all_targets;
@@ -219,9 +217,9 @@ int delete_debug_msg_receiver(struct command_context *cmd_ctx, struct target *ta
        int do_all_targets = 0;
 
        /* if no target has been specified search all of them */
-       if (target == NULL) {
+       if (!target) {
                /* if no targets haven been specified */
-               if (all_targets == NULL)
+               if (!all_targets)
                        return ERROR_OK;
 
                target = all_targets;
@@ -236,7 +234,7 @@ int delete_debug_msg_receiver(struct command_context *cmd_ctx, struct target *ta
                        if (c->cmd_ctx == cmd_ctx) {
                                *p = next;
                                free(c);
-                               if (*p == NULL) {
+                               if (!*p) {
                                        /* disable callback */
                                        target->dbg_msg_enabled = 0;
                                }
@@ -258,13 +256,13 @@ COMMAND_HANDLER(handle_target_request_debugmsgs_command)
 
        int receiving = 0;
 
-       if (target->type->target_request_data == NULL) {
+       if (!target->type->target_request_data) {
                LOG_ERROR("Target %s does not support target requests", target_name(target));
                return ERROR_OK;
        }
 
-       /* see if reciever is already registered */
-       if (find_debug_msg_receiver(CMD_CTX, target) != NULL)
+       /* see if receiver is already registered */
+       if (find_debug_msg_receiver(CMD_CTX, target))
                receiving = 1;
 
        if (CMD_ARGC > 0) {
@@ -285,7 +283,7 @@ COMMAND_HANDLER(handle_target_request_debugmsgs_command)
                        return ERROR_COMMAND_SYNTAX_ERROR;
        }
 
-       command_print(CMD_CTX, "receiving debug messages from current target %s",
+       command_print(CMD, "receiving debug messages from current target %s",
                        (receiving) ? (charmsg_mode ? "charmsg" : "enabled") : "disabled");
        return ERROR_OK;
 }