very slight cleanup of flash banks handling.

[openocd.git] / src / tcl / commands.tcl

diff --git a/src/tcl/commands.tcl b/src/tcl/commands.tcl
index a25badcc8151f673aa786e3cc452840b34fd6980..1da8f1b2a029e0fb772dd511974a5dee93bcf04f 100644 (file)
--- a/src/tcl/commands.tcl
+++ b/src/tcl/commands.tcl
@@ -34,25 +34,22 @@ proc exit {} {
        openocd_throw exit
 }
 
-# If a fn is unknown to Tcl, we try to execute it as an OpenOCD command
-proc unknown {args} {
-
-       # This is uglier than it needs to be since the "flash banks" is really
-       # a single command. For now only "flash banks" has been converted from
-       # C to Tcl as an example, but if we do decide to go down this path, then
-       # some more generic scheme will be put in place here.
-       #
-       # Help texts need a makeover. There needs to be help texts for
-       # tcl procs + perhaps some work w.r.t. making the help command
-       # format things prettier.
-       if {[string compare [lindex $args 0] flash]==0 && [string compare [lindex $args 1] banks]==0} {
+# We have currently converted only "flash banks" to tcl.
+proc flash args {
+       if {[string compare [lindex $args 0] banks]==0} {
                return [flash_banks_pretty]
-       }  
+       }
+       openocd_throw "flash $args"
+}
 
-       # We print out as we run the command
+# If a fn is unknown to Tcl, we try to execute it as an OpenOCD command
+proc unknown {args} {
        if {[string length $args]>0} {
-               openocd_throw "$args"
+               openocd_throw $args
        }
+       # openocd_throw outputs while running and also sets the
+       # primary return value to the output of the command
+       #
        # The primary return value have been set by "openocd" above,
        # so we need to clear it, lest we print out the output from
        # the command twice.