X-Git-Url: https://review.openocd.org/gitweb?a=blobdiff_plain;f=src%2Ftarget%2Fsmp.c;h=da9ee8b468fa1bf7626260d58eab869a3345d400;hb=b01b5fe13a67d6ff33b792348c24c5f92a5a8a1b;hp=66dbfec16c8f634b95395c7c3732a539c637f3e2;hpb=3d62c3df6ddb09f1485c25d665e248856989d180;p=openocd.git

diff --git a/src/target/smp.c b/src/target/smp.c
index 66dbfec16c..da9ee8b468 100644
--- a/src/target/smp.c
+++ b/src/target/smp.c
@@ -15,7 +15,7 @@
  *   You should have received a copy of the GNU General Public License     *
  *   along with this program; if not, write to the                         *
  *   Free Software Foundation, Inc.,                                       *
- *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
+ *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.           *
  ***************************************************************************/
 
 #ifdef HAVE_CONFIG_H
@@ -56,21 +56,19 @@
 
 /* packet j :smp status request */
 int gdb_read_smp_packet(struct connection *connection,
-		char *packet, int packet_size)
+		char const *packet, int packet_size)
 {
 	struct target *target = get_target_from_connection(connection);
-	uint32_t len = sizeof(int32_t);
-	uint8_t *buffer;
-	char *hex_buffer;
 	int retval = ERROR_OK;
 	if (target->smp) {
 		if (strncmp(packet, "jc", 2) == 0) {
-			hex_buffer = malloc(len * 2 + 1);
-			buffer = (uint8_t *)&target->gdb_service->core[0];
-			int pkt_len = hexify(hex_buffer, (char *)buffer, len, len * 2 + 1);
+			const uint32_t len = sizeof(target->gdb_service->core[0]);
+			char hex_buffer[len * 2 + 1];
+			uint8_t buffer[len];
+			buf_set_u32(buffer, 0, len * 8, target->gdb_service->core[0]);
+			int pkt_len = hexify(hex_buffer, (char *)buffer, sizeof(buffer), sizeof(hex_buffer));
 
 			retval = gdb_put_packet(connection, hex_buffer, pkt_len);
-			free(hex_buffer);
 		}
 	} else
 		retval = gdb_put_packet(connection, "E01", 3);
@@ -79,7 +77,7 @@ int gdb_read_smp_packet(struct connection *connection,
 
 /* J :  smp set request */
 int gdb_write_smp_packet(struct connection *connection,
-		char *packet, int packet_size)
+		char const *packet, int packet_size)
 {
 	struct target *target = get_target_from_connection(connection);
 	char *separator;