target/arm_adi_v5,arm_dap: introduce pre_connect_init() dap operation 42/7542/6
authorTomas Vanek <vanekt@fbl.cz>
Wed, 15 Mar 2023 12:58:52 +0000 (13:58 +0100)
committerTomas Vanek <vanekt@fbl.cz>
Fri, 29 Dec 2023 14:34:50 +0000 (14:34 +0000)
SWD multidrop requires some initialization once before connecting
all daps. Provide an optional pre-connect dap operation.

Change-Id: I778215c512c56423a425dda80ab19a739f22f285
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: https://review.openocd.org/c/openocd/+/7542
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
src/target/arm_adi_v5.h
src/target/arm_dap.c

index e07b577af683f047365b875bba7543fce4a418c8..fc7fdafd84cf72f84cec4f07772ebff850c434dd 100644 (file)
@@ -420,6 +420,9 @@ struct adiv5_dap {
  * available until run().
  */
 struct dap_ops {
+       /** Optional; called once on the first enabled dap before connecting */
+       int (*pre_connect_init)(struct adiv5_dap *dap);
+
        /** connect operation for SWD */
        int (*connect)(struct adiv5_dap *dap);
 
index 84cc6c743bd14f797b2b70192977a70a5d77f8bb..9f4afae74372b2c287fa935094224a830cfc88eb 100644 (file)
@@ -91,6 +91,7 @@ static int dap_init_all(void)
 {
        struct arm_dap_object *obj;
        int retval;
+       bool pre_connect = true;
 
        LOG_DEBUG("Initializing all DAPs ...");
 
@@ -123,6 +124,14 @@ static int dap_init_all(void)
                                is_adiv6(dap) ? "ADIv6" : "ADIv5");
                }
 
+               if (pre_connect && dap->ops->pre_connect_init) {
+                       retval = dap->ops->pre_connect_init(dap);
+                       if (retval != ERROR_OK)
+                               return retval;
+
+                       pre_connect = false;
+               }
+
                retval = dap->ops->connect(dap);
                if (retval != ERROR_OK)
                        return retval;

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)