From e887cfb9e8e8e42513b38e09960849becc5d42e3 Mon Sep 17 00:00:00 2001 From: Walter Ji Date: Mon, 9 Oct 2023 11:42:44 +0800 Subject: [PATCH] target/mips32: check read regs result in save context Add result check for mips32_pracc_read_regs in mips32_save_context. Change-Id: Ie796d2b05a9feb11e246c2d0771b52cad4fb70db Signed-off-by: Walter Ji Reviewed-on: https://review.openocd.org/c/openocd/+/7932 Reviewed-by: Oleksij Rempel Tested-by: jenkins Reviewed-by: Antonio Borneo --- src/target/mips32.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/target/mips32.c b/src/target/mips32.c index 18160b2373..99688b0080 100644 --- a/src/target/mips32.c +++ b/src/target/mips32.c @@ -306,7 +306,11 @@ int mips32_save_context(struct target *target) struct mips32_common *mips32 = target_to_mips32(target); /* read core registers */ - mips32_pracc_read_regs(mips32); + int retval = mips32_pracc_read_regs(mips32); + if (retval != ERROR_OK) { + LOG_ERROR("Could not read core registers from target"); + return retval; + } for (i = 0; i < MIPS32_NUM_REGS; i++) { if (!mips32->core_cache->reg_list[i].valid) -- 2.30.2