- only some cosmetic changes, convert \r\n to unix
[openocd.git] / src / flash / cfi.c
index 83a8120a4d897bce69b16a9727fca3e7517811d2..cc5a69e1c81b2b4c9e6f0583bac6b55c31a36605 100644 (file)
@@ -52,6 +52,9 @@ int cfi_handle_part_id_command(struct command_context_s *cmd_ctx, char *cmd, cha
 #define CFI_MAX_BUS_WIDTH      4
 #define CFI_MAX_CHIP_WIDTH     4
 
+/* defines internal maximum size for code fragment in cfi_intel_write_block() */
+#define CFI_MAX_INTEL_CODESIZE 256
+
 flash_driver_t cfi_flash =
 {
        .name = "cfi",
@@ -66,17 +69,37 @@ flash_driver_t cfi_flash =
        .info = cfi_info
 };
 
+cfi_unlock_addresses_t cfi_unlock_addresses[] =
+{
+       [CFI_UNLOCK_555_2AA] = { .unlock1 = 0x555, .unlock2 = 0x2aa },
+       [CFI_UNLOCK_5555_2AAA] = { .unlock1 = 0x5555, .unlock2 = 0x2aaa },
+};
+
 /* CFI fixups foward declarations */
+void cfi_fixup_non_cfi(flash_bank_t *flash, void *param);
 void cfi_fixup_0002_erase_regions(flash_bank_t *flash, void *param);
+void cfi_fixup_0002_unlock_addresses(flash_bank_t *flash, void *param);
 void cfi_fixup_atmel_reversed_erase_regions(flash_bank_t *flash, void *param);
 
 /* fixup after identifying JEDEC manufactuer and ID */
 cfi_fixup_t cfi_jedec_fixups[] = {
+       {CFI_MFR_SST, 0x00D4, cfi_fixup_non_cfi, NULL},
+       {CFI_MFR_SST, 0x00D5, cfi_fixup_non_cfi, NULL},
+       {CFI_MFR_SST, 0x00D6, cfi_fixup_non_cfi, NULL},
+       {CFI_MFR_SST, 0x00D7, cfi_fixup_non_cfi, NULL},
+       {CFI_MFR_ST, 0x00D5, cfi_fixup_non_cfi, NULL},
+       {CFI_MFR_ST, 0x00D6, cfi_fixup_non_cfi, NULL},
+       {CFI_MFR_AMD, 0x2223, cfi_fixup_non_cfi, NULL},
+       {CFI_MFR_AMD, 0x22ab, cfi_fixup_non_cfi, NULL},
        {0, 0, NULL, NULL}
 };
 
 /* fixup after reading cmdset 0002 primary query table */
 cfi_fixup_t cfi_0002_fixups[] = {
+       {CFI_MFR_SST, 0x00D4, cfi_fixup_0002_unlock_addresses, &cfi_unlock_addresses[CFI_UNLOCK_5555_2AAA]},
+       {CFI_MFR_SST, 0x00D5, cfi_fixup_0002_unlock_addresses, &cfi_unlock_addresses[CFI_UNLOCK_5555_2AAA]},
+       {CFI_MFR_SST, 0x00D6, cfi_fixup_0002_unlock_addresses, &cfi_unlock_addresses[CFI_UNLOCK_5555_2AAA]},
+       {CFI_MFR_SST, 0x00D7, cfi_fixup_0002_unlock_addresses, &cfi_unlock_addresses[CFI_UNLOCK_5555_2AAA]},
        {CFI_MFR_ATMEL, 0x00C8, cfi_fixup_atmel_reversed_erase_regions, NULL},
        {CFI_MFR_ANY, CFI_ID_ANY, cfi_fixup_0002_erase_regions, NULL},
        {0, 0, NULL, NULL}
@@ -121,16 +144,15 @@ inline u32 flash_address(flash_bank_t *bank, int sector, u32 offset)
 
 void cfi_command(flash_bank_t *bank, u8 cmd, u8 *cmd_buf)
 {
-       cfi_flash_bank_t *cfi_info = bank->driver_priv;
        int i;
-       
+
        /* clear whole buffer, to ensure bits that exceed the bus_width
         * are set to zero
         */
        for (i = 0; i < CFI_MAX_BUS_WIDTH; i++)
                cmd_buf[i] = 0;
 
-       if (cfi_info->target->endianness == TARGET_LITTLE_ENDIAN)
+       if (bank->target->endianness == TARGET_LITTLE_ENDIAN)
        {
                for (i = bank->bus_width; i > 0; i--)
                {
@@ -152,13 +174,12 @@ void cfi_command(flash_bank_t *bank, u8 cmd, u8 *cmd_buf)
  */
 u8 cfi_query_u8(flash_bank_t *bank, int sector, u32 offset)
 {
-       cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 data[CFI_MAX_BUS_WIDTH];
-               
+
        target->type->read_memory(target, flash_address(bank, sector, offset), bank->bus_width, 1, data);
-       
-       if (cfi_info->target->endianness == TARGET_LITTLE_ENDIAN)
+
+       if (bank->target->endianness == TARGET_LITTLE_ENDIAN)
                return data[0];
        else
                return data[bank->bus_width - 1];
@@ -170,18 +191,17 @@ u8 cfi_query_u8(flash_bank_t *bank, int sector, u32 offset)
  */
 u8 cfi_get_u8(flash_bank_t *bank, int sector, u32 offset)
 {
-       cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 data[CFI_MAX_BUS_WIDTH];
        int i;
-       
+
        target->type->read_memory(target, flash_address(bank, sector, offset), bank->bus_width, 1, data);
-       
-       if (cfi_info->target->endianness == TARGET_LITTLE_ENDIAN)
+
+       if (bank->target->endianness == TARGET_LITTLE_ENDIAN)
        {
                for (i = 0; i < bank->bus_width / bank->chip_width; i++)
                        data[0] |= data[i];
-               
+
                return data[0];
        }
        else
@@ -189,20 +209,19 @@ u8 cfi_get_u8(flash_bank_t *bank, int sector, u32 offset)
                u8 value = 0;
                for (i = 0; i < bank->bus_width / bank->chip_width; i++)
                        value |= data[bank->bus_width - 1 - i];
-               
+
                return value;
        }
 }
 
 u16 cfi_query_u16(flash_bank_t *bank, int sector, u32 offset)
 {
-       cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 data[CFI_MAX_BUS_WIDTH * 2];
-       
+
        target->type->read_memory(target, flash_address(bank, sector, offset), bank->bus_width, 2, data);
 
-       if (cfi_info->target->endianness == TARGET_LITTLE_ENDIAN)
+       if (bank->target->endianness == TARGET_LITTLE_ENDIAN)
                return data[0] | data[bank->bus_width] << 8;
        else
                return data[bank->bus_width - 1] | data[(2 * bank->bus_width) - 1] << 8;
@@ -210,31 +229,29 @@ u16 cfi_query_u16(flash_bank_t *bank, int sector, u32 offset)
 
 u32 cfi_query_u32(flash_bank_t *bank, int sector, u32 offset)
 {
-       cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 data[CFI_MAX_BUS_WIDTH * 4];
-       
+
        target->type->read_memory(target, flash_address(bank, sector, offset), bank->bus_width, 4, data);
-       
-       if (cfi_info->target->endianness == TARGET_LITTLE_ENDIAN)
+
+       if (bank->target->endianness == TARGET_LITTLE_ENDIAN)
                return data[0] | data[bank->bus_width] << 8 | data[bank->bus_width * 2] << 16 | data[bank->bus_width * 3] << 24;
        else
-               return data[bank->bus_width - 1] | data[(2* bank->bus_width) - 1] << 8 | 
+               return data[bank->bus_width - 1] | data[(2* bank->bus_width) - 1] << 8 |
                                data[(3 * bank->bus_width) - 1] << 16 | data[(4 * bank->bus_width) - 1] << 24;
 }
 
 void cfi_intel_clear_status_register(flash_bank_t *bank)
 {
-       cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 command[8];
-       
+
        if (target->state != TARGET_HALTED)
        {
                ERROR("BUG: attempted to clear status register while target wasn't halted");
                exit(-1);
        }
-       
+
        cfi_command(bank, 0x50, command);
        target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
 }
@@ -242,7 +259,7 @@ void cfi_intel_clear_status_register(flash_bank_t *bank)
 u8 cfi_intel_wait_status_busy(flash_bank_t *bank, int timeout)
 {
        u8 status;
-       
+
        while ((!((status = cfi_get_u8(bank, 0, 0x0)) & 0x80)) && (timeout-- > 0))
        {
                DEBUG("status: 0x%x", status);
@@ -253,7 +270,7 @@ u8 cfi_intel_wait_status_busy(flash_bank_t *bank, int timeout)
        status = status & 0xfe;
 
        DEBUG("status: 0x%x", status);
-       
+
        if ((status & 0x80) != 0x80)
        {
                ERROR("timeout while waiting for WSM to become ready");
@@ -273,17 +290,17 @@ u8 cfi_intel_wait_status_busy(flash_bank_t *bank, int timeout)
                        ERROR("Error in Block Erasure or Clear Lock-Bits");
                if (status & 0x40)
                        ERROR("Block Erase Suspended");
-               
+
                cfi_intel_clear_status_register(bank);
        }
-       
+
        return status;
 }
 
 int cfi_spansion_wait_status_busy(flash_bank_t *bank, int timeout)
 {
        u8 status, oldstatus;
-       
+
        oldstatus = cfi_get_u8(bank, 0, 0x0);
 
        do {
@@ -304,11 +321,11 @@ int cfi_spansion_wait_status_busy(flash_bank_t *bank, int timeout)
                        DEBUG("status: 0x%x", status);
                        return(ERROR_OK);
                }
-               
+
                oldstatus = status;
                usleep(1000);
        } while (timeout-- > 0);
-       
+
        ERROR("timeout, status: 0x%x", status);
 
        return(ERROR_FLASH_BUSY);
@@ -318,15 +335,15 @@ int cfi_read_intel_pri_ext(flash_bank_t *bank)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
        cfi_intel_pri_ext_t *pri_ext = malloc(sizeof(cfi_intel_pri_ext_t));
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 command[8];
-       
+
        cfi_info->pri_ext = pri_ext;
-       
+
        pri_ext->pri[0] = cfi_query_u8(bank, 0, cfi_info->pri_addr + 0);
        pri_ext->pri[1] = cfi_query_u8(bank, 0, cfi_info->pri_addr + 1);
        pri_ext->pri[2] = cfi_query_u8(bank, 0, cfi_info->pri_addr + 2);
-       
+
        if ((pri_ext->pri[0] != 'P') || (pri_ext->pri[1] != 'R') || (pri_ext->pri[2] != 'I'))
        {
                cfi_command(bank, 0xf0, command);
@@ -335,37 +352,37 @@ int cfi_read_intel_pri_ext(flash_bank_t *bank)
                target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
                return ERROR_FLASH_BANK_INVALID;
        }
-       
+
        pri_ext->major_version = cfi_query_u8(bank, 0, cfi_info->pri_addr + 3);
        pri_ext->minor_version = cfi_query_u8(bank, 0, cfi_info->pri_addr + 4);
-       
+
        DEBUG("pri: '%c%c%c', version: %c.%c", pri_ext->pri[0], pri_ext->pri[1], pri_ext->pri[2], pri_ext->major_version, pri_ext->minor_version);
-       
+
        pri_ext->feature_support = cfi_query_u32(bank, 0, cfi_info->pri_addr + 5);
        pri_ext->suspend_cmd_support = cfi_query_u8(bank, 0, cfi_info->pri_addr + 9);
        pri_ext->blk_status_reg_mask = cfi_query_u16(bank, 0, cfi_info->pri_addr + 0xa);
-       
+
        DEBUG("feature_support: 0x%x, suspend_cmd_support: 0x%x, blk_status_reg_mask: 0x%x", pri_ext->feature_support, pri_ext->suspend_cmd_support, pri_ext->blk_status_reg_mask);
-       
+
        pri_ext->vcc_optimal = cfi_query_u8(bank, 0, cfi_info->pri_addr + 0xc);
        pri_ext->vpp_optimal = cfi_query_u8(bank, 0, cfi_info->pri_addr + 0xd);
-       
+
        DEBUG("Vcc opt: %1.1x.%1.1x, Vpp opt: %1.1x.%1.1x",
                  (pri_ext->vcc_optimal & 0xf0) >> 4, pri_ext->vcc_optimal & 0x0f,
                  (pri_ext->vpp_optimal & 0xf0) >> 4, pri_ext->vpp_optimal & 0x0f);
-       
+
        pri_ext->num_protection_fields = cfi_query_u8(bank, 0, cfi_info->pri_addr + 0xe);
        if (pri_ext->num_protection_fields != 1)
        {
                WARNING("expected one protection register field, but found %i", pri_ext->num_protection_fields);
        }
-       
+
        pri_ext->prot_reg_addr = cfi_query_u16(bank, 0, cfi_info->pri_addr + 0xf);
        pri_ext->fact_prot_reg_size = cfi_query_u8(bank, 0, cfi_info->pri_addr + 0x11);
        pri_ext->user_prot_reg_size = cfi_query_u8(bank, 0, cfi_info->pri_addr + 0x12);
 
        DEBUG("protection_fields: %i, prot_reg_addr: 0x%x, factory pre-programmed: %i, user programmable: %i", pri_ext->num_protection_fields, pri_ext->prot_reg_addr, 1 << pri_ext->fact_prot_reg_size, 1 << pri_ext->user_prot_reg_size);
-       
+
        return ERROR_OK;
 }
 
@@ -373,25 +390,25 @@ int cfi_read_spansion_pri_ext(flash_bank_t *bank)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
        cfi_spansion_pri_ext_t *pri_ext = malloc(sizeof(cfi_spansion_pri_ext_t));
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 command[8];
 
        cfi_info->pri_ext = pri_ext;
-       
+
        pri_ext->pri[0] = cfi_query_u8(bank, 0, cfi_info->pri_addr + 0);
        pri_ext->pri[1] = cfi_query_u8(bank, 0, cfi_info->pri_addr + 1);
        pri_ext->pri[2] = cfi_query_u8(bank, 0, cfi_info->pri_addr + 2);
-       
+
        if ((pri_ext->pri[0] != 'P') || (pri_ext->pri[1] != 'R') || (pri_ext->pri[2] != 'I'))
        {
                cfi_command(bank, 0xf0, command);
                target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
                return ERROR_FLASH_BANK_INVALID;
        }
-       
+
        pri_ext->major_version = cfi_query_u8(bank, 0, cfi_info->pri_addr + 3);
        pri_ext->minor_version = cfi_query_u8(bank, 0, cfi_info->pri_addr + 4);
-       
+
        DEBUG("pri: '%c%c%c', version: %c.%c", pri_ext->pri[0], pri_ext->pri[1], pri_ext->pri[2], pri_ext->major_version, pri_ext->minor_version);
 
        pri_ext->SiliconRevision = cfi_query_u8(bank, 0, cfi_info->pri_addr + 5);
@@ -414,13 +431,18 @@ int cfi_read_spansion_pri_ext(flash_bank_t *bank)
 
        DEBUG("Burst Mode: 0x%x, Page Mode: 0x%x, ", pri_ext->BurstMode, pri_ext->PageMode);
 
-       
+
        DEBUG("Vpp min: %2.2d.%1.1d, Vpp max: %2.2d.%1.1x",
                  (pri_ext->VppMin & 0xf0) >> 4, pri_ext->VppMin & 0x0f,
                  (pri_ext->VppMax & 0xf0) >> 4, pri_ext->VppMax & 0x0f);
-       
+
        DEBUG("WP# protection 0x%x", pri_ext->TopBottom);
-       
+
+       /* default values for implementation specific workarounds */
+       pri_ext->_unlock1 = cfi_unlock_addresses[CFI_UNLOCK_555_2AA].unlock1;
+       pri_ext->_unlock2 = cfi_unlock_addresses[CFI_UNLOCK_555_2AA].unlock2;
+       pri_ext->_reversed_geometry = 0;
+
        return ERROR_OK;
 }
 
@@ -429,41 +451,41 @@ int cfi_read_atmel_pri_ext(flash_bank_t *bank)
        cfi_atmel_pri_ext_t atmel_pri_ext;
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
        cfi_spansion_pri_ext_t *pri_ext = malloc(sizeof(cfi_spansion_pri_ext_t));
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 command[8];
-       
+
        /* ATMEL devices use the same CFI primary command set (0x2) as AMD/Spansion,
         * but a different primary extended query table.
         * We read the atmel table, and prepare a valid AMD/Spansion query table.
         */
-        
+
        memset(pri_ext, 0, sizeof(cfi_spansion_pri_ext_t));
-       
+
        cfi_info->pri_ext = pri_ext;
-       
+
        atmel_pri_ext.pri[0] = cfi_query_u8(bank, 0, cfi_info->pri_addr + 0);
        atmel_pri_ext.pri[1] = cfi_query_u8(bank, 0, cfi_info->pri_addr + 1);
        atmel_pri_ext.pri[2] = cfi_query_u8(bank, 0, cfi_info->pri_addr + 2);
-       
+
        if ((atmel_pri_ext.pri[0] != 'P') || (atmel_pri_ext.pri[1] != 'R') || (atmel_pri_ext.pri[2] != 'I'))
        {
                cfi_command(bank, 0xf0, command);
                target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
                return ERROR_FLASH_BANK_INVALID;
        }
-       
+
        pri_ext->pri[0] = atmel_pri_ext.pri[0];
        pri_ext->pri[1] = atmel_pri_ext.pri[1];
        pri_ext->pri[2] = atmel_pri_ext.pri[2];
-       
+
        atmel_pri_ext.major_version = cfi_query_u8(bank, 0, cfi_info->pri_addr + 3);
        atmel_pri_ext.minor_version = cfi_query_u8(bank, 0, cfi_info->pri_addr + 4);
-       
+
        DEBUG("pri: '%c%c%c', version: %c.%c", atmel_pri_ext.pri[0], atmel_pri_ext.pri[1], atmel_pri_ext.pri[2], atmel_pri_ext.major_version, atmel_pri_ext.minor_version);
-       
+
        pri_ext->major_version = atmel_pri_ext.major_version;
        pri_ext->minor_version = atmel_pri_ext.minor_version;
-       
+
        atmel_pri_ext.features = cfi_query_u8(bank, 0, cfi_info->pri_addr + 5);
        atmel_pri_ext.bottom_boot = cfi_query_u8(bank, 0, cfi_info->pri_addr + 6);
        atmel_pri_ext.burst_mode = cfi_query_u8(bank, 0, cfi_info->pri_addr + 7);
@@ -471,7 +493,7 @@ int cfi_read_atmel_pri_ext(flash_bank_t *bank)
 
        DEBUG("features: 0x%2.2x, bottom_boot: 0x%2.2x, burst_mode: 0x%2.2x, page_mode: 0x%2.2x",
                atmel_pri_ext.features, atmel_pri_ext.bottom_boot, atmel_pri_ext.burst_mode, atmel_pri_ext.page_mode);
-       
+
        if (atmel_pri_ext.features & 0x02)
                pri_ext->EraseSuspend = 2;
 
@@ -479,14 +501,17 @@ int cfi_read_atmel_pri_ext(flash_bank_t *bank)
                pri_ext->TopBottom = 2;
        else
                pri_ext->TopBottom = 3;
-       
+
+       pri_ext->_unlock1 = cfi_unlock_addresses[CFI_UNLOCK_555_2AA].unlock1;
+       pri_ext->_unlock2 = cfi_unlock_addresses[CFI_UNLOCK_555_2AA].unlock2;
+
        return ERROR_OK;
 }
 
 int cfi_read_0002_pri_ext(flash_bank_t *bank)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       
+
        if (cfi_info->manufacturer == CFI_MFR_ATMEL)
        {
                return cfi_read_atmel_pri_ext(bank);
@@ -502,29 +527,29 @@ int cfi_spansion_info(struct flash_bank_s *bank, char *buf, int buf_size)
        int printed;
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
        cfi_spansion_pri_ext_t *pri_ext = cfi_info->pri_ext;
-               
+
        printed = snprintf(buf, buf_size, "\nSpansion primary algorithm extend information:\n");
        buf += printed;
        buf_size -= printed;
-       
-       printed = snprintf(buf, buf_size, "pri: '%c%c%c', version: %c.%c\n", pri_ext->pri[0], 
-                          pri_ext->pri[1], pri_ext->pri[2], 
+
+       printed = snprintf(buf, buf_size, "pri: '%c%c%c', version: %c.%c\n", pri_ext->pri[0],
+                          pri_ext->pri[1], pri_ext->pri[2],
                           pri_ext->major_version, pri_ext->minor_version);
        buf += printed;
        buf_size -= printed;
-       
-       printed = snprintf(buf, buf_size, "Silicon Rev.: 0x%x, Address Sensitive unlock: 0x%x\n", 
+
+       printed = snprintf(buf, buf_size, "Silicon Rev.: 0x%x, Address Sensitive unlock: 0x%x\n",
                           (pri_ext->SiliconRevision) >> 2,
                           (pri_ext->SiliconRevision) & 0x03);
        buf += printed;
        buf_size -= printed;
-       
-       printed = snprintf(buf, buf_size, "Erase Suspend: 0x%x, Sector Protect: 0x%x\n", 
+
+       printed = snprintf(buf, buf_size, "Erase Suspend: 0x%x, Sector Protect: 0x%x\n",
                           pri_ext->EraseSuspend,
                           pri_ext->BlkProt);
        buf += printed;
        buf_size -= printed;
-       
+
        printed = snprintf(buf, buf_size, "VppMin: %2.2d.%1.1x, VppMax: %2.2d.%1.1x\n",
                (pri_ext->VppMin & 0xf0) >> 4, pri_ext->VppMin & 0x0f,
                (pri_ext->VppMax & 0xf0) >> 4, pri_ext->VppMax & 0x0f);
@@ -537,34 +562,34 @@ int cfi_intel_info(struct flash_bank_s *bank, char *buf, int buf_size)
        int printed;
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
        cfi_intel_pri_ext_t *pri_ext = cfi_info->pri_ext;
-               
+
        printed = snprintf(buf, buf_size, "\nintel primary algorithm extend information:\n");
        buf += printed;
        buf_size -= printed;
-       
+
        printed = snprintf(buf, buf_size, "pri: '%c%c%c', version: %c.%c\n", pri_ext->pri[0], pri_ext->pri[1], pri_ext->pri[2], pri_ext->major_version, pri_ext->minor_version);
        buf += printed;
        buf_size -= printed;
-       
+
        printed = snprintf(buf, buf_size, "feature_support: 0x%x, suspend_cmd_support: 0x%x, blk_status_reg_mask: 0x%x\n", pri_ext->feature_support, pri_ext->suspend_cmd_support, pri_ext->blk_status_reg_mask);
        buf += printed;
        buf_size -= printed;
-       
+
        printed = snprintf(buf, buf_size, "Vcc opt: %1.1x.%1.1x, Vpp opt: %1.1x.%1.1x\n",
                (pri_ext->vcc_optimal & 0xf0) >> 4, pri_ext->vcc_optimal & 0x0f,
                (pri_ext->vpp_optimal & 0xf0) >> 4, pri_ext->vpp_optimal & 0x0f);
        buf += printed;
        buf_size -= printed;
-       
+
        printed = snprintf(buf, buf_size, "protection_fields: %i, prot_reg_addr: 0x%x, factory pre-programmed: %i, user programmable: %i\n", pri_ext->num_protection_fields, pri_ext->prot_reg_addr, 1 << pri_ext->fact_prot_reg_size, 1 << pri_ext->user_prot_reg_size);
-       
+
        return ERROR_OK;
 }
 
 int cfi_register_commands(struct command_context_s *cmd_ctx)
 {
        /*command_t *cfi_cmd = */register_command(cmd_ctx, NULL, "cfi", NULL, COMMAND_ANY, NULL);
-       /*      
+       /*
        register_command(cmd_ctx, cfi_cmd, "part_id", cfi_handle_part_id_command, COMMAND_EXEC,
                                         "print part id of cfi flash bank <num>");
        */
@@ -577,108 +602,110 @@ int cfi_flash_bank_command(struct command_context_s *cmd_ctx, char *cmd, char **
 {
        cfi_flash_bank_t *cfi_info;
        int i;
-       
+
        if (argc < 6)
        {
                WARNING("incomplete flash_bank cfi configuration");
                return ERROR_FLASH_BANK_INVALID;
        }
-       
+
        if ((strtoul(args[4], NULL, 0) > CFI_MAX_CHIP_WIDTH)
                || (strtoul(args[3], NULL, 0) > CFI_MAX_BUS_WIDTH))
        {
                ERROR("chip and bus width have to specified in byte");
                return ERROR_FLASH_BANK_INVALID;
        }
-       
+
        cfi_info = malloc(sizeof(cfi_flash_bank_t));
        bank->driver_priv = cfi_info;
-       
-       cfi_info->x16_as_x8 = 1;
-       
-       cfi_info->target = get_target_by_num(strtoul(args[5], NULL, 0));
-       if (!cfi_info->target)
-       {
-               ERROR("no target '%s' configured", args[5]);
-               exit(-1);
-       }
+  
+  cfi_info->write_algorithm       = NULL;
+  cfi_info->erase_check_algorithm = NULL;
+
+       cfi_info->x16_as_x8 = 0;
+       cfi_info->jedec_probe = 0;
+       cfi_info->not_cfi = 0;
 
        for (i = 6; i < argc; i++)
        {
-               if (strcmp(args[i], "x16_as_x8") != 0)
+               if (strcmp(args[i], "x16_as_x8") == 0)
+               {
+                       cfi_info->x16_as_x8 = 1;
+               }
+               else if (strcmp(args[i], "jedec_probe") == 0)
                {
-                       cfi_info->x16_as_x8 = 0;
+                       cfi_info->jedec_probe = 1;
                }
        }
-               
+
        cfi_info->write_algorithm = NULL;
 
        /* bank wasn't probed yet */
        cfi_info->qry[0] = -1;
-       
+
        return ERROR_OK;
 }
 
 int cfi_intel_erase(struct flash_bank_s *bank, int first, int last)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 command[8];
        int i;
-       
+
        cfi_intel_clear_status_register(bank);
 
        for (i = first; i <= last; i++)
        {
                cfi_command(bank, 0x20, command);
                target->type->write_memory(target, flash_address(bank, i, 0x0), bank->bus_width, 1, command);
-                       
+
                cfi_command(bank, 0xd0, command);
                target->type->write_memory(target, flash_address(bank, i, 0x0), bank->bus_width, 1, command);
-               
+
                if (cfi_intel_wait_status_busy(bank, 1000 * (1 << cfi_info->block_erase_timeout_typ)) == 0x80)
                        bank->sectors[i].is_erased = 1;
                else
                {
                        cfi_command(bank, 0xff, command);
                        target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
-                       
+
                        ERROR("couldn't erase block %i of flash bank at base 0x%x", i, bank->base);
                        return ERROR_FLASH_OPERATION_FAILED;
                }
        }
-       
+
        cfi_command(bank, 0xff, command);
        target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
-       
+
        return ERROR_OK;
 }
-       
+
 int cfi_spansion_erase(struct flash_bank_s *bank, int first, int last)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
        cfi_spansion_pri_ext_t *pri_ext = cfi_info->pri_ext;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 command[8];
        int i;
-       
+
        for (i = first; i <= last; i++)
        {
                cfi_command(bank, 0xaa, command);
-               target->type->write_memory(target, flash_address(bank, 0, 0x555), bank->bus_width, 1, command);
-                       
+               target->type->write_memory(target, flash_address(bank, 0, pri_ext->_unlock1), bank->bus_width, 1, command);
+
                cfi_command(bank, 0x55, command);
-               target->type->write_memory(target, flash_address(bank, 0, 0x2aa), bank->bus_width, 1, command);
-               
+               target->type->write_memory(target, flash_address(bank, 0, pri_ext->_unlock2), bank->bus_width, 1, command);
+
                cfi_command(bank, 0x80, command);
-               target->type->write_memory(target, flash_address(bank, 0, 0x555), bank->bus_width, 1, command);
+               target->type->write_memory(target, flash_address(bank, 0, pri_ext->_unlock1), bank->bus_width, 1, command);
 
                cfi_command(bank, 0xaa, command);
-               target->type->write_memory(target, flash_address(bank, 0, 0x555), bank->bus_width, 1, command);
-                       
+               target->type->write_memory(target, flash_address(bank, 0, pri_ext->_unlock1), bank->bus_width, 1, command);
+
                cfi_command(bank, 0x55, command);
-               target->type->write_memory(target, flash_address(bank, 0, 0x2aa), bank->bus_width, 1, command);
-               
+               target->type->write_memory(target, flash_address(bank, 0, pri_ext->_unlock2), bank->bus_width, 1, command);
+
                cfi_command(bank, 0x30, command);
                target->type->write_memory(target, flash_address(bank, i, 0x0), bank->bus_width, 1, command);
 
@@ -688,27 +715,27 @@ int cfi_spansion_erase(struct flash_bank_s *bank, int first, int last)
                {
                        cfi_command(bank, 0xf0, command);
                        target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
-                       
+
                        ERROR("couldn't erase block %i of flash bank at base 0x%x", i, bank->base);
                        return ERROR_FLASH_OPERATION_FAILED;
                }
        }
-       
+
        cfi_command(bank, 0xf0, command);
        target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
-       
+
        return ERROR_OK;
 }
-       
+
 int cfi_erase(struct flash_bank_s *bank, int first, int last)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       
-       if (cfi_info->target->state != TARGET_HALTED)
+
+       if (bank->target->state != TARGET_HALTED)
        {
                return ERROR_TARGET_NOT_HALTED;
        }
-       
+
        if ((first < 0) || (last < first) || (last >= bank->num_sectors))
        {
                return ERROR_FLASH_SECTOR_INVALID;
@@ -716,7 +743,7 @@ int cfi_erase(struct flash_bank_s *bank, int first, int last)
 
        if (cfi_info->qry[0] != 'Q')
                return ERROR_FLASH_BANK_NOT_PROBED;
-       
+
        switch(cfi_info->pri_id)
        {
                case 1:
@@ -730,7 +757,7 @@ int cfi_erase(struct flash_bank_s *bank, int first, int last)
                        ERROR("cfi primary command set %i unsupported", cfi_info->pri_id);
                        break;
        }
-       
+
        return ERROR_OK;
 }
 
@@ -738,17 +765,17 @@ int cfi_intel_protect(struct flash_bank_s *bank, int set, int first, int last)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
        cfi_intel_pri_ext_t *pri_ext = cfi_info->pri_ext;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 command[8];
        int retry = 0;
        int i;
-       
+
        /* if the device supports neither legacy lock/unlock (bit 3) nor
         * instant individual block locking (bit 5).
         */
        if (!(pri_ext->feature_support & 0x28))
                return ERROR_FLASH_OPERATION_FAILED;
-       
+
        cfi_intel_clear_status_register(bank);
 
        for (i = first; i <= last; i++)
@@ -784,25 +811,25 @@ int cfi_intel_protect(struct flash_bank_s *bank, int set, int first, int last)
                        cfi_command(bank, 0x90, command);
                        target->type->write_memory(target, flash_address(bank, 0, 0x55), bank->bus_width, 1, command);
                        block_status = cfi_get_u8(bank, i, 0x2);
-                       
+
                        if ((block_status & 0x1) != set)
                        {
                                ERROR("couldn't change block lock status (set = %i, block_status = 0x%2.2x)", set, block_status);
                                cfi_command(bank, 0x70, command);
                                target->type->write_memory(target, flash_address(bank, 0, 0x55), bank->bus_width, 1, command);
                                cfi_intel_wait_status_busy(bank, 10);
-                               
+
                                if (retry > 10)
                                        return ERROR_FLASH_OPERATION_FAILED;
                                else
                                {
                                        i--;
-                                       retry++;        
+                                       retry++;
                                }
-                       }               
+                       }
                }
        }
-       
+
        /* if the device doesn't support individual block lock bits set/clear,
         * all blocks have been unlocked in parallel, so we set those that should be protected
         */
@@ -810,42 +837,44 @@ int cfi_intel_protect(struct flash_bank_s *bank, int set, int first, int last)
        {
                for (i = 0; i < bank->num_sectors; i++)
                {
-                       cfi_intel_clear_status_register(bank);
-                       cfi_command(bank, 0x60, command);
-                       target->type->write_memory(target, flash_address(bank, i, 0x0), bank->bus_width, 1, command);
                        if (bank->sectors[i].is_protected == 1)
                        {
+                               cfi_intel_clear_status_register(bank);
+
+                               cfi_command(bank, 0x60, command);
+                               target->type->write_memory(target, flash_address(bank, i, 0x0), bank->bus_width, 1, command);
+
                                cfi_command(bank, 0x01, command);
                                target->type->write_memory(target, flash_address(bank, i, 0x0), bank->bus_width, 1, command);
+
+                               cfi_intel_wait_status_busy(bank, 100);
                        }
-                       
-                       cfi_intel_wait_status_busy(bank, 100);
                }
        }
-       
+
        cfi_command(bank, 0xff, command);
        target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
-       
+
        return ERROR_OK;
 }
 
 int cfi_protect(struct flash_bank_s *bank, int set, int first, int last)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       
-       if (cfi_info->target->state != TARGET_HALTED)
+
+       if (bank->target->state != TARGET_HALTED)
        {
                return ERROR_TARGET_NOT_HALTED;
        }
-       
+
        if ((first < 0) || (last < first) || (last >= bank->num_sectors))
        {
                return ERROR_FLASH_SECTOR_INVALID;
        }
-       
+
        if (cfi_info->qry[0] != 'Q')
                return ERROR_FLASH_BANK_NOT_PROBED;
-       
+
        switch(cfi_info->pri_id)
        {
                case 1:
@@ -856,45 +885,64 @@ int cfi_protect(struct flash_bank_s *bank, int set, int first, int last)
                        ERROR("cfi primary command set %i unsupported", cfi_info->pri_id);
                        break;
        }
-       
+
        return ERROR_OK;
 }
 
-void cfi_add_byte(struct flash_bank_s *bank, u8 *word, u8 byte)
+/* FIXME Replace this by a simple memcpy() - still unsure about sideeffects */
+static void cfi_add_byte(struct flash_bank_s *bank, u8 *word, u8 byte)
 {
-       cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       target_t *target = cfi_info->target;
+       //target_t *target = bank->target;
 
        int i;
-       
-       if (target->endianness == TARGET_LITTLE_ENDIAN)
-       {
+
+       // NOTE:
+       // The data to flash must not be changed in endian! We write a bytestrem in
+       // target byte order already. Only the control and status byte lane of the flash
+       // WSM is interpreted by the CPU in different ways, when read a u16 or u32
+       // word (data seems to be in the upper or lower byte lane for u16 accesses).
+
+       //if (target->endianness == TARGET_LITTLE_ENDIAN)
+       //{
                /* shift bytes */
                for (i = 0; i < bank->bus_width - 1; i++)
                        word[i] = word[i + 1];
                word[bank->bus_width - 1] = byte;
-       }
-       else
+       //}
+       //else
+       //{
+       //      /* shift bytes */
+       //      for (i = bank->bus_width - 1; i > 0; i--)
+       //              word[i] = word[i - 1];
+       //      word[0] = byte;
+       //}
+}
+
+/* Convert code image to target endian */
+/* FIXME create general block conversion fcts in target.c?) */ static
+void cfi_fix_code_endian(target_t *target, u32 *dest, const u32 *src, u32 count)
+{
+       u32 i;
+       for (i=0; i< count; i++)
        {
-               /* shift bytes */
-               for (i = bank->bus_width - 1; i > 0; i--)
-                       word[i] = word[i - 1];
-               word[0] = byte;
+               target_buffer_set_u32(target, (u8*)dest, *src);
+               dest++;
+               src++;
        }
 }
 
 int cfi_intel_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address, u32 count)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        reg_param_t reg_params[7];
        armv4_5_algorithm_t armv4_5_info;
        working_area_t *source;
        u32 buffer_size = 32768;
-       u8 write_command[CFI_MAX_BUS_WIDTH];
-       u8 busy_pattern[CFI_MAX_BUS_WIDTH];
-       u8 error_pattern[CFI_MAX_BUS_WIDTH];
-       int retval;
+       u8 write_command_buf[CFI_MAX_BUS_WIDTH];
+       u8 busy_pattern_buf[CFI_MAX_BUS_WIDTH];
+       u8 error_pattern_buf[CFI_MAX_BUS_WIDTH];
+       u32 write_command_val, busy_pattern_val, error_pattern_val;
 
        /* algorithm register usage:
         * r0: source address (in RAM)
@@ -905,8 +953,8 @@ int cfi_intel_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address, u3
         * r5: busy test pattern
         * r6: error test pattern
         */
-        
-       u32 word_32_code[] = {
+
+       static const u32 word_32_code[] = {
                0xe4904004,   /* loop:  ldr r4, [r0], #4 */
                0xe5813000,   /*                str r3, [r1] */
                0xe5814000,   /*                str r4, [r1] */
@@ -920,10 +968,10 @@ int cfi_intel_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address, u3
                0x0a000001,   /*                beq done */
                0xe2811004,   /*                add r1, r1 #4 */
                0xeafffff2,   /*                b loop */
-               0xeafffffe,   /* done:  b -2 */
+               0xeafffffe    /* done:  b -2 */
        };
-       
-       u32 word_16_code[] = {
+
+       static const u32 word_16_code[] = {
                0xe0d040b2,   /* loop:  ldrh r4, [r0], #2 */
                0xe1c130b0,   /*                strh r3, [r1] */
                0xe1c140b0,   /*                strh r4, [r1] */
@@ -937,10 +985,10 @@ int cfi_intel_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address, u3
                0x0a000001,   /*                beq done */
                0xe2811002,   /*                add r1, r1 #2 */
                0xeafffff2,   /*                b loop */
-               0xeafffffe,   /* done:  b -2 */
+               0xeafffffe    /* done:  b -2 */
        };
-       
-       u32 word_8_code[] = {
+
+       static const u32 word_8_code[] = {
                0xe4d04001,   /* loop:  ldrb r4, [r0], #1 */
                0xe5c13000,   /*                strb r3, [r1] */
                0xe5c14000,   /*                strb r4, [r1] */
@@ -954,57 +1002,89 @@ int cfi_intel_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address, u3
                0x0a000001,   /*                beq done */
                0xe2811001,   /*                add r1, r1 #1 */
                0xeafffff2,   /*                b loop */
-               0xeafffffe,   /* done:  b -2 */
+               0xeafffffe    /* done:  b -2 */
        };
-       
+       u32 target_code[CFI_MAX_INTEL_CODESIZE];
+       const u32 *target_code_src;
+       int target_code_size;
+       int retval = ERROR_OK;
+
+
        cfi_intel_clear_status_register(bank);
-               
+
        armv4_5_info.common_magic = ARMV4_5_COMMON_MAGIC;
        armv4_5_info.core_mode = ARMV4_5_MODE_SVC;
        armv4_5_info.core_state = ARMV4_5_STATE_ARM;
-                       
+  
+       /* If we are setting up the write_algorith, we need target_code_src */
+       /* if not we only need target_code_size.                                                                                                                */
+       /*                                                                                                                                                                                                                                                                      */
+       /* However, we don't want to create multiple code paths, so we                  */
+       /* do the unecessary evaluation of target_code_src, which the                   */
+       /* compiler will probably nicely optimize away if not needed                            */
+  
+       /* prepare algorithm code for target endian */
+       switch (bank->bus_width)
+       {
+       case 1 :
+               target_code_src = word_8_code;
+               target_code_size = sizeof(word_8_code);
+               break;
+       case 2 :
+               target_code_src = word_16_code;
+               target_code_size = sizeof(word_16_code);
+               break;
+       case 4 :
+               target_code_src = word_32_code;
+               target_code_size = sizeof(word_32_code);
+               break;
+       default:
+               ERROR("Unsupported bank buswidth %d, can't do block memory writes", bank->bus_width);
+               return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
+       }
+  
        /* flash write code */
        if (!cfi_info->write_algorithm)
        {
-               if (target_alloc_working_area(target, 4 * 14, &cfi_info->write_algorithm) != ERROR_OK)
+               if ( target_code_size > sizeof(target_code) )
                {
-                       WARNING("no working area available, can't do block memory writes");
+                       WARNING("Internal error - target code buffer to small. Increase CFI_MAX_INTEL_CODESIZE and recompile.");
                        return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
-               };
-                       
-               /* write algorithm code to working area */
-               if (bank->bus_width == 1)
-               {
-                       target_write_buffer(target, cfi_info->write_algorithm->address, 14 * 4, (u8*)word_8_code);
                }
-               else if (bank->bus_width == 2)
-               {
-                       target_write_buffer(target, cfi_info->write_algorithm->address, 14 * 4, (u8*)word_16_code);
-               }       
-               else if (bank->bus_width == 4)
+               cfi_fix_code_endian(target, target_code, target_code_src, target_code_size);
+
+               /* Get memory for block write handler */
+               retval = target_alloc_working_area(target, target_code_size, &cfi_info->write_algorithm);
+               if (retval != ERROR_OK)
                {
-                       target_write_buffer(target, cfi_info->write_algorithm->address, 14 * 4, (u8*)word_32_code);
-               }
-               else
+                       WARNING("No working area available, can't do block memory writes");
+                       return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
+               };
+
+               /* write algorithm code to working area */
+               retval = target_write_buffer(target, cfi_info->write_algorithm->address, target_code_size, (u8*)target_code);
+               if (retval != ERROR_OK)
                {
-                       return ERROR_FLASH_OPERATION_FAILED;
+                       ERROR("Unable to write block write code to target");
+                       goto cleanup;
                }
        }
-       
+
+       /* Get a workspace buffer for the data to flash starting with 32k size.
+          Half size until buffer would be smaller 256 Bytem then fail back */
+       /* FIXME Why 256 bytes, why not 32 bytes (smallest flash write page */
        while (target_alloc_working_area(target, buffer_size, &source) != ERROR_OK)
        {
                buffer_size /= 2;
                if (buffer_size <= 256)
                {
-                       /* if we already allocated the writing code, but failed to get a buffer, free the algorithm */
-                       if (cfi_info->write_algorithm)
-                               target_free_working_area(target, cfi_info->write_algorithm);
-                       
                        WARNING("no large enough working area available, can't do block memory writes");
-                       return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
+                       retval = ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
+                       goto cleanup;
                }
        };
 
+       /* setup algo registers */
        init_reg_param(&reg_params[0], "r0", 32, PARAM_OUT);
        init_reg_param(&reg_params[1], "r1", 32, PARAM_OUT);
        init_reg_param(&reg_params[2], "r2", 32, PARAM_OUT);
@@ -1013,46 +1093,100 @@ int cfi_intel_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address, u3
        init_reg_param(&reg_params[5], "r5", 32, PARAM_OUT);
        init_reg_param(&reg_params[6], "r6", 32, PARAM_OUT);
 
-       cfi_command(bank, 0x40, write_command);
-       cfi_command(bank, 0x80, busy_pattern);
-       cfi_command(bank, 0x7e, error_pattern);
+       /* prepare command and status register patterns */
+       cfi_command(bank, 0x40, write_command_buf);
+       cfi_command(bank, 0x80, busy_pattern_buf);
+       cfi_command(bank, 0x7e, error_pattern_buf);
+
+       switch (bank->bus_width)
+       {
+       case 1 :
+               write_command_val = write_command_buf[0];
+               busy_pattern_val = busy_pattern_buf[0];
+               error_pattern_val = error_pattern_buf[0];
+               break;
+       case 2 :
+               write_command_val = target_buffer_get_u16(target, write_command_buf);
+               busy_pattern_val = target_buffer_get_u16(target, busy_pattern_buf);
+               error_pattern_val = target_buffer_get_u16(target, error_pattern_buf);
+               break;
+       case 4 :
+               write_command_val = target_buffer_get_u32(target, write_command_buf);
+               busy_pattern_val = target_buffer_get_u32(target, busy_pattern_buf);
+               error_pattern_val = target_buffer_get_u32(target, error_pattern_buf);
+               break;
+       default :
+               ERROR("Unsupported bank buswidth %d, can't do block memory writes", bank->bus_width);
+               retval = ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
+               goto cleanup;
+       }
+
+       INFO("Using target buffer at 0x%08x and of size 0x%04x", source->address, buffer_size );
 
+       /* Programming main loop */
        while (count > 0)
        {
                u32 thisrun_count = (count > buffer_size) ? buffer_size : count;
-               
+               u32 wsm_error;
+
                target_write_buffer(target, source->address, thisrun_count, buffer);
-               
+
                buf_set_u32(reg_params[0].value, 0, 32, source->address);
                buf_set_u32(reg_params[1].value, 0, 32, address);
                buf_set_u32(reg_params[2].value, 0, 32, thisrun_count / bank->bus_width);
-               buf_set_u32(reg_params[3].value, 0, 32, target_buffer_get_u32(target, write_command));
-               buf_set_u32(reg_params[5].value, 0, 32, target_buffer_get_u32(target, busy_pattern));
-               buf_set_u32(reg_params[6].value, 0, 32, target_buffer_get_u32(target, error_pattern));
-               buf_set_u32(reg_params[5].value, 0, 32, buf_get_u32(busy_pattern, 0, 32));
-               buf_set_u32(reg_params[6].value, 0, 32, buf_get_u32(error_pattern, 0, 32));
-       
-               if ((retval = target->type->run_algorithm(target, 0, NULL, 7, reg_params, cfi_info->write_algorithm->address, cfi_info->write_algorithm->address + (13 * 4), 10000, &armv4_5_info)) != ERROR_OK)
+
+               buf_set_u32(reg_params[3].value, 0, 32, write_command_val);
+               buf_set_u32(reg_params[5].value, 0, 32, busy_pattern_val);
+               buf_set_u32(reg_params[6].value, 0, 32, error_pattern_val);
+
+               INFO("Write 0x%04x bytes to flash at 0x%08x", thisrun_count, address );
+
+               /* Execute algorithm, assume breakpoint for last instruction */
+               retval = target->type->run_algorithm(target, 0, NULL, 7, reg_params,
+                       cfi_info->write_algorithm->address,
+                       cfi_info->write_algorithm->address + target_code_size - sizeof(u32),
+                       10000, /* 10s should be enough for max. 32k of data */
+                       &armv4_5_info);
+
+               /* On failure try a fall back to direct word writes */
+               if (retval != ERROR_OK)
                {
                        cfi_intel_clear_status_register(bank);
-                       return ERROR_FLASH_OPERATION_FAILED;
+                       ERROR("Execution of flash algorythm failed. Can't fall back. Please report.");
+                       retval = ERROR_FLASH_OPERATION_FAILED;
+                       //retval = ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
+                       // FIXME To allow fall back or recovery, we must save the actual status
+                       //       somewhere, so that a higher level code can start recovery.
+                       goto cleanup;
                }
-       
-               if (buf_get_u32(reg_params[4].value, 0, 32) & target_buffer_get_u32(target, error_pattern))
+
+               /* Check return value from algo code */
+               wsm_error = buf_get_u32(reg_params[4].value, 0, 32) & error_pattern_val;
+               if (wsm_error)
                {
                        /* read status register (outputs debug inforation) */
                        cfi_intel_wait_status_busy(bank, 100);
                        cfi_intel_clear_status_register(bank);
-                       return ERROR_FLASH_OPERATION_FAILED;
+                       retval = ERROR_FLASH_OPERATION_FAILED;
+                       goto cleanup;
                }
-               
+
                buffer += thisrun_count;
                address += thisrun_count;
                count -= thisrun_count;
        }
-       
-       target_free_working_area(target, source);
-       
+
+       /* free up resources */
+cleanup:
+       if (source)
+               target_free_working_area(target, source);
+
+       if (cfi_info->write_algorithm)
+       {
+               target_free_working_area(target, cfi_info->write_algorithm);
+               cfi_info->write_algorithm = NULL;
+       }
+
        destroy_reg_param(&reg_params[0]);
        destroy_reg_param(&reg_params[1]);
        destroy_reg_param(&reg_params[2]);
@@ -1060,15 +1194,15 @@ int cfi_intel_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address, u3
        destroy_reg_param(&reg_params[4]);
        destroy_reg_param(&reg_params[5]);
        destroy_reg_param(&reg_params[6]);
-       
-       return ERROR_OK;
+
+       return retval;
 }
 
 int cfi_spansion_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address, u32 count)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
        cfi_spansion_pri_ext_t *pri_ext = cfi_info->pri_ext;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        reg_param_t reg_params[10];
        armv4_5_algorithm_t armv4_5_info;
        working_area_t *source;
@@ -1078,8 +1212,6 @@ int cfi_spansion_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address,
        int i;
        int retval;
        int exit_code = ERROR_OK;
-       int code_size;
-       void *code_p;
 
        /* input parameters - */
        /*      R0 = source address */
@@ -1095,8 +1227,8 @@ int cfi_spansion_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address,
        /* unlock registers - */
        /*  R8 = unlock1_addr */
        /*  R9 = unlock1_cmd */
-       /*  R10 = unlock1_addr */
-       /*  R11 = unlock1_cmd */
+       /*  R10 = unlock2_addr */
+       /*  R11 = unlock2_cmd */
 
        u32 word_32_code[] = {
                                                /* 00008100 <sp_32_code>:               */
@@ -1130,9 +1262,9 @@ int cfi_spansion_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address,
                                                /*                                                              */
                                                /* 00008154 <sp_32_done>:               */
                0xeafffffe              /* b    8154 <sp_32_done>               */
-        };
-        
-        u32 word_16_code[] = {
+               };
+
+               u32 word_16_code[] = {
                                /* 00008158 <sp_16_code>:              */
                0xe0d050b2,     /* ldrh r5, [r0], #2               */
                0xe1c890b0,     /* strh r9, [r8]                                */
@@ -1163,10 +1295,10 @@ int cfi_spansion_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address,
                0xeaffffe8,     /* b    8158 <sp_16_code>              */
                                /*                                     */
                                /* 000081ac <sp_16_done>:              */
-               0xeafffffe      /* b    81ac <sp_16_done>              */  
-        };
-        
-        u32 word_8_code[] = {
+               0xeafffffe      /* b    81ac <sp_16_done>              */
+               };
+
+               u32 word_8_code[] = {
                                /* 000081b0 <sp_16_code_end>:          */
                0xe4d05001,     /* ldrb r5, [r0], #1                   */
                0xe5c89000,     /* strb r9, [r8]                                */
@@ -1199,46 +1331,57 @@ int cfi_spansion_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address,
                                /* 00008204 <sp_8_done>:               */
                0xeafffffe      /* b    8204 <sp_8_done>               */
        };
-       
+
        armv4_5_info.common_magic = ARMV4_5_COMMON_MAGIC;
        armv4_5_info.core_mode = ARMV4_5_MODE_SVC;
        armv4_5_info.core_state = ARMV4_5_STATE_ARM;
-                       
+
        /* flash write code */
        if (!cfi_info->write_algorithm)
        {
-               /* write algorithm code to working area */
+               u8 *code_p;
+
+               /* convert bus-width dependent algorithm code to correct endiannes */
                if (bank->bus_width == 1)
                {
-                       code_size = sizeof(word_8_code);
-                       code_p = word_8_code;
+                       code_p = malloc(24 * 4);
+
+                       for (i = 0; i < 24; i++)
+                               target_buffer_set_u32(target, code_p + (i*4), word_8_code[i]);
                }
                else if (bank->bus_width == 2)
                {
-                       code_size = sizeof(word_16_code);
-                       code_p = word_16_code;
+                       code_p = malloc(24 * 4);
+
+                       for (i = 0; i < 24; i++)
+                               target_buffer_set_u32(target, code_p + (i*4), word_16_code[i]);
                }
                else if (bank->bus_width == 4)
                {
-                       code_size = sizeof(word_32_code);
-                       code_p = word_32_code;
+                       code_p = malloc(24 * 4);
+
+                       for (i = 0; i < 24; i++)
+                               target_buffer_set_u32(target, code_p + (i*4), word_32_code[i]);
                }
                else
                {
                        return ERROR_FLASH_OPERATION_FAILED;
                }
 
-               if (target_alloc_working_area(target, code_size,
-                                                     &cfi_info->write_algorithm) != ERROR_OK)
+               /* allocate working area */
+               if (target_alloc_working_area(target, 24 * 4,
+                       &cfi_info->write_algorithm) != ERROR_OK)
                {
                        WARNING("no working area available, can't do block memory writes");
                        return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
                }
-                       
-               target_write_buffer(target, cfi_info->write_algorithm->address, 
-                                   code_size, code_p);
+
+               /* write algorithm code to working area */
+               target_write_buffer(target, cfi_info->write_algorithm->address, 24 * 4, code_p);
+
+               free(code_p);
        }
-       
+
        while (target_alloc_working_area(target, buffer_size, &source) != ERROR_OK)
        {
                buffer_size /= 2;
@@ -1247,7 +1390,7 @@ int cfi_spansion_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address,
                        /* if we already allocated the writing code, but failed to get a buffer, free the algorithm */
                        if (cfi_info->write_algorithm)
                                target_free_working_area(target, cfi_info->write_algorithm);
-                       
+
                        WARNING("not enough working area available, can't do block memory writes");
                        return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
                }
@@ -1267,9 +1410,9 @@ int cfi_spansion_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address,
        while (count > 0)
        {
                u32 thisrun_count = (count > buffer_size) ? buffer_size : count;
-               
+
                target_write_buffer(target, source->address, thisrun_count, buffer);
-               
+
                buf_set_u32(reg_params[0].value, 0, 32, source->address);
                buf_set_u32(reg_params[1].value, 0, 32, address);
                buf_set_u32(reg_params[2].value, 0, 32, thisrun_count / bank->bus_width);
@@ -1277,30 +1420,32 @@ int cfi_spansion_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address,
                buf_set_u32(reg_params[3].value, 0, 32, buf_get_u32(write_command, 0, 32));
                cfi_command(bank, 0x80, write_command);
                buf_set_u32(reg_params[4].value, 0, 32, buf_get_u32(write_command, 0, 32));
-               buf_set_u32(reg_params[6].value, 0, 32, flash_address(bank, 0, 0x555));
+               buf_set_u32(reg_params[6].value, 0, 32, flash_address(bank, 0, pri_ext->_unlock1));
                buf_set_u32(reg_params[7].value, 0, 32, 0xaa);
-               buf_set_u32(reg_params[8].value, 0, 32, flash_address(bank, 0, 0xaaa));
+               buf_set_u32(reg_params[8].value, 0, 32, flash_address(bank, 0, pri_ext->_unlock2));
                buf_set_u32(reg_params[9].value, 0, 32, 0x55);
-       
-               retval = target->type->run_algorithm(target, 0, NULL, 10, reg_params, 
-                                                    cfi_info->write_algorithm->address, 
-                                                    cfi_info->write_algorithm->address + (code_size - 4), 
+
+               retval = target->type->run_algorithm(target, 0, NULL, 10, reg_params,
+                                                    cfi_info->write_algorithm->address,
+                                                    cfi_info->write_algorithm->address + ((24 * 4) - 4),
                                                     10000, &armv4_5_info);
 
                status = buf_get_u32(reg_params[5].value, 0, 32);
+
                if ((retval != ERROR_OK) || status != 0x80)
                {
                        DEBUG("status: 0x%x", status);
                        exit_code = ERROR_FLASH_OPERATION_FAILED;
                        break;
                }
-               
+
                buffer += thisrun_count;
                address += thisrun_count;
                count -= thisrun_count;
        }
-       
+
+       target_free_working_area(target, source);
+
        destroy_reg_param(&reg_params[0]);
        destroy_reg_param(&reg_params[1]);
        destroy_reg_param(&reg_params[2]);
@@ -1318,24 +1463,94 @@ int cfi_spansion_write_block(struct flash_bank_s *bank, u8 *buffer, u32 address,
 int cfi_intel_write_word(struct flash_bank_s *bank, u8 *word, u32 address)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 command[8];
-       
+
        cfi_intel_clear_status_register(bank);
        cfi_command(bank, 0x40, command);
        target->type->write_memory(target, address, bank->bus_width, 1, command);
-       
+
        target->type->write_memory(target, address, bank->bus_width, 1, word);
-       
+
        if (cfi_intel_wait_status_busy(bank, 1000 * (1 << cfi_info->word_write_timeout_max)) != 0x80)
        {
                cfi_command(bank, 0xff, command);
                target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
-               
+
                ERROR("couldn't write word at base 0x%x, address %x", bank->base, address);
                return ERROR_FLASH_OPERATION_FAILED;
        }
-       
+
+       return ERROR_OK;
+}
+
+int cfi_intel_write_words(struct flash_bank_s *bank, u8 *word, u32 wordcount, u32 address)
+{
+       cfi_flash_bank_t *cfi_info = bank->driver_priv;
+       target_t *target = bank->target;
+       u8 command[8];
+
+       /* Calculate buffer size and boundary mask */
+       u32 buffersize = 1UL << cfi_info->max_buf_write_size;
+       u32 buffermask = buffersize-1;
+       u32 bufferwsize;
+
+       /* Check for valid range */
+       if (address & buffermask)
+       {
+               ERROR("Write address at base 0x%x, address %x not aligned to 2^%d boundary", bank->base, address, cfi_info->max_buf_write_size);
+               return ERROR_FLASH_OPERATION_FAILED;
+       }
+       switch(bank->chip_width)
+       {
+       case 4 : bufferwsize = buffersize / 4; break;
+       case 2 : bufferwsize = buffersize / 2; break;
+       case 1 : bufferwsize = buffersize; break;
+       default:
+               ERROR("Unsupported chip width %d", bank->chip_width);
+               return ERROR_FLASH_OPERATION_FAILED;
+       }
+
+       /* Check for valid size */
+       if (wordcount > bufferwsize)
+       {
+               ERROR("Number of data words %d exceeds available buffersize %d", wordcount, buffersize);
+               return ERROR_FLASH_OPERATION_FAILED;
+       }
+
+       /* Write to flash buffer */
+       cfi_intel_clear_status_register(bank);
+
+       /* Initiate buffer operation _*/
+       cfi_command(bank, 0xE8, command);
+       target->type->write_memory(target, address, bank->bus_width, 1, command);
+       if (cfi_intel_wait_status_busy(bank, 1000 * (1 << cfi_info->buf_write_timeout_max)) != 0x80)
+       {
+               cfi_command(bank, 0xff, command);
+               target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
+
+               ERROR("couldn't start buffer write operation at base 0x%x, address %x", bank->base, address);
+               return ERROR_FLASH_OPERATION_FAILED;
+       }
+
+       /* Write buffer wordcount-1 and data words */
+       cfi_command(bank, bufferwsize-1, command);
+       target->type->write_memory(target, address, bank->bus_width, 1, command);
+
+       target->type->write_memory(target, address, bank->bus_width, bufferwsize, word);
+
+       /* Commit write operation */
+       cfi_command(bank, 0xd0, command);
+       target->type->write_memory(target, address, bank->bus_width, 1, command);
+       if (cfi_intel_wait_status_busy(bank, 1000 * (1 << cfi_info->buf_write_timeout_max)) != 0x80)
+       {
+               cfi_command(bank, 0xff, command);
+               target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
+
+               ERROR("Buffer write at base 0x%x, address %x failed.", bank->base, address);
+               return ERROR_FLASH_OPERATION_FAILED;
+       }
+
        return ERROR_OK;
 }
 
@@ -1343,36 +1558,36 @@ int cfi_spansion_write_word(struct flash_bank_s *bank, u8 *word, u32 address)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
        cfi_spansion_pri_ext_t *pri_ext = cfi_info->pri_ext;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 command[8];
-       
+
        cfi_command(bank, 0xaa, command);
-       target->type->write_memory(target, flash_address(bank, 0, 0x555), bank->bus_width, 1, command);
-       
+       target->type->write_memory(target, flash_address(bank, 0, pri_ext->_unlock1), bank->bus_width, 1, command);
+
        cfi_command(bank, 0x55, command);
-       target->type->write_memory(target, flash_address(bank, 0, 0x2aa), bank->bus_width, 1, command);
-       
+       target->type->write_memory(target, flash_address(bank, 0, pri_ext->_unlock2), bank->bus_width, 1, command);
+
        cfi_command(bank, 0xa0, command);
-       target->type->write_memory(target, flash_address(bank, 0, 0x555), bank->bus_width, 1, command);
+       target->type->write_memory(target, flash_address(bank, 0, pri_ext->_unlock1), bank->bus_width, 1, command);
 
        target->type->write_memory(target, address, bank->bus_width, 1, word);
-       
+
        if (cfi_spansion_wait_status_busy(bank, 1000 * (1 << cfi_info->word_write_timeout_max)) != ERROR_OK)
        {
                cfi_command(bank, 0xf0, command);
                target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
-               
+
                ERROR("couldn't write word at base 0x%x, address %x", bank->base, address);
                return ERROR_FLASH_OPERATION_FAILED;
        }
-       
+
        return ERROR_OK;
 }
 
 int cfi_write_word(struct flash_bank_s *bank, u8 *word, u32 address)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       
+
        switch(cfi_info->pri_id)
        {
                case 1:
@@ -1386,29 +1601,52 @@ int cfi_write_word(struct flash_bank_s *bank, u8 *word, u32 address)
                        ERROR("cfi primary command set %i unsupported", cfi_info->pri_id);
                        break;
        }
-       
+
+       return ERROR_FLASH_OPERATION_FAILED;
+}
+
+int cfi_write_words(struct flash_bank_s *bank, u8 *word, u32 wordcount, u32 address)
+{
+       cfi_flash_bank_t *cfi_info = bank->driver_priv;
+
+       switch(cfi_info->pri_id)
+       {
+               case 1:
+               case 3:
+                       return cfi_intel_write_words(bank, word, wordcount, address);
+                       break;
+               case 2:
+                       //return cfi_spansion_write_words(bank, word, address);
+                       ERROR("cfi primary command set %i unimplemented - FIXME", cfi_info->pri_id);
+                       break;
+               default:
+                       ERROR("cfi primary command set %i unsupported", cfi_info->pri_id);
+                       break;
+       }
+
        return ERROR_FLASH_OPERATION_FAILED;
 }
 
 int cfi_write(struct flash_bank_s *bank, u8 *buffer, u32 offset, u32 count)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u32 address = bank->base + offset;      /* address of first byte to be programmed */
        u32 write_p, copy_p;
        int align;      /* number of unaligned bytes */
+       int blk_count; /* number of bus_width bytes for block copy */
        u8 current_word[CFI_MAX_BUS_WIDTH * 4]; /* word (bus_width size) currently being programmed */
        int i;
        int retval;
-       
-       if (cfi_info->target->state != TARGET_HALTED)
+
+       if (bank->target->state != TARGET_HALTED)
        {
                return ERROR_TARGET_NOT_HALTED;
        }
-       
+
        if (offset + count > bank->size)
                return ERROR_FLASH_DST_OUT_OF_BANK;
-       
+
        if (cfi_info->qry[0] != 'Q')
                return ERROR_FLASH_BANK_NOT_PROBED;
 
@@ -1416,6 +1654,8 @@ int cfi_write(struct flash_bank_s *bank, u8 *buffer, u32 offset, u32 count)
        write_p = address & ~(bank->bus_width - 1);
        if ((align = address - write_p) != 0)
        {
+               INFO("Fixup %d unaligned head bytes", align );
+
                for (i = 0; i < bank->bus_width; i++)
                        current_word[i] = 0;
                copy_p = write_p;
@@ -1443,62 +1683,110 @@ int cfi_write(struct flash_bank_s *bank, u8 *buffer, u32 offset, u32 count)
                        target->type->read_memory(target, copy_p, 1, 1, &byte);
                        cfi_add_byte(bank, current_word, byte);
                }
-               
+
                retval = cfi_write_word(bank, current_word, write_p);
                if (retval != ERROR_OK)
                        return retval;
                write_p = copy_p;
        }
-       
+
        /* handle blocks of bus_size aligned bytes */
+       blk_count = count & ~(bank->bus_width - 1); /* round down, leave tail bytes */
        switch(cfi_info->pri_id)
        {
                /* try block writes (fails without working area) */
                case 1:
                case 3:
-                       retval = cfi_intel_write_block(bank, buffer, write_p, count);
+                       retval = cfi_intel_write_block(bank, buffer, write_p, blk_count);
                        break;
                case 2:
-                       retval = cfi_spansion_write_block(bank, buffer, write_p, count);
+                       retval = cfi_spansion_write_block(bank, buffer, write_p, blk_count);
                        break;
                default:
                        ERROR("cfi primary command set %i unsupported", cfi_info->pri_id);
-      retval = ERROR_FLASH_OPERATION_FAILED;
+                       retval = ERROR_FLASH_OPERATION_FAILED;
                        break;
        }
-       if (retval != ERROR_OK)
+       if (retval == ERROR_OK)
+       {
+               /* Increment pointers and decrease count on succesful block write */
+               buffer += blk_count;
+               write_p += blk_count;
+               count -= blk_count;
+       }
+       else
        {
                if (retval == ERROR_TARGET_RESOURCE_NOT_AVAILABLE)
                {
+                       u32 buffersize = 1UL << cfi_info->max_buf_write_size;
+                       u32 buffermask = buffersize-1;
+                       u32 bufferwsize;
+
+                       switch(bank->chip_width)
+                       {
+                       case 4 : bufferwsize = buffersize / 4; break;
+                       case 2 : bufferwsize = buffersize / 2; break;
+                       case 1 : bufferwsize = buffersize; break;
+                       default:
+                               ERROR("Unsupported chip width %d", bank->chip_width);
+                               return ERROR_FLASH_OPERATION_FAILED;
+                       }
+
                        /* fall back to memory writes */
                        while (count > bank->bus_width)
                        {
-                               for (i = 0; i < bank->bus_width; i++)
-                                       current_word[i] = 0;
-                       
-                               for (i = 0; i < bank->bus_width; i++)
+                               if ((write_p & 0xff) == 0)
+                               {
+                                       INFO("Programming at %08x, count %08x bytes remaining", write_p, count);
+                               }
+                               if ((count > bufferwsize) && !(write_p & buffermask))
                                {
-                                       cfi_add_byte(bank, current_word, *buffer++);
+                                       retval = cfi_write_words(bank, buffer, bufferwsize, write_p);
+                                       if (retval != ERROR_OK)
+                                               return retval;
+
+                                       buffer += buffersize;
+                                       write_p += buffersize;
+                                       count -= buffersize;
+                               }
+                               else
+                               {
+                                       for (i = 0; i < bank->bus_width; i++)
+                                               current_word[i] = 0;
+
+                                       for (i = 0; i < bank->bus_width; i++)
+                                       {
+                                               cfi_add_byte(bank, current_word, *buffer++);
+                                       }
+
+                                       retval = cfi_write_word(bank, current_word, write_p);
+                                       if (retval != ERROR_OK)
+                                               return retval;
+
+                                       write_p += bank->bus_width;
+                                       count -= bank->bus_width;
                                }
-                       
-                               retval = cfi_write_word(bank, current_word, write_p);
-                               if (retval != ERROR_OK)
-                                       return retval;
-                               write_p += bank->bus_width;
-                               count -= bank->bus_width;
                        }
                }
                else
                        return retval;
        }
-       
+
+       /* return to read array mode, so we can read from flash again for padding */
+       cfi_command(bank, 0xf0, current_word);
+       target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, current_word);
+       cfi_command(bank, 0xff, current_word);
+       target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, current_word);
+
        /* handle unaligned tail bytes */
        if (count > 0)
        {
+               INFO("Fixup %d unaligned tail bytes", count );
+
                copy_p = write_p;
                for (i = 0; i < bank->bus_width; i++)
                        current_word[i] = 0;
-               
+
                for (i = 0; (i < bank->bus_width) && (count > 0); ++i, ++copy_p)
                {
                        cfi_add_byte(bank, current_word, *buffer++);
@@ -1514,13 +1802,13 @@ int cfi_write(struct flash_bank_s *bank, u8 *buffer, u32 offset, u32 count)
                if (retval != ERROR_OK)
                        return retval;
        }
-       
+
        /* return to read array mode */
        cfi_command(bank, 0xf0, current_word);
        target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, current_word);
        cfi_command(bank, 0xff, current_word);
        target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, current_word);
-       
+
        return ERROR_OK;
 }
 
@@ -1528,7 +1816,7 @@ void cfi_fixup_atmel_reversed_erase_regions(flash_bank_t *bank, void *param)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
        cfi_spansion_pri_ext_t *pri_ext = cfi_info->pri_ext;
-       
+
        pri_ext->_reversed_geometry = 1;
 }
 
@@ -1537,16 +1825,16 @@ void cfi_fixup_0002_erase_regions(flash_bank_t *bank, void *param)
        int i;
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
        cfi_spansion_pri_ext_t *pri_ext = cfi_info->pri_ext;
-       
+
        if ((pri_ext->_reversed_geometry) || (pri_ext->TopBottom == 3))
        {
                DEBUG("swapping reversed erase region information on cmdset 0002 device");
-               
+
                for (i = 0; i < cfi_info->num_erase_regions / 2; i++)
                {
                        int j = (cfi_info->num_erase_regions - 1) - i;
                        u32 swap;
-       
+
                        swap = cfi_info->erase_region_info[i];
                        cfi_info->erase_region_info[i] = cfi_info->erase_region_info[j];
                        cfi_info->erase_region_info[j] = swap;
@@ -1554,23 +1842,44 @@ void cfi_fixup_0002_erase_regions(flash_bank_t *bank, void *param)
        }
 }
 
+void cfi_fixup_0002_unlock_addresses(flash_bank_t *bank, void *param)
+{
+       cfi_flash_bank_t *cfi_info = bank->driver_priv;
+       cfi_spansion_pri_ext_t *pri_ext = cfi_info->pri_ext;
+       cfi_unlock_addresses_t *unlock_addresses = param;
+
+       pri_ext->_unlock1 = unlock_addresses->unlock1;
+       pri_ext->_unlock2 = unlock_addresses->unlock2;
+}
+
 int cfi_probe(struct flash_bank_s *bank)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 command[8];
        int num_sectors = 0;
        int i;
        int sector = 0;
        u32 offset = 0;
-               
+       u32 unlock1 = 0x555;
+       u32 unlock2 = 0x2aa;
+
+       /* JEDEC standard JESD21C uses 0x5555 and 0x2aaa as unlock addresses,
+        * while CFI compatible AMD/Spansion flashes use 0x555 and 0x2aa
+        */
+       if (cfi_info->jedec_probe)
+       {
+               unlock1 = 0x5555;
+               unlock2 = 0x2aaa;
+       }
+
        /* switch to read identifier codes mode ("AUTOSELECT") */
        cfi_command(bank, 0xaa, command);
-       target->type->write_memory(target, flash_address(bank, 0, 0x555), bank->bus_width, 1, command);
+       target->type->write_memory(target, flash_address(bank, 0, unlock1), bank->bus_width, 1, command);
        cfi_command(bank, 0x55, command);
-       target->type->write_memory(target, flash_address(bank, 0, 0x2aa), bank->bus_width, 1, command);
+       target->type->write_memory(target, flash_address(bank, 0, unlock2), bank->bus_width, 1, command);
        cfi_command(bank, 0x90, command);
-       target->type->write_memory(target, flash_address(bank, 0, 0x555), bank->bus_width, 1, command);
+       target->type->write_memory(target, flash_address(bank, 0, unlock1), bank->bus_width, 1, command);
 
        if (bank->chip_width == 1)
        {
@@ -1585,7 +1894,7 @@ int cfi_probe(struct flash_bank_s *bank)
                target_read_u16(target, bank->base + 0x0, &cfi_info->manufacturer);
                target_read_u16(target, bank->base + 0x2, &cfi_info->device_id);
        }
-       
+
        /* switch back to read array mode */
        cfi_command(bank, 0xf0, command);
        target->type->write_memory(target, flash_address(bank, 0, 0x00), bank->bus_width, 1, command);
@@ -1594,118 +1903,145 @@ int cfi_probe(struct flash_bank_s *bank)
 
        cfi_fixup(bank, cfi_jedec_fixups);
 
-       /* enter CFI query mode
-        * according to JEDEC Standard No. 68.01,
-        * a single bus sequence with address = 0x55, data = 0x98 should put
-        * the device into CFI query mode.
-        * 
-        * SST flashes clearly violate this, and we will consider them incompatbile for now
+       /* query only if this is a CFI compatible flash,
+        * otherwise the relevant info has already been filled in
         */
-       cfi_command(bank, 0x98, command);
-       target->type->write_memory(target, flash_address(bank, 0, 0x55), bank->bus_width, 1, command);
-       
-       cfi_info->qry[0] = cfi_query_u8(bank, 0, 0x10);
-       cfi_info->qry[1] = cfi_query_u8(bank, 0, 0x11);
-       cfi_info->qry[2] = cfi_query_u8(bank, 0, 0x12);
-       
-       DEBUG("CFI qry returned: 0x%2.2x 0x%2.2x 0x%2.2x", cfi_info->qry[0], cfi_info->qry[1], cfi_info->qry[2]);
-       
-       if ((cfi_info->qry[0] != 'Q') || (cfi_info->qry[1] != 'R') || (cfi_info->qry[2] != 'Y'))
+       if (cfi_info->not_cfi == 0)
        {
+               /* enter CFI query mode
+                * according to JEDEC Standard No. 68.01,
+                * a single bus sequence with address = 0x55, data = 0x98 should put
+                * the device into CFI query mode.
+                *
+                * SST flashes clearly violate this, and we will consider them incompatbile for now
+                */
+               cfi_command(bank, 0x98, command);
+               target->type->write_memory(target, flash_address(bank, 0, 0x55), bank->bus_width, 1, command);
+
+               cfi_info->qry[0] = cfi_query_u8(bank, 0, 0x10);
+               cfi_info->qry[1] = cfi_query_u8(bank, 0, 0x11);
+               cfi_info->qry[2] = cfi_query_u8(bank, 0, 0x12);
+
+               DEBUG("CFI qry returned: 0x%2.2x 0x%2.2x 0x%2.2x", cfi_info->qry[0], cfi_info->qry[1], cfi_info->qry[2]);
+
+               if ((cfi_info->qry[0] != 'Q') || (cfi_info->qry[1] != 'R') || (cfi_info->qry[2] != 'Y'))
+               {
+                       cfi_command(bank, 0xf0, command);
+                       target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
+                       cfi_command(bank, 0xff, command);
+                       target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
+                       return ERROR_FLASH_BANK_INVALID;
+               }
+
+               cfi_info->pri_id = cfi_query_u16(bank, 0, 0x13);
+               cfi_info->pri_addr = cfi_query_u16(bank, 0, 0x15);
+               cfi_info->alt_id = cfi_query_u16(bank, 0, 0x17);
+               cfi_info->alt_addr = cfi_query_u16(bank, 0, 0x19);
+
+               DEBUG("qry: '%c%c%c', pri_id: 0x%4.4x, pri_addr: 0x%4.4x, alt_id: 0x%4.4x, alt_addr: 0x%4.4x", cfi_info->qry[0], cfi_info->qry[1], cfi_info->qry[2], cfi_info->pri_id, cfi_info->pri_addr, cfi_info->alt_id, cfi_info->alt_addr);
+
+               cfi_info->vcc_min = cfi_query_u8(bank, 0, 0x1b);
+               cfi_info->vcc_max = cfi_query_u8(bank, 0, 0x1c);
+               cfi_info->vpp_min = cfi_query_u8(bank, 0, 0x1d);
+               cfi_info->vpp_max = cfi_query_u8(bank, 0, 0x1e);
+               cfi_info->word_write_timeout_typ = cfi_query_u8(bank, 0, 0x1f);
+               cfi_info->buf_write_timeout_typ = cfi_query_u8(bank, 0, 0x20);
+               cfi_info->block_erase_timeout_typ = cfi_query_u8(bank, 0, 0x21);
+               cfi_info->chip_erase_timeout_typ = cfi_query_u8(bank, 0, 0x22);
+               cfi_info->word_write_timeout_max = cfi_query_u8(bank, 0, 0x23);
+               cfi_info->buf_write_timeout_max = cfi_query_u8(bank, 0, 0x24);
+               cfi_info->block_erase_timeout_max = cfi_query_u8(bank, 0, 0x25);
+               cfi_info->chip_erase_timeout_max = cfi_query_u8(bank, 0, 0x26);
+
+               DEBUG("Vcc min: %1.1x.%1.1x, Vcc max: %1.1x.%1.1x, Vpp min: %1.1x.%1.1x, Vpp max: %1.1x.%1.1x",
+                       (cfi_info->vcc_min & 0xf0) >> 4, cfi_info->vcc_min & 0x0f,
+                       (cfi_info->vcc_max & 0xf0) >> 4, cfi_info->vcc_max & 0x0f,
+                       (cfi_info->vpp_min & 0xf0) >> 4, cfi_info->vpp_min & 0x0f,
+                       (cfi_info->vpp_max & 0xf0) >> 4, cfi_info->vpp_max & 0x0f);
+               DEBUG("typ. word write timeout: %u, typ. buf write timeout: %u, typ. block erase timeout: %u, typ. chip erase timeout: %u", 1 << cfi_info->word_write_timeout_typ, 1 << cfi_info->buf_write_timeout_typ,
+                       1 << cfi_info->block_erase_timeout_typ, 1 << cfi_info->chip_erase_timeout_typ);
+               DEBUG("max. word write timeout: %u, max. buf write timeout: %u, max. block erase timeout: %u, max. chip erase timeout: %u", (1 << cfi_info->word_write_timeout_max) * (1 << cfi_info->word_write_timeout_typ),
+                       (1 << cfi_info->buf_write_timeout_max) * (1 << cfi_info->buf_write_timeout_typ),
+                       (1 << cfi_info->block_erase_timeout_max) * (1 << cfi_info->block_erase_timeout_typ),
+                       (1 << cfi_info->chip_erase_timeout_max) * (1 << cfi_info->chip_erase_timeout_typ));
+
+               cfi_info->dev_size = cfi_query_u8(bank, 0, 0x27);
+               cfi_info->interface_desc = cfi_query_u16(bank, 0, 0x28);
+               cfi_info->max_buf_write_size = cfi_query_u16(bank, 0, 0x2a);
+               cfi_info->num_erase_regions = cfi_query_u8(bank, 0, 0x2c);
+
+               DEBUG("size: 0x%x, interface desc: %i, max buffer write size: %x", 1 << cfi_info->dev_size, cfi_info->interface_desc, (1 << cfi_info->max_buf_write_size));
+
+               if (((1 << cfi_info->dev_size) * bank->bus_width / bank->chip_width) != bank->size)
+               {
+                       WARNING("configuration specifies 0x%x size, but a 0x%x size flash was found", bank->size, 1 << cfi_info->dev_size);
+               }
+
+               if (cfi_info->num_erase_regions)
+               {
+                       cfi_info->erase_region_info = malloc(4 * cfi_info->num_erase_regions);
+                       for (i = 0; i < cfi_info->num_erase_regions; i++)
+                       {
+                               cfi_info->erase_region_info[i] = cfi_query_u32(bank, 0, 0x2d + (4 * i));
+                               DEBUG("erase region[%i]: %i blocks of size 0x%x", i, (cfi_info->erase_region_info[i] & 0xffff) + 1, (cfi_info->erase_region_info[i] >> 16) * 256);
+                       }
+               }
+               else
+               {
+                       cfi_info->erase_region_info = NULL;
+               }
+
+               /* We need to read the primary algorithm extended query table before calculating
+                * the sector layout to be able to apply fixups
+                */
+               switch(cfi_info->pri_id)
+               {
+                       /* Intel command set (standard and extended) */
+                       case 0x0001:
+                       case 0x0003:
+                               cfi_read_intel_pri_ext(bank);
+                               break;
+                       /* AMD/Spansion, Atmel, ... command set */
+                       case 0x0002:
+                               cfi_read_0002_pri_ext(bank);
+                               break;
+                       default:
+                               ERROR("cfi primary command set %i unsupported", cfi_info->pri_id);
+                               break;
+               }
+
+               /* return to read array mode
+                * we use both reset commands, as some Intel flashes fail to recognize the 0xF0 command
+                */
                cfi_command(bank, 0xf0, command);
                target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
                cfi_command(bank, 0xff, command);
                target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
-               return ERROR_FLASH_BANK_INVALID;
        }
-       
-       cfi_info->pri_id = cfi_query_u16(bank, 0, 0x13);
-       cfi_info->pri_addr = cfi_query_u16(bank, 0, 0x15);
-       cfi_info->alt_id = cfi_query_u16(bank, 0, 0x17);
-       cfi_info->alt_addr = cfi_query_u16(bank, 0, 0x19);
-       
-       DEBUG("qry: '%c%c%c', pri_id: 0x%4.4x, pri_addr: 0x%4.4x, alt_id: 0x%4.4x, alt_addr: 0x%4.4x", cfi_info->qry[0], cfi_info->qry[1], cfi_info->qry[2], cfi_info->pri_id, cfi_info->pri_addr, cfi_info->alt_id, cfi_info->alt_addr);
-       
-       cfi_info->vcc_min = cfi_query_u8(bank, 0, 0x1b);
-       cfi_info->vcc_max = cfi_query_u8(bank, 0, 0x1c);
-       cfi_info->vpp_min = cfi_query_u8(bank, 0, 0x1d);
-       cfi_info->vpp_max = cfi_query_u8(bank, 0, 0x1e);
-       cfi_info->word_write_timeout_typ = cfi_query_u8(bank, 0, 0x1f);
-       cfi_info->buf_write_timeout_typ = cfi_query_u8(bank, 0, 0x20);
-       cfi_info->block_erase_timeout_typ = cfi_query_u8(bank, 0, 0x21);
-       cfi_info->chip_erase_timeout_typ = cfi_query_u8(bank, 0, 0x22);
-       cfi_info->word_write_timeout_max = cfi_query_u8(bank, 0, 0x23);
-       cfi_info->buf_write_timeout_max = cfi_query_u8(bank, 0, 0x24);
-       cfi_info->block_erase_timeout_max = cfi_query_u8(bank, 0, 0x25);
-       cfi_info->chip_erase_timeout_max = cfi_query_u8(bank, 0, 0x26);
-       
-       DEBUG("Vcc min: %1.1x.%1.1x, Vcc max: %1.1x.%1.1x, Vpp min: %1.1x.%1.1x, Vpp max: %1.1x.%1.1x",
-               (cfi_info->vcc_min & 0xf0) >> 4, cfi_info->vcc_min & 0x0f,
-               (cfi_info->vcc_max & 0xf0) >> 4, cfi_info->vcc_max & 0x0f,
-               (cfi_info->vpp_min & 0xf0) >> 4, cfi_info->vpp_min & 0x0f,
-               (cfi_info->vpp_max & 0xf0) >> 4, cfi_info->vpp_max & 0x0f);
-       DEBUG("typ. word write timeout: %u, typ. buf write timeout: %u, typ. block erase timeout: %u, typ. chip erase timeout: %u", 1 << cfi_info->word_write_timeout_typ, 1 << cfi_info->buf_write_timeout_typ,
-               1 << cfi_info->block_erase_timeout_typ, 1 << cfi_info->chip_erase_timeout_typ);
-       DEBUG("max. word write timeout: %u, max. buf write timeout: %u, max. block erase timeout: %u, max. chip erase timeout: %u", (1 << cfi_info->word_write_timeout_max) * (1 << cfi_info->word_write_timeout_typ),
-               (1 << cfi_info->buf_write_timeout_max) * (1 << cfi_info->buf_write_timeout_typ),
-               (1 << cfi_info->block_erase_timeout_max) * (1 << cfi_info->block_erase_timeout_typ),
-               (1 << cfi_info->chip_erase_timeout_max) * (1 << cfi_info->chip_erase_timeout_typ));
-       
-       cfi_info->dev_size = cfi_query_u8(bank, 0, 0x27);
-       cfi_info->interface_desc = cfi_query_u16(bank, 0, 0x28);
-       cfi_info->max_buf_write_size = cfi_query_u16(bank, 0, 0x2a);
-       cfi_info->num_erase_regions = cfi_query_u8(bank, 0, 0x2c);
-       
-       DEBUG("size: 0x%x, interface desc: %i, max buffer write size: %x", 1 << cfi_info->dev_size, cfi_info->interface_desc, (1 << cfi_info->max_buf_write_size));
-       
-       if (((1 << cfi_info->dev_size) * bank->bus_width / bank->chip_width) != bank->size)
-       {
-               WARNING("configuration specifies 0x%x size, but a 0x%x size flash was found", bank->size, 1 << cfi_info->dev_size);
-       }
-       
-       if (cfi_info->num_erase_regions)
-       {
-               cfi_info->erase_region_info = malloc(4 * cfi_info->num_erase_regions);
-               for (i = 0; i < cfi_info->num_erase_regions; i++)
-               {
-                       cfi_info->erase_region_info[i] = cfi_query_u32(bank, 0, 0x2d + (4 * i));
-                       DEBUG("erase region[%i]: %i blocks of size 0x%x", i, (cfi_info->erase_region_info[i] & 0xffff) + 1, (cfi_info->erase_region_info[i] >> 16) * 256);
-                       
-                       num_sectors += (cfi_info->erase_region_info[i] & 0xffff) + 1;
-               }
-       }
-       else
-       {
-               cfi_info->erase_region_info = NULL;
-       }
-               
-       /* We need to read the primary algorithm extended query table before calculating
-        * the sector layout to be able to apply fixups
-        */     
+
+       /* apply fixups depending on the primary command set */
        switch(cfi_info->pri_id)
        {
                /* Intel command set (standard and extended) */
                case 0x0001:
                case 0x0003:
-                       cfi_read_intel_pri_ext(bank);
                        cfi_fixup(bank, cfi_0001_fixups);
                        break;
                /* AMD/Spansion, Atmel, ... command set */
-        case 0x0002:
-                       cfi_read_0002_pri_ext(bank);
+               case 0x0002:
                        cfi_fixup(bank, cfi_0002_fixups);
                        break;
                default:
                        ERROR("cfi primary command set %i unsupported", cfi_info->pri_id);
                        break;
        }
-       
+
        if (cfi_info->num_erase_regions == 0)
        {
-               /* a device might have only one erase block, spanning the whole device */ 
+               /* a device might have only one erase block, spanning the whole device */
                bank->num_sectors = 1;
                bank->sectors = malloc(sizeof(flash_sector_t));
-               
+
                bank->sectors[sector].offset = 0x0;
                bank->sectors[sector].size = bank->size;
                bank->sectors[sector].is_erased = -1;
@@ -1713,9 +2049,14 @@ int cfi_probe(struct flash_bank_s *bank)
        }
        else
        {
+               for (i = 0; i < cfi_info->num_erase_regions; i++)
+               {
+                       num_sectors += (cfi_info->erase_region_info[i] & 0xffff) + 1;
+               }
+
                bank->num_sectors = num_sectors;
                bank->sectors = malloc(sizeof(flash_sector_t) * num_sectors);
-               
+
                for (i = 0; i < cfi_info->num_erase_regions; i++)
                {
                        int j;
@@ -1730,25 +2071,17 @@ int cfi_probe(struct flash_bank_s *bank)
                        }
                }
        }
-       
-       /* return to read array mode
-        * we use both reset commands, as some Intel flashes fail to recognize the 0xF0 command
-        */
-       cfi_command(bank, 0xf0, command);
-       target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
-       cfi_command(bank, 0xff, command);
-       target->type->write_memory(target, flash_address(bank, 0, 0x0), bank->bus_width, 1, command);
-       
+
        return ERROR_OK;
 }
 
 int cfi_erase_check(struct flash_bank_s *bank)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        int i;
        int retval;
-       
+
        if (!cfi_info->erase_check_algorithm)
        {
                u32 erase_check_code[] =
@@ -1759,7 +2092,7 @@ int cfi_erase_check(struct flash_bank_s *bank)
                        0x1afffffb,     /* b -4                                 */
                        0xeafffffe      /* b 0                                  */
                };
-               
+
                /* make sure we have a working area */
                if (target_alloc_working_area(target, 20, &cfi_info->erase_check_algorithm) != ERROR_OK)
                {
@@ -1768,53 +2101,53 @@ int cfi_erase_check(struct flash_bank_s *bank)
                else
                {
                        u8 erase_check_code_buf[5 * 4];
-                       
+
                        for (i = 0; i < 5; i++)
                                target_buffer_set_u32(target, erase_check_code_buf + (i*4), erase_check_code[i]);
-                       
+
                        /* write algorithm code to working area */
                        target->type->write_memory(target, cfi_info->erase_check_algorithm->address, 4, 5, erase_check_code_buf);
                }
        }
-       
+
        if (!cfi_info->erase_check_algorithm)
        {
                u32 *buffer = malloc(4096);
-               
+
                for (i = 0; i < bank->num_sectors; i++)
                {
                        u32 address = bank->base + bank->sectors[i].offset;
                        u32 size = bank->sectors[i].size;
                        u32 check = 0xffffffffU;
                        int erased = 1;
-                       
+
                        while (size > 0)
                        {
                                u32 thisrun_size = (size > 4096) ? 4096 : size;
                                int j;
-                               
+
                                target->type->read_memory(target, address, 4, thisrun_size / 4, (u8*)buffer);
-                               
+
                                for (j = 0; j < thisrun_size / 4; j++)
                                        check &= buffer[j];
-                               
+
                                if (check != 0xffffffff)
                                {
                                        erased = 0;
                                        break;
                                }
-                               
+
                                size -= thisrun_size;
                                address += thisrun_size;
                        }
-                       
+
                        bank->sectors[i].is_erased = erased;
                }
-               
+
                free(buffer);
        }
        else
-       {       
+       {
                for (i = 0; i < bank->num_sectors; i++)
                {
                        u32 address = bank->base + bank->sectors[i].offset;
@@ -1822,34 +2155,34 @@ int cfi_erase_check(struct flash_bank_s *bank)
 
                        reg_param_t reg_params[3];
                        armv4_5_algorithm_t armv4_5_info;
-                       
+
                        armv4_5_info.common_magic = ARMV4_5_COMMON_MAGIC;
                        armv4_5_info.core_mode = ARMV4_5_MODE_SVC;
                        armv4_5_info.core_state = ARMV4_5_STATE_ARM;
-                       
+
                        init_reg_param(&reg_params[0], "r0", 32, PARAM_OUT);
                        buf_set_u32(reg_params[0].value, 0, 32, address);
-                       
+
                        init_reg_param(&reg_params[1], "r1", 32, PARAM_OUT);
                        buf_set_u32(reg_params[1].value, 0, 32, size);
-                       
+
                        init_reg_param(&reg_params[2], "r2", 32, PARAM_IN_OUT);
                        buf_set_u32(reg_params[2].value, 0, 32, 0xff);
-                       
+
                        if ((retval = target->type->run_algorithm(target, 0, NULL, 3, reg_params, cfi_info->erase_check_algorithm->address, cfi_info->erase_check_algorithm->address + 0x10, 10000, &armv4_5_info)) != ERROR_OK)
                                return ERROR_FLASH_OPERATION_FAILED;
-                       
+
                        if (buf_get_u32(reg_params[2].value, 0, 32) == 0xff)
                                bank->sectors[i].is_erased = 1;
                        else
                                bank->sectors[i].is_erased = 0;
-                       
+
                        destroy_reg_param(&reg_params[0]);
                        destroy_reg_param(&reg_params[1]);
                        destroy_reg_param(&reg_params[2]);
                }
        }
-       
+
        return ERROR_OK;
 }
 
@@ -1857,10 +2190,10 @@ int cfi_intel_protect_check(struct flash_bank_s *bank)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
        cfi_intel_pri_ext_t *pri_ext = cfi_info->pri_ext;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 command[CFI_MAX_BUS_WIDTH];
        int i;
-       
+
        /* check if block lock bits are supported on this device */
        if (!(pri_ext->blk_status_reg_mask & 0x1))
                return ERROR_FLASH_OPERATION_FAILED;
@@ -1871,7 +2204,7 @@ int cfi_intel_protect_check(struct flash_bank_s *bank)
        for (i = 0; i < bank->num_sectors; i++)
        {
                u8 block_status = cfi_get_u8(bank, i, 0x2);
-               
+
                if (block_status & 1)
                        bank->sectors[i].is_protected = 1;
                else
@@ -1888,23 +2221,23 @@ int cfi_spansion_protect_check(struct flash_bank_s *bank)
 {
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
        cfi_spansion_pri_ext_t *pri_ext = cfi_info->pri_ext;
-       target_t *target = cfi_info->target;
+       target_t *target = bank->target;
        u8 command[8];
        int i;
-       
+
        cfi_command(bank, 0xaa, command);
-       target->type->write_memory(target, flash_address(bank, 0, 0x555), bank->bus_width, 1, command);
-       
+       target->type->write_memory(target, flash_address(bank, 0, pri_ext->_unlock1), bank->bus_width, 1, command);
+
        cfi_command(bank, 0x55, command);
-       target->type->write_memory(target, flash_address(bank, 0, 0x2aa), bank->bus_width, 1, command);
-       
+       target->type->write_memory(target, flash_address(bank, 0, pri_ext->_unlock2), bank->bus_width, 1, command);
+
        cfi_command(bank, 0x90, command);
-       target->type->write_memory(target, flash_address(bank, 0, 0x555), bank->bus_width, 1, command);
+       target->type->write_memory(target, flash_address(bank, 0, pri_ext->_unlock1), bank->bus_width, 1, command);
 
        for (i = 0; i < bank->num_sectors; i++)
        {
                u8 block_status = cfi_get_u8(bank, i, 0x2);
-               
+
                if (block_status & 1)
                        bank->sectors[i].is_protected = 1;
                else
@@ -1923,7 +2256,7 @@ int cfi_protect_check(struct flash_bank_s *bank)
 
        if (cfi_info->qry[0] != 'Q')
                return ERROR_FLASH_BANK_NOT_PROBED;
-       
+
        switch(cfi_info->pri_id)
        {
                case 1:
@@ -1937,7 +2270,7 @@ int cfi_protect_check(struct flash_bank_s *bank)
                        ERROR("cfi primary command set %i unsupported", cfi_info->pri_id);
                        break;
        }
-       
+
        return ERROR_OK;
 }
 
@@ -1945,13 +2278,13 @@ int cfi_info(struct flash_bank_s *bank, char *buf, int buf_size)
 {
        int printed;
        cfi_flash_bank_t *cfi_info = bank->driver_priv;
-       
-       if (cfi_info->qry[0] == -1)
+
+       if (cfi_info->qry[0] == (char)-1)
        {
                printed = snprintf(buf, buf_size, "\ncfi flash bank not probed yet\n");
                return ERROR_OK;
        }
-       
+
        printed = snprintf(buf, buf_size, "\ncfi information:\n");
        buf += printed;
        buf_size -= printed;
@@ -1960,34 +2293,34 @@ int cfi_info(struct flash_bank_s *bank, char *buf, int buf_size)
                cfi_info->manufacturer, cfi_info->device_id);
        buf += printed;
        buf_size -= printed;
-               
+
        printed = snprintf(buf, buf_size, "qry: '%c%c%c', pri_id: 0x%4.4x, pri_addr: 0x%4.4x, alt_id: 0x%4.4x, alt_addr: 0x%4.4x\n", cfi_info->qry[0], cfi_info->qry[1], cfi_info->qry[2], cfi_info->pri_id, cfi_info->pri_addr, cfi_info->alt_id, cfi_info->alt_addr);
        buf += printed;
        buf_size -= printed;
-       
+
        printed = snprintf(buf, buf_size, "Vcc min: %1.1x.%1.1x, Vcc max: %1.1x.%1.1x, Vpp min: %1.1x.%1.1x, Vpp max: %1.1x.%1.1x\n", (cfi_info->vcc_min & 0xf0) >> 4, cfi_info->vcc_min & 0x0f,
        (cfi_info->vcc_max & 0xf0) >> 4, cfi_info->vcc_max & 0x0f,
        (cfi_info->vpp_min & 0xf0) >> 4, cfi_info->vpp_min & 0x0f,
        (cfi_info->vpp_max & 0xf0) >> 4, cfi_info->vpp_max & 0x0f);
        buf += printed;
        buf_size -= printed;
-       
+
        printed = snprintf(buf, buf_size, "typ. word write timeout: %u, typ. buf write timeout: %u, typ. block erase timeout: %u, typ. chip erase timeout: %u\n", 1 << cfi_info->word_write_timeout_typ, 1 << cfi_info->buf_write_timeout_typ,
                  1 << cfi_info->block_erase_timeout_typ, 1 << cfi_info->chip_erase_timeout_typ);
        buf += printed;
        buf_size -= printed;
-       
+
        printed = snprintf(buf, buf_size, "max. word write timeout: %u, max. buf write timeout: %u, max. block erase timeout: %u, max. chip erase timeout: %u\n", (1 << cfi_info->word_write_timeout_max) * (1 << cfi_info->word_write_timeout_typ),
                  (1 << cfi_info->buf_write_timeout_max) * (1 << cfi_info->buf_write_timeout_typ),
                  (1 << cfi_info->block_erase_timeout_max) * (1 << cfi_info->block_erase_timeout_typ),
                  (1 << cfi_info->chip_erase_timeout_max) * (1 << cfi_info->chip_erase_timeout_typ));
        buf += printed;
        buf_size -= printed;
-       
+
        printed = snprintf(buf, buf_size, "size: 0x%x, interface desc: %i, max buffer write size: %x\n", 1 << cfi_info->dev_size, cfi_info->interface_desc, cfi_info->max_buf_write_size);
        buf += printed;
        buf_size -= printed;
-       
+
        switch(cfi_info->pri_id)
        {
                case 1:
@@ -2001,6 +2334,6 @@ int cfi_info(struct flash_bank_s *bank, char *buf, int buf_size)
                        ERROR("cfi primary command set %i unsupported", cfi_info->pri_id);
                        break;
        }
-       
+
        return ERROR_OK;
 }

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)