move more nor flash implementation details
[openocd.git] / src / flash / flash.c
index fda2c91a12e2a025b2a33ced2cbef4a5c47405c2..2cf56ed57b9a250bbce76e20c258514132afacf0 100644 (file)
@@ -2,6 +2,12 @@
  *   Copyright (C) 2005 by Dominic Rath                                    *
  *   Dominic.Rath@gmx.de                                                   *
  *                                                                         *
+ *   Copyright (C) 2007,2008 Ã˜yvind Harboe                                 *
+ *   oyvind.harboe@zylin.com                                               *
+ *                                                                         *
+ *   Copyright (C) 2008 by Spencer Oliver                                  *
+ *   spen@spen-soft.co.uk                                                  *
+ *                                                                         *
  *   This program is free software; you can redistribute it and/or modify  *
  *   it under the terms of the GNU General Public License as published by  *
  *   the Free Software Foundation; either version 2 of the License, or     *
 #endif
 
 #include "flash.h"
-#include "command.h"
-#include "target.h"
-#include "time_support.h"
-#include "fileio.h"
-#include "image.h"
-#include "log.h"
-#include "armv4_5.h"
-#include "algorithm.h"
-#include "binarybuffer.h"
-#include "armv7m.h"
-
-#include <string.h>
-#include <unistd.h>
-#include <stdlib.h>
-#include <sys/types.h>
-#include <sys/stat.h>
-#include <errno.h>
-#include <inttypes.h>
-
-/* command handlers */
-int handle_flash_bank_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
-int handle_flash_banks_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
-int handle_flash_info_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
-int handle_flash_probe_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
-int handle_flash_erase_check_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
-int handle_flash_erase_address_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
-int handle_flash_protect_check_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
-int handle_flash_erase_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
-int handle_flash_write_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
-int handle_flash_write_bank_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
-int handle_flash_write_image_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
-int handle_flash_fill_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
-int handle_flash_protect_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
-flash_bank_t *get_flash_bank_by_addr(target_t *target, u32 addr);
+#include "common.h"
+#include <target/image.h>
+#include <helper/time_support.h>
 
 /* flash drivers
  */
-extern flash_driver_t lpc2000_flash;
-extern flash_driver_t cfi_flash;
-extern flash_driver_t at91sam7_flash;
-extern flash_driver_t str7x_flash;
-extern flash_driver_t str9x_flash;
-extern flash_driver_t stellaris_flash;
-extern flash_driver_t str9xpec_flash;
-extern flash_driver_t stm32x_flash;
-extern flash_driver_t tms470_flash;
-extern flash_driver_t ecosflash_flash;
-extern flash_driver_t lpc288x_flash;
-
-flash_driver_t *flash_drivers[] =
-{
+extern struct flash_driver lpc2000_flash;
+extern struct flash_driver lpc288x_flash;
+extern struct flash_driver lpc2900_flash;
+extern struct flash_driver cfi_flash;
+extern struct flash_driver at91sam3_flash;
+extern struct flash_driver at91sam7_flash;
+extern struct flash_driver str7x_flash;
+extern struct flash_driver str9x_flash;
+extern struct flash_driver aduc702x_flash;
+extern struct flash_driver stellaris_flash;
+extern struct flash_driver str9xpec_flash;
+extern struct flash_driver stm32x_flash;
+extern struct flash_driver tms470_flash;
+extern struct flash_driver ecosflash_flash;
+extern struct flash_driver ocl_flash;
+extern struct flash_driver pic32mx_flash;
+extern struct flash_driver avr_flash;
+extern struct flash_driver faux_flash;
+
+struct flash_driver *flash_drivers[] = {
        &lpc2000_flash,
+       &lpc288x_flash,
+       &lpc2900_flash,
        &cfi_flash,
        &at91sam7_flash,
+       &at91sam3_flash,
        &str7x_flash,
        &str9x_flash,
+       &aduc702x_flash,
        &stellaris_flash,
        &str9xpec_flash,
        &stm32x_flash,
        &tms470_flash,
        &ecosflash_flash,
-       &lpc288x_flash,
+       &ocl_flash,
+       &pic32mx_flash,
+       &avr_flash,
+       &faux_flash,
        NULL,
 };
 
-flash_bank_t *flash_banks;
-static         command_t *flash_cmd;
-
-/* wafer thin wrapper for invoking the flash driver */
-static int flash_driver_write(struct flash_bank_s *bank, u8 *buffer, u32 offset, u32 count)
-{
-       int retval;
-
-       retval=bank->driver->write(bank, buffer, offset, count);
-       if (retval!=ERROR_OK)
-       {
-               LOG_ERROR("error writing to flash at address 0x%08x at offset 0x%8.8x (%d)", bank->base, offset, retval);
-       }
-
-       return retval;
-}
-
-static int flash_driver_erase(struct flash_bank_s *bank, int first, int last)
-{
-       int retval;
-
-       retval=bank->driver->erase(bank, first, last);
-       if (retval!=ERROR_OK)
-       {
-               LOG_ERROR("failed erasing sectors %d to %d (%d)", first, last, retval);
-       }
-
-       return retval;
-}
-
-int flash_driver_protect(struct flash_bank_s *bank, int set, int first, int last)
-{
-       int retval;
-
-       retval=bank->driver->protect(bank, set, first, last);
-       if (retval!=ERROR_OK)
-       {
-               LOG_ERROR("failed setting protection for areas %d to %d (%d)", first, last, retval);
-       }
-
-       return retval;
-}
+struct flash_bank *flash_banks;
 
-
-int flash_register_commands(struct command_context_s *cmd_ctx)
+struct flash_bank *get_flash_bank_by_num_noprobe(int num)
 {
-       flash_cmd = register_command(cmd_ctx, NULL, "flash", NULL, COMMAND_ANY, NULL);
-
-       register_command(cmd_ctx, flash_cmd, "bank", handle_flash_bank_command, COMMAND_CONFIG, "flash_bank <driver> <base> <size> <chip_width> <bus_width> <target> [driver_options ...]");
-       return ERROR_OK;
-}
-
-int flash_init_drivers(struct command_context_s *cmd_ctx)
-{
-       if (flash_banks)
-       {
-               register_command(cmd_ctx, flash_cmd, "banks", handle_flash_banks_command, COMMAND_EXEC,
-                                                "list configured flash banks ");
-               register_command(cmd_ctx, flash_cmd, "info", handle_flash_info_command, COMMAND_EXEC,
-                                                "print info about flash bank <num>");
-               register_command(cmd_ctx, flash_cmd, "probe", handle_flash_probe_command, COMMAND_EXEC,
-                                                "identify flash bank <num>");
-               register_command(cmd_ctx, flash_cmd, "erase_check", handle_flash_erase_check_command, COMMAND_EXEC,
-                                                "check erase state of sectors in flash bank <num>");
-               register_command(cmd_ctx, flash_cmd, "protect_check", handle_flash_protect_check_command, COMMAND_EXEC,
-                                                "check protection state of sectors in flash bank <num>");
-               register_command(cmd_ctx, flash_cmd, "erase_sector", handle_flash_erase_command, COMMAND_EXEC,
-                                                "erase sectors at <bank> <first> <last>");
-               register_command(cmd_ctx, flash_cmd, "erase_address", handle_flash_erase_address_command, COMMAND_EXEC,
-                                                "erase address range <address> <length>");
-
-               register_command(cmd_ctx, flash_cmd, "fillw", handle_flash_fill_command, COMMAND_EXEC,
-                                                "fill with pattern <address> <word_pattern> <count>");
-               register_command(cmd_ctx, flash_cmd, "fillh", handle_flash_fill_command, COMMAND_EXEC,
-                                                "fill with pattern <address> <halfword_pattern> <count>");
-               register_command(cmd_ctx, flash_cmd, "fillb", handle_flash_fill_command, COMMAND_EXEC,
-                                                "fill with pattern <address> <byte_pattern> <count>");
-
-               register_command(cmd_ctx, flash_cmd, "write_bank", handle_flash_write_bank_command, COMMAND_EXEC,
-                                                "write binary data to <bank> <file> <offset>");
-               register_command(cmd_ctx, flash_cmd, "write_image", handle_flash_write_image_command, COMMAND_EXEC,
-                                                "write_image [erase] <file> [offset] [type]");
-               register_command(cmd_ctx, flash_cmd, "protect", handle_flash_protect_command, COMMAND_EXEC,
-                                                "set protection of sectors at <bank> <first> <last> <on|off>");
-       }
-
-       return ERROR_OK;
-}
-
-flash_bank_t *get_flash_bank_by_num_noprobe(int num)
-{
-       flash_bank_t *p;
+       struct flash_bank *p;
        int i = 0;
 
        for (p = flash_banks; p; p = p->next)
@@ -192,9 +93,9 @@ flash_bank_t *get_flash_bank_by_num_noprobe(int num)
        return NULL;
 }
 
-int flash_get_bank_count()
+int flash_get_bank_count(void)
 {
-       flash_bank_t *p;
+       struct flash_bank *p;
        int i = 0;
        for (p = flash_banks; p; p = p->next)
        {
@@ -203,670 +104,47 @@ int flash_get_bank_count()
        return i;
 }
 
-flash_bank_t *get_flash_bank_by_num(int num)
+struct flash_bank *get_flash_bank_by_name(const char *name)
 {
-       flash_bank_t *p = get_flash_bank_by_num_noprobe(num);
-       int retval;
+       unsigned requested = get_flash_name_index(name);
+       unsigned found = 0;
 
-       if (p == NULL)
-               return NULL;
-
-       retval = p->driver->auto_probe(p);
-
-       if (retval != ERROR_OK)
+       struct flash_bank *bank;
+       for (bank = flash_banks; NULL != bank; bank = bank->next)
        {
-               LOG_ERROR("auto_probe failed %d\n", retval);
-               return NULL;
-       }
-       return p;
-}
-
-int handle_flash_bank_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
-{
-       int i;
-       int found = 0;
-       target_t *target;
-
-       if (argc < 6)
-       {
-               return ERROR_COMMAND_SYNTAX_ERROR;
-       }
-
-       if ((target = get_target_by_num(strtoul(args[5], NULL, 0))) == NULL)
-       {
-               LOG_ERROR("target %lu not defined", strtoul(args[5], NULL, 0));
-               return ERROR_OK;
-       }
-
-       for (i = 0; flash_drivers[i]; i++)
-       {
-               if (strcmp(args[0], flash_drivers[i]->name) == 0)
-               {
-                       flash_bank_t *p, *c;
-
-                       /* register flash specific commands */
-                       if (flash_drivers[i]->register_commands(cmd_ctx) != ERROR_OK)
-                       {
-                               LOG_ERROR("couldn't register '%s' commands", args[0]);
-                               exit(-1);
-                       }
-
-                       c = malloc(sizeof(flash_bank_t));
-                       c->target = target;
-                       c->driver = flash_drivers[i];
-                       c->driver_priv = NULL;
-                       c->base = strtoul(args[1], NULL, 0);
-                       c->size = strtoul(args[2], NULL, 0);
-                       c->chip_width = strtoul(args[3], NULL, 0);
-                       c->bus_width = strtoul(args[4], NULL, 0);
-                       c->num_sectors = 0;
-                       c->sectors = NULL;
-                       c->next = NULL;
-
-                       if (flash_drivers[i]->flash_bank_command(cmd_ctx, cmd, args, argc, c) != ERROR_OK)
-                       {
-                               LOG_ERROR("'%s' driver rejected flash bank at 0x%8.8x", args[0], c->base);
-                               free(c);
-                               return ERROR_OK;
-                       }
-
-                       /* put flash bank in linked list */
-                       if (flash_banks)
-                       {
-                               /* find last flash bank */
-                               for (p = flash_banks; p && p->next; p = p->next);
-                               if (p)
-                                       p->next = c;
-                       }
-                       else
-                       {
-                               flash_banks = c;
-                       }
-
-                       found = 1;
-               }
-       }
-
-       /* no matching flash driver found */
-       if (!found)
-       {
-               LOG_ERROR("flash driver '%s' not found", args[0]);
-               exit(-1);
-       }
-
-       return ERROR_OK;
-}
-
-int handle_flash_banks_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
-{
-       flash_bank_t *p;
-       int i = 0;
-
-       if (!flash_banks)
-       {
-               command_print(cmd_ctx, "no flash banks configured");
-               return ERROR_OK;
-       }
-
-       for (p = flash_banks; p; p = p->next)
-       {
-               command_print(cmd_ctx, "#%i: %s at 0x%8.8x, size 0x%8.8x, buswidth %i, chipwidth %i",
-                                         i++, p->driver->name, p->base, p->size, p->bus_width, p->chip_width);
-       }
-
-       return ERROR_OK;
-}
-
-int handle_flash_info_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
-{
-       flash_bank_t *p;
-       int i = 0;
-       int j = 0;
-       int retval;
-
-       if (argc != 1)
-       {
-               return ERROR_COMMAND_SYNTAX_ERROR;
-       }
-
-       for (p = flash_banks; p; p = p->next, i++)
-       {
-               if (i == strtoul(args[0], NULL, 0))
-               {
-                       char buf[1024];
-
-                       /* attempt auto probe */
-                       if ((retval = p->driver->auto_probe(p)) != ERROR_OK)
-                               return retval;
-
-                       command_print(cmd_ctx, "#%i: %s at 0x%8.8x, size 0x%8.8x, buswidth %i, chipwidth %i",
-                                               i, p->driver->name, p->base, p->size, p->bus_width, p->chip_width);
-                       for (j = 0; j < p->num_sectors; j++)
-                       {
-                               char *protect_state;
-
-                               if (p->sectors[j].is_protected == 0)
-                                       protect_state = "not protected";
-                               else if (p->sectors[j].is_protected == 1)
-                                       protect_state = "protected";
-                               else
-                                       protect_state = "protection state unknown";
-
-                               command_print(cmd_ctx, "\t#%i: 0x%8.8x (0x%x %ikB) %s",
-                                                       j, p->sectors[j].offset, p->sectors[j].size, p->sectors[j].size>>10,
-                                                       protect_state);
-                       }
-
-                       *buf = '\0'; /* initialize buffer, otherwise it migh contain garbage if driver function fails */
-                       retval = p->driver->info(p, buf, sizeof(buf));
-                       command_print(cmd_ctx, "%s", buf);
-                       if (retval != ERROR_OK)
-                               LOG_ERROR("error retrieving flash info (%d)", retval);
-               }
-       }
-
-       return ERROR_OK;
-}
-
-int handle_flash_probe_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
-{
-       flash_bank_t *p;
-       int retval;
-
-       if (argc != 1)
-       {
-               return ERROR_COMMAND_SYNTAX_ERROR;
-       }
-
-       p = get_flash_bank_by_num_noprobe(strtoul(args[0], NULL, 0));
-       if (p)
-       {
-               if ((retval = p->driver->probe(p)) == ERROR_OK)
-               {
-                       command_print(cmd_ctx, "flash '%s' found at 0x%8.8x", p->driver->name, p->base);
-               }
-               else if (retval == ERROR_FLASH_BANK_INVALID)
-               {
-                       command_print(cmd_ctx, "probing failed for flash bank '#%s' at 0x%8.8x",
-                                                 args[0], p->base);
-               }
-               else
-               {
-                       command_print(cmd_ctx, "unknown error when probing flash bank '#%s' at 0x%8.8x",
-                                                 args[0], p->base);
-               }
-       }
-       else
-       {
-               command_print(cmd_ctx, "flash bank '#%s' is out of bounds", args[0]);
-       }
-
-       return ERROR_OK;
-}
-
-int handle_flash_erase_check_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
-{
-       flash_bank_t *p;
-       int retval;
-
-       if (argc != 1)
-       {
-               return ERROR_COMMAND_SYNTAX_ERROR;
-       }
-
-       p = get_flash_bank_by_num(strtoul(args[0], NULL, 0));
-       if (p)
-       {
-               int j;
-               if ((retval = p->driver->erase_check(p)) == ERROR_OK)
-               {
-                       command_print(cmd_ctx, "successfully checked erase state", p->driver->name, p->base);
-               }
-               else
-               {
-                       command_print(cmd_ctx, "unknown error when checking erase state of flash bank #%s at 0x%8.8x",
-                               args[0], p->base);
-               }
-               
-               for (j = 0; j < p->num_sectors; j++)
-               {
-                       char *erase_state;
-
-                       if (p->sectors[j].is_erased == 0)
-                               erase_state = "not erased";
-                       else if (p->sectors[j].is_erased == 1)
-                               erase_state = "erased";
-                       else
-                               erase_state = "erase state unknown";
-
-                       command_print(cmd_ctx, "\t#%i: 0x%8.8x (0x%x %ikB) %s",
-                                               j, p->sectors[j].offset, p->sectors[j].size, p->sectors[j].size>>10,
-                                               erase_state);
-               }
-               
+               if (strcmp(bank->name, name) == 0)
+                       return bank;
+               if (!flash_driver_name_matches(bank->driver->name, name))
+                       continue;
+               if (++found < requested)
+                       continue;
+               return bank;
        }
-
-       return ERROR_OK;
+       return NULL;
 }
 
-int handle_flash_erase_address_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
+struct flash_bank *get_flash_bank_by_num(int num)
 {
-       flash_bank_t *p;
+       struct flash_bank *p = get_flash_bank_by_num_noprobe(num);
        int retval;
-       int address;
-       int length;
-       duration_t duration;
-       char *duration_text;
-
-       target_t *target = get_current_target(cmd_ctx);
-
-       if (argc != 2)
-       {
-               return ERROR_COMMAND_SYNTAX_ERROR;
-       }
 
-       address = strtoul(args[0], NULL, 0);
-       length = strtoul(args[1], NULL, 0);
-       if (length <= 0)
-       {
-               command_print(cmd_ctx, "Length must be >0");
-               return ERROR_COMMAND_SYNTAX_ERROR;
-       }
-
-       p = get_flash_bank_by_addr(target, address);
        if (p == NULL)
-       {
-               return ERROR_COMMAND_SYNTAX_ERROR;
-       }
-
-       /* We can't know if we did a resume + halt, in which case we no longer know the erased state */
-       flash_set_dirty();
-
-       duration_start_measure(&duration);
-
-       if ((retval = flash_erase_address_range(target, address, length)) == ERROR_OK)
-       {
-               duration_stop_measure(&duration, &duration_text);
-               command_print(cmd_ctx, "erased address 0x%8.8x length %i in %s", address, length, duration_text);
-               free(duration_text);
-       }
-
-       return retval;
-}
-
-int handle_flash_protect_check_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
-{
-       flash_bank_t *p;
-       int retval;
-
-       if (argc != 1)
-       {
-               return ERROR_COMMAND_SYNTAX_ERROR;
-       }
-
-       p = get_flash_bank_by_num(strtoul(args[0], NULL, 0));
-       if (p)
-       {
-               if ((retval = p->driver->protect_check(p)) == ERROR_OK)
-               {
-                       command_print(cmd_ctx, "successfully checked protect state");
-               }
-               else if (retval == ERROR_FLASH_OPERATION_FAILED)
-               {
-                       command_print(cmd_ctx, "checking protection state failed (possibly unsupported) by flash #%s at 0x%8.8x", args[0], p->base);
-               }
-               else
-               {
-                       command_print(cmd_ctx, "unknown error when checking protection state of flash bank '#%s' at 0x%8.8x", args[0], p->base);
-               }
-       }
-       else
-       {
-               return ERROR_COMMAND_SYNTAX_ERROR;
-       }
-
-       return ERROR_OK;
-}
-
-int handle_flash_erase_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
-{
-       if (argc > 2)
-       {
-               int first = strtoul(args[1], NULL, 0);
-               int last = strtoul(args[2], NULL, 0);
-               int retval;
-               flash_bank_t *p = get_flash_bank_by_num(strtoul(args[0], NULL, 0));
-               duration_t duration;
-               char *duration_text;
-
-               duration_start_measure(&duration);
-
-               if (!p)
-               {
-                       return ERROR_COMMAND_SYNTAX_ERROR;
-               }
-
-               if ((retval = flash_driver_erase(p, first, last)) == ERROR_OK)
-               {
-                       duration_stop_measure(&duration, &duration_text);
-
-                       command_print(cmd_ctx, "erased sectors %i through %i on flash bank %i in %s", first, last, strtoul(args[0], 0, 0), duration_text);
-                       free(duration_text);
-               }
-       }
-       else
-       {
-               return ERROR_COMMAND_SYNTAX_ERROR;
-       }
-
-       return ERROR_OK;
-}
-
-int handle_flash_protect_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
-{
-       if (argc > 3)
-       {
-               int first = strtoul(args[1], NULL, 0);
-               int last = strtoul(args[2], NULL, 0);
-               int set;
-               int retval;
-               flash_bank_t *p = get_flash_bank_by_num(strtoul(args[0], NULL, 0));
-               if (!p)
-               {
-                       command_print(cmd_ctx, "flash bank '#%s' is out of bounds", args[0]);
-                       return ERROR_OK;
-               }
-
-               if (strcmp(args[3], "on") == 0)
-                       set = 1;
-               else if (strcmp(args[3], "off") == 0)
-                       set = 0;
-               else
-               {
-                       return ERROR_COMMAND_SYNTAX_ERROR;
-               }
-
-               retval = flash_driver_protect(p, set, first, last);
-               if (retval == ERROR_OK)
-               {
-                       command_print(cmd_ctx, "%s protection for sectors %i through %i on flash bank %i", (set) ? "set" : "cleared", first, last, strtoul(args[0], 0, 0));
-               }
-       }
-       else
-       {
-               return ERROR_COMMAND_SYNTAX_ERROR;
-
-       }
-
-       return ERROR_OK;
-}
-
-int handle_flash_write_image_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
-{
-       target_t *target = get_current_target(cmd_ctx);
-
-       image_t image;
-       u32 written;
-
-       duration_t duration;
-       char *duration_text;
-
-       int retval;
-
-       if (argc < 1)
-       {
-               return ERROR_COMMAND_SYNTAX_ERROR;
-       }
-       
-       /* flash auto-erase is disabled by default*/
-       int auto_erase = 0;
-       
-       if (strcmp(args[0], "erase")==0)
-       {
-               auto_erase = 1;
-               args++;
-               argc--;
-               command_print(cmd_ctx, "auto erase enabled");
-       }
-       
-
-       if (argc < 1)
-       {
-               return ERROR_COMMAND_SYNTAX_ERROR;
-       }
-       
-       if (!target)
-       {
-               LOG_ERROR("no target selected");
-               return ERROR_FAIL;
-       }
-
-       duration_start_measure(&duration);
-
-       if (argc >= 2)
-       {
-               image.base_address_set = 1;
-               image.base_address = strtoul(args[1], NULL, 0);
-       }
-       else
-       {
-               image.base_address_set = 0;
-               image.base_address = 0x0;
-       }
-
-       image.start_address_set = 0;
+               return NULL;
 
-       retval = image_open(&image, args[0], (argc == 3) ? args[2] : NULL);
-       if (retval != ERROR_OK)
-       {
-               return retval;
-       }
+       retval = p->driver->auto_probe(p);
 
-       retval = flash_write(target, &image, &written, auto_erase);
        if (retval != ERROR_OK)
        {
-               image_close(&image);
-               return retval;
-       }
-
-       duration_stop_measure(&duration, &duration_text);
-       if (retval == ERROR_OK)
-       {
-               command_print(cmd_ctx, "wrote %u byte from file %s in %s (%f kb/s)",
-                               written, args[0], duration_text,
-                               (float)written / 1024.0 / ((float)duration.duration.tv_sec + ((float)duration.duration.tv_usec / 1000000.0)));
-       }
-       free(duration_text);
-
-       image_close(&image);
-
-       return retval;
-}
-
-int handle_flash_fill_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
-{
-       int err = ERROR_OK;
-       u32 address;
-       u32 pattern;
-       u32 count;
-       u8 chunk[1024];
-       u32 wrote = 0;
-       int chunk_count;
-       char *duration_text;
-       duration_t duration;
-       target_t *target = get_current_target(cmd_ctx);
-       u32 i;
-       int wordsize;
-       
-       if (argc != 3)
-       {
-               return ERROR_COMMAND_SYNTAX_ERROR;
-       }
-       
-       address = strtoul(args[0], NULL, 0);
-       pattern = strtoul(args[1], NULL, 0);
-       count   = strtoul(args[2], NULL, 0);
-       
-       if(count == 0)
-               return ERROR_OK;
-
-
-       switch(cmd[4])
-       {
-       case 'w':
-               wordsize=4;
-               break;
-       case 'h':
-               wordsize=2;
-               break;
-       case 'b':
-               wordsize=1;
-               break;
-       default:
-               return ERROR_COMMAND_SYNTAX_ERROR;
-       }
-       
-       chunk_count = MIN(count, (1024 / wordsize));
-       switch(wordsize)
-       {
-       case 4:
-               for(i = 0; i < chunk_count; i++)
-               {
-                       target_buffer_set_u32(target, chunk + i * wordsize, pattern);
-               }
-               break;
-       case 2:
-               for(i = 0; i < chunk_count; i++)
-               {
-                       target_buffer_set_u16(target, chunk + i * wordsize, pattern);
-               }
-               break;
-       case 1:
-               memset(chunk, pattern, chunk_count);
-               break;
-       default:
-               LOG_ERROR("BUG: can't happen");
-               exit(-1);
-       }
-       
-       duration_start_measure(&duration);
-
-       flash_set_dirty();
-       err = flash_erase_address_range( target, address, count*wordsize );
-       if (err == ERROR_OK)
-       {
-               for (wrote=0; wrote<(count*wordsize); wrote+=sizeof(chunk))
-               { 
-                       int cur_size = MIN( (count*wordsize - wrote) , 1024 );
-                       if (err == ERROR_OK)
-                       {
-                               flash_bank_t *bank;
-                               bank = get_flash_bank_by_addr(target, address);
-                               if(bank == NULL)
-                               {
-                                       err = ERROR_FAIL;
-                                       break;
-                               }
-                               err = flash_driver_write(bank, chunk, address - bank->base + wrote, cur_size);
-                               wrote += cur_size;
-                       }
-                       if (err!=ERROR_OK)
-                               break;
-               }
-       }
-       
-       duration_stop_measure(&duration, &duration_text);
-
-       if(err == ERROR_OK)
-       {
-               float speed;
-               speed=wrote / 1024.0;
-               speed/=((float)duration.duration.tv_sec + ((float)duration.duration.tv_usec / 1000000.0));
-               command_print(cmd_ctx, "wrote %d bytes to 0x%8.8x in %s (%f kb/s)",
-                       count*wordsize, address, duration_text,
-                       speed);
-       }
-       free(duration_text);
-       return ERROR_OK;
-}
-
-int handle_flash_write_bank_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
-{
-       u32 offset;
-       u8 *buffer;
-       u32 buf_cnt;
-
-       fileio_t fileio;
-
-       duration_t duration;
-       char *duration_text;
-
-       int retval;
-       flash_bank_t *p;
-
-       if (argc != 3)
-       {
-               return ERROR_COMMAND_SYNTAX_ERROR;
-       }
-
-       duration_start_measure(&duration);
-
-       offset = strtoul(args[2], NULL, 0);
-       p = get_flash_bank_by_num(strtoul(args[0], NULL, 0));
-       if (!p)
-       {
-               command_print(cmd_ctx, "flash bank '#%s' is out of bounds", args[0]);
-               return ERROR_OK;
-       }
-
-       if (fileio_open(&fileio, args[1], FILEIO_READ, FILEIO_BINARY) != ERROR_OK)
-       {
-               return ERROR_OK;
-       }
-
-       buffer = malloc(fileio.size);
-       if (fileio_read(&fileio, fileio.size, buffer, &buf_cnt) != ERROR_OK)
-       {
-               return ERROR_OK;
-       }
-
-       retval = flash_driver_write(p, buffer, offset, buf_cnt);
-
-       free(buffer);
-
-       duration_stop_measure(&duration, &duration_text);
-       if (retval!=ERROR_OK)
-       {
-       command_print(cmd_ctx, "wrote  %"PRIi64" byte from file %s to flash bank %i at offset 0x%8.8x in %s (%f kb/s)",
-               fileio.size, args[1], strtoul(args[0], NULL, 0), offset, duration_text,
-               (float)fileio.size / 1024.0 / ((float)duration.duration.tv_sec + ((float)duration.duration.tv_usec / 1000000.0)));
-       }
-       free(duration_text);
-
-       fileio_close(&fileio);
-
-       return retval;
-}
-
-void flash_set_dirty(void)
-{
-       flash_bank_t *c;
-       int i;
-
-       /* set all flash to require erasing */
-       for (c = flash_banks; c; c = c->next)
-       {
-               for (i = 0; i < c->num_sectors; i++)
-               {
-                       c->sectors[i].is_erased = 0;
-               }
+               LOG_ERROR("auto_probe failed %d\n", retval);
+               return NULL;
        }
+       return p;
 }
 
 /* lookup flash bank by address */
-flash_bank_t *get_flash_bank_by_addr(target_t *target, u32 addr)
+struct flash_bank *get_flash_bank_by_addr(struct target *target, uint32_t addr)
 {
-       flash_bank_t *c;
+       struct flash_bank *c;
 
        /* cycle through bank list */
        for (c = flash_banks; c; c = c->next)
@@ -880,426 +158,102 @@ flash_bank_t *get_flash_bank_by_addr(target_t *target, u32 addr)
                        return NULL;
                }
                /* check whether address belongs to this flash bank */
-               if ((addr >= c->base) && (addr < c->base + c->size) && target == c->target)
+               if ((addr >= c->base) && (addr <= c->base + (c->size - 1)) && target == c->target)
                        return c;
        }
-       LOG_ERROR("No flash at address 0x%08x\n", addr);
+       LOG_ERROR("No flash at address 0x%08" PRIx32 "\n", addr);
        return NULL;
 }
 
-/* erase given flash region, selects proper bank according to target and address */
-int flash_erase_address_range(target_t *target, u32 addr, u32 length)
+int default_flash_mem_blank_check(struct flash_bank *bank)
 {
-       flash_bank_t *c;
-       int first = -1;
-       int last = -1;
+       struct target *target = bank->target;
+       const int buffer_size = 1024;
        int i;
+       uint32_t nBytes;
+       int retval = ERROR_OK;
 
-       if ((c = get_flash_bank_by_addr(target, addr)) == NULL)
-               return ERROR_FLASH_DST_OUT_OF_BANK; /* no corresponding bank found */
-
-       if (c->size == 0 || c->num_sectors == 0)
-       {
-               LOG_ERROR("Bank is invalid");
-               return ERROR_FLASH_BANK_INVALID;
-       }
-
-       if (length == 0)
+       if (bank->target->state != TARGET_HALTED)
        {
-               /* special case, erase whole bank when length is zero */
-               if (addr != c->base)
-                       return ERROR_FLASH_DST_BREAKS_ALIGNMENT;
-
-               return flash_driver_erase(c, 0, c->num_sectors - 1);
+               LOG_ERROR("Target not halted");
+               return ERROR_TARGET_NOT_HALTED;
        }
 
-       /* check whether it fits */
-       if (addr + length > c->base + c->size)
-               return ERROR_FLASH_DST_BREAKS_ALIGNMENT;
+       uint8_t *buffer = malloc(buffer_size);
 
-       addr -= c->base;
-
-       for (i = 0; i < c->num_sectors; i++)
+       for (i = 0; i < bank->num_sectors; i++)
        {
-               /* check whether sector overlaps with the given range and is not yet erased */
-               if (addr < c->sectors[i].offset + c->sectors[i].size && addr + length > c->sectors[i].offset && c->sectors[i].is_erased != 1) {
-                       /* if first is not set yet then this is the first sector */
-                       if (first == -1)
-                               first = i;
-                       last = i; /* and it is the last one so far in any case */
-               }
-       }
-
-       if( first == -1 || last == -1 )
-               return ERROR_OK;
-
-       return flash_driver_erase(c, first, last);
-}
-
-/* write (optional verify) an image to flash memory of the given target */
-int flash_write(target_t *target, image_t *image, u32 *written, int erase)
-{
-       int retval=ERROR_OK;
-
-       int section;
-       u32 section_offset;
-       flash_bank_t *c;
+               uint32_t j;
+               bank->sectors[i].is_erased = 1;
 
-       section = 0;
-       section_offset = 0;
-
-       if (written)
-               *written = 0;
-
-       if (erase)
-       {
-               /* assume all sectors need erasing - stops any problems
-                * when flash_write is called multiple times */
-
-               flash_set_dirty();
-       }
-
-       /* loop until we reach end of the image */
-       while (section < image->num_sections)
-       {
-               u32 buffer_size;
-               u8 *buffer;
-               int section_first;
-               int section_last;
-               u32 run_address = image->sections[section].base_address + section_offset;
-               u32 run_size = image->sections[section].size - section_offset;
-
-               if (image->sections[section].size ==  0)
-               {
-                       LOG_WARNING("empty section %d", section);
-                       section++;
-                       section_offset = 0;
-                       continue;
-               }
-
-               /* find the corresponding flash bank */
-               if ((c = get_flash_bank_by_addr(target, run_address)) == NULL)
+               for (j = 0; j < bank->sectors[i].size; j += buffer_size)
                {
-                       section++; /* and skip it */
-                       section_offset = 0;
-                       continue;
-               }
-
-               /* collect consecutive sections which fall into the same bank */
-               section_first = section;
-               section_last = section;
-               while ((run_address + run_size < c->base + c->size)
-                               && (section_last + 1 < image->num_sections))
-               {
-                       if (image->sections[section_last + 1].base_address < (run_address + run_size))
+                       uint32_t chunk;
+                       chunk = buffer_size;
+                       if (chunk > (j - bank->sectors[i].size))
                        {
-                               LOG_DEBUG("section %d out of order(very slightly surprising, but supported)", section_last + 1);
-                               break;
+                               chunk = (j - bank->sectors[i].size);
                        }
-                       if (image->sections[section_last + 1].base_address != (run_address + run_size))
-                               break;
-                       run_size += image->sections[++section_last].size;
-               }
 
-               /* fit the run into bank constraints */
-               if (run_address + run_size > c->base + c->size)
-                       run_size = c->base + c->size - run_address;
-
-               /* allocate buffer */
-               buffer = malloc(run_size);
-               buffer_size = 0;
-
-               /* read sections to the buffer */
-               while (buffer_size < run_size)
-               {
-                       u32 size_read;
-
-                       if (buffer_size - run_size <= image->sections[section].size - section_offset)
-                               size_read = buffer_size - run_size;
-                       else
-                               size_read = image->sections[section].size - section_offset;
-
-                       if ((retval = image_read_section(image, section, section_offset,
-                                       size_read, buffer + buffer_size, &size_read)) != ERROR_OK || size_read == 0)
+                       retval = target_read_memory(target, bank->base + bank->sectors[i].offset + j, 4, chunk/4, buffer);
+                       if (retval != ERROR_OK)
                        {
-                               free(buffer);
-
-                               return retval;
+                               goto done;
                        }
 
-                       buffer_size += size_read;
-                       section_offset += size_read;
-
-                       if (section_offset >= image->sections[section].size)
+                       for (nBytes = 0; nBytes < chunk; nBytes++)
                        {
-                               section++;
-                               section_offset = 0;
+                               if (buffer[nBytes] != 0xFF)
+                               {
+                                       bank->sectors[i].is_erased = 0;
+                                       break;
+                               }
                        }
                }
-
-               retval = ERROR_OK;
-
-               if (erase)
-               {
-                       /* calculate and erase sectors */
-                       retval = flash_erase_address_range( target, run_address, run_size );
-               }
-
-               if (retval == ERROR_OK)
-               {
-                       /* write flash sectors */
-                       retval = flash_driver_write(c, buffer, run_address - c->base, run_size);
-               }
-
-               free(buffer);
-
-               if (retval != ERROR_OK)
-               {
-                       return retval; /* abort operation */
-               }
-
-               if (written != NULL)
-                       *written += run_size; /* add run size to total written counter */
        }
 
+       done:
+       free(buffer);
+
        return retval;
 }
 
-int default_flash_blank_check(struct flash_bank_s *bank)
+int default_flash_blank_check(struct flash_bank *bank)
 {
-       target_t *target = bank->target;
-       u8 buffer[1024];
-       int buffer_size=sizeof(buffer);
+       struct target *target = bank->target;
        int i;
-       int nBytes;
-       
+       int retval;
+       int fast_check = 0;
+       uint32_t blank;
+
        if (bank->target->state != TARGET_HALTED)
        {
+               LOG_ERROR("Target not halted");
                return ERROR_TARGET_NOT_HALTED;
        }
-       
-       int retval;
-       int fast_check=0;
-       working_area_t *erase_check_algorithm;
-#if 0
-       /* FIX! doesn't work yet... */
-       /*
-       char test(char *a, int len, char t)
-       {
-         int i=0;
-       
-         for (i=0; i<len; i++)
-               {
-                 t&=a[i];
-       
-               }
-       }
-       
-       $ arm-elf-gcc -c -mthumb -O3 test.c
-       
-       $ arm-elf-objdump --disassemble test.o
-       
-       test.o:     file format elf32-littlearm
-       
-       Disassembly of section .text:
-       
-       00000000 <test>:
-          0:   b510            push    {r4, lr}
-          2:   0612            lsl     r2, r2, #24
-          4:   1c04            mov     r4, r0          (add r4, r0, #0)
-          6:   0e10            lsr     r0, r2, #24
-          8:   2200            mov     r2, #0
-          a:   2900            cmp     r1, #0
-          c:   dd04            ble     18 <test+0x18>
-          e:   5ca3            ldrb    r3, [r4, r2]
-         10:   3201            add     r2, #1
-         12:   4018            and     r0, r3
-         14:   428a            cmp     r2, r1
-         16:   dbfa            blt     e <test+0xe>
-         18:   bd10            pop     {r4, pc}
-         1a:   46c0            nop                     (mov r8, r8)
-       
-
-       */
-       u16 erase_check_code[] =
-       {
-                0x0612,//            lsl     r2, r2, #24
-                0x1c04,//            mov     r4, r0          (add r4, r0, #0)
-                0x0e10,//            lsr     r0, r2, #24
-                0x2200,//            mov     r2, #0
-                0x2900,//            cmp     r1, #0
-                0xdd04,//            ble     18 <test+0x18>
-                0x5ca3,//            ldrb    r3, [r4, r2]
-                0x3201,//            add     r2, #1
-                0x4018,//            and     r0, r3
-                0x428a,//            cmp     r2, r1
-                0xdbfa,//            blt     e <test+0xe>
-                0x46c0,//            nop                     (mov r8, r8)
-                
-       };
 
-
-       
-       /* make sure we have a working area */
-       if (target_alloc_working_area(target, ((sizeof(erase_check_code)+3)/4)*4, &erase_check_algorithm) != ERROR_OK)
-       {
-               erase_check_algorithm = NULL;
-       }
-       
-       if (erase_check_algorithm)
+       for (i = 0; i < bank->num_sectors; i++)
        {
-               u8 erase_check_code_buf[((sizeof(erase_check_code)+3)/4)*4];
-               LOG_DEBUG("Running fast flash erase check");
-               
-               for (i = 0; i < sizeof(erase_check_code)/sizeof(*erase_check_code); i++)
-                       target_buffer_set_u16(target, erase_check_code_buf + (i*2), erase_check_code[i]);
+               uint32_t address = bank->base + bank->sectors[i].offset;
+               uint32_t size = bank->sectors[i].size;
 
-               /* write algorithm code to working area */
-               if ((retval=target->type->write_memory(target, erase_check_algorithm->address, 2, sizeof(erase_check_code)/sizeof(*erase_check_code), erase_check_code_buf))==ERROR_OK)
+               if ((retval = target_blank_check_memory(target, address, size, &blank)) != ERROR_OK)
                {
-                       for (i = 0; i < bank->num_sectors; i++)
-                       {
-                               u32 address = bank->base + bank->sectors[i].offset;
-                               u32 size = bank->sectors[i].size;
-       
-                               reg_param_t reg_params[3];
-                               armv7m_algorithm_t arm_info;
-       
-                               arm_info.common_magic = ARMV7M_COMMON_MAGIC;
-                               arm_info.core_mode = ARMV7M_MODE_ANY;
-                               arm_info.core_state = ARMV7M_STATE_THUMB;
-       
-                               init_reg_param(&reg_params[0], "r0", 32, PARAM_OUT);
-                               buf_set_u32(reg_params[0].value, 0, 32, address);
-       
-                               init_reg_param(&reg_params[1], "r1", 32, PARAM_OUT);
-                               buf_set_u32(reg_params[1].value, 0, 32, size);
-       
-                               init_reg_param(&reg_params[2], "r2", 32, PARAM_IN_OUT);
-                               buf_set_u32(reg_params[2].value, 0, 32, 0xff);
-       
-                               if ((retval = target->type->run_algorithm(target, 0, NULL, 3, reg_params, erase_check_algorithm->address, 
-                                               erase_check_algorithm->address + sizeof(erase_check_code) - 2, 10000, &arm_info)) != ERROR_OK)
-                                       break;
-       
-                               if (buf_get_u32(reg_params[2].value, 0, 32) == 0xff)
-                                       bank->sectors[i].is_erased = 1;
-                               else
-                                       bank->sectors[i].is_erased = 0;
-       
-                               destroy_reg_param(&reg_params[0]);
-                               destroy_reg_param(&reg_params[1]);
-                               destroy_reg_param(&reg_params[2]);
-                       }
-                       if (i == bank->num_sectors)
-                       {
-                               fast_check = 1;
-                       }
-               } 
-               target_free_working_area(target, erase_check_algorithm);
-       }
-#endif
-       if (!fast_check)
-       {
-               /* try ARM7 instead */
-       
-               u32 erase_check_code[] =
-               {
-                       0xe4d03001,     /* ldrb r3, [r0], #1    */
-                       0xe0022003, /* and r2, r2, r3           */
-                       0xe2511001, /* subs r1, r1, #1          */
-                       0x1afffffb,     /* b -4                                 */
-                       0xeafffffe      /* b 0                                  */
-               };
-
-               /* make sure we have a working area */
-               if (target_alloc_working_area(target, 20, &erase_check_algorithm) == ERROR_OK)
-               {
-                       u8 erase_check_code_buf[5 * 4];
-
-                       for (i = 0; i < 5; i++)
-                               target_buffer_set_u32(target, erase_check_code_buf + (i*4), erase_check_code[i]);
-
-                       /* write algorithm code to working area */
-                       if ((retval=target->type->write_memory(target, erase_check_algorithm->address, 4, 5, erase_check_code_buf))==ERROR_OK)
-                       {
-                               for (i = 0; i < bank->num_sectors; i++)
-                               {
-                                       u32 address = bank->base + bank->sectors[i].offset;
-                                       u32 size = bank->sectors[i].size;
-                       
-                                       reg_param_t reg_params[3];
-                                       armv4_5_algorithm_t armv4_5_info;
-                       
-                                       armv4_5_info.common_magic = ARMV4_5_COMMON_MAGIC;
-                                       armv4_5_info.core_mode = ARMV4_5_MODE_SVC;
-                                       armv4_5_info.core_state = ARMV4_5_STATE_ARM;
-                       
-                                       init_reg_param(&reg_params[0], "r0", 32, PARAM_OUT);
-                                       buf_set_u32(reg_params[0].value, 0, 32, address);
-                       
-                                       init_reg_param(&reg_params[1], "r1", 32, PARAM_OUT);
-                                       buf_set_u32(reg_params[1].value, 0, 32, size);
-                       
-                                       init_reg_param(&reg_params[2], "r2", 32, PARAM_IN_OUT);
-                                       buf_set_u32(reg_params[2].value, 0, 32, 0xff);
-                       
-                                       if ((retval = target->type->run_algorithm(target, 0, NULL, 3, reg_params, 
-                                                       erase_check_algorithm->address, erase_check_algorithm->address + 0x10, 10000, &armv4_5_info)) != ERROR_OK)
-                                               break;
-                       
-                                       if (buf_get_u32(reg_params[2].value, 0, 32) == 0xff)
-                                               bank->sectors[i].is_erased = 1;
-                                       else
-                                               bank->sectors[i].is_erased = 0;
-                       
-                                       destroy_reg_param(&reg_params[0]);
-                                       destroy_reg_param(&reg_params[1]);
-                                       destroy_reg_param(&reg_params[2]);
-                               }
-                               if (i == bank->num_sectors)
-                               {
-                                       fast_check = 1;
-                               }
-                       } 
-                       target_free_working_area(target, erase_check_algorithm);
+                       fast_check = 0;
+                       break;
                }
+               if (blank == 0xFF)
+                       bank->sectors[i].is_erased = 1;
+               else
+                       bank->sectors[i].is_erased = 0;
+               fast_check = 1;
        }
 
-       
        if (!fast_check)
        {
                LOG_USER("Running slow fallback erase check - add working memory");
-               for (i = 0; i < bank->num_sectors; i++)
-               {
-                       int j;
-                       bank->sectors[i].is_erased = 1;
-                       
-                       for (j=0; j<bank->sectors[i].size; j+=buffer_size)
-                       {
-                               int chunk;
-                               int retval;
-                               chunk=buffer_size;
-                               if (chunk>(j-bank->sectors[i].size))
-                               {
-                                       chunk=(j-bank->sectors[i].size);
-                               }
-                               
-                               retval=target->type->read_memory(target, bank->base + bank->sectors[i].offset + j, 4, chunk/4, buffer);
-                               if (retval!=ERROR_OK)
-                                       return retval;
-                       
-                               for (nBytes = 0; nBytes < chunk; nBytes++)
-                               {
-                                       if (buffer[nBytes] != 0xFF)
-                                       {
-                                               bank->sectors[i].is_erased = 0;
-                                               break;
-                                       }
-                               }
-                       }
-               }
+               return default_flash_mem_blank_check(bank);
        }
-       
+
        return ERROR_OK;
 }

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)