NAND: fix off-by-one error in erase command argument range
[openocd.git] / src / flash / nand / at91sam9.c
index 7cfd763a8b157d350fbe047b8d55c56e2a1f48a6..92ab047f623a3e9972c3dcc79066d3b48c14805a 100644 (file)
@@ -414,12 +414,16 @@ static int at91sam9_read_page(struct nand_device *nand, uint32_t page,
                                // attempt recovery
                                uint32_t parity;
 
-                               target_read_u32(target, info->ecc + AT91C_ECCx_PR, &parity);
+                               target_read_u32(target,
+                                               info->ecc + AT91C_ECCx_PR,
+                                               &parity);
                                uint32_t word = (parity & 0x0000FFF0) >> 4;
                                uint32_t bit = parity & 0x0F;
 
                                data[word] ^= (0x1) << bit;
-                               LOG_INFO("Data word %d, bit %d corrected.", word, bit);
+                               LOG_INFO("Data word %d, bit %d corrected.",
+                                               (unsigned) word,
+                                               (unsigned) bit);
                        }
                }
 
@@ -693,28 +697,30 @@ static const struct command_registration at91sam9_sub_command_handlers[] = {
                .handler = handle_at91sam9_cle_command,
                .mode = COMMAND_CONFIG,
                .help = "set command latch enable address line (default is 22)",
-               .usage = "<device_id> <address_line>",
+               .usage = "bank_id address_line",
        },
        {
                .name = "ale",
                .handler = handle_at91sam9_ale_command,
                .mode = COMMAND_CONFIG,
                .help = "set address latch enable address line (default is 21)",
-               .usage = "<device_id> <address_line>",
+               .usage = "bank_id address_line",
        },
        {
                .name = "rdy_busy",
                .handler = handle_at91sam9_rdy_busy_command,
                .mode = COMMAND_CONFIG,
-               .help = "set the input pin connected to RDY/~BUSY signal (no default)",
-               .usage = "<device_id> <base_pioc> <pin_num>",
+               .help = "set the GPIO input pin connected to "
+                       "the RDY/~BUSY signal (no default)",
+               .usage = "bank_id pio_base_addr pin_num",
        },
        {
                .name = "ce",
                .handler = handle_at91sam9_ce_command,
                .mode = COMMAND_CONFIG,
-               .help = "set the output pin connected to chip enable signal (no default)",
-               .usage = "<device_id> <base_pioc> <pin_num>",
+               .help = "set the GPIO output pin connected to "
+                       "the chip enable signal (no default)",
+               .usage = "bank_id pio_base_addr pin_num",
        },
        COMMAND_REGISTRATION_DONE
 };

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)