flash/nor/tcl: 'flash list' command: add the flash bank target
[openocd.git] / src / flash / nor / at91sam4.c
index 958ec5ec0a0f5575c24197ea3aa85093d645358c..4ec2ee89ecec7393f698885f59507a8493ffda63 100644 (file)
@@ -2318,7 +2318,7 @@ static struct sam4_chip *target2sam4(struct target *target)
 {
        struct sam4_chip *chip;
 
-       if (target == NULL)
+       if (!target)
                return NULL;
 
        chip = all_sam4_chips;
@@ -2611,7 +2611,7 @@ static int sam4_get_details(struct sam4_bank_private *private)
                else
                        details++;
        }
-       if (details->name == NULL) {
+       if (!details->name) {
                LOG_ERROR("SAM4 ChipID 0x%08x not found in table (perhaps you can ID this chip?)",
                        (unsigned int)(private->chip->cfg.CHIPID_CIDR));
                /* Help the victim, print details about the chip */
@@ -2662,7 +2662,7 @@ static int sam4_info(struct flash_bank *bank, struct command_invocation *cmd)
        int k = bank->size / 1024;
 
        private = get_sam4_bank_private(bank);
-       if (private == NULL)
+       if (!private)
                return ERROR_FAIL;
 
        command_print_sameline(cmd, "%s bank %d: %d kB at " TARGET_ADDR_FMT,
@@ -2715,9 +2715,9 @@ static int sam4_probe(struct flash_bank *bank)
                }
        }
 
-       if (bank->sectors == NULL) {
+       if (!bank->sectors) {
                bank->sectors = calloc(private->nsectors, (sizeof((bank->sectors)[0])));
-               if (bank->sectors == NULL) {
+               if (!bank->sectors) {
                        LOG_ERROR("No memory!");
                        return ERROR_FAIL;
                }
@@ -3092,7 +3092,7 @@ COMMAND_HANDLER(sam4_handle_info_command)
        int r;
 
        /* bank0 must exist before we can do anything */
-       if (chip->details.bank[0].bank == NULL) {
+       if (!chip->details.bank[0].bank) {
                x = 0;
 need_define:
                command_print(CMD,
@@ -3118,7 +3118,7 @@ need_define:
                if (!(chip->details.bank[x].present))
                        continue;
 
-               if (chip->details.bank[x].bank == NULL)
+               if (!chip->details.bank[x].bank)
                        goto need_define;
 
                if (chip->details.bank[x].probed)
@@ -3153,7 +3153,7 @@ COMMAND_HANDLER(sam4_handle_gpnvm_command)
                return ERROR_TARGET_NOT_HALTED;
        }
 
-       if (chip->details.bank[0].bank == NULL) {
+       if (!chip->details.bank[0].bank) {
                command_print(CMD, "Bank0 must be defined first via: flash bank %s ...",
                        at91sam4_flash.name);
                return ERROR_FAIL;

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)