jtag: linuxgpiod: drop extra parenthesis

[openocd.git] / src / flash / nor / str9x.c

diff --git a/src/flash/nor/str9x.c b/src/flash/nor/str9x.c
index 3b7ca2aa7deef424fc5322ce53307e4c4a5fd1b8..1a26b839e9aa063f90da653cfbaccae3ad67ecd0 100644 (file)
--- a/src/flash/nor/str9x.c
+++ b/src/flash/nor/str9x.c
@@ -1,3 +1,5 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+
 /***************************************************************************
  *   Copyright (C) 2005 by Dominic Rath                                    *
  *   Dominic.Rath@gmx.de                                                   *
@@ -7,19 +9,6 @@
  *
  *   Copyright (C) 2008 by Oyvind Harboe                                   *
  *   oyvind.harboe@zylin.com                                               *
- *                                                                         *
- *   This program is free software; you can redistribute it and/or modify  *
- *   it under the terms of the GNU General Public License as published by  *
- *   the Free Software Foundation; either version 2 of the License, or     *
- *   (at your option) any later version.                                   *
- *                                                                         *
- *   This program is distributed in the hope that it will be useful,       *
- *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
- *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
- *   GNU General Public License for more details.                          *
- *                                                                         *
- *   You should have received a copy of the GNU General Public License     *
- *   along with this program.  If not, see <http://www.gnu.org/licenses/>. *
  ***************************************************************************/
 
 #ifdef HAVE_CONFIG_H
@@ -68,7 +57,7 @@ static int str9x_build_block_list(struct flash_bank *bank)
        struct str9x_flash_bank *str9x_info = bank->driver_priv;
 
        int i;
-       int num_sectors;
+       unsigned int num_sectors;
        int b0_sectors = 0, b1_sectors = 0;
        uint32_t offset = 0;
 
@@ -164,7 +153,6 @@ static int str9x_protect_check(struct flash_bank *bank)
        struct str9x_flash_bank *str9x_info = bank->driver_priv;
        struct target *target = bank->target;
 
-       int i;
        uint32_t adr;
        uint32_t status = 0;
        uint16_t hstatus = 0;
@@ -211,7 +199,7 @@ static int str9x_protect_check(struct flash_bank *bank)
        if (retval != ERROR_OK)
                return retval;
 
-       for (i = 0; i < bank->num_sectors; i++) {
+       for (unsigned int i = 0; i < bank->num_sectors; i++) {
                if (status & str9x_info->sector_bits[i])
                        bank->sectors[i].is_protected = 1;
                else
@@ -221,10 +209,10 @@ static int str9x_protect_check(struct flash_bank *bank)
        return ERROR_OK;
 }
 
-static int str9x_erase(struct flash_bank *bank, int first, int last)
+static int str9x_erase(struct flash_bank *bank, unsigned int first,
+               unsigned int last)
 {
        struct target *target = bank->target;
-       int i;
        uint32_t adr;
        uint8_t status;
        uint8_t erase_cmd;
@@ -250,7 +238,7 @@ static int str9x_erase(struct flash_bank *bank, int first, int last)
        /* this is so the compiler can *know* */
        assert(total_timeout > 0);
 
-       for (i = first; i <= last; i++) {
+       for (unsigned int i = first; i <= last; i++) {
                int retval;
                adr = bank->base + bank->sectors[i].offset;
 
@@ -301,17 +289,13 @@ static int str9x_erase(struct flash_bank *bank, int first, int last)
                        break;
        }
 
-       for (i = first; i <= last; i++)
-               bank->sectors[i].is_erased = 1;
-
        return ERROR_OK;
 }
 
-static int str9x_protect(struct flash_bank *bank,
-               int set, int first, int last)
+static int str9x_protect(struct flash_bank *bank, int set, unsigned int first,
+               unsigned int last)
 {
        struct target *target = bank->target;
-       int i;
        uint32_t adr;
        uint8_t status;
 
@@ -320,7 +304,7 @@ static int str9x_protect(struct flash_bank *bank,
                return ERROR_TARGET_NOT_HALTED;
        }
 
-       for (i = first; i <= last; i++) {
+       for (unsigned int i = first; i <= last; i++) {
                /* Level One Protection */
 
                adr = bank->base + bank->sectors[i].offset;
@@ -356,7 +340,7 @@ static int str9x_write_block(struct flash_bank *bank,
        struct arm_algorithm arm_algo;
        int retval = ERROR_OK;
 
-       /* see contib/loaders/flash/str9x.s for src */
+       /* see contrib/loaders/flash/str9x.s for src */
 
        static const uint32_t str9x_flash_write_code[] = {
                                        /* write:                               */
@@ -468,7 +452,6 @@ static int str9x_write(struct flash_bank *bank,
        int retval;
        uint32_t check_address = offset;
        uint32_t bank_adr;
-       int i;
 
        if (bank->target->state != TARGET_HALTED) {
                LOG_ERROR("Target not halted");
@@ -480,7 +463,7 @@ static int str9x_write(struct flash_bank *bank,
                return ERROR_FLASH_DST_BREAKS_ALIGNMENT;
        }
 
-       for (i = 0; i < bank->num_sectors; i++) {
+       for (unsigned int i = 0; i < bank->num_sectors; i++) {
                uint32_t sec_start = bank->sectors[i].offset;
                uint32_t sec_end = sec_start + bank->sectors[i].size;
 
@@ -614,7 +597,7 @@ COMMAND_HANDLER(str9x_handle_flash_config_command)
 
        struct flash_bank *bank;
        int retval = CALL_COMMAND_HANDLER(flash_command_get_bank, 0, &bank);
-       if (ERROR_OK != retval)
+       if (retval != ERROR_OK)
                return retval;
 
        uint32_t bbsr, nbbsr, bbadr, nbbadr;
@@ -667,7 +650,7 @@ static const struct command_registration str9x_command_handlers[] = {
        COMMAND_REGISTRATION_DONE
 };
 
-struct flash_driver str9x_flash = {
+const struct flash_driver str9x_flash = {
        .name = "str9x",
        .commands = str9x_command_handlers,
        .flash_bank_command = str9x_flash_bank_command,
@@ -679,4 +662,5 @@ struct flash_driver str9x_flash = {
        .auto_probe = str9x_probe,
        .erase_check = default_flash_blank_check,
        .protect_check = str9x_protect_check,
+       .free_driver_priv = default_flash_free_driver_priv,
 };