drivers/remote_bitbang: Group adapter commands
[openocd.git] / src / jtag / drivers / remote_bitbang.c
index a1c11b2445d0e917dacfaba546cb86a54a4f584b..ce1a065445c795db5bd9c552834dc01e2ecae29f 100644 (file)
@@ -13,9 +13,7 @@
  *   GNU General Public License for more details.                          *
  *                                                                         *
  *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.           *
+ *   along with this program.  If not, see <http://www.gnu.org/licenses/>. *
  ***************************************************************************/
 
 #ifdef HAVE_CONFIG_H
 #include <sys/un.h>
 #include <netdb.h>
 #endif
+#include "helper/system.h"
+#include "helper/replacements.h"
 #include <jtag/interface.h>
 #include "bitbang.h"
 
 /* arbitrary limit on host name length: */
 #define REMOTE_BITBANG_HOST_MAX 255
 
-#define REMOTE_BITBANG_RAISE_ERROR(expr ...) \
-       do { \
-               LOG_ERROR(expr); \
-               LOG_ERROR("Terminating openocd."); \
-               exit(-1); \
-       } while (0)
-
 static char *remote_bitbang_host;
 static char *remote_bitbang_port;
 
-FILE *remote_bitbang_in;
-FILE *remote_bitbang_out;
+static int remote_bitbang_fd;
+static uint8_t remote_bitbang_send_buf[512];
+static unsigned int remote_bitbang_send_buf_used;
+
+/* Circular buffer. When start == end, the buffer is empty. */
+static char remote_bitbang_recv_buf[64];
+static unsigned int remote_bitbang_recv_buf_start;
+static unsigned int remote_bitbang_recv_buf_end;
 
-static void remote_bitbang_putc(int c)
+static bool remote_bitbang_buf_full(void)
 {
-       if (EOF == fputc(c, remote_bitbang_out))
-               REMOTE_BITBANG_RAISE_ERROR("remote_bitbang_putc: %s", strerror(errno));
+       return remote_bitbang_recv_buf_end ==
+               ((remote_bitbang_recv_buf_start + sizeof(remote_bitbang_recv_buf) - 1) %
+                sizeof(remote_bitbang_recv_buf));
 }
 
-static int remote_bitbang_quit(void)
+/* Read any incoming data, placing it into the buffer. */
+static int remote_bitbang_fill_buf(void)
 {
-       if (EOF == fputc('Q', remote_bitbang_out)) {
-               LOG_ERROR("fputs: %s", strerror(errno));
-               return ERROR_FAIL;
+       socket_nonblock(remote_bitbang_fd);
+       while (!remote_bitbang_buf_full()) {
+               unsigned int contiguous_available_space;
+               if (remote_bitbang_recv_buf_end >= remote_bitbang_recv_buf_start) {
+                       contiguous_available_space = sizeof(remote_bitbang_recv_buf) -
+                               remote_bitbang_recv_buf_end;
+                       if (remote_bitbang_recv_buf_start == 0)
+                               contiguous_available_space -= 1;
+               } else {
+                       contiguous_available_space = remote_bitbang_recv_buf_start -
+                               remote_bitbang_recv_buf_end - 1;
+               }
+               ssize_t count = read_socket(remote_bitbang_fd,
+                               remote_bitbang_recv_buf + remote_bitbang_recv_buf_end,
+                               contiguous_available_space);
+               if (count > 0) {
+                       remote_bitbang_recv_buf_end += count;
+                       if (remote_bitbang_recv_buf_end == sizeof(remote_bitbang_recv_buf))
+                               remote_bitbang_recv_buf_end = 0;
+               } else if (count == 0) {
+                       return ERROR_OK;
+               } else if (count < 0) {
+#ifdef _WIN32
+                       if (WSAGetLastError() == WSAEWOULDBLOCK) {
+#else
+                       if (errno == EAGAIN) {
+#endif
+                               return ERROR_OK;
+                       } else {
+                               log_socket_error("remote_bitbang_fill_buf");
+                               return ERROR_FAIL;
+                       }
+               }
        }
 
-       if (EOF == fflush(remote_bitbang_out)) {
-               LOG_ERROR("fflush: %s", strerror(errno));
-               return ERROR_FAIL;
+       return ERROR_OK;
+}
+
+static int remote_bitbang_flush(void)
+{
+       if (remote_bitbang_send_buf_used <= 0)
+               return ERROR_OK;
+
+       unsigned int offset = 0;
+       while (offset < remote_bitbang_send_buf_used) {
+               ssize_t written = write_socket(remote_bitbang_fd, remote_bitbang_send_buf + offset,
+                                                                          remote_bitbang_send_buf_used - offset);
+               if (written < 0) {
+                       log_socket_error("remote_bitbang_putc");
+                       remote_bitbang_send_buf_used = 0;
+                       return ERROR_FAIL;
+               }
+               offset += written;
        }
+       remote_bitbang_send_buf_used = 0;
+       return ERROR_OK;
+}
+
+typedef enum {
+       NO_FLUSH,
+       FLUSH_SEND_BUF
+} flush_bool_t;
 
-       /* We only need to close one of the FILE*s, because they both use the same */
-       /* underlying file descriptor. */
-       if (EOF == fclose(remote_bitbang_out)) {
-               LOG_ERROR("fclose: %s", strerror(errno));
+static int remote_bitbang_queue(int c, flush_bool_t flush)
+{
+       remote_bitbang_send_buf[remote_bitbang_send_buf_used++] = c;
+       if (flush == FLUSH_SEND_BUF ||
+                       remote_bitbang_send_buf_used >= ARRAY_SIZE(remote_bitbang_send_buf))
+               return remote_bitbang_flush();
+       return ERROR_OK;
+}
+
+static int remote_bitbang_quit(void)
+{
+       if (remote_bitbang_queue('Q', FLUSH_SEND_BUF) == ERROR_FAIL)
+               return ERROR_FAIL;
+
+       if (close_socket(remote_bitbang_fd) != 0) {
+               log_socket_error("close_socket");
                return ERROR_FAIL;
        }
 
@@ -77,55 +143,88 @@ static int remote_bitbang_quit(void)
        return ERROR_OK;
 }
 
-/* Get the next read response. */
-static int remote_bitbang_rread(void)
+static bb_value_t char_to_int(int c)
 {
-       if (EOF == fflush(remote_bitbang_out)) {
-               remote_bitbang_quit();
-               REMOTE_BITBANG_RAISE_ERROR("fflush: %s", strerror(errno));
-       }
-
-       int c = fgetc(remote_bitbang_in);
        switch (c) {
                case '0':
-                       return 0;
+                       return BB_LOW;
                case '1':
-                       return 1;
+                       return BB_HIGH;
                default:
                        remote_bitbang_quit();
-                       REMOTE_BITBANG_RAISE_ERROR(
-                                       "remote_bitbang: invalid read response: %c(%i)", c, c);
+                       LOG_ERROR("remote_bitbang: invalid read response: %c(%i)", c, c);
+                       return BB_ERROR;
+       }
+}
+
+/* Get the next read response. */
+static bb_value_t remote_bitbang_rread(void)
+{
+       if (remote_bitbang_flush() != ERROR_OK)
+               return ERROR_FAIL;
+
+       /* Enable blocking access. */
+       socket_block(remote_bitbang_fd);
+       char c;
+       ssize_t count = read_socket(remote_bitbang_fd, &c, 1);
+       if (count == 1) {
+               return char_to_int(c);
+       } else {
+               remote_bitbang_quit();
+               LOG_ERROR("read_socket: count=%d", (int) count);
+               log_socket_error("read_socket");
+               return BB_ERROR;
        }
 }
 
-static int remote_bitbang_read(void)
+static int remote_bitbang_sample(void)
 {
-       remote_bitbang_putc('R');
+       if (remote_bitbang_fill_buf() != ERROR_OK)
+               return ERROR_FAIL;
+       assert(!remote_bitbang_buf_full());
+       return remote_bitbang_queue('R', NO_FLUSH);
+}
+
+static bb_value_t remote_bitbang_read_sample(void)
+{
+       if (remote_bitbang_recv_buf_start == remote_bitbang_recv_buf_end) {
+               if (remote_bitbang_fill_buf() != ERROR_OK)
+                       return ERROR_FAIL;
+       }
+       if (remote_bitbang_recv_buf_start != remote_bitbang_recv_buf_end) {
+               int c = remote_bitbang_recv_buf[remote_bitbang_recv_buf_start];
+               remote_bitbang_recv_buf_start =
+                       (remote_bitbang_recv_buf_start + 1) % sizeof(remote_bitbang_recv_buf);
+               return char_to_int(c);
+       }
        return remote_bitbang_rread();
 }
 
-static void remote_bitbang_write(int tck, int tms, int tdi)
+static int remote_bitbang_write(int tck, int tms, int tdi)
 {
        char c = '0' + ((tck ? 0x4 : 0x0) | (tms ? 0x2 : 0x0) | (tdi ? 0x1 : 0x0));
-       remote_bitbang_putc(c);
+       return remote_bitbang_queue(c, NO_FLUSH);
 }
 
-static void remote_bitbang_reset(int trst, int srst)
+static int remote_bitbang_reset(int trst, int srst)
 {
        char c = 'r' + ((trst ? 0x2 : 0x0) | (srst ? 0x1 : 0x0));
-       remote_bitbang_putc(c);
+       /* Always flush the send buffer on reset, because the reset call need not be
+        * followed by jtag_execute_queue(). */
+       return remote_bitbang_queue(c, FLUSH_SEND_BUF);
 }
 
-static void remote_bitbang_blink(int on)
+static int remote_bitbang_blink(int on)
 {
        char c = on ? 'B' : 'b';
-       remote_bitbang_putc(c);
+       return remote_bitbang_queue(c, FLUSH_SEND_BUF);
 }
 
 static struct bitbang_interface remote_bitbang_bitbang = {
-       .read = &remote_bitbang_read,
+       .buf_size = sizeof(remote_bitbang_recv_buf) - 1,
+       .sample = &remote_bitbang_sample,
+       .read_sample = &remote_bitbang_read_sample,
        .write = &remote_bitbang_write,
-       .reset = &remote_bitbang_reset,
        .blink = &remote_bitbang_blink,
 };
 
@@ -133,7 +232,7 @@ static int remote_bitbang_init_tcp(void)
 {
        struct addrinfo hints = { .ai_family = AF_UNSPEC, .ai_socktype = SOCK_STREAM };
        struct addrinfo *result, *rp;
-       int fd;
+       int fd = 0;
 
        LOG_INFO("Connecting to %s:%s",
                        remote_bitbang_host ? remote_bitbang_host : "localhost",
@@ -151,7 +250,7 @@ static int remote_bitbang_init_tcp(void)
         If socket(2) (or connect(2)) fails, we (close the socket
         and) try the next address. */
 
-       for (rp = result; rp != NULL ; rp = rp->ai_next) {
+       for (rp = result; rp ; rp = rp->ai_next) {
                fd = socket(rp->ai_family, rp->ai_socktype, rp->ai_protocol);
                if (fd == -1)
                        continue;
@@ -164,8 +263,8 @@ static int remote_bitbang_init_tcp(void)
 
        freeaddrinfo(result); /* No longer needed */
 
-       if (rp == NULL) { /* No address succeeded */
-               LOG_ERROR("Failed to connect: %s", strerror(errno));
+       if (!rp) { /* No address succeeded */
+               log_socket_error("Failed to connect");
                return ERROR_FAIL;
        }
 
@@ -174,7 +273,7 @@ static int remote_bitbang_init_tcp(void)
 
 static int remote_bitbang_init_unix(void)
 {
-       if (remote_bitbang_host == NULL) {
+       if (!remote_bitbang_host) {
                LOG_ERROR("host/socket not specified");
                return ERROR_FAIL;
        }
@@ -182,7 +281,7 @@ static int remote_bitbang_init_unix(void)
        LOG_INFO("Connecting to unix socket %s", remote_bitbang_host);
        int fd = socket(PF_UNIX, SOCK_STREAM, 0);
        if (fd < 0) {
-               LOG_ERROR("socket: %s", strerror(errno));
+               log_socket_error("socket");
                return ERROR_FAIL;
        }
 
@@ -192,7 +291,7 @@ static int remote_bitbang_init_unix(void)
        addr.sun_path[sizeof(addr.sun_path)-1] = '\0';
 
        if (connect(fd, (struct sockaddr *)&addr, sizeof(struct sockaddr_un)) < 0) {
-               LOG_ERROR("connect: %s", strerror(errno));
+               log_socket_error("connect");
                return ERROR_FAIL;
        }
 
@@ -201,31 +300,19 @@ static int remote_bitbang_init_unix(void)
 
 static int remote_bitbang_init(void)
 {
-       int fd;
        bitbang_interface = &remote_bitbang_bitbang;
 
+       remote_bitbang_recv_buf_start = 0;
+       remote_bitbang_recv_buf_end = 0;
+
        LOG_INFO("Initializing remote_bitbang driver");
-       if (remote_bitbang_port == NULL)
-               fd = remote_bitbang_init_unix();
+       if (!remote_bitbang_port)
+               remote_bitbang_fd = remote_bitbang_init_unix();
        else
-               fd = remote_bitbang_init_tcp();
-
-       if (fd < 0)
-               return fd;
-
-       remote_bitbang_in = fdopen(fd, "r");
-       if (remote_bitbang_in == NULL) {
-               LOG_ERROR("fdopen: failed to open read stream");
-               close(fd);
-               return ERROR_FAIL;
-       }
+               remote_bitbang_fd = remote_bitbang_init_tcp();
 
-       remote_bitbang_out = fdopen(fd, "w");
-       if (remote_bitbang_out == NULL) {
-               LOG_ERROR("fdopen: failed to open write stream");
-               fclose(remote_bitbang_in);
-               return ERROR_FAIL;
-       }
+       if (remote_bitbang_fd < 0)
+               return remote_bitbang_fd;
 
        LOG_INFO("remote_bitbang driver initialized");
        return ERROR_OK;
@@ -253,9 +340,9 @@ COMMAND_HANDLER(remote_bitbang_handle_remote_bitbang_host_command)
        return ERROR_COMMAND_SYNTAX_ERROR;
 }
 
-static const struct command_registration remote_bitbang_command_handlers[] = {
+static const struct command_registration remote_bitbang_subcommand_handlers[] = {
        {
-               .name = "remote_bitbang_port",
+               .name = "port",
                .handler = remote_bitbang_handle_remote_bitbang_port_command,
                .mode = COMMAND_CONFIG,
                .help = "Set the port to use to connect to the remote jtag.\n"
@@ -263,7 +350,7 @@ static const struct command_registration remote_bitbang_command_handlers[] = {
                .usage = "port_number",
        },
        {
-               .name = "remote_bitbang_host",
+               .name = "host",
                .handler = remote_bitbang_handle_remote_bitbang_host_command,
                .mode = COMMAND_CONFIG,
                .help = "Set the host to use to connect to the remote jtag.\n"
@@ -273,10 +360,44 @@ static const struct command_registration remote_bitbang_command_handlers[] = {
        COMMAND_REGISTRATION_DONE,
 };
 
-struct jtag_interface remote_bitbang_interface = {
+static const struct command_registration remote_bitbang_command_handlers[] = {
+       {
+               .name = "remote_bitbang",
+               .mode = COMMAND_ANY,
+               .help = "perform remote_bitbang management",
+               .chain = remote_bitbang_subcommand_handlers,
+               .usage = "",
+       },
+       COMMAND_REGISTRATION_DONE
+};
+
+static int remote_bitbang_execute_queue(void)
+{
+       /* safety: the send buffer must be empty, no leftover characters from
+        * previous transactions */
+       assert(remote_bitbang_send_buf_used == 0);
+
+       /* process the JTAG command queue */
+       int ret = bitbang_execute_queue();
+       if (ret != ERROR_OK)
+               return ret;
+
+       /* flush not-yet-sent characters, if any */
+       return remote_bitbang_flush();
+}
+
+static struct jtag_interface remote_bitbang_interface = {
+       .execute_queue = &remote_bitbang_execute_queue,
+};
+
+struct adapter_driver remote_bitbang_adapter_driver = {
        .name = "remote_bitbang",
-       .execute_queue = &bitbang_execute_queue,
+       .transports = jtag_only,
        .commands = remote_bitbang_command_handlers,
+
        .init = &remote_bitbang_init,
        .quit = &remote_bitbang_quit,
+       .reset = &remote_bitbang_reset,
+
+       .jtag_ops = &remote_bitbang_interface,
 };

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)