fix leaky file-handle in virtex2 driver
[openocd.git] / src / pld / xilinx_bit.c
index 7911b8dc14ff39e58d08fa9ec4e8982cfa459d00..792b3375b62217e30ce7a5785aeea53019b3b797 100644 (file)
@@ -96,31 +96,37 @@ int xilinx_read_bit_file(struct xilinx_bit_file *bit_file, const char *filename)
        read_count = fread(bit_file->unknown_header, 1, 13, input_file);
        if (read_count != 13) {
                LOG_ERROR("couldn't read unknown_header from file '%s'", filename);
+               fclose(input_file);
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
 
        if (read_section(input_file, 2, 'a', NULL, &bit_file->source_file) != ERROR_OK) {
                xilinx_free_bit_file(bit_file);
+               fclose(input_file);
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
 
        if (read_section(input_file, 2, 'b', NULL, &bit_file->part_name) != ERROR_OK) {
                xilinx_free_bit_file(bit_file);
+               fclose(input_file);
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
 
        if (read_section(input_file, 2, 'c', NULL, &bit_file->date) != ERROR_OK) {
                xilinx_free_bit_file(bit_file);
+               fclose(input_file);
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
 
        if (read_section(input_file, 2, 'd', NULL, &bit_file->time) != ERROR_OK) {
                xilinx_free_bit_file(bit_file);
+               fclose(input_file);
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
 
        if (read_section(input_file, 4, 'e', &bit_file->length, &bit_file->data) != ERROR_OK) {
                xilinx_free_bit_file(bit_file);
+               fclose(input_file);
                return ERROR_PLD_FILE_LOAD_FAILED;
        }
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)