svf: fix memory leak on error during command execution
[openocd.git] / src / svf / svf.c
index 05fb21d631ee13837c4091afa940227a831bc9fd..2a133128045da6aa970443e1b9f02f328bfc71eb 100644 (file)
@@ -473,27 +473,31 @@ COMMAND_HANDLER(handle_svf_command)
                }
 
                /* HDR %d TDI (0) */
-               if (svf_set_padding(&svf_para.hdr_para, header_dr_len, 0) != ERROR_OK) {
-                       LOG_ERROR("failed to set data header");
-                       return ERROR_FAIL;
+               ret = svf_set_padding(&svf_para.hdr_para, header_dr_len, 0);
+               if (ret != ERROR_OK) {
+                       command_print(CMD, "failed to set data header");
+                       goto free_all;
                }
 
                /* HIR %d TDI (0xFF) */
-               if (svf_set_padding(&svf_para.hir_para, header_ir_len, 0xFF) != ERROR_OK) {
-                       LOG_ERROR("failed to set instruction header");
-                       return ERROR_FAIL;
+               ret = svf_set_padding(&svf_para.hir_para, header_ir_len, 0xFF);
+               if (ret != ERROR_OK) {
+                       command_print(CMD, "failed to set instruction header");
+                       goto free_all;
                }
 
                /* TDR %d TDI (0) */
-               if (svf_set_padding(&svf_para.tdr_para, trailer_dr_len, 0) != ERROR_OK) {
-                       LOG_ERROR("failed to set data trailer");
-                       return ERROR_FAIL;
+               ret = svf_set_padding(&svf_para.tdr_para, trailer_dr_len, 0);
+               if (ret != ERROR_OK) {
+                       command_print(CMD, "failed to set data trailer");
+                       goto free_all;
                }
 
                /* TIR %d TDI (0xFF) */
-               if (svf_set_padding(&svf_para.tir_para, trailer_ir_len, 0xFF) != ERROR_OK) {
-                       LOG_ERROR("failed to set instruction trailer");
-                       return ERROR_FAIL;
+               ret = svf_set_padding(&svf_para.tir_para, trailer_ir_len, 0xFF);
+               if (ret != ERROR_OK) {
+                       command_print(CMD, "failed to set instruction trailer");
+                       goto free_all;
                }
        }
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)