/* YUK! - but this is currently a global.... */
extern struct jtag_interface *jtag_interface;
-static int (cmsis_dap_queue_ap_abort)(struct adiv5_dap *dap, uint8_t *ack)
+static int cmsis_dap_clear_sticky_errors(struct adiv5_dap *dap)
{
- LOG_DEBUG("CMSIS-ADI: cmsis_dap_queue_ap_abort");
+ LOG_DEBUG(" ");
- /* FIXME: implement this properly cmsis-dap has DAP_WriteABORT()
- * for now just hack @ everything */
- return jtag_interface->swd->write_reg(
- (CMSIS_CMD_DP | CMSIS_CMD_WRITE | CMSIS_CMD_A32(DP_ABORT)), 0x1e);
+ const struct swd_driver *swd = jtag_interface->swd;
+ assert(swd);
+
+ return swd->write_reg(swd_cmd(false, false, DP_ABORT),
+ STKCMPCLR | STKERRCLR | WDERRCLR | ORUNERRCLR);
}
-static int cmsis_dap_queue_dp_read(struct adiv5_dap *dap, unsigned reg, uint32_t *data)
+static int cmsis_dap_queue_ap_abort(struct adiv5_dap *dap, uint8_t *ack)
{
- LOG_DEBUG("CMSIS-ADI: cmsis_dap_queue_dp_read %d", reg);
-
- int retval = jtag_interface->swd->read_reg(
- (CMSIS_CMD_DP | CMSIS_CMD_READ | CMSIS_CMD_A32(reg)), data);
+ LOG_DEBUG(" ");
- if (retval != ERROR_OK) {
- /* fault response */
- uint8_t ack = retval & 0xff;
- cmsis_dap_queue_ap_abort(dap, &ack);
- }
+ const struct swd_driver *swd = jtag_interface->swd;
+ assert(swd);
- return retval;
+ return swd->write_reg(swd_cmd(false, false, DP_ABORT),
+ DAPABORT | STKCMPCLR | STKERRCLR | WDERRCLR | ORUNERRCLR);
}
-static int cmsis_dap_queue_idcode_read(struct adiv5_dap *dap, uint8_t *ack, uint32_t *data)
+static int cmsis_dap_queue_dp_read(struct adiv5_dap *dap, unsigned reg, uint32_t *data)
{
- LOG_DEBUG("CMSIS-ADI: cmsis_dap_queue_idcode_read");
+ LOG_DEBUG("reg = %d", reg);
- int retval = cmsis_dap_queue_dp_read(dap, DP_IDCODE, data);
- if (retval != ERROR_OK)
- return retval;
+ int retval = jtag_interface->swd->read_reg(
+ (CMSIS_CMD_DP | CMSIS_CMD_READ | CMSIS_CMD_A32(reg)), data);
- *ack = retval;
+ if (retval != ERROR_OK)
+ cmsis_dap_clear_sticky_errors(dap);
- return ERROR_OK;
+ return retval;
}
static int (cmsis_dap_queue_dp_write)(struct adiv5_dap *dap, unsigned reg, uint32_t data)
{
- LOG_DEBUG("CMSIS-ADI: cmsis_dap_queue_dp_write %d 0x%08" PRIx32, reg, data);
+ LOG_DEBUG("reg = %d, data = 0x%08" PRIx32, reg, data);
/* setting the ORUNDETECT bit causes issues for some targets,
* disable until we find out why */
int retval = jtag_interface->swd->write_reg(
(CMSIS_CMD_DP | CMSIS_CMD_WRITE | CMSIS_CMD_A32(reg)), data);
- if (retval != ERROR_OK) {
- /* fault response */
- uint8_t ack = retval & 0xff;
- cmsis_dap_queue_ap_abort(dap, &ack);
- }
+ if (retval != ERROR_OK)
+ cmsis_dap_clear_sticky_errors(dap);
return retval;
}
if (retval != ERROR_OK)
return retval;
- LOG_DEBUG("CMSIS-ADI: cmsis_dap_queue_ap_read %d", reg);
+ LOG_DEBUG("reg = %d", reg);
retval = jtag_interface->swd->read_reg(
(CMSIS_CMD_AP | CMSIS_CMD_READ | CMSIS_CMD_A32(reg)), data);
- if (retval != ERROR_OK) {
- /* fault response */
- uint8_t ack = retval & 0xff;
- cmsis_dap_queue_ap_abort(dap, &ack);
- }
+ if (retval != ERROR_OK)
+ cmsis_dap_clear_sticky_errors(dap);
return retval;
}
if (retval != ERROR_OK)
return retval;
- LOG_DEBUG("CMSIS-ADI: cmsis_dap_queue_ap_write %d 0x%08" PRIx32, reg, data);
+ LOG_DEBUG("reg = %d, data = 0x%08" PRIx32, reg, data);
retval = jtag_interface->swd->write_reg(
(CMSIS_CMD_AP | CMSIS_CMD_WRITE | CMSIS_CMD_A32(reg)), data);
- if (retval != ERROR_OK) {
- /* fault response */
- uint8_t ack = retval & 0xff;
- cmsis_dap_queue_ap_abort(dap, &ack);
- }
-
- return retval;
-}
-
-static int (cmsis_dap_queue_ap_read_block)(struct adiv5_dap *dap, unsigned reg,
- uint32_t blocksize, uint8_t *buffer)
-{
- LOG_DEBUG("CMSIS-ADI: cmsis_dap_queue_ap_read_block 0x%08" PRIx32, blocksize);
-
- int retval = jtag_interface->swd->read_block(
- (CMSIS_CMD_AP | CMSIS_CMD_READ | CMSIS_CMD_A32(AP_REG_DRW)),
- blocksize, buffer);
-
- if (retval != ERROR_OK) {
- /* fault response */
- uint8_t ack = retval & 0xff;
- cmsis_dap_queue_ap_abort(dap, &ack);
- }
+ if (retval != ERROR_OK)
+ cmsis_dap_clear_sticky_errors(dap);
return retval;
}
/** Executes all queued DAP operations. */
static int cmsis_dap_run(struct adiv5_dap *dap)
{
- LOG_DEBUG("CMSIS-ADI: cmsis_dap_run");
+ LOG_DEBUG(" ");
/* FIXME: for now the CMSIS-DAP interface hard-wires a zero-size queue. */
+ int ret;
+ uint32_t ctrlstat;
+
+ /*
+ Some debug dongles do more than asked for(e.g. EDBG from
+ Atmel) behind the scene and issuing an AP write
+ may result in more than just APACC SWD transaction, which in
+ turn can possibly set sticky error bit in CTRL/STAT register
+ of the DP(an example would be writing SYSRESETREQ to AIRCR).
+ Such adapters may interpret CMSIS-DAP secification
+ differently and not guarantee to be report those failures
+ via status byte of the return USB packet from CMSIS-DAP, so
+ we need to check CTRL/STAT and if that happens to clear it.
+ */
+ ret = cmsis_dap_queue_dp_read(dap, DP_CTRL_STAT, &ctrlstat);
+ if (ret != ERROR_OK) {
+ LOG_ERROR("Failed to read CTRL/STAT register");
+ return ret;
+ }
- return ERROR_OK;
+ if (ctrlstat & SSTICKYERR) {
+ LOG_WARNING("SSTICKYERR was set, clearing it");
+ ret = cmsis_dap_clear_sticky_errors(dap);
+ if (ret != ERROR_OK) {
+ LOG_ERROR("Failed to clear sticky errors");
+ return ret;
+ }
+ }
+
+ return ret;
}
const struct dap_ops cmsis_dap_ops = {
.is_swd = true,
- .queue_idcode_read = cmsis_dap_queue_idcode_read,
.queue_dp_read = cmsis_dap_queue_dp_read,
.queue_dp_write = cmsis_dap_queue_dp_write,
.queue_ap_read = cmsis_dap_queue_ap_read,
.queue_ap_write = cmsis_dap_queue_ap_write,
- .queue_ap_read_block = cmsis_dap_queue_ap_read_block,
.queue_ap_abort = cmsis_dap_queue_ap_abort,
.run = cmsis_dap_run,
};
static int cmsis_dap_select(struct command_context *ctx)
{
- LOG_DEBUG("CMSIS-ADI: cmsis_dap_select");
+ LOG_DEBUG(" ");
int retval = register_commands(ctx, NULL, cmsis_dap_handlers);
uint32_t idcode;
int status;
- LOG_DEBUG("CMSIS-ADI: cmsis_dap_init");
+ LOG_DEBUG("CMSIS-ADI init");
/* Force the DAP's ops vector for CMSIS-DAP mode.
* messy - is there a better way? */
}
#endif
- uint8_t ack;
-
- status = cmsis_dap_queue_idcode_read(dap, &ack, &idcode);
+ status = cmsis_dap_queue_dp_read(dap, DP_IDCODE, &idcode);
if (status == ERROR_OK)
LOG_INFO("IDCODE 0x%08" PRIx32, idcode);
/* force clear all sticky faults */
- cmsis_dap_queue_ap_abort(dap, &ack);
+ cmsis_dap_clear_sticky_errors(dap);
/* this is a workaround to get polling working */
jtag_add_reset(0, 0);