target: create/use register_cache_invalidate()

[openocd.git] / src / target / etm.c

diff --git a/src/target/etm.c b/src/target/etm.c
index 3b5fa61f33776741935e65bb982bdd7ce8e222ba..1678c2fb4543db32cc65e5edb539362a9128faf3 100644 (file)
--- a/src/target/etm.c
+++ b/src/target/etm.c
@@ -234,7 +234,7 @@ static const struct reg_arch_type etm_scan6_type = {
 static struct reg *etm_reg_lookup(struct etm_context *etm_ctx, unsigned id)
 {
        struct reg_cache *cache = etm_ctx->reg_cache;
-       int i;
+       unsigned i;
 
        for (i = 0; i < cache->num_regs; i++) {
                struct etm_reg *reg = cache->reg_list[i].arch_info;
@@ -1214,25 +1214,14 @@ static COMMAND_HELPER(handle_etm_tracemode_command_update,
                return ERROR_INVALID_ARGUMENTS;
        }
 
-       if (strcmp(CMD_ARGV[2], "enable") == 0)
+       bool etmv1_cycle_accurate;
+       COMMAND_PARSE_ENABLE(CMD_ARGV[2], etmv1_cycle_accurate);
+       if (etmv1_cycle_accurate)
                tracemode |= ETMV1_CYCLE_ACCURATE;
-       else if (strcmp(CMD_ARGV[2], "disable") == 0)
-               tracemode |= 0;
-       else
-       {
-               command_print(CMD_CTX, "invalid option '%s'", CMD_ARGV[2]);
-               return ERROR_INVALID_ARGUMENTS;
-       }
 
-       if (strcmp(CMD_ARGV[3], "enable") == 0)
+       bool etmv1_branch_output;
+       COMMAND_PARSE_ENABLE(CMD_ARGV[3], etmv1_branch_output);
                tracemode |= ETMV1_BRANCH_OUTPUT;
-       else if (strcmp(CMD_ARGV[3], "disable") == 0)
-               tracemode |= 0;
-       else
-       {
-               command_print(CMD_CTX, "invalid option '%s'", CMD_ARGV[3]);
-               return ERROR_INVALID_ARGUMENTS;
-       }
 
        /* IGNORED:
         *  - CPRT tracing (coprocessor register transfers)