Merge remote branch 'origin/master' into HEAD
[openocd.git] / src / target / mips32_pracc.c
index 34794f3383d156aada8a25e3a27f62fd28818cda..816f35270fb91c38aefb1e01ab55d144fc4b3ca7 100644 (file)
@@ -33,7 +33,6 @@ instruction after a branch instruction (one delay slot).
 
 For example:
 
-
     LW $2, ($5 +10)
     B foo
     LW $1, ($2 +100)
@@ -91,18 +90,36 @@ struct mips32_pracc_context
        struct mips_ejtag *ejtag_info;
 };
 
+static int mips32_pracc_read_mem8(struct mips_ejtag *ejtag_info,
+               uint32_t addr, int count, uint8_t *buf);
+static int mips32_pracc_read_mem16(struct mips_ejtag *ejtag_info,
+               uint32_t addr, int count, uint16_t *buf);
+static int mips32_pracc_read_mem32(struct mips_ejtag *ejtag_info,
+               uint32_t addr, int count, uint32_t *buf);
+static int mips32_pracc_read_u32(struct mips_ejtag *ejtag_info,
+               uint32_t addr, uint32_t *buf);
+
+static int mips32_pracc_write_mem8(struct mips_ejtag *ejtag_info,
+               uint32_t addr, int count, uint8_t *buf);
+static int mips32_pracc_write_mem16(struct mips_ejtag *ejtag_info,
+               uint32_t addr, int count, uint16_t *buf);
+static int mips32_pracc_write_mem32(struct mips_ejtag *ejtag_info,
+               uint32_t addr, int count, uint32_t *buf);
+static int mips32_pracc_write_u32(struct mips_ejtag *ejtag_info,
+               uint32_t addr, uint32_t *buf);
+
 static int wait_for_pracc_rw(struct mips_ejtag *ejtag_info, uint32_t *ctrl)
 {
        uint32_t ejtag_ctrl;
 
        while (1)
        {
-               mips_ejtag_set_instr(ejtag_info, EJTAG_INST_CONTROL, NULL);
+               mips_ejtag_set_instr(ejtag_info, EJTAG_INST_CONTROL);
                ejtag_ctrl = ejtag_info->ejtag_ctrl;
                mips_ejtag_drscan_32(ejtag_info, &ejtag_ctrl);
                if (ejtag_ctrl & EJTAG_CTRL_PRACC)
                        break;
-               LOG_DEBUG("DEBUGMODULE: No memory access in progress!\n");
+               LOG_DEBUG("DEBUGMODULE: No memory access in progress!");
                return ERROR_JTAG_DEVICE_ERROR;
        }
 
@@ -129,7 +146,7 @@ static int mips32_pracc_exec_read(struct mips32_pracc_context *ctx, uint32_t add
                data = ctx->local_oparam[offset];
        }
        else if ((address >= MIPS32_PRACC_TEXT)
-               && (address <= MIPS32_PRACC_TEXT + ctx->code_len*4))
+               && (address <= MIPS32_PRACC_TEXT + ctx->code_len * 4))
        {
                offset = (address - MIPS32_PRACC_TEXT) / 4;
                data = ctx->code[offset];
@@ -145,24 +162,21 @@ static int mips32_pracc_exec_read(struct mips32_pracc_context *ctx, uint32_t add
                 * to start of debug vector */
 
                data = 0;
-               LOG_ERROR("Error reading unexpected address %8.8" PRIx32 "", address);
+               LOG_ERROR("Error reading unexpected address 0x%8.8" PRIx32 "", address);
                return ERROR_JTAG_DEVICE_ERROR;
        }
 
        /* Send the data out */
-       mips_ejtag_set_instr(ctx->ejtag_info, EJTAG_INST_DATA, NULL);
+       mips_ejtag_set_instr(ctx->ejtag_info, EJTAG_INST_DATA);
        mips_ejtag_drscan_32(ctx->ejtag_info, &data);
 
        /* Clear the access pending bit (let the processor eat!) */
-
        ejtag_ctrl = ejtag_info->ejtag_ctrl & ~EJTAG_CTRL_PRACC;
-       mips_ejtag_set_instr(ctx->ejtag_info, EJTAG_INST_CONTROL, NULL);
+       mips_ejtag_set_instr(ctx->ejtag_info, EJTAG_INST_CONTROL);
        mips_ejtag_drscan_32(ctx->ejtag_info, &ejtag_ctrl);
 
        jtag_add_clocks(5);
-       jtag_execute_queue();
-
-       return ERROR_OK;
+       return jtag_execute_queue();
 }
 
 static int mips32_pracc_exec_write(struct mips32_pracc_context *ctx, uint32_t address)
@@ -171,16 +185,19 @@ static int mips32_pracc_exec_write(struct mips32_pracc_context *ctx, uint32_t ad
        int offset;
        struct mips_ejtag *ejtag_info = ctx->ejtag_info;
 
-       mips_ejtag_set_instr(ctx->ejtag_info, EJTAG_INST_DATA, NULL);
+       mips_ejtag_set_instr(ctx->ejtag_info, EJTAG_INST_DATA);
        mips_ejtag_drscan_32(ctx->ejtag_info, &data);
 
        /* Clear access pending bit */
        ejtag_ctrl = ejtag_info->ejtag_ctrl & ~EJTAG_CTRL_PRACC;
-       mips_ejtag_set_instr(ctx->ejtag_info, EJTAG_INST_CONTROL, NULL);
+       mips_ejtag_set_instr(ctx->ejtag_info, EJTAG_INST_CONTROL);
        mips_ejtag_drscan_32(ctx->ejtag_info, &ejtag_ctrl);
 
        jtag_add_clocks(5);
-       jtag_execute_queue();
+       int retval;
+       retval = jtag_execute_queue();
+       if (retval != ERROR_OK)
+               return retval;
 
        if ((address >= MIPS32_PRACC_PARAM_IN)
                && (address <= MIPS32_PRACC_PARAM_IN + ctx->num_iparam * 4))
@@ -201,14 +218,15 @@ static int mips32_pracc_exec_write(struct mips32_pracc_context *ctx, uint32_t ad
        }
        else
        {
-               LOG_ERROR("Error writing unexpected address %8.8" PRIx32 "", address);
+               LOG_ERROR("Error writing unexpected address 0x%8.8" PRIx32 "", address);
                return ERROR_JTAG_DEVICE_ERROR;
        }
 
        return ERROR_OK;
 }
 
-int mips32_pracc_exec(struct mips_ejtag *ejtag_info, int code_len, const uint32_t *code, int num_param_in, uint32_t *param_in, int num_param_out, uint32_t *param_out, int cycle)
+int mips32_pracc_exec(struct mips_ejtag *ejtag_info, int code_len, const uint32_t *code,
+               int num_param_in, uint32_t *param_in, int num_param_out, uint32_t *param_out, int cycle)
 {
        uint32_t ejtag_ctrl;
        uint32_t address, data;
@@ -231,11 +249,9 @@ int mips32_pracc_exec(struct mips_ejtag *ejtag_info, int code_len, const uint32_
                        return retval;
 
                address = data = 0;
-               mips_ejtag_set_instr(ejtag_info, EJTAG_INST_ADDRESS, NULL);
+               mips_ejtag_set_instr(ejtag_info, EJTAG_INST_ADDRESS);
                mips_ejtag_drscan_32(ejtag_info, &address);
 
-//             printf("Adres: %.8x\n", address);
-
                /* Check for read or write */
                if (ejtag_ctrl & EJTAG_CTRL_PRNW)
                {
@@ -287,48 +303,44 @@ int mips32_pracc_read_mem(struct mips_ejtag *ejtag_info, uint32_t addr, int size
        return ERROR_OK;
 }
 
-int mips32_pracc_read_mem32(struct mips_ejtag *ejtag_info, uint32_t addr, int count, uint32_t *buf)
+static int mips32_pracc_read_mem32(struct mips_ejtag *ejtag_info, uint32_t addr, int count, uint32_t *buf)
 {
        static const uint32_t code[] = {
                                                                                                                        /* start: */
                MIPS32_MTC0(15,31,0),                                                           /* move $15 to COP0 DeSave */
-               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),             /* $15 = MIPS32_PRACC_STACK */
+               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),                     /* $15 = MIPS32_PRACC_STACK */
                MIPS32_ORI(15,15,LOWER16(MIPS32_PRACC_STACK)),
-               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
-               MIPS32_SW(9,0,15),                                                                      /* sw $9,($15) */
-               MIPS32_SW(10,0,15),                                                             /* sw $10,($15) */
-               MIPS32_SW(11,0,15),                                                             /* sw $11,($15) */
+               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
+               MIPS32_SW(9,0,15),                                                                      /* sw $9,($15) */
+               MIPS32_SW(10,0,15),                                                                     /* sw $10,($15) */
+               MIPS32_SW(11,0,15),                                                                     /* sw $11,($15) */
 
                MIPS32_LUI(8,UPPER16(MIPS32_PRACC_PARAM_IN)),           /* $8 = MIPS32_PRACC_PARAM_IN */
                MIPS32_ORI(8,8,LOWER16(MIPS32_PRACC_PARAM_IN)),
                MIPS32_LW(9,0,8),                                                                       /* $9 = mem[$8]; read addr */
                MIPS32_LW(10,4,8),                                                                      /* $10 = mem[$8 + 4]; read count */
-               MIPS32_LUI(11,UPPER16(MIPS32_PRACC_PARAM_OUT)),         /* $11 = MIPS32_PRACC_PARAM_OUT */
+               MIPS32_LUI(11,UPPER16(MIPS32_PRACC_PARAM_OUT)),         /* $11 = MIPS32_PRACC_PARAM_OUT */
                MIPS32_ORI(11,11,LOWER16(MIPS32_PRACC_PARAM_OUT)),
-               MIPS32_NOP,
                                                                                                                        /* loop: */
-               MIPS32_BEQ(0,10,9),                                                                     /* beq 0, $10, end */
+               MIPS32_BEQ(0,10,8),                                                                     /* beq 0, $10, end */
                MIPS32_NOP,
 
-               MIPS32_LW(8,0,9),                                                                       /* lw $8,0($9), Load $8 with the word @mem[$9] */
-               MIPS32_SW(8,0,11),                                                                      /* sw $8,0($11) */
+               MIPS32_LW(8,0,9),                                                                       /* lw $8,0($9), Load $8 with the word @mem[$9] */
+               MIPS32_SW(8,0,11),                                                                      /* sw $8,0($11) */
 
-               MIPS32_ADDI(10,10,NEG16(1)),                                            /* $10-- */
-               MIPS32_ADDI(9,9,4),                                                             /* $1 += 4 */
-               MIPS32_ADDI(11,11,4),                                                           /* $11 += 4 */
+               MIPS32_ADDI(10,10,NEG16(1)),                                            /* $10-- */
+               MIPS32_ADDI(9,9,4),                                                                     /* $1 += 4 */
+               MIPS32_ADDI(11,11,4),                                                           /* $11 += 4 */
 
-               MIPS32_NOP,
-               MIPS32_B(NEG16(9)),                                                                     /* b loop */
+               MIPS32_B(NEG16(8)),                                                                     /* b loop */
                MIPS32_NOP,
                                                                                                                        /* end: */
-               MIPS32_LW(11,0,15),                                                             /* lw $11,($15) */
-               MIPS32_LW(10,0,15),                                                             /* lw $10,($15) */
-               MIPS32_LW(9,0,15),                                                                      /* lw $9,($15) */
-               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
+               MIPS32_LW(11,0,15),                                                                     /* lw $11,($15) */
+               MIPS32_LW(10,0,15),                                                                     /* lw $10,($15) */
+               MIPS32_LW(9,0,15),                                                                      /* lw $9,($15) */
+               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
+               MIPS32_B(NEG16(27)),                                                            /* b start */
                MIPS32_MFC0(15,31,0),                                                           /* move COP0 DeSave to $15 */
-               MIPS32_NOP,
-               MIPS32_B(NEG16(31)),                                                            /* b start */
-               MIPS32_NOP,
        };
 
        int retval = ERROR_OK;
@@ -361,24 +373,23 @@ int mips32_pracc_read_mem32(struct mips_ejtag *ejtag_info, uint32_t addr, int co
        return retval;
 }
 
-int mips32_pracc_read_u32(struct mips_ejtag *ejtag_info, uint32_t addr, uint32_t *buf)
+static int mips32_pracc_read_u32(struct mips_ejtag *ejtag_info, uint32_t addr, uint32_t *buf)
 {
        static const uint32_t code[] = {
                                                                                                                        /* start: */
                MIPS32_MTC0(15,31,0),                                                           /* move $15 to COP0 DeSave */
-               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),             /* $15 = MIPS32_PRACC_STACK */
+               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),                     /* $15 = MIPS32_PRACC_STACK */
                MIPS32_ORI(15,15,LOWER16(MIPS32_PRACC_STACK)),
-               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
+               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
 
-               MIPS32_LW(8,NEG16(MIPS32_PRACC_STACK-MIPS32_PRACC_PARAM_IN), 15),  //load R8 @ param_in[0] = address
+               MIPS32_LW(8,NEG16(MIPS32_PRACC_STACK-MIPS32_PRACC_PARAM_IN),15), /* load R8 @ param_in[0] = address */
 
-               MIPS32_LW(8,0,8),                                                                       /* lw $8,0($8), Load $8 with the word @mem[$8] */
-               MIPS32_SW(8,NEG16(MIPS32_PRACC_STACK-MIPS32_PRACC_PARAM_OUT),15),                                                                       /* sw $8,0($9) */
+               MIPS32_LW(8,0,8),                                                                       /* lw $8,0($8), Load $8 with the word @mem[$8] */
+               MIPS32_SW(8,NEG16(MIPS32_PRACC_STACK-MIPS32_PRACC_PARAM_OUT),15), /* store R8 @ param_out[0] */
 
-               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
-               MIPS32_B(NEG16(9)),     //was 17                                                        /* b start */
-               MIPS32_MFC0(15,31,0),   //this instruction will be executed (MIPS executes instruction after jump)                                                      /* move COP0 DeSave to $15 */
-               MIPS32_NOP,
+               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
+               MIPS32_B(NEG16(9)),                                                                     /* b start */
+               MIPS32_MFC0(15,31,0),                                                           /* move COP0 DeSave to $15 */
        };
 
        int retval = ERROR_OK;
@@ -387,7 +398,7 @@ int mips32_pracc_read_u32(struct mips_ejtag *ejtag_info, uint32_t addr, uint32_t
        param_in[0] = addr;
 
        if ((retval = mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code,
-               ARRAY_SIZE(param_in), param_in, sizeof(uint32_t), buf, 1)) != ERROR_OK)
+               ARRAY_SIZE(param_in), param_in, 1, buf, 1)) != ERROR_OK)
        {
                return retval;
        }
@@ -395,17 +406,17 @@ int mips32_pracc_read_u32(struct mips_ejtag *ejtag_info, uint32_t addr, uint32_t
        return retval;
 }
 
-int mips32_pracc_read_mem16(struct mips_ejtag *ejtag_info, uint32_t addr, int count, uint16_t *buf)
+static int mips32_pracc_read_mem16(struct mips_ejtag *ejtag_info, uint32_t addr, int count, uint16_t *buf)
 {
        static const uint32_t code[] = {
                                                                                                                        /* start: */
                MIPS32_MTC0(15,31,0),                                                           /* move $15 to COP0 DeSave */
-               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),             /* $15 = MIPS32_PRACC_STACK */
+               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),                     /* $15 = MIPS32_PRACC_STACK */
                MIPS32_ORI(15,15,LOWER16(MIPS32_PRACC_STACK)),
-               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
-               MIPS32_SW(9,0,15),                                                                      /* sw $9,($15) */
-               MIPS32_SW(10,0,15),                                                             /* sw $10,($15) */
-               MIPS32_SW(11,0,15),                                                             /* sw $11,($15) */
+               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
+               MIPS32_SW(9,0,15),                                                                      /* sw $9,($15) */
+               MIPS32_SW(10,0,15),                                                                     /* sw $10,($15) */
+               MIPS32_SW(11,0,15),                                                                     /* sw $11,($15) */
 
                MIPS32_LUI(8,UPPER16(MIPS32_PRACC_PARAM_IN)),           /* $8 = MIPS32_PRACC_PARAM_IN */
                MIPS32_ORI(8,8,LOWER16(MIPS32_PRACC_PARAM_IN)),
@@ -413,36 +424,32 @@ int mips32_pracc_read_mem16(struct mips_ejtag *ejtag_info, uint32_t addr, int co
                MIPS32_LW(10,4,8),                                                                      /* $10 = mem[$8 + 4]; read count */
                MIPS32_LUI(11,UPPER16(MIPS32_PRACC_PARAM_OUT)),         /* $11 = MIPS32_PRACC_PARAM_OUT */
                MIPS32_ORI(11,11,LOWER16(MIPS32_PRACC_PARAM_OUT)),
-               MIPS32_NOP,
                                                                                                                        /* loop: */
-               MIPS32_BEQ(0,10,9),                                                             /* beq 0, $10, end */
+               MIPS32_BEQ(0,10,8),                                                                     /* beq 0, $10, end */
                MIPS32_NOP,
 
-               MIPS32_LHU(8,0,9),                                                                      /* lw $8,0($9), Load $8 with the halfword @mem[$9] */
-               MIPS32_SW(8,0,11),                                                                      /* sw $8,0($11) */
-
-               MIPS32_ADDI(10,10,NEG16(1)),                                            /* $10-- */
-               MIPS32_ADDI(9,9,2),                                                             /* $9 += 2 */
-               MIPS32_ADDI(11,11,4),                                                           /* $11 += 4 */
-               MIPS32_NOP,
-               MIPS32_B(NEG16(9)),                                                                     /* b loop */
-               MIPS32_NOP,
+               MIPS32_LHU(8,0,9),                                                                      /* lw $8,0($9), Load $8 with the halfword @mem[$9] */
+               MIPS32_SW(8,0,11),                                                                      /* sw $8,0($11) */
 
-               MIPS32_LW(11,0,15),                                                             /* lw $11,($15) */
-               MIPS32_LW(10,0,15),                                                             /* lw $10,($15) */
-               MIPS32_LW(9,0,15),                                                                      /* lw $9,($15) */
-               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
-               MIPS32_MFC0(15,31,0),                                                           /* move COP0 DeSave to $15 */
-               MIPS32_NOP,
-               MIPS32_B(NEG16(31)),                                                            /* b start */
+               MIPS32_ADDI(10,10,NEG16(1)),                                            /* $10-- */
+               MIPS32_ADDI(9,9,2),                                                                     /* $9 += 2 */
+               MIPS32_ADDI(11,11,4),                                                           /* $11 += 4 */
+               MIPS32_B(NEG16(8)),                                                                     /* b loop */
                MIPS32_NOP,
+                                                                                                                       /* end: */
+               MIPS32_LW(11,0,15),                                                                     /* lw $11,($15) */
+               MIPS32_LW(10,0,15),                                                                     /* lw $10,($15) */
+               MIPS32_LW(9,0,15),                                                                      /* lw $9,($15) */
+               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
+               MIPS32_B(NEG16(27)),                                                            /* b start */
+               MIPS32_MFC0(15,30,0),                                                           /* move COP0 DeSave to $15 */
        };
 
-//     /* TODO remove array */
+       /* TODO remove array */
        uint32_t *param_out = malloc(count * sizeof(uint32_t));
        int i;
 
-//     int retval;
+       int retval = ERROR_OK;
        int blocksize;
        int bytesread;
        uint32_t param_in[2];
@@ -458,7 +465,7 @@ int mips32_pracc_read_mem16(struct mips_ejtag *ejtag_info, uint32_t addr, int co
                param_in[0] = addr;
                param_in[1] = blocksize;
 
-               mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code, \
+               retval = mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code,
                        ARRAY_SIZE(param_in), param_in, count, param_out, 1);
 
 //             count -= blocksize;
@@ -473,57 +480,53 @@ int mips32_pracc_read_mem16(struct mips_ejtag *ejtag_info, uint32_t addr, int co
 
        free(param_out);
 
-       return ERROR_OK;
+       return retval;
 }
 
-int mips32_pracc_read_mem8(struct mips_ejtag *ejtag_info, uint32_t addr, int count, uint8_t *buf)
+static int mips32_pracc_read_mem8(struct mips_ejtag *ejtag_info, uint32_t addr, int count, uint8_t *buf)
 {
        static const uint32_t code[] = {
                                                                                                                        /* start: */
                MIPS32_MTC0(15,31,0),                                                           /* move $15 to COP0 DeSave */
-               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),             /* $15 = MIPS32_PRACC_STACK */
+               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),                     /* $15 = MIPS32_PRACC_STACK */
                MIPS32_ORI(15,15,LOWER16(MIPS32_PRACC_STACK)),
-               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
-               MIPS32_SW(9,0,15),                                                                      /* sw $9,($15) */
-               MIPS32_SW(10,0,15),                                                             /* sw $10,($15) */
-               MIPS32_SW(11,0,15),                                                             /* sw $11,($15) */
+               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
+               MIPS32_SW(9,0,15),                                                                      /* sw $9,($15) */
+               MIPS32_SW(10,0,15),                                                                     /* sw $10,($15) */
+               MIPS32_SW(11,0,15),                                                                     /* sw $11,($15) */
 
-               MIPS32_LUI(8,UPPER16(MIPS32_PRACC_PARAM_IN)),           /* $8 = MIPS32_PRACC_PARAM_IN */
+               MIPS32_LUI(8,UPPER16(MIPS32_PRACC_PARAM_IN)),           /* $8 = MIPS32_PRACC_PARAM_IN */
                MIPS32_ORI(8,8,LOWER16(MIPS32_PRACC_PARAM_IN)),
-               MIPS32_LW(9,0,8),                                                                       /* $9 = mem[$8]; read addr */
-               MIPS32_LW(10,4,8),                                                                      /* $10 = mem[$8 + 4]; read count */
-               MIPS32_LUI(11,UPPER16(MIPS32_PRACC_PARAM_OUT)),         /* $11 = MIPS32_PRACC_PARAM_OUT */
+               MIPS32_LW(9,0,8),                                                                       /* $9 = mem[$8]; read addr */
+               MIPS32_LW(10,4,8),                                                                      /* $10 = mem[$8 + 4]; read count */
+               MIPS32_LUI(11,UPPER16(MIPS32_PRACC_PARAM_OUT)),         /* $11 = MIPS32_PRACC_PARAM_OUT */
                MIPS32_ORI(11,11,LOWER16(MIPS32_PRACC_PARAM_OUT)),
-               MIPS32_NOP,
                                                                                                                        /* loop: */
-               MIPS32_BEQ(0,10,9),                                                             /* beq 0, $10, end */
+               MIPS32_BEQ(0,10,8),                                                                     /* beq 0, $10, end */
                MIPS32_NOP,
 
-               MIPS32_LBU(8,0,9),                                                                      /* lw $8,0($9), Load t4 with the byte @mem[t1] */
-               MIPS32_SW(8,0,11),                                                                      /* sw $8,0($11) */
+               MIPS32_LBU(8,0,9),                                                                      /* lw $8,0($9), Load t4 with the byte @mem[t1] */
+               MIPS32_SW(8,0,11),                                                                      /* sw $8,0($11) */
 
-               MIPS32_ADDI(10,10,NEG16(1)),                                            /* $10-- */
-               MIPS32_ADDI(9,9,1),                                                             /* $9 += 1 */
-               MIPS32_ADDI(11,11,4),                                                           /* $11 += 4 */
-               MIPS32_NOP,
-               MIPS32_B(NEG16(9)),                                                                     /* b loop */
+               MIPS32_ADDI(10,10,NEG16(1)),                                            /* $10-- */
+               MIPS32_ADDI(9,9,1),                                                                     /* $9 += 1 */
+               MIPS32_ADDI(11,11,4),                                                           /* $11 += 4 */
+               MIPS32_B(NEG16(8)),                                                                     /* b loop */
                MIPS32_NOP,
                                                                                                                        /* end: */
-               MIPS32_LW(11,0,15),                                                             /* lw $11,($15) */
-               MIPS32_LW(10,0,15),                                                             /* lw $10,($15) */
-               MIPS32_LW(9,0,15),                                                                      /* lw $9,($15) */
-               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
+               MIPS32_LW(11,0,15),                                                                     /* lw $11,($15) */
+               MIPS32_LW(10,0,15),                                                                     /* lw $10,($15) */
+               MIPS32_LW(9,0,15),                                                                      /* lw $9,($15) */
+               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
+               MIPS32_B(NEG16(27)),                                                            /* b start */
                MIPS32_MFC0(15,31,0),                                                           /* move COP0 DeSave to $15 */
-               MIPS32_NOP,
-               MIPS32_B(NEG16(31)),                                                            /* b start */
-               MIPS32_NOP,
        };
 
-//     /* TODO remove array */
+       /* TODO remove array */
        uint32_t *param_out = malloc(count * sizeof(uint32_t));
        int i;
 
-//     int retval;
+       int retval = ERROR_OK;
        int blocksize;
        int bytesread;
        uint32_t param_in[2];
@@ -539,7 +542,7 @@ int mips32_pracc_read_mem8(struct mips_ejtag *ejtag_info, uint32_t addr, int cou
                param_in[0] = addr;
                param_in[1] = blocksize;
 
-               mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code, \
+               retval = mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code,
                        ARRAY_SIZE(param_in), param_in, count, param_out, 1);
 
 //             count -= blocksize;
@@ -554,7 +557,7 @@ int mips32_pracc_read_mem8(struct mips_ejtag *ejtag_info, uint32_t addr, int cou
 
        free(param_out);
 
-       return ERROR_OK;
+       return retval;
 }
 
 int mips32_pracc_write_mem(struct mips_ejtag *ejtag_info, uint32_t addr, int size, int count, void *buf)
@@ -575,77 +578,75 @@ int mips32_pracc_write_mem(struct mips_ejtag *ejtag_info, uint32_t addr, int siz
        return ERROR_OK;
 }
 
-int mips32_pracc_write_mem32(struct mips_ejtag *ejtag_info, uint32_t addr, int count, uint32_t *buf)
+static int mips32_pracc_write_mem32(struct mips_ejtag *ejtag_info, uint32_t addr, int count, uint32_t *buf)
 {
-
-//NC: use destination pointer as loop counter (last address is in $10)
        static const uint32_t code[] = {
                                                                                                                        /* start: */
                MIPS32_MTC0(15,31,0),                                                           /* move $15 to COP0 DeSave */
-               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),             /* $15 = MIPS32_PRACC_STACK */
+               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),                     /* $15 = MIPS32_PRACC_STACK */
                MIPS32_ORI(15,15,LOWER16(MIPS32_PRACC_STACK)),
-               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
-               MIPS32_SW(9,0,15),                                                                      /* sw $9,($15) */
-               MIPS32_SW(10,0,15),                                                             /* sw $10,($15) */
-               MIPS32_SW(11,0,15),                                                             /* sw $11,($15) */
-
-               MIPS32_ADDI(8,15,NEG16(MIPS32_PRACC_STACK-MIPS32_PRACC_PARAM_IN)),  //$8= MIPS32_PRACC_PARAM_IN
-               MIPS32_LW(9,0,8),                                                                       /* Load write addr to $9 */
-               MIPS32_LW(10,4,8),      //last address                                                                  /* Load write count to $10 */
-               MIPS32_ADDI(8,8,8),     // $8 += 8 beginning of data
-
-//loop:
-               MIPS32_LW(11,0,8),                                                                      /* lw $11,0($8), Load $11 with the word @mem[$8] */
-               MIPS32_SW(11,0,9),                                                                      /* sw $11,0($9) */
-
-               MIPS32_ADDI(9,9,4),                                                             /* $9 += 4 */
-               MIPS32_BNE(10,9,NEG16(4)),  //was 9 BNE $10, 9, loop                                                                    /* b loop */
-               MIPS32_ADDI(8,8,4),  //this instruction is part of the loop (one delay slot)!   /* $8 += 4 */
+               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
+               MIPS32_SW(9,0,15),                                                                      /* sw $9,($15) */
+               MIPS32_SW(10,0,15),                                                                     /* sw $10,($15) */
+               MIPS32_SW(11,0,15),                                                                     /* sw $11,($15) */
+
+               MIPS32_ADDI(8,15,NEG16(MIPS32_PRACC_STACK-MIPS32_PRACC_PARAM_IN)),  /* $8= MIPS32_PRACC_PARAM_IN */
+               MIPS32_LW(9,0,8),                                                                       /* Load write addr to $9 */
+               MIPS32_LW(10,4,8),                                                                      /* Load write count to $10 */
+               MIPS32_ADDI(8,8,8),                                                                     /* $8 += 8 beginning of data */
+
+                                                                                                                       /* loop: */
+               MIPS32_LW(11,0,8),                                                                      /* lw $11,0($8), Load $11 with the word @mem[$8] */
+               MIPS32_SW(11,0,9),                                                                      /* sw $11,0($9) */
+
+               MIPS32_ADDI(9,9,4),                                                                     /* $9 += 4 */
+               MIPS32_BNE(10,9,NEG16(4)),                                                      /* bne $10, $9, loop */
+               MIPS32_ADDI(8,8,4),                                                                     /* $8 += 4 */
+
                                                                                                                        /* end: */
-               MIPS32_LW(11,0,15),                                                             /* lw $11,($15) */
-               MIPS32_LW(10,0,15),                                                             /* lw $10,($15) */
-               MIPS32_LW(9,0,15),                                                                      /* lw $9,($15) */
-               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
-               MIPS32_B(NEG16(21)),     //was 30                                                       /* b start */
+               MIPS32_LW(11,0,15),                                                                     /* lw $11,($15) */
+               MIPS32_LW(10,0,15),                                                                     /* lw $10,($15) */
+               MIPS32_LW(9,0,15),                                                                      /* lw $9,($15) */
+               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
+               MIPS32_B(NEG16(21)),                                                            /* b start */
                MIPS32_MFC0(15,31,0),                                                           /* move COP0 DeSave to $15 */
-               MIPS32_NOP, //this one will not be executed
        };
 
        /* TODO remove array */
        uint32_t *param_in = malloc((count + 2) * sizeof(uint32_t));
        param_in[0] = addr;
-       param_in[1] = addr + count * sizeof(uint32_t);  //last address
+       param_in[1] = addr + (count * sizeof(uint32_t));        /* last address */
 
        memcpy(&param_in[2], buf, count * sizeof(uint32_t));
 
-       mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code, \
+       int retval;
+       retval = mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code,
                count + 2, param_in, 0, NULL, 1);
 
        free(param_in);
 
-       return ERROR_OK;
+       return retval;
 }
 
-int mips32_pracc_write_u32(struct mips_ejtag *ejtag_info, uint32_t addr, uint32_t *buf)
+static int mips32_pracc_write_u32(struct mips_ejtag *ejtag_info, uint32_t addr, uint32_t *buf)
 {
        static const uint32_t code[] = {
                                                                                                                        /* start: */
                MIPS32_MTC0(15,31,0),                                                           /* move $15 to COP0 DeSave */
-               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),             /* $15 = MIPS32_PRACC_STACK */
+               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),                     /* $15 = MIPS32_PRACC_STACK */
                MIPS32_ORI(15,15,LOWER16(MIPS32_PRACC_STACK)),
-               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
-               MIPS32_SW(9,0,15),                                                                      /* sw $9,($15) */
+               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
+               MIPS32_SW(9,0,15),                                                                      /* sw $9,($15) */
 
-               MIPS32_LW(8,NEG16((MIPS32_PRACC_STACK-MIPS32_PRACC_PARAM_IN)-4), 15),  //load R8 @ param_in[1] = data
-               MIPS32_LW(9,NEG16(MIPS32_PRACC_STACK-MIPS32_PRACC_PARAM_IN), 15),  //load R9 @ param_in[0] = address
+               MIPS32_LW(8,NEG16((MIPS32_PRACC_STACK-MIPS32_PRACC_PARAM_IN)-4), 15),   /* load R8 @ param_in[1] = data */
+               MIPS32_LW(9,NEG16(MIPS32_PRACC_STACK-MIPS32_PRACC_PARAM_IN), 15),               /* load R9 @ param_in[0] = address */
 
-               MIPS32_SW(8,0,9),                                                                       /* sw $8,0($9) */
+               MIPS32_SW(8,0,9),                                                                       /* sw $8,0($9) */
 
-               MIPS32_LW(9,0,15),                                                                      /* lw $9,($15) */
-               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
+               MIPS32_LW(9,0,15),                                                                      /* lw $9,($15) */
+               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
                MIPS32_B(NEG16(11)),                                                            /* b start */
-               MIPS32_MFC0(15,31,0),                                                   /* move COP0 DeSave to $15 */
-               MIPS32_NOP,
+               MIPS32_MFC0(15,31,0),                                                           /* move COP0 DeSave to $15 */
        };
 
        /* TODO remove array */
@@ -653,53 +654,47 @@ int mips32_pracc_write_u32(struct mips_ejtag *ejtag_info, uint32_t addr, uint32_
        param_in[0] = addr;
        param_in[1] = *buf;
 
-       mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code, \
-               ARRAY_SIZE(param_in),param_in, 0, NULL, 1);
-
-       return ERROR_OK;
+       return mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code,
+               ARRAY_SIZE(param_in), param_in, 0, NULL, 1);
 }
 
-int mips32_pracc_write_mem16(struct mips_ejtag *ejtag_info, uint32_t addr, int count, uint16_t *buf)
+static int mips32_pracc_write_mem16(struct mips_ejtag *ejtag_info, uint32_t addr, int count, uint16_t *buf)
 {
        static const uint32_t code[] = {
                                                                                                                        /* start: */
                MIPS32_MTC0(15,31,0),                                                           /* move $15 to COP0 DeSave */
-               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),             /* $15 = MIPS32_PRACC_STACK */
+               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),                     /* $15 = MIPS32_PRACC_STACK */
                MIPS32_ORI(15,15,LOWER16(MIPS32_PRACC_STACK)),
-               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
-               MIPS32_SW(9,0,15),                                                                      /* sw $9,($15) */
-               MIPS32_SW(10,0,15),                                                             /* sw $10,($15) */
-               MIPS32_SW(11,0,15),                                                             /* sw $11,($15) */
+               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
+               MIPS32_SW(9,0,15),                                                                      /* sw $9,($15) */
+               MIPS32_SW(10,0,15),                                                                     /* sw $10,($15) */
+               MIPS32_SW(11,0,15),                                                                     /* sw $11,($15) */
 
-               MIPS32_LUI(8,UPPER16(MIPS32_PRACC_PARAM_IN)),           /* $8 = MIPS32_PRACC_PARAM_IN */
+               MIPS32_LUI(8,UPPER16(MIPS32_PRACC_PARAM_IN)),           /* $8 = MIPS32_PRACC_PARAM_IN */
                MIPS32_ORI(8,8,LOWER16(MIPS32_PRACC_PARAM_IN)),
-               MIPS32_LW(9,0,8),                                                                       /* Load write addr to $9 */
-               MIPS32_LW(10,4,8),                                                                      /* Load write count to $10 */
-               MIPS32_ADDI(8,8,8),                                                             /* $8 += 8 */
-               MIPS32_NOP,
+               MIPS32_LW(9,0,8),                                                                       /* Load write addr to $9 */
+               MIPS32_LW(10,4,8),                                                                      /* Load write count to $10 */
+               MIPS32_ADDI(8,8,8),                                                                     /* $8 += 8 */
                                                                                                                        /* loop: */
-               MIPS32_BEQ(0,10,9),                                                                     /* beq $0, $10, end */
+               MIPS32_BEQ(0,10,8),                                                                     /* beq $0, $10, end */
                MIPS32_NOP,
 
-               MIPS32_LW(11,0,8),                                                                      /* lw $11,0($8), Load $11 with the word @mem[$8] */
-               MIPS32_SH(11,0,9),                                                                      /* sh $11,0($9) */
+               MIPS32_LW(11,0,8),                                                                      /* lw $11,0($8), Load $11 with the word @mem[$8] */
+               MIPS32_SH(11,0,9),                                                                      /* sh $11,0($9) */
 
-               MIPS32_ADDI(10,10,NEG16(1)),                                            /* $10-- */
-               MIPS32_ADDI(9,9,2),                                                             /* $9 += 2 */
-               MIPS32_ADDI(8,8,4),                                                             /* $8 += 4 */
+               MIPS32_ADDI(10,10,NEG16(1)),                                            /* $10-- */
+               MIPS32_ADDI(9,9,2),                                                                     /* $9 += 2 */
+               MIPS32_ADDI(8,8,4),                                                                     /* $8 += 4 */
 
-               MIPS32_NOP,
-               MIPS32_B(NEG16(9)),                                                                     /* b loop */
+               MIPS32_B(NEG16(8)),                                                                     /* b loop */
                MIPS32_NOP,
                                                                                                                        /* end: */
-               MIPS32_LW(11,0,15),                                                             /* lw $11,($15) */
-               MIPS32_LW(10,0,15),                                                             /* lw $10,($15) */
-               MIPS32_LW(9,0,15),                                                                      /* lw $9,($15) */
-               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
+               MIPS32_LW(11,0,15),                                                                     /* lw $11,($15) */
+               MIPS32_LW(10,0,15),                                                                     /* lw $10,($15) */
+               MIPS32_LW(9,0,15),                                                                      /* lw $9,($15) */
+               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
+               MIPS32_B(NEG16(26)),                                                            /* b start */
                MIPS32_MFC0(15,31,0),                                                           /* move COP0 DeSave to $15 */
-               MIPS32_NOP,
-               MIPS32_B(NEG16(30)),                                                            /* b start */
-               MIPS32_NOP,
        };
 
        /* TODO remove array */
@@ -713,55 +708,52 @@ int mips32_pracc_write_mem16(struct mips_ejtag *ejtag_info, uint32_t addr, int c
                param_in[i + 2] = buf[i];
        }
 
-       mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code, \
+       int retval;
+       retval = mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code,
                count + 2, param_in, 0, NULL, 1);
 
        free(param_in);
 
-       return ERROR_OK;
+       return retval;
 }
 
-int mips32_pracc_write_mem8(struct mips_ejtag *ejtag_info, uint32_t addr, int count, uint8_t *buf)
+static int mips32_pracc_write_mem8(struct mips_ejtag *ejtag_info, uint32_t addr, int count, uint8_t *buf)
 {
        static const uint32_t code[] = {
                                                                                                                        /* start: */
                MIPS32_MTC0(15,31,0),                                                           /* move $15 to COP0 DeSave */
-               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),             /* $15 = MIPS32_PRACC_STACK */
+               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),                     /* $15 = MIPS32_PRACC_STACK */
                MIPS32_ORI(15,15,LOWER16(MIPS32_PRACC_STACK)),
-               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
-               MIPS32_SW(9,0,15),                                                                      /* sw $9,($15) */
-               MIPS32_SW(10,0,15),                                                             /* sw $10,($15) */
-               MIPS32_SW(11,0,15),                                                             /* sw $11,($15) */
+               MIPS32_SW(8,0,15),                                                                      /* sw $8,($15) */
+               MIPS32_SW(9,0,15),                                                                      /* sw $9,($15) */
+               MIPS32_SW(10,0,15),                                                                     /* sw $10,($15) */
+               MIPS32_SW(11,0,15),                                                                     /* sw $11,($15) */
 
-               MIPS32_LUI(8,UPPER16(MIPS32_PRACC_PARAM_IN)),           /* $8 = MIPS32_PRACC_PARAM_IN */
+               MIPS32_LUI(8,UPPER16(MIPS32_PRACC_PARAM_IN)),           /* $8 = MIPS32_PRACC_PARAM_IN */
                MIPS32_ORI(8,8,LOWER16(MIPS32_PRACC_PARAM_IN)),
-               MIPS32_LW(9,0,8),                                                                       /* Load write addr to $9 */
-               MIPS32_LW(10,4,8),                                                                      /* Load write count to $10 */
-               MIPS32_ADDI(8,8,8),                                                             /* $8 += 8 */
-               MIPS32_NOP,
+               MIPS32_LW(9,0,8),                                                                       /* Load write addr to $9 */
+               MIPS32_LW(10,4,8),                                                                      /* Load write count to $10 */
+               MIPS32_ADDI(8,8,8),                                                                     /* $8 += 8 */
                                                                                                                        /* loop: */
-               MIPS32_BEQ(0,10,9),                                                                     /* beq $0, $10, end */
+               MIPS32_BEQ(0,10,8),                                                                     /* beq $0, $10, end */
                MIPS32_NOP,
 
-               MIPS32_LW(11,0,8),                                                                      /* lw $11,0($8), Load $11 with the word @mem[$8] */
-               MIPS32_SB(11,0,9),                                                                      /* sb $11,0($9) */
+               MIPS32_LW(11,0,8),                                                                      /* lw $11,0($8), Load $11 with the word @mem[$8] */
+               MIPS32_SB(11,0,9),                                                                      /* sb $11,0($9) */
 
-               MIPS32_ADDI(10,10,NEG16(1)),                                            /* $10-- */
-               MIPS32_ADDI(9,9,1),                                                             /* $9 += 1 */
-               MIPS32_ADDI(8,8,4),                                                             /* $8 += 4 */
+               MIPS32_ADDI(10,10,NEG16(1)),                                            /* $10-- */
+               MIPS32_ADDI(9,9,1),                                                                     /* $9 += 1 */
+               MIPS32_ADDI(8,8,4),                                                                     /* $8 += 4 */
 
-               MIPS32_NOP,
-               MIPS32_B(NEG16(9)),                                                                     /* b loop */
+               MIPS32_B(NEG16(8)),                                                                     /* b loop */
                MIPS32_NOP,
                                                                                                                        /* end: */
-               MIPS32_LW(11,0,15),                                                             /* lw $11,($15) */
-               MIPS32_LW(10,0,15),                                                             /* lw $10,($15) */
-               MIPS32_LW(9,0,15),                                                                      /* lw $9,($15) */
-               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
+               MIPS32_LW(11,0,15),                                                                     /* lw $11,($15) */
+               MIPS32_LW(10,0,15),                                                                     /* lw $10,($15) */
+               MIPS32_LW(9,0,15),                                                                      /* lw $9,($15) */
+               MIPS32_LW(8,0,15),                                                                      /* lw $8,($15) */
+               MIPS32_B(NEG16(26)),                                                            /* b start */
                MIPS32_MFC0(15,31,0),                                                           /* move COP0 DeSave to $15 */
-               MIPS32_NOP,
-               MIPS32_B(NEG16(30)),                                                            /* b start */
-               MIPS32_NOP,
        };
 
        /* TODO remove array */
@@ -776,8 +768,8 @@ int mips32_pracc_write_mem8(struct mips_ejtag *ejtag_info, uint32_t addr, int co
                param_in[i + 2] = buf[i];
        }
 
-       retval = mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code, \
-               count +2, param_in, 0, NULL, 1);
+       retval = mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code,
+               count + 2, param_in, 0, NULL, 1);
 
        free(param_in);
 
@@ -788,70 +780,68 @@ int mips32_pracc_write_regs(struct mips_ejtag *ejtag_info, uint32_t *regs)
 {
        static const uint32_t code[] = {
                                                                                                                /* start: */
-               MIPS32_LUI(2,UPPER16(MIPS32_PRACC_PARAM_IN)),   /* $2 = MIPS32_PRACC_PARAM_IN */
+               MIPS32_LUI(2,UPPER16(MIPS32_PRACC_PARAM_IN)),   /* $2 = MIPS32_PRACC_PARAM_IN */
                MIPS32_ORI(2,2,LOWER16(MIPS32_PRACC_PARAM_IN)),
-               MIPS32_LW(1,1*4,2),                                                     /* lw $1,1*4($2) */
-               MIPS32_LW(15,15*4,2),                                                   /* lw $15,15*4($2) */
+               MIPS32_LW(1,1*4,2),                                                             /* lw $1,1*4($2) */
+               MIPS32_LW(15,15*4,2),                                                   /* lw $15,15*4($2) */
                MIPS32_MTC0(15,31,0),                                                   /* move $15 to COP0 DeSave */
-               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),     /* $15 = MIPS32_PRACC_STACK */
+               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),             /* $15 = MIPS32_PRACC_STACK */
                MIPS32_ORI(15,15,LOWER16(MIPS32_PRACC_STACK)),
-               MIPS32_SW(1,0,15),                                                              /* sw $1,($15) */
-               MIPS32_LUI(1,UPPER16(MIPS32_PRACC_PARAM_IN)),   /* $1 = MIPS32_PRACC_PARAM_IN */
+               MIPS32_SW(1,0,15),                                                              /* sw $1,($15) */
+               MIPS32_LUI(1,UPPER16(MIPS32_PRACC_PARAM_IN)),   /* $1 = MIPS32_PRACC_PARAM_IN */
                MIPS32_ORI(1,1,LOWER16(MIPS32_PRACC_PARAM_IN)),
-               MIPS32_LW(3,3*4,1),                                                     /* lw $3,3*4($1) */
-               MIPS32_LW(4,4*4,1),                                                     /* lw $4,4*4($1) */
-               MIPS32_LW(5,5*4,1),                                                     /* lw $5,5*4($1) */
-               MIPS32_LW(6,6*4,1),                                                     /* lw $6,6*4($1) */
-               MIPS32_LW(7,7*4,1),                                                     /* lw $7,7*4($1) */
-               MIPS32_LW(8,8*4,1),                                                     /* lw $8,8*4($1) */
-               MIPS32_LW(9,9*4,1),                                                     /* lw $9,9*4($1) */
-               MIPS32_LW(10,10*4,1),                                                   /* lw $10,10*4($1) */
-               MIPS32_LW(11,11*4,1),                                                   /* lw $11,11*4($1) */
-               MIPS32_LW(12,12*4,1),                                                   /* lw $12,12*4($1) */
-               MIPS32_LW(13,13*4,1),                                                   /* lw $13,13*4($1) */
-               MIPS32_LW(14,14*4,1),                                                   /* lw $14,14*4($1) */
-               MIPS32_LW(16,16*4,1),                                                   /* lw $16,16*4($1) */
-               MIPS32_LW(17,17*4,1),                                                   /* lw $17,17*4($1) */
-               MIPS32_LW(18,18*4,1),                                                   /* lw $18,18*4($1) */
-               MIPS32_LW(19,19*4,1),                                                   /* lw $19,19*4($1) */
-               MIPS32_LW(20,20*4,1),                                                   /* lw $20,20*4($1) */
-               MIPS32_LW(21,21*4,1),                                                   /* lw $21,21*4($1) */
-               MIPS32_LW(22,22*4,1),                                                   /* lw $22,22*4($1) */
-               MIPS32_LW(23,23*4,1),                                                   /* lw $23,23*4($1) */
-               MIPS32_LW(24,24*4,1),                                                   /* lw $24,24*4($1) */
-               MIPS32_LW(25,25*4,1),                                                   /* lw $25,25*4($1) */
-               MIPS32_LW(26,26*4,1),                                                   /* lw $26,26*4($1) */
-               MIPS32_LW(27,27*4,1),                                                   /* lw $27,27*4($1) */
-               MIPS32_LW(28,28*4,1),                                                   /* lw $28,28*4($1) */
-               MIPS32_LW(29,29*4,1),                                                   /* lw $29,29*4($1) */
-               MIPS32_LW(30,30*4,1),                                                   /* lw $30,30*4($1) */
-               MIPS32_LW(31,31*4,1),                                                   /* lw $31,31*4($1) */
-
-               MIPS32_LW(2,32*4,1),                                                    /* lw $2,32*4($1) */
+               MIPS32_LW(3,3*4,1),                                                             /* lw $3,3*4($1) */
+               MIPS32_LW(4,4*4,1),                                                             /* lw $4,4*4($1) */
+               MIPS32_LW(5,5*4,1),                                                             /* lw $5,5*4($1) */
+               MIPS32_LW(6,6*4,1),                                                             /* lw $6,6*4($1) */
+               MIPS32_LW(7,7*4,1),                                                             /* lw $7,7*4($1) */
+               MIPS32_LW(8,8*4,1),                                                             /* lw $8,8*4($1) */
+               MIPS32_LW(9,9*4,1),                                                             /* lw $9,9*4($1) */
+               MIPS32_LW(10,10*4,1),                                                   /* lw $10,10*4($1) */
+               MIPS32_LW(11,11*4,1),                                                   /* lw $11,11*4($1) */
+               MIPS32_LW(12,12*4,1),                                                   /* lw $12,12*4($1) */
+               MIPS32_LW(13,13*4,1),                                                   /* lw $13,13*4($1) */
+               MIPS32_LW(14,14*4,1),                                                   /* lw $14,14*4($1) */
+               MIPS32_LW(16,16*4,1),                                                   /* lw $16,16*4($1) */
+               MIPS32_LW(17,17*4,1),                                                   /* lw $17,17*4($1) */
+               MIPS32_LW(18,18*4,1),                                                   /* lw $18,18*4($1) */
+               MIPS32_LW(19,19*4,1),                                                   /* lw $19,19*4($1) */
+               MIPS32_LW(20,20*4,1),                                                   /* lw $20,20*4($1) */
+               MIPS32_LW(21,21*4,1),                                                   /* lw $21,21*4($1) */
+               MIPS32_LW(22,22*4,1),                                                   /* lw $22,22*4($1) */
+               MIPS32_LW(23,23*4,1),                                                   /* lw $23,23*4($1) */
+               MIPS32_LW(24,24*4,1),                                                   /* lw $24,24*4($1) */
+               MIPS32_LW(25,25*4,1),                                                   /* lw $25,25*4($1) */
+               MIPS32_LW(26,26*4,1),                                                   /* lw $26,26*4($1) */
+               MIPS32_LW(27,27*4,1),                                                   /* lw $27,27*4($1) */
+               MIPS32_LW(28,28*4,1),                                                   /* lw $28,28*4($1) */
+               MIPS32_LW(29,29*4,1),                                                   /* lw $29,29*4($1) */
+               MIPS32_LW(30,30*4,1),                                                   /* lw $30,30*4($1) */
+               MIPS32_LW(31,31*4,1),                                                   /* lw $31,31*4($1) */
+
+               MIPS32_LW(2,32*4,1),                                                    /* lw $2,32*4($1) */
                MIPS32_MTC0(2,12,0),                                                    /* move $2 to status */
-               MIPS32_LW(2,33*4,1),                                                    /* lw $2,33*4($1) */
+               MIPS32_LW(2,33*4,1),                                                    /* lw $2,33*4($1) */
                MIPS32_MTLO(2),                                                                 /* move $2 to lo */
-               MIPS32_LW(2,34*4,1),                                                    /* lw $2,34*4($1) */
+               MIPS32_LW(2,34*4,1),                                                    /* lw $2,34*4($1) */
                MIPS32_MTHI(2),                                                                 /* move $2 to hi */
-               MIPS32_LW(2,35*4,1),                                                    /* lw $2,35*4($1) */
+               MIPS32_LW(2,35*4,1),                                                    /* lw $2,35*4($1) */
                MIPS32_MTC0(2,8,0),                                                             /* move $2 to badvaddr */
-               MIPS32_LW(2,36*4,1),                                                    /* lw $2,36*4($1) */
+               MIPS32_LW(2,36*4,1),                                                    /* lw $2,36*4($1) */
                MIPS32_MTC0(2,13,0),                                                    /* move $2 to cause*/
-               MIPS32_LW(2,37*4,1),                                                    /* lw $2,37*4($1) */
-               MIPS32_MTC0(2,24,0),                                                    /* move $2 to pc */
+               MIPS32_LW(2,37*4,1),                                                    /* lw $2,37*4($1) */
+               MIPS32_MTC0(2,24,0),                                                    /* move $2 to depc (pc) */
 
-               MIPS32_LW(2,2*4,1),                                                     /* lw $2,2*4($1) */
-               MIPS32_LW(1,0,15),                                                              /* lw $1,($15) */
+               MIPS32_LW(2,2*4,1),                                                             /* lw $2,2*4($1) */
+               MIPS32_LW(1,0,15),                                                              /* lw $1,($15) */
+               MIPS32_B(NEG16(53)),                                                    /* b start */
                MIPS32_MFC0(15,31,0),                                                   /* move COP0 DeSave to $15 */
-               MIPS32_NOP,
-               MIPS32_B(NEG16(55)),                                                    /* b start */
-               MIPS32_NOP,
        };
 
        int retval;
 
-       retval = mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code, \
-               38, regs, 0, NULL, 1);
+       retval = mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code,
+                       MIPS32NUMCOREREGS, regs, 0, NULL, 1);
 
        return retval;
 }
@@ -861,74 +851,72 @@ int mips32_pracc_read_regs(struct mips_ejtag *ejtag_info, uint32_t *regs)
        static const uint32_t code[] = {
                                                                                                                /* start: */
                MIPS32_MTC0(2,31,0),                                                    /* move $2 to COP0 DeSave */
-               MIPS32_LUI(2,UPPER16(MIPS32_PRACC_PARAM_OUT)),  /* $2 = MIPS32_PRACC_PARAM_OUT */
+               MIPS32_LUI(2,UPPER16(MIPS32_PRACC_PARAM_OUT)),  /* $2 = MIPS32_PRACC_PARAM_OUT */
                MIPS32_ORI(2,2,LOWER16(MIPS32_PRACC_PARAM_OUT)),
                MIPS32_SW(0,0*4,2),                                                             /* sw $0,0*4($2) */
-               MIPS32_SW(1,1*4,2),                                                     /* sw $1,1*4($2) */
-               MIPS32_SW(15,15*4,2),                                                   /* sw $15,15*4($2) */
+               MIPS32_SW(1,1*4,2),                                                             /* sw $1,1*4($2) */
+               MIPS32_SW(15,15*4,2),                                                   /* sw $15,15*4($2) */
                MIPS32_MFC0(2,31,0),                                                    /* move COP0 DeSave to $2 */
                MIPS32_MTC0(15,31,0),                                                   /* move $15 to COP0 DeSave */
-               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),     /* $15 = MIPS32_PRACC_STACK */
+               MIPS32_LUI(15,UPPER16(MIPS32_PRACC_STACK)),             /* $15 = MIPS32_PRACC_STACK */
                MIPS32_ORI(15,15,LOWER16(MIPS32_PRACC_STACK)),
-               MIPS32_SW(1,0,15),                                                              /* sw $1,($15) */
-               MIPS32_SW(2,0,15),                                                              /* sw $2,($15) */
-               MIPS32_LUI(1,UPPER16(MIPS32_PRACC_PARAM_OUT)),  /* $1 = MIPS32_PRACC_PARAM_OUT */
+               MIPS32_SW(1,0,15),                                                              /* sw $1,($15) */
+               MIPS32_SW(2,0,15),                                                              /* sw $2,($15) */
+               MIPS32_LUI(1,UPPER16(MIPS32_PRACC_PARAM_OUT)),  /* $1 = MIPS32_PRACC_PARAM_OUT */
                MIPS32_ORI(1,1,LOWER16(MIPS32_PRACC_PARAM_OUT)),
-               MIPS32_SW(2,2*4,1),                                                     /* sw $2,2*4($1) */
-               MIPS32_SW(3,3*4,1),                                                     /* sw $3,3*4($1) */
-               MIPS32_SW(4,4*4,1),                                                     /* sw $4,4*4($1) */
-               MIPS32_SW(5,5*4,1),                                                     /* sw $5,5*4($1) */
-               MIPS32_SW(6,6*4,1),                                                     /* sw $6,6*4($1) */
-               MIPS32_SW(7,7*4,1),                                                     /* sw $7,7*4($1) */
-               MIPS32_SW(8,8*4,1),                                                     /* sw $8,8*4($1) */
-               MIPS32_SW(9,9*4,1),                                                     /* sw $9,9*4($1) */
-               MIPS32_SW(10,10*4,1),                                                   /* sw $10,10*4($1) */
-               MIPS32_SW(11,11*4,1),                                                   /* sw $11,11*4($1) */
-               MIPS32_SW(12,12*4,1),                                                   /* sw $12,12*4($1) */
-               MIPS32_SW(13,13*4,1),                                                   /* sw $13,13*4($1) */
-               MIPS32_SW(14,14*4,1),                                                   /* sw $14,14*4($1) */
-               MIPS32_SW(16,16*4,1),                                                   /* sw $16,16*4($1) */
-               MIPS32_SW(17,17*4,1),                                                   /* sw $17,17*4($1) */
-               MIPS32_SW(18,18*4,1),                                                   /* sw $18,18*4($1) */
-               MIPS32_SW(19,19*4,1),                                                   /* sw $19,19*4($1) */
-               MIPS32_SW(20,20*4,1),                                                   /* sw $20,20*4($1) */
-               MIPS32_SW(21,21*4,1),                                                   /* sw $21,21*4($1) */
-               MIPS32_SW(22,22*4,1),                                                   /* sw $22,22*4($1) */
-               MIPS32_SW(23,23*4,1),                                                   /* sw $23,23*4($1) */
-               MIPS32_SW(24,24*4,1),                                                   /* sw $24,24*4($1) */
-               MIPS32_SW(25,25*4,1),                                                   /* sw $25,25*4($1) */
-               MIPS32_SW(26,26*4,1),                                                   /* sw $26,26*4($1) */
-               MIPS32_SW(27,27*4,1),                                                   /* sw $27,27*4($1) */
-               MIPS32_SW(28,28*4,1),                                                   /* sw $28,28*4($1) */
-               MIPS32_SW(29,29*4,1),                                                   /* sw $29,29*4($1) */
-               MIPS32_SW(30,30*4,1),                                                   /* sw $30,30*4($1) */
-               MIPS32_SW(31,31*4,1),                                                   /* sw $31,31*4($1) */
+               MIPS32_SW(2,2*4,1),                                                             /* sw $2,2*4($1) */
+               MIPS32_SW(3,3*4,1),                                                             /* sw $3,3*4($1) */
+               MIPS32_SW(4,4*4,1),                                                             /* sw $4,4*4($1) */
+               MIPS32_SW(5,5*4,1),                                                             /* sw $5,5*4($1) */
+               MIPS32_SW(6,6*4,1),                                                             /* sw $6,6*4($1) */
+               MIPS32_SW(7,7*4,1),                                                             /* sw $7,7*4($1) */
+               MIPS32_SW(8,8*4,1),                                                             /* sw $8,8*4($1) */
+               MIPS32_SW(9,9*4,1),                                                             /* sw $9,9*4($1) */
+               MIPS32_SW(10,10*4,1),                                                   /* sw $10,10*4($1) */
+               MIPS32_SW(11,11*4,1),                                                   /* sw $11,11*4($1) */
+               MIPS32_SW(12,12*4,1),                                                   /* sw $12,12*4($1) */
+               MIPS32_SW(13,13*4,1),                                                   /* sw $13,13*4($1) */
+               MIPS32_SW(14,14*4,1),                                                   /* sw $14,14*4($1) */
+               MIPS32_SW(16,16*4,1),                                                   /* sw $16,16*4($1) */
+               MIPS32_SW(17,17*4,1),                                                   /* sw $17,17*4($1) */
+               MIPS32_SW(18,18*4,1),                                                   /* sw $18,18*4($1) */
+               MIPS32_SW(19,19*4,1),                                                   /* sw $19,19*4($1) */
+               MIPS32_SW(20,20*4,1),                                                   /* sw $20,20*4($1) */
+               MIPS32_SW(21,21*4,1),                                                   /* sw $21,21*4($1) */
+               MIPS32_SW(22,22*4,1),                                                   /* sw $22,22*4($1) */
+               MIPS32_SW(23,23*4,1),                                                   /* sw $23,23*4($1) */
+               MIPS32_SW(24,24*4,1),                                                   /* sw $24,24*4($1) */
+               MIPS32_SW(25,25*4,1),                                                   /* sw $25,25*4($1) */
+               MIPS32_SW(26,26*4,1),                                                   /* sw $26,26*4($1) */
+               MIPS32_SW(27,27*4,1),                                                   /* sw $27,27*4($1) */
+               MIPS32_SW(28,28*4,1),                                                   /* sw $28,28*4($1) */
+               MIPS32_SW(29,29*4,1),                                                   /* sw $29,29*4($1) */
+               MIPS32_SW(30,30*4,1),                                                   /* sw $30,30*4($1) */
+               MIPS32_SW(31,31*4,1),                                                   /* sw $31,31*4($1) */
 
                MIPS32_MFC0(2,12,0),                                                    /* move status to $2 */
-               MIPS32_SW(2,32*4,1),                                                    /* sw $2,32*4($1) */
+               MIPS32_SW(2,32*4,1),                                                    /* sw $2,32*4($1) */
                MIPS32_MFLO(2),                                                                 /* move lo to $2 */
-               MIPS32_SW(2,33*4,1),                                                    /* sw $2,33*4($1) */
+               MIPS32_SW(2,33*4,1),                                                    /* sw $2,33*4($1) */
                MIPS32_MFHI(2),                                                                 /* move hi to $2 */
-               MIPS32_SW(2,34*4,1),                                                    /* sw $2,34*4($1) */
+               MIPS32_SW(2,34*4,1),                                                    /* sw $2,34*4($1) */
                MIPS32_MFC0(2,8,0),                                                             /* move badvaddr to $2 */
-               MIPS32_SW(2,35*4,1),                                                    /* sw $2,35*4($1) */
+               MIPS32_SW(2,35*4,1),                                                    /* sw $2,35*4($1) */
                MIPS32_MFC0(2,13,0),                                                    /* move cause to $2 */
-               MIPS32_SW(2,36*4,1),                                                    /* sw $2,36*4($1) */
-               MIPS32_MFC0(2,24,0),                                                    /* move pc to $2 */
-               MIPS32_SW(2,37*4,1),                                                    /* sw $2,37*4($1) */
+               MIPS32_SW(2,36*4,1),                                                    /* sw $2,36*4($1) */
+               MIPS32_MFC0(2,24,0),                                                    /* move depc (pc) to $2 */
+               MIPS32_SW(2,37*4,1),                                                    /* sw $2,37*4($1) */
 
-               MIPS32_LW(2,0,15),                                                              /* lw $2,($15) */
-               MIPS32_LW(1,0,15),                                                              /* lw $1,($15) */
+               MIPS32_LW(2,0,15),                                                              /* lw $2,($15) */
+               MIPS32_LW(1,0,15),                                                              /* lw $1,($15) */
+               MIPS32_B(NEG16(58)),                                                    /* b start */
                MIPS32_MFC0(15,31,0),                                                   /* move COP0 DeSave to $15 */
-               MIPS32_NOP,
-               MIPS32_B(NEG16(60)),                                                    /* b start */
-               MIPS32_NOP,
        };
 
        int retval;
 
-       retval = mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code, \
-               0, NULL, 38, regs, 1);
+       retval = mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code,
+               0, NULL, MIPS32NUMCOREREGS, regs, 1);
 
        return retval;
 }
@@ -941,7 +929,7 @@ int mips32_pracc_read_regs(struct mips_ejtag *ejtag_info, uint32_t *regs)
  * 3. data ...
  */
 int mips32_pracc_fastdata_xfer(struct mips_ejtag *ejtag_info, struct working_area *source,
-                                                               int write, uint32_t addr, int count, uint32_t *buf)
+                                                               int write_t, uint32_t addr, int count, uint32_t *buf)
 {
        uint32_t handler_code[] = {
                /* caution when editing, table is modified below */
@@ -970,7 +958,6 @@ int mips32_pracc_fastdata_xfer(struct mips_ejtag *ejtag_info, struct working_are
                MIPS32_ORI(15,15,LOWER16(MIPS32_PRACC_TEXT)),
                MIPS32_JR(15),                                                                  /* jr start */
                MIPS32_MFC0(15,31,0),                                                   /* move COP0 DeSave to $15 */
-               MIPS32_NOP,
        };
 
        uint32_t jmp_code[] = {
@@ -981,16 +968,13 @@ int mips32_pracc_fastdata_xfer(struct mips_ejtag *ejtag_info, struct working_are
                MIPS32_NOP,
        };
 
-#define JMP_CODE_SIZE (sizeof(jmp_code)/sizeof(jmp_code[0]))
-#define HANDLER_CODE_SIZE sizeof(handler_code)/sizeof(handler_code[0])
-
        int retval, i;
        uint32_t val, ejtag_ctrl, address;
 
        if (source->size < MIPS32_FASTDATA_HANDLER_SIZE)
                return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
 
-       if (write)
+       if (write_t)
        {
                handler_code[8] = MIPS32_LW(11,0,8);    /* load data from probe at fastdata area */
                handler_code[9] = MIPS32_SW(11,0,9);    /* store data to RAM @ r9 */
@@ -1002,33 +986,29 @@ int mips32_pracc_fastdata_xfer(struct mips_ejtag *ejtag_info, struct working_are
        }
 
        /* write program into RAM */
-       mips32_pracc_write_mem32(ejtag_info, source->address, HANDLER_CODE_SIZE, handler_code);
-
-       /* quick verify RAM is working */
-       mips32_pracc_read_u32(ejtag_info, source->address, &val);
-       if (val != handler_code[0])
+       if (write_t != ejtag_info->fast_access_save)
        {
-               LOG_ERROR("fastdata handler verify failed\n");
-               return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
+               mips32_pracc_write_mem32(ejtag_info, source->address, ARRAY_SIZE(handler_code), handler_code);
+               /* save previous operation to speed to any consecutive read/writes */
+               ejtag_info->fast_access_save = write_t;
        }
 
-       LOG_INFO("%s using 0x%.8x for write handler\n", __func__, source->address);
+       LOG_DEBUG("%s using 0x%.8" PRIx32 " for write handler", __func__, source->address);
 
        jmp_code[1] |= UPPER16(source->address);
        jmp_code[2] |= LOWER16(source->address);
 
-       for (i = 0; i < (int) JMP_CODE_SIZE; i++)
+       for (i = 0; i < (int) ARRAY_SIZE(jmp_code); i++)
        {
                if ((retval = wait_for_pracc_rw(ejtag_info, &ejtag_ctrl)) != ERROR_OK)
                        return retval;
 
-               mips_ejtag_set_instr(ejtag_info, EJTAG_INST_DATA, NULL);
+               mips_ejtag_set_instr(ejtag_info, EJTAG_INST_DATA);
                mips_ejtag_drscan_32(ejtag_info, &jmp_code[i]);
 
                /* Clear the access pending bit (let the processor eat!) */
-
                ejtag_ctrl = ejtag_info->ejtag_ctrl & ~EJTAG_CTRL_PRACC;
-               mips_ejtag_set_instr(ejtag_info, EJTAG_INST_CONTROL, NULL);
+               mips_ejtag_set_instr(ejtag_info, EJTAG_INST_CONTROL);
                mips_ejtag_drscan_32(ejtag_info, &ejtag_ctrl);
        }
 
@@ -1037,7 +1017,7 @@ int mips32_pracc_fastdata_xfer(struct mips_ejtag *ejtag_info, struct working_are
 
        /* next fetch to dmseg should be in FASTDATA_AREA, check */
        address = 0;
-       mips_ejtag_set_instr(ejtag_info, EJTAG_INST_ADDRESS, NULL);
+       mips_ejtag_set_instr(ejtag_info, EJTAG_INST_ADDRESS);
        mips_ejtag_drscan_32(ejtag_info, &address);
 
        if (address != MIPS32_PRACC_FASTDATA_AREA)
@@ -1045,18 +1025,18 @@ int mips32_pracc_fastdata_xfer(struct mips_ejtag *ejtag_info, struct working_are
 
        /* Send the load start address */
        val = addr;
-       mips_ejtag_set_instr(ejtag_info, EJTAG_INST_FASTDATA, NULL);
+       mips_ejtag_set_instr(ejtag_info, EJTAG_INST_FASTDATA);
        mips_ejtag_fastdata_scan(ejtag_info, 1, &val);
 
        /* Send the load end address */
        val = addr + (count - 1) * 4;
-       mips_ejtag_set_instr(ejtag_info, EJTAG_INST_FASTDATA, NULL);
+       mips_ejtag_set_instr(ejtag_info, EJTAG_INST_FASTDATA);
        mips_ejtag_fastdata_scan(ejtag_info, 1, &val);
 
        for (i = 0; i < count; i++)
        {
                /* Send the data out using fastdata (clears the access pending bit) */
-               if ((retval = mips_ejtag_fastdata_scan(ejtag_info, write, buf++)) != ERROR_OK)
+               if ((retval = mips_ejtag_fastdata_scan(ejtag_info, write_t, buf++)) != ERROR_OK)
                        return retval;
        }
 
@@ -1070,11 +1050,11 @@ int mips32_pracc_fastdata_xfer(struct mips_ejtag *ejtag_info, struct working_are
                return retval;
 
        address = 0;
-       mips_ejtag_set_instr(ejtag_info, EJTAG_INST_ADDRESS, NULL);
+       mips_ejtag_set_instr(ejtag_info, EJTAG_INST_ADDRESS);
        mips_ejtag_drscan_32(ejtag_info, &address);
 
        if (address != MIPS32_PRACC_TEXT)
-               LOG_ERROR("mini program did not return to start\n");
+               LOG_ERROR("mini program did not return to start");
 
        return retval;
 }

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)