smp: replace commands smp_on/smp_off with "smp [on|off]"

[openocd.git] / src / target / smp.c

diff --git a/src/target/smp.c b/src/target/smp.c
index da9ee8b468fa1bf7626260d58eab869a3345d400..87944331e059aa3d865e094784e8ad7b23a5eecb 100644 (file)
--- a/src/target/smp.c
+++ b/src/target/smp.c
@@ -13,9 +13,7 @@
  *   GNU General Public License for more details.                          *
  *                                                                         *
  *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.           *
+ *   along with this program.  If not, see <http://www.gnu.org/licenses/>. *
  ***************************************************************************/
 
 #ifdef HAVE_CONFIG_H
@@ -66,7 +64,8 @@ int gdb_read_smp_packet(struct connection *connection,
                        char hex_buffer[len * 2 + 1];
                        uint8_t buffer[len];
                        buf_set_u32(buffer, 0, len * 8, target->gdb_service->core[0]);
-                       int pkt_len = hexify(hex_buffer, (char *)buffer, sizeof(buffer), sizeof(hex_buffer));
+                       size_t pkt_len = hexify(hex_buffer, buffer, sizeof(buffer),
+                               sizeof(hex_buffer));
 
                        retval = gdb_put_packet(connection, hex_buffer, pkt_len);
                }
@@ -97,3 +96,82 @@ int gdb_write_smp_packet(struct connection *connection,
 
        return retval;
 }
+
+COMMAND_HANDLER(default_handle_smp_command)
+{
+       struct target *target = get_current_target(CMD_CTX);
+       struct target_list *head;
+
+       if (CMD_ARGC > 1)
+               return ERROR_COMMAND_SYNTAX_ERROR;
+
+       if (!CMD_ARGC) {
+               command_print(CMD_CTX, "%s", target->smp ? "on" : "off");
+               return ERROR_OK;
+       }
+
+       if (!strcmp(CMD_ARGV[0], "on")) {
+               foreach_smp_target(head, target->head)
+                       head->target->smp = 1;
+
+               return ERROR_OK;
+       }
+
+       if (!strcmp(CMD_ARGV[0], "off")) {
+               foreach_smp_target(head, target->head)
+                       head->target->smp = 0;
+
+               /* fixes the target display to the debugger */
+               if (target->head)
+                       target->gdb_service->target = target;
+
+               return ERROR_OK;
+       }
+
+       return ERROR_COMMAND_SYNTAX_ERROR;
+}
+
+COMMAND_HANDLER(deprecated_handle_smp_on_command)
+{
+       const char *argv[] = {"on", NULL};
+
+       LOG_WARNING("\'smp_on\' is deprecated, please use \'smp on\' instead.");
+       CMD_ARGC = 1;
+       CMD_ARGV = argv;
+       return CALL_COMMAND_HANDLER(default_handle_smp_command);
+}
+
+COMMAND_HANDLER(deprecated_handle_smp_off_command)
+{
+       const char *argv[] = {"off", NULL};
+
+       LOG_WARNING("\'smp_off\' is deprecated, please use \'smp off\' instead.");
+       CMD_ARGC = 1;
+       CMD_ARGV = argv;
+       return CALL_COMMAND_HANDLER(default_handle_smp_command);
+}
+
+const struct command_registration smp_command_handlers[] = {
+       {
+               .name = "smp",
+               .handler = default_handle_smp_command,
+               .mode = COMMAND_EXEC,
+               .help = "smp handling",
+               .usage = "[on|off]",
+       },
+       {
+               .name = "smp_on",
+               .handler = deprecated_handle_smp_on_command,
+               .mode = COMMAND_EXEC,
+               .help = "Restart smp handling",
+               .usage = "",
+       },
+       {
+               .name = "smp_off",
+               .handler = deprecated_handle_smp_off_command,
+               .mode = COMMAND_EXEC,
+               .help = "Stop smp handling",
+               .usage = "",
+       },
+       COMMAND_REGISTRATION_DONE
+};