Remove whitespace that occurs after '('.
[openocd.git] / src / target / target_request.c
index 1aa7d3983528d2aff69e62c8159e881d08d7094e..af59a6df10ff49af377c4d77fef0406ef16d612c 100644 (file)
 #include "config.h"
 #endif
 
-#include "replacements.h"
-#include "log.h"
-#include "target.h"
 #include "target_request.h"
+#include "target_type.h"
 #include "binarybuffer.h"
-#include "command.h"
 #include "trace.h"
+#include "log.h"
 
-#include <stdlib.h>
-#include <string.h>
 
-command_t *target_request_cmd = NULL;
+static command_t *target_request_cmd = NULL;
 static int charmsg_mode = 0;
 
-int target_asciimsg(target_t *target, u32 length)
+static int target_asciimsg(target_t *target, uint32_t length)
 {
        char *msg = malloc(CEIL(length + 1, 4) * 4);
        debug_msg_receiver_t *c = target->dbgmsg;
-       
-       target->type->target_request_data(target, CEIL(length, 4), (u8*)msg);
+
+       target->type->target_request_data(target, CEIL(length, 4), (uint8_t*)msg);
        msg[length] = 0;
-       
+
        LOG_DEBUG("%s", msg);
-       
+
        while (c)
        {
                command_print(c->cmd_ctx, "%s", msg);
                c = c->next;
        }
-       
+
        return ERROR_OK;
 }
 
-int target_charmsg(target_t *target, u8 msg)
+static int target_charmsg(target_t *target, uint8_t msg)
 {
        LOG_USER_N("%c", msg);
-       
+
        return ERROR_OK;
 }
 
-int target_hexmsg(target_t *target, int size, u32 length)
+static int target_hexmsg(target_t *target, int size, uint32_t length)
 {
-       u8 *data = malloc(CEIL(length * size, 4) * 4);
+       uint8_t *data = malloc(CEIL(length * size, 4) * 4);
        char line[128];
        int line_len;
        debug_msg_receiver_t *c = target->dbgmsg;
-       u32 i;
-       
-       LOG_DEBUG("size: %i, length: %i", size, length);
+       uint32_t i;
 
-       target->type->target_request_data(target, CEIL(length * size, 4), (u8*)data);
+       LOG_DEBUG("size: %i, length: %i", (int)size, (int)length);
+
+       target->type->target_request_data(target, CEIL(length * size, 4), (uint8_t*)data);
 
        line_len = 0;
        for (i = 0; i < length; i++)
@@ -85,7 +81,7 @@ int target_hexmsg(target_t *target, int size, u32 length)
                switch (size)
                {
                        case 4:
-                               line_len += snprintf(line + line_len, 128 - line_len, "%8.8x ", le_to_h_u32(data + (4*i)));
+                               line_len += snprintf(line + line_len, 128 - line_len, "%8.8" PRIx32 " ", le_to_h_u32(data + (4*i)));
                                break;
                        case 2:
                                line_len += snprintf(line + line_len, 128 - line_len, "%4.4x ", le_to_h_u16(data + (2*i)));
@@ -94,11 +90,11 @@ int target_hexmsg(target_t *target, int size, u32 length)
                                line_len += snprintf(line + line_len, 128 - line_len, "%2.2x ", data[i]);
                                break;
                }
-               
+
                if ((i%8 == 7) || (i == length - 1))
                {
                        LOG_DEBUG("%s", line);
-                       
+
                        while (c)
                        {
                                command_print(c->cmd_ctx, "%s", line);
@@ -108,7 +104,7 @@ int target_hexmsg(target_t *target, int size, u32 length)
                        line_len = 0;
                }
        }
-       
+
        free(data);
 
        return ERROR_OK;
@@ -117,11 +113,11 @@ int target_hexmsg(target_t *target, int size, u32 length)
 /* handle requests from the target received by a target specific
  * side-band channel (e.g. ARM7/9 DCC)
  */
-int target_request(target_t *target, u32 request)
+int target_request(target_t *target, uint32_t request)
 {
        target_req_cmd_t target_req_cmd = request & 0xff;
 
-       if ( charmsg_mode ) {
+       if (charmsg_mode ) {
                target_charmsg(target, target_req_cmd );
                return ERROR_OK;
        }
@@ -150,14 +146,14 @@ int target_request(target_t *target, u32 request)
                        LOG_ERROR("unknown target request: %2.2x", target_req_cmd);
                        break;
        }
-       
+
        return ERROR_OK;
 }
 
-int add_debug_msg_receiver(struct command_context_s *cmd_ctx, target_t *target)
+static int add_debug_msg_receiver(struct command_context_s *cmd_ctx, target_t *target)
 {
        debug_msg_receiver_t **p = &target->dbgmsg;
-       
+
        if (target == NULL)
                return ERROR_INVALID_ARGUMENTS;
 
@@ -175,18 +171,18 @@ int add_debug_msg_receiver(struct command_context_s *cmd_ctx, target_t *target)
        (*p) = malloc(sizeof(debug_msg_receiver_t));
        (*p)->cmd_ctx = cmd_ctx;
        (*p)->next = NULL;
-       
+
        /* enable callback */
        target->dbg_msg_enabled = 1;
-       
+
        return ERROR_OK;
 }
 
-debug_msg_receiver_t* find_debug_msg_receiver(struct command_context_s *cmd_ctx, target_t *target)
+static debug_msg_receiver_t* find_debug_msg_receiver(struct command_context_s *cmd_ctx, target_t *target)
 {
        int do_all_targets = 0;
        debug_msg_receiver_t **p = &target->dbgmsg;
-       
+
        /* if no target has been specified search all of them */
        if (target == NULL)
        {
@@ -197,7 +193,7 @@ debug_msg_receiver_t* find_debug_msg_receiver(struct command_context_s *cmd_ctx,
                target = all_targets;
                do_all_targets = 1;
        }
-       
+
        do
        {
                while (*p)
@@ -208,10 +204,10 @@ debug_msg_receiver_t* find_debug_msg_receiver(struct command_context_s *cmd_ctx,
                        }
                        p = &((*p)->next);
                }
-               
+
                target = target->next;
        } while (target && do_all_targets);
-       
+
        return NULL;
 }
 
@@ -220,14 +216,14 @@ int delete_debug_msg_receiver(struct command_context_s *cmd_ctx, target_t *targe
        debug_msg_receiver_t **p;
        debug_msg_receiver_t *c;
        int do_all_targets = 0;
-       
+
        /* if no target has been specified search all of them */
        if (target == NULL)
        {
                /* if no targets haven been specified */
                if (all_targets == NULL)
                        return ERROR_OK;
-               
+
                target = all_targets;
                do_all_targets = 1;
        }
@@ -254,19 +250,19 @@ int delete_debug_msg_receiver(struct command_context_s *cmd_ctx, target_t *targe
                                p = &(c->next);
                        c = next;
                }
-       
+
                target = target->next;
        } while (target && do_all_targets);
-       
+
        return ERROR_OK;
 }
 
-int handle_target_request_debugmsgs_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
+static int handle_target_request_debugmsgs_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
 {
        target_t *target = get_current_target(cmd_ctx);
 
        int receiving = 0;
-       
+
        /* see if reciever is already registered */
        if (find_debug_msg_receiver(cmd_ctx, target) != NULL)
                receiving = 1;
@@ -297,7 +293,7 @@ int handle_target_request_debugmsgs_command(struct command_context_s *cmd_ctx, c
                        command_print(cmd_ctx, "usage: target_request debugmsgs ['enable'|'disable'|'charmsg']");
                }
        }
-       
+
        command_print(cmd_ctx, "receiving debug messages from current target %s",
                      (receiving) ? (charmsg_mode?"charmsg":"enabled") : "disabled" );
        return ERROR_OK;
@@ -307,7 +303,7 @@ int target_request_register_commands(struct command_context_s *cmd_ctx)
 {
        target_request_cmd =
                register_command(cmd_ctx, NULL, "target_request", NULL, COMMAND_ANY, "target_request commands");
-       
+
        register_command(cmd_ctx, target_request_cmd, "debugmsgs", handle_target_request_debugmsgs_command,
                COMMAND_EXEC, "enable/disable reception of debug messages from target");
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)