X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=blobdiff_plain;f=HACKING;h=162da8698ea4ba85a516ba1269add777c74a7ff8;hp=395b5b3167c5ff09f7613f4ac06e3d7ad8315d36;hb=33d220d10a069be34095313f51ae22052a079b34;hpb=7074321ade3f489786f6590030de41ed63f20eba
diff --git a/HACKING b/HACKING
index 395b5b3167..162da8698e 100644
--- a/HACKING
+++ b/HACKING
@@ -47,8 +47,14 @@ Add yourself to the GPL copyright for non-trivial changes.
add a username of your choice.
Your username will be required in step 3 and substituted wherever
the string 'USERNAME' is found.
- -# Add an SSH public key following the directions on github:
- https://help.github.com/articles/generating-ssh-keys
+ -# Create an SSH public key following the directions on github:
+ https://help.github.com/articles/generating-ssh-keys . You can skip step 3
+ (adding key to Github account) and 4 (testing) - these are useful only if
+ you actually use Github or want to test whether the new key works fine.
+ -# Add this new SSH key to your Gerrit account:
+ go to 'Settings' > 'SSH Public Keys', paste the contents of
+ ~/.ssh/id_rsa.pub into the text field (if it's not visible click on
+ 'Add Key ...' button) and confirm by clicking 'Add' button.
-# Clone the git repository, rather than just download the source:
@code
git clone git://git.code.sf.net/p/openocd/code openocd
@@ -166,6 +172,13 @@ not have to) be disregarded if all conditions listed below are met:
@section browsing Browsing Patches
All OpenOCD patches can be reviewed here.
+
+@section reviewing Reviewing Patches
+From the main Review
+page select the patch you want to review and click on that patch. On the
+appearing page select the download method (top right). Apply the
+patch. After building and testing you can leave a note with the "Reply"
+button and mark the patch with -1, 0 and +1.
*/
/** @file
This file contains the @ref patchguide page.