X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=blobdiff_plain;f=PATCHES;h=74a76fdb4deed549058e56fb979c4c0722dc8779;hp=8b88ecf70c4e020bcab57b208e8768e36a999111;hb=747d6f22868dd87cb54341cc22d9eb3687039735;hpb=8737be6ab71f98afae75a57349fbfd506f53e193 diff --git a/PATCHES b/PATCHES index 8b88ecf70c..74a76fdb4d 100644 --- a/PATCHES +++ b/PATCHES @@ -1,28 +1,47 @@ -Please mail patches to: - -openocd-development@lists.berlios.de - -The patch should be against svn trunk using an SVN -diff. - -Attach the patch to the email as a .txt file and -also write a short change log entry that maintainers -can copy and paste into the commit message - -Add yourself to the GPL copyright for non-trivial changes. - -To create a patch from the command line: - -svn diff >mypatch.txt - -http://svnbook.red-bean.com/en/1.0/re09.html - -NB! remember to use "svn add" on new files first! - -http://svnbook.red-bean.com/en/1.0/re01.html - - - -If you have a decent SVN GUI, then that should be -able to create and apply patches as well... - \ No newline at end of file +// This file is part of the Doxygen Developer Manual +/** @page patchguide Patch Guidelines + +Please mail patches to: @par + openocd-development@lists.berlios.de + +Note that you can't send patches to that list unless +you're a member, despite what the list info page says. + +@section Patch Guidelines in a Nutshell + +Your patches should be against git mainline. Submit output +of "git diff"; equivalently, quilt patches are OK. + +It should be a "good patch": focus it on a single +issue, and make it be easily reviewable. Don't make +it so large that it's hard to review; split large +patches into smaller ones. (That can also help +track down bugs later on.) All patches should +be "clean", which includes preserving the existing +coding style and updating documentation as needed.j + +Attach the patch to the email as a .txt file and +also write a short change log entry that maintainers +can copy and paste into the commit message + +Say if it's a bugfix (describe the bug) or a new +feature. Don't expect patches to merge immediately +for the next release. Be ready to rework patches +in response to feedback. + +Add yourself to the GPL copyright for non-trivial changes. + +To create a patch from the command line: +@code + git diff >mypatch.txt +@endcode + +@section More Information on Patching + +The @ref primerpatches provides a more complete guide to creating, +managing, and contributing patches to the OpenOCD project. + + */ +/** @file +This file contains the @ref patchguide page. +*/