X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=blobdiff_plain;f=src%2Fjtag%2Fdrivers%2Fjlink.c;h=40665c3e788e3d47c7d6963fafece1a7330dfb38;hp=871bf24c613ef8be43d5b4bd3ff1053ad1562600;hb=fb9277191b715566c82b633a474a5c7c78fcfe1a;hpb=67332532194b16b99f0535a41b4179ca5df349b0;ds=sidebyside diff --git a/src/jtag/drivers/jlink.c b/src/jtag/drivers/jlink.c index 871bf24c61..40665c3e78 100644 --- a/src/jtag/drivers/jlink.c +++ b/src/jtag/drivers/jlink.c @@ -47,16 +47,12 @@ * pid = ( usb_address > 0x4) ? 0x0101 : (0x101 + usb_address) */ -#define JLINK_OB_PID 0x0105 +#define JLINK_USB_INTERFACE_CLASS 0xff +#define JLINK_USB_INTERFACE_SUBCLASS 0xff +#define JLINK_USB_INTERFACE_PROTOCOL 0xff -#define JLINK_WRITE_ENDPOINT 0x02 -#define JLINK_READ_ENDPOINT 0x81 - -#define JLINK_OB_WRITE_ENDPOINT 0x06 -#define JLINK_OB_READ_ENDPOINT 0x85 - -static unsigned int jlink_write_ep = JLINK_WRITE_ENDPOINT; -static unsigned int jlink_read_ep = JLINK_READ_ENDPOINT; +static unsigned int jlink_write_ep; +static unsigned int jlink_read_ep; static unsigned int jlink_hw_jtag_version = 2; #define JLINK_USB_TIMEOUT 1000 @@ -81,6 +77,7 @@ static uint8_t usb_out_buffer[JLINK_OUT_BUFFER_SIZE]; #define EMU_CMD_SET_SPEED 0x05 #define EMU_CMD_GET_STATE 0x07 #define EMU_CMD_SET_KS_POWER 0x08 +#define EMU_CMD_REGISTER 0x09 #define EMU_CMD_GET_SPEEDS 0xc0 #define EMU_CMD_GET_HW_INFO 0xc1 #define EMU_CMD_GET_COUNTERS 0xc2 @@ -116,6 +113,10 @@ static uint8_t usb_out_buffer[JLINK_OUT_BUFFER_SIZE]; #define EMU_CMD_WRITE_MEM_ARM79 0xf7 #define EMU_CMD_READ_MEM_ARM79 0xf8 +/* Register subcommands */ +#define REG_CMD_REGISTER 100 +#define REG_CMD_UNREGISTER 101 + /* bits return from EMU_CMD_GET_CAPS */ #define EMU_CAP_RESERVED_1 0 #define EMU_CAP_GET_HW_VERSION 1 @@ -150,7 +151,7 @@ static uint8_t usb_out_buffer[JLINK_OUT_BUFFER_SIZE]; #define EMU_CAP_RAWTRACE 30 #define EMU_CAP_RESERVED_3 31 -static char *jlink_cap_str[] = { +static const char * const jlink_cap_str[] = { "Always 1.", "Supports command EMU_CMD_GET_HARDWARE_VERSION", "Supports command EMU_CMD_WRITE_DCC", @@ -189,19 +190,14 @@ static char *jlink_cap_str[] = { #define JLINK_MAX_SPEED 12000 /* J-Link hardware versions */ -#define JLINK_HW_TYPE_JLINK 0 -#define JLINK_HW_TYPE_JTRACE 1 -#define JLINK_HW_TYPE_FLASHER 2 -#define JLINK_HW_TYPE_JLINK_PRO 3 -#define JLINK_HW_TYPE_MAX 4 - -static char *jlink_hw_type_str[] = { - "J-Link", - "J-Trace", - "Flasher", - "J-Link Pro", -}; - +#define JLINK_HW_TYPE_JLINK 0 +#define JLINK_HW_TYPE_JTRACE 1 +#define JLINK_HW_TYPE_FLASHER 2 +#define JLINK_HW_TYPE_JLINK_PRO 3 +#define JLINK_HW_TYPE_JLINK_LITE_ADI 5 +#define JLINK_HW_TYPE_LPCLINK2 18 + +/* Interface selection */ #define JLINK_TIF_JTAG 0 #define JLINK_TIF_SWD 1 #define JLINK_SWD_DIR_IN 0 @@ -260,6 +256,8 @@ static struct jlink *jlink_handle; static uint16_t vids[] = { 0x1366, 0x1366, 0x1366, 0x1366, 0x1366, 0 }; static uint16_t pids[] = { 0x0101, 0x0102, 0x0103, 0x0104, 0x0105, 0 }; +static char *jlink_serial; + static uint32_t jlink_caps; static uint32_t jlink_hw_type; @@ -434,6 +432,41 @@ static int jlink_khz(int khz, int *jtag_speed) return ERROR_OK; } +static int jlink_register(void) +{ + int result; + usb_out_buffer[0] = EMU_CMD_REGISTER; + usb_out_buffer[1] = REG_CMD_REGISTER; + /* 2 - 11 is "additional parameter", + * 12 - 13 is connection handle, zero initially */ + memset(&usb_out_buffer[2], 0, 10 + 2); + + result = jlink_usb_write(jlink_handle, 14); + if (result != 14) { + LOG_ERROR("J-Link register write failed (%d)", result); + return ERROR_JTAG_DEVICE_ERROR; + } + + /* Returns: + * 0 - 1 connection handle, + * 2 - 3 number of information entities, + * 4 - 5 size of a single information struct, + * 6 - 7 number of additional bytes, + * 8 - ... reply data + * + * Try to read the whole USB bulk packet + */ + result = jtag_libusb_bulk_read(jlink_handle->usb_handle, jlink_read_ep, + (char *)usb_in_buffer, sizeof(usb_in_buffer), + JLINK_USB_TIMEOUT); + if (!result) { + LOG_ERROR("J-Link register read failed (0 bytes received)"); + return ERROR_JTAG_DEVICE_ERROR; + } + + return ERROR_OK; +} + /* * select transport interface * @@ -507,28 +540,6 @@ static int jlink_init(void) return ERROR_JTAG_INIT_FAILED; } - /* - * The next three instructions were added after discovering a problem - * while using an oscilloscope. - * For the V8 SAM-ICE dongle (and likely other j-link device variants), - * the reset line to the target microprocessor was found to cycle only - * intermittently during emulator startup (even after encountering the - * downstream reset instruction later in the code). - * This was found to create two issues: - * 1) In general it is a bad practice to not reset a CPU to a known - * state when starting an emulator and - * 2) something critical happens inside the dongle when it does the - * first read following a new USB session. - * Keeping the processor in reset during the first read collecting - * version information seems to prevent errant - * "J-Link command EMU_CMD_VERSION failed" issues. - */ - - LOG_INFO("J-Link initialization started / target CPU reset initiated"); - jlink_simple_command(EMU_CMD_HW_TRST0); - jlink_simple_command(EMU_CMD_HW_RESET0); - usleep(1000); - jlink_hw_jtag_version = 2; if (jlink_get_version_info() == ERROR_OK) { @@ -536,6 +547,10 @@ static int jlink_init(void) jlink_get_status(); } + /* Registration is sometimes necessary for SWD to work */ + if (jlink_caps & (1<= JLINK_HW_TYPE_MAX) - LOG_INFO("J-Link hw type uknown 0x%" PRIx32, jlink_hw_type); - else - LOG_INFO("J-Link hw type %s", jlink_hw_type_str[jlink_hw_type]); + switch (jlink_hw_type) { + case JLINK_HW_TYPE_JLINK: + LOG_INFO("J-Link hw type J-Link"); + break; + case JLINK_HW_TYPE_JTRACE: + LOG_INFO("J-Link hw type J-Trace"); + break; + case JLINK_HW_TYPE_FLASHER: + LOG_INFO("J-Link hw type Flasher"); + break; + case JLINK_HW_TYPE_JLINK_PRO: + LOG_INFO("J-Link hw type J-Link Pro"); + break; + case JLINK_HW_TYPE_JLINK_LITE_ADI: + LOG_INFO("J-Link hw type J-Link Lite-ADI"); + break; + case JLINK_HW_TYPE_LPCLINK2: + LOG_INFO("J-Link hw type J-Link on LPC-Link2"); + break; + default: + LOG_INFO("J-Link hw type unknown 0x%" PRIx32, jlink_hw_type); + break; + } } if (jlink_caps & (1 << EMU_CAP_GET_MAX_BLOCK_SIZE)) { @@ -991,6 +1021,19 @@ COMMAND_HANDLER(jlink_pid_command) return ERROR_OK; } +COMMAND_HANDLER(jlink_serial_command) +{ + if (CMD_ARGC != 1) { + LOG_ERROR("Need exactly one argument to jlink_serial"); + return ERROR_FAIL; + } + if (jlink_serial) + free(jlink_serial); + jlink_serial = strdup(CMD_ARGV[0]); + + return ERROR_OK; +} + COMMAND_HANDLER(jlink_handle_jlink_info_command) { if (jlink_get_version_info() == ERROR_OK) { @@ -1307,6 +1350,12 @@ static const struct command_registration jlink_subcommand_handlers[] = { .mode = COMMAND_CONFIG, .help = "set the pid of the interface we want to use", }, + { + .name = "serial", + .handler = &jlink_serial_command, + .mode = COMMAND_CONFIG, + .help = "set the serial number of the J-Link adapter we want to use" + }, COMMAND_REGISTRATION_DONE }; @@ -1343,7 +1392,7 @@ static void jlink_swd_read_reg(struct adiv5_dap *dap, uint8_t cmd, uint32_t *val static int_least32_t jlink_swd_frequency(struct adiv5_dap *dap, int_least32_t hz) { if (hz > 0) - jlink_speed(hz); + jlink_speed(hz / 1000); return hz; } @@ -1641,9 +1690,9 @@ static int jlink_swd_run_queue(struct adiv5_dap *dap) int ack = buf_get_u32(usb_in_buffer, pending_scan_results_buffer[i].first, 3); if (ack != SWD_ACK_OK) { - LOG_ERROR("SWD ack not OK: %d %s", ack, + LOG_DEBUG("SWD ack not OK: %d %s", ack, ack == SWD_ACK_WAIT ? "WAIT" : ack == SWD_ACK_FAULT ? "FAULT" : "JUNK"); - queued_retval = ack; + queued_retval = ack == SWD_ACK_WAIT ? ERROR_WAIT : ERROR_FAIL; goto skip; } else if (pending_scan_results_buffer[i].length) { uint32_t data = buf_get_u32(usb_in_buffer, 3 + pending_scan_results_buffer[i].first, 32); @@ -1716,7 +1765,7 @@ static void jlink_swd_queue_cmd(struct adiv5_dap *dap, uint8_t cmd, uint32_t *ds static struct jlink *jlink_usb_open() { struct jtag_libusb_device_handle *devh; - if (jtag_libusb_open(vids, pids, &devh) != ERROR_OK) + if (jtag_libusb_open(vids, pids, jlink_serial, &devh) != ERROR_OK) return NULL; /* BE ***VERY CAREFUL*** ABOUT MAKING CHANGES IN THIS @@ -1730,7 +1779,15 @@ static struct jlink *jlink_usb_open() * committing them! */ -#if IS_WIN32 == 0 +/* This entire block can probably be removed. It was a workaround for + * libusb0.1 and old JLink firmware. It has already be removed for + * windows and causing problems (LPC Link-2 with JLink firmware) on + * Linux with libusb1.0. + * + * However, for now the behavior will be left unchanged for non-windows + * platforms using libusb0.1 due to lack of testing. + */ +#if IS_WIN32 == 0 && HAVE_LIBUSB1 == 0 jtag_libusb_reset_device(devh); @@ -1740,7 +1797,7 @@ static struct jlink *jlink_usb_open() /* reopen jlink after usb_reset * on win32 this may take a second or two to re-enumerate */ int retval; - while ((retval = jtag_libusb_open(vids, pids, &devh)) != ERROR_OK) { + while ((retval = jtag_libusb_open(vids, pids, jlink_serial, &devh)) != ERROR_OK) { usleep(1000); timeout--; if (!timeout) @@ -1752,29 +1809,15 @@ static struct jlink *jlink_usb_open() #endif - /* usb_set_configuration required under win32 */ - struct jtag_libusb_device *udev = jtag_libusb_get_device(devh); + /* usb_set_configuration is only required under win32 + * with libusb 0.1 and libusb0.sys. For libusb 1.0 it is a no-op + * since the configuration is already set. */ jtag_libusb_set_configuration(devh, 0); - jtag_libusb_claim_interface(devh, 0); - -#if 0 - /* - * This makes problems under Mac OS X. And is not needed - * under Windows. Hopefully this will not break a linux build - */ - usb_set_altinterface(result->usb_handle, 0); -#endif - - /* Use the OB endpoints if the JLink we matched is a Jlink-OB adapter */ - uint16_t matched_pid; - if (jtag_libusb_get_pid(udev, &matched_pid) == ERROR_OK) { - if (matched_pid == JLINK_OB_PID) { - jlink_read_ep = JLINK_OB_WRITE_ENDPOINT; - jlink_write_ep = JLINK_OB_READ_ENDPOINT; - } - } - jtag_libusb_get_endpoints(udev, &jlink_read_ep, &jlink_write_ep); + jtag_libusb_choose_interface(devh, &jlink_read_ep, &jlink_write_ep, + JLINK_USB_INTERFACE_CLASS, + JLINK_USB_INTERFACE_SUBCLASS, + JLINK_USB_INTERFACE_PROTOCOL); struct jlink *result = malloc(sizeof(struct jlink)); result->usb_handle = devh;