X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=blobdiff_plain;f=src%2Frtos%2Frtos.c;h=735c1065b576ccde05586e6f00c1c859ec1d3467;hp=61fc7936ff20f4a0f3f0c173e27e8ccb05baf731;hb=03410e92dae6efbb2dc474fb7556117cc60c3f82;hpb=b5c616b90ec3e2e75d48dc6765b06a86ca44e05f diff --git a/src/rtos/rtos.c b/src/rtos/rtos.c index 61fc7936ff..735c1065b5 100644 --- a/src/rtos/rtos.c +++ b/src/rtos/rtos.c @@ -15,7 +15,7 @@ * You should have received a copy of the GNU General Public License * * along with this program; if not, write to the * * Free Software Foundation, Inc., * - * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. * + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. * ***************************************************************************/ #ifdef HAVE_CONFIG_H @@ -25,16 +25,16 @@ #include "rtos.h" #include "target/target.h" #include "helper/log.h" +#include "helper/binarybuffer.h" #include "server/gdb_server.h" -static void hex_to_str(char *dst, char *hex_src); - /* RTOSs */ extern struct rtos_type FreeRTOS_rtos; extern struct rtos_type ThreadX_rtos; extern struct rtos_type eCos_rtos; extern struct rtos_type Linux_os; extern struct rtos_type ChibiOS_rtos; +extern struct rtos_type embKernel_rtos; static struct rtos_type *rtos_types[] = { &ThreadX_rtos, @@ -42,10 +42,11 @@ static struct rtos_type *rtos_types[] = { &eCos_rtos, &Linux_os, &ChibiOS_rtos, + &embKernel_rtos, NULL }; -int rtos_thread_packet(struct connection *connection, char *packet, int packet_size); +int rtos_thread_packet(struct connection *connection, const char *packet, int packet_size); int rtos_smp_init(struct target *target) { @@ -137,7 +138,7 @@ int rtos_create(Jim_GetOptInfo *goi, struct target *target) return JIM_ERR; } -int gdb_thread_packet(struct connection *connection, char *packet, int packet_size) +int gdb_thread_packet(struct connection *connection, char const *packet, int packet_size) { struct target *target = get_target_from_connection(connection); if (target->rtos == NULL) @@ -146,7 +147,7 @@ int gdb_thread_packet(struct connection *connection, char *packet, int packet_si return target->rtos->gdb_thread_packet(connection, packet, packet_size); } -static char *next_symbol(struct rtos *os, char *cur_symbol, uint64_t cur_addr) +static const char *next_symbol(struct rtos *os, char *cur_symbol, uint64_t cur_addr) { symbol_table_elem_t *s; @@ -185,12 +186,13 @@ static char *next_symbol(struct rtos *os, char *cur_symbol, uint64_t cur_addr) * * rtos_qsymbol() returns 1 if an RTOS has been detected, or 0 otherwise. */ -int rtos_qsymbol(struct connection *connection, char *packet, int packet_size) +int rtos_qsymbol(struct connection *connection, char const *packet, int packet_size) { int rtos_detected = 0; - uint64_t addr; + uint64_t addr = 0; size_t reply_len; - char reply[GDB_BUFFER_SIZE], cur_sym[GDB_BUFFER_SIZE / 2] = "", *next_sym; + char reply[GDB_BUFFER_SIZE], cur_sym[GDB_BUFFER_SIZE / 2] = ""; + const char *next_sym; struct target *target = get_target_from_connection(connection); struct rtos *os = target->rtos; @@ -200,7 +202,8 @@ int rtos_qsymbol(struct connection *connection, char *packet, int packet_size) goto done; /* Decode any symbol name in the packet*/ - hex_to_str(cur_sym, strchr(packet + 8, ':') + 1); + int len = unhexify(cur_sym, strchr(packet + 8, ':') + 1, strlen(strchr(packet + 8, ':') + 1)); + cur_sym[len] = 0; if ((strcmp(packet, "qSymbol::") != 0) && /* GDB is not offering symbol lookup for the first time */ (!sscanf(packet, "qSymbol:%" SCNx64 ":", &addr))) { /* GDB did not found an address for a symbol */ @@ -210,12 +213,13 @@ int rtos_qsymbol(struct connection *connection, char *packet, int packet_size) goto done; } else { /* Autodetecting RTOS - try next RTOS */ - if (!rtos_try_next(target)) + if (!rtos_try_next(target)) { + LOG_WARNING("No RTOS could be auto-detected!"); goto done; + } /* Next RTOS selected - invalidate current symbol */ cur_sym[0] = '\x00'; - } } next_sym = next_symbol(os, cur_sym, addr); @@ -229,7 +233,7 @@ int rtos_qsymbol(struct connection *connection, char *packet, int packet_size) } if (os->type->detect_rtos(target)) { - LOG_OUTPUT("Auto-detected RTOS: %s\r\n", os->type->name); + LOG_INFO("Auto-detected RTOS: %s", os->type->name); rtos_detected = 1; goto done; } else { @@ -239,19 +243,19 @@ int rtos_qsymbol(struct connection *connection, char *packet, int packet_size) } if (8 + (strlen(next_sym) * 2) + 1 > sizeof(reply)) { - LOG_OUTPUT("ERROR: RTOS symbol '%s' name is too long for GDB!", next_sym); + LOG_ERROR("ERROR: RTOS symbol '%s' name is too long for GDB!", next_sym); goto done; } - reply_len = sprintf(reply, "qSymbol:"); - reply_len += str_to_hex(reply + reply_len, next_sym); + reply_len = snprintf(reply, sizeof(reply), "qSymbol:"); + reply_len += hexify(reply + reply_len, next_sym, 0, sizeof(reply) - reply_len); done: gdb_put_packet(connection, reply, reply_len); return rtos_detected; } -int rtos_thread_packet(struct connection *connection, char *packet, int packet_size) +int rtos_thread_packet(struct connection *connection, char const *packet, int packet_size) { struct target *target = get_target_from_connection(connection); @@ -286,7 +290,7 @@ int rtos_thread_packet(struct connection *connection, char *packet, int packet_s if (detail->extra_info_str != NULL) str_size += strlen(detail->extra_info_str); - char *tmp_str = (char *) malloc(str_size + 7); + char *tmp_str = malloc(str_size + 7); char *tmp_str_ptr = tmp_str; if (detail->display_str != NULL) @@ -306,10 +310,10 @@ int rtos_thread_packet(struct connection *connection, char *packet, int packet_s assert(strlen(tmp_str) == (size_t) (tmp_str_ptr - tmp_str)); - char *hex_str = (char *) malloc(strlen(tmp_str)*2 + 1); - str_to_hex(hex_str, tmp_str); + char *hex_str = malloc(strlen(tmp_str) * 2 + 1); + int pkt_len = hexify(hex_str, tmp_str, 0, strlen(tmp_str) * 2 + 1); - gdb_put_packet(connection, hex_str, strlen(hex_str)); + gdb_put_packet(connection, hex_str, pkt_len); free(hex_str); free(tmp_str); return ERROR_OK; @@ -326,21 +330,22 @@ int rtos_thread_packet(struct connection *connection, char *packet, int packet_s return ERROR_OK; } else if (strncmp(packet, "qfThreadInfo", 12) == 0) { int i; - if ((target->rtos != NULL) && (target->rtos->thread_count != 0)) { - - char *out_str = (char *) malloc(17 * target->rtos->thread_count + 5); - char *tmp_str = out_str; - tmp_str += sprintf(tmp_str, "m"); - for (i = 0; i < target->rtos->thread_count; i++) { - if (i != 0) - tmp_str += sprintf(tmp_str, ","); - tmp_str += sprintf(tmp_str, "%016" PRIx64, - target->rtos->thread_details[i].threadid); + if (target->rtos != NULL) { + if (target->rtos->thread_count == 0) { + gdb_put_packet(connection, "l", 1); + } else { + /*thread id are 16 char +1 for ',' */ + char *out_str = malloc(17 * target->rtos->thread_count + 1); + char *tmp_str = out_str; + for (i = 0; i < target->rtos->thread_count; i++) { + tmp_str += sprintf(tmp_str, "%c%016" PRIx64, i == 0 ? 'm' : ',', + target->rtos->thread_details[i].threadid); + } + gdb_put_packet(connection, out_str, strlen(out_str)); + free(out_str); } - tmp_str[0] = 0; - gdb_put_packet(connection, out_str, strlen(out_str)); } else - gdb_put_packet(connection, "", 0); + gdb_put_packet(connection, "l", 1); return ERROR_OK; } else if (strncmp(packet, "qsThreadInfo", 12) == 0) { @@ -429,18 +434,19 @@ int rtos_generic_stack_read(struct target *target, int retval; if (stack_ptr == 0) { - LOG_OUTPUT("Error: null stack pointer in thread\r\n"); + LOG_ERROR("Error: null stack pointer in thread"); return -5; } /* Read the stack */ - uint8_t *stack_data = (uint8_t *) malloc(stacking->stack_registers_size); + uint8_t *stack_data = malloc(stacking->stack_registers_size); uint32_t address = stack_ptr; if (stacking->stack_growth_direction == 1) address -= stacking->stack_registers_size; retval = target_read_buffer(target, address, stacking->stack_registers_size, stack_data); if (retval != ERROR_OK) { - LOG_OUTPUT("Error reading stack frame from FreeRTOS thread\r\n"); + free(stack_data); + LOG_ERROR("Error reading stack frame from thread"); return retval; } #if 0 @@ -451,7 +457,7 @@ int rtos_generic_stack_read(struct target *target, #endif for (i = 0; i < stacking->num_output_registers; i++) list_size += stacking->register_offsets[i].width_bits/8; - *hex_reg_list = (char *)malloc(list_size*2 + 1); + *hex_reg_list = malloc(list_size*2 + 1); tmp_str_ptr = *hex_reg_list; new_stack_ptr = stack_ptr - stacking->stack_growth_direction * stacking->stack_registers_size; @@ -474,6 +480,7 @@ int rtos_generic_stack_read(struct target *target, stack_data[stacking->register_offsets[i].offset + j]); } } + free(stack_data); /* LOG_OUTPUT("Output register string: %s\r\n", *hex_reg_list); */ return ERROR_OK; } @@ -501,42 +508,26 @@ int rtos_try_next(struct target *target) return 1; } -static void hex_to_str(char *dst, char *hex_src) -{ - int src_pos = 0; - int dst_pos = 0; - - while (hex_src[src_pos] != '\x00') { - char hex_char = hex_src[src_pos]; - char hex_digit_val = - (hex_char >= - 'a') ? hex_char-'a'+ - 10 : (hex_char >= 'A') ? hex_char-'A'+10 : hex_char-'0'; - if (0 == (src_pos & 0x01)) { - dst[dst_pos] = hex_digit_val; - dst[dst_pos+1] = 0; - } else { - ((unsigned char *)dst)[dst_pos] <<= 4; - ((unsigned char *)dst)[dst_pos] += hex_digit_val; - dst_pos++; - } - src_pos++; - } - -} - -int str_to_hex(char *hex_dst, char *src) -{ - char *posptr = hex_dst; - unsigned i; - for (i = 0; i < strlen(src); i++) - posptr += sprintf(posptr, "%02x", (unsigned char)src[i]); - return posptr - hex_dst; -} - int rtos_update_threads(struct target *target) { if ((target->rtos != NULL) && (target->rtos->type != NULL)) target->rtos->type->update_threads(target->rtos); return ERROR_OK; } + +void rtos_free_threadlist(struct rtos *rtos) +{ + if (rtos->thread_details) { + int j; + + for (j = 0; j < rtos->thread_count; j++) { + struct thread_detail *current_thread = &rtos->thread_details[j]; + free(current_thread->display_str); + free(current_thread->thread_name_str); + free(current_thread->extra_info_str); + } + free(rtos->thread_details); + rtos->thread_details = NULL; + rtos->thread_count = 0; + } +}