X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=blobdiff_plain;f=src%2Ftarget%2Fbreakpoints.c;h=bbaff4e7565067c5136c9ed53637b396b48e3e11;hp=e722f67ef799e28baa00c170c142d3cca9729597;hb=HEAD;hpb=2c6d312ec9e1aec514e80b7c317ed93d72197ba2

diff --git a/src/target/breakpoints.c b/src/target/breakpoints.c
index e722f67ef7..c39a980570 100644
--- a/src/target/breakpoints.c
+++ b/src/target/breakpoints.c
@@ -1,25 +1,13 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+
 /***************************************************************************
  *   Copyright (C) 2005 by Dominic Rath                                    *
  *   Dominic.Rath@gmx.de                                                   *
  *                                                                         *
  *   Copyright (C) ST-Ericsson SA 2011                                     *
  *   michel.jaouen@stericsson.com : smp minimum support                    *
- *                                                                         *
- *   This program is free software; you can redistribute it and/or modify  *
- *   it under the terms of the GNU General Public License as published by  *
- *   the Free Software Foundation; either version 2 of the License, or     *
- *   (at your option) any later version.                                   *
- *                                                                         *
- *   This program is distributed in the hope that it will be useful,       *
- *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
- *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
- *   GNU General Public License for more details.                          *
- *                                                                         *
- *   You should have received a copy of the GNU General Public License     *
- *   along with this program; if not, write to the                         *
- *   Free Software Foundation, Inc.,                                       *
- *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
  ***************************************************************************/
+
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
@@ -27,44 +15,46 @@
 #include "target.h"
 #include <helper/log.h>
 #include "breakpoints.h"
+#include "smp.h"
 
+enum breakpoint_watchpoint {
+	BREAKPOINT,
+	WATCHPOINT,
+};
 
-static char *breakpoint_type_strings[] =
-{
+static const char * const breakpoint_type_strings[] = {
 	"hardware",
 	"software"
 };
 
-static char *watchpoint_rw_strings[] =
-{
+static const char * const watchpoint_rw_strings[] = {
 	"read",
 	"write",
 	"access"
 };
 
-// monotonic counter/id-number for breakpoints and watch points
+/* monotonic counter/id-number for breakpoints and watch points */
 static int bpwp_unique_id;
 
-int breakpoint_add_internal(struct target *target, uint32_t address, uint32_t length, enum breakpoint_type type)
+static int breakpoint_add_internal(struct target *target,
+	target_addr_t address,
+	uint32_t length,
+	enum breakpoint_type type)
 {
 	struct breakpoint *breakpoint = target->breakpoints;
 	struct breakpoint **breakpoint_p = &target->breakpoints;
-	char *reason;
+	const char *reason;
 	int retval;
-	int n;
 
-	n = 0;
-	while (breakpoint)
-	{
-		n++;
+	while (breakpoint) {
 		if (breakpoint->address == address) {
 			/* FIXME don't assume "same address" means "same
 			 * breakpoint" ... check all the parameters before
 			 * succeeding.
 			 */
-			LOG_DEBUG("Duplicate Breakpoint address: 0x%08" PRIx32 " (BP %d)",
-					address, breakpoint->unique_id);
-			return ERROR_OK;
+			LOG_TARGET_ERROR(target, "Duplicate Breakpoint address: " TARGET_ADDR_FMT " (BP %" PRIu32 ")",
+				address, breakpoint->unique_id);
+			return ERROR_TARGET_DUPLICATE_BREAKPOINT;
 		}
 		breakpoint_p = &breakpoint->next;
 		breakpoint = breakpoint->next;
@@ -75,59 +65,58 @@ int breakpoint_add_internal(struct target *target, uint32_t address, uint32_t le
 	(*breakpoint_p)->asid = 0;
 	(*breakpoint_p)->length = length;
 	(*breakpoint_p)->type = type;
-	(*breakpoint_p)->set = 0;
+	(*breakpoint_p)->is_set = false;
 	(*breakpoint_p)->orig_instr = malloc(length);
 	(*breakpoint_p)->next = NULL;
 	(*breakpoint_p)->unique_id = bpwp_unique_id++;
 
 	retval = target_add_breakpoint(target, *breakpoint_p);
 	switch (retval) {
-	case ERROR_OK:
-		break;
-	case ERROR_TARGET_RESOURCE_NOT_AVAILABLE:
-		reason = "resource not available";
-		goto fail;
-	case ERROR_TARGET_NOT_HALTED:
-		reason = "target running";
-		goto fail;
-	default:
-		reason = "unknown reason";
+		case ERROR_OK:
+			break;
+		case ERROR_TARGET_RESOURCE_NOT_AVAILABLE:
+			reason = "resource not available";
+			goto fail;
+		case ERROR_TARGET_NOT_HALTED:
+			reason = "target running";
+			goto fail;
+		default:
+			reason = "unknown reason";
 fail:
-		LOG_ERROR("can't add breakpoint: %s", reason);
-		free((*breakpoint_p)->orig_instr);
-		free(*breakpoint_p);
-		*breakpoint_p = NULL;
-		return retval;
+			LOG_TARGET_ERROR(target, "can't add breakpoint: %s", reason);
+			free((*breakpoint_p)->orig_instr);
+			free(*breakpoint_p);
+			*breakpoint_p = NULL;
+			return retval;
 	}
 
-	LOG_DEBUG("added %s breakpoint at 0x%8.8" PRIx32 " of length 0x%8.8x, (BPID: %d)",
-			breakpoint_type_strings[(*breakpoint_p)->type],
-			(*breakpoint_p)->address, (*breakpoint_p)->length,
-			(*breakpoint_p)->unique_id);
+	LOG_TARGET_DEBUG(target, "added %s breakpoint at " TARGET_ADDR_FMT
+			" of length 0x%8.8x, (BPID: %" PRIu32 ")",
+		breakpoint_type_strings[(*breakpoint_p)->type],
+		(*breakpoint_p)->address, (*breakpoint_p)->length,
+		(*breakpoint_p)->unique_id);
 
 	return ERROR_OK;
 }
 
-int context_breakpoint_add_internal(struct target *target, uint32_t asid, uint32_t length, enum breakpoint_type type)
+static int context_breakpoint_add_internal(struct target *target,
+	uint32_t asid,
+	uint32_t length,
+	enum breakpoint_type type)
 {
 	struct breakpoint *breakpoint = target->breakpoints;
 	struct breakpoint **breakpoint_p = &target->breakpoints;
 	int retval;
-	int n;
-
-	n = 0;
-	while (breakpoint)
-	{
-		n++;
-		if (breakpoint->asid == asid)
-		{
+
+	while (breakpoint) {
+		if (breakpoint->asid == asid) {
 			/* FIXME don't assume "same address" means "same
 			 * breakpoint" ... check all the parameters before
 			 * succeeding.
 			 */
-			LOG_DEBUG("Duplicate Breakpoint asid: 0x%08" PRIx32 " (BP %d)",
-					asid, breakpoint->unique_id);
-			return -1;
+			LOG_ERROR("Duplicate Breakpoint asid: 0x%08" PRIx32 " (BP %" PRIu32 ")",
+				asid, breakpoint->unique_id);
+			return ERROR_TARGET_DUPLICATE_BREAKPOINT;
 		}
 		breakpoint_p = &breakpoint->next;
 		breakpoint = breakpoint->next;
@@ -138,52 +127,50 @@ int context_breakpoint_add_internal(struct target *target, uint32_t asid, uint32
 	(*breakpoint_p)->asid = asid;
 	(*breakpoint_p)->length = length;
 	(*breakpoint_p)->type = type;
-	(*breakpoint_p)->set = 0;
+	(*breakpoint_p)->is_set = false;
 	(*breakpoint_p)->orig_instr = malloc(length);
 	(*breakpoint_p)->next = NULL;
 	(*breakpoint_p)->unique_id = bpwp_unique_id++;
 	retval = target_add_context_breakpoint(target, *breakpoint_p);
-	if (retval != ERROR_OK)
-	{
-		LOG_ERROR("could not add breakpoint");
+	if (retval != ERROR_OK) {
+		LOG_TARGET_ERROR(target, "could not add breakpoint");
 		free((*breakpoint_p)->orig_instr);
 		free(*breakpoint_p);
 		*breakpoint_p = NULL;
 		return retval;
 	}
 
-	LOG_DEBUG("added %s Context breakpoint at 0x%8.8" PRIx32 " of length 0x%8.8x, (BPID: %d)",
-			breakpoint_type_strings[(*breakpoint_p)->type],
-			(*breakpoint_p)->asid, (*breakpoint_p)->length,
-			(*breakpoint_p)->unique_id);
+	LOG_TARGET_DEBUG(target, "added %s Context breakpoint at 0x%8.8" PRIx32 " of length 0x%8.8x, (BPID: %" PRIu32 ")",
+		breakpoint_type_strings[(*breakpoint_p)->type],
+		(*breakpoint_p)->asid, (*breakpoint_p)->length,
+		(*breakpoint_p)->unique_id);
 
 	return ERROR_OK;
 }
 
-int hybrid_breakpoint_add_internal(struct target *target, uint32_t address, uint32_t asid, uint32_t length, enum breakpoint_type type)
+static int hybrid_breakpoint_add_internal(struct target *target,
+	target_addr_t address,
+	uint32_t asid,
+	uint32_t length,
+	enum breakpoint_type type)
 {
 	struct breakpoint *breakpoint = target->breakpoints;
 	struct breakpoint **breakpoint_p = &target->breakpoints;
 	int retval;
-	int n;
-	n = 0;
-	while (breakpoint)
-	{
-		n++;
+
+	while (breakpoint) {
 		if ((breakpoint->asid == asid) && (breakpoint->address == address)) {
 			/* FIXME don't assume "same address" means "same
 			 * breakpoint" ... check all the parameters before
 			 * succeeding.
 			 */
-			LOG_DEBUG("Duplicate Hybrid Breakpoint asid: 0x%08" PRIx32 " (BP %d)",
-					asid, breakpoint->unique_id);
-			return -1;
-		}
-		else if ((breakpoint->address == address) && (breakpoint->asid == 0))
-		{
-			LOG_DEBUG("Duplicate Breakpoint IVA: 0x%08" PRIx32 " (BP %d)",
-					address, breakpoint->unique_id);
-			return -1;
+			LOG_TARGET_ERROR(target, "Duplicate Hybrid Breakpoint asid: 0x%08" PRIx32 " (BP %" PRIu32 ")",
+				asid, breakpoint->unique_id);
+			return ERROR_TARGET_DUPLICATE_BREAKPOINT;
+		} else if ((breakpoint->address == address) && (breakpoint->asid == 0)) {
+			LOG_TARGET_ERROR(target, "Duplicate Breakpoint IVA: " TARGET_ADDR_FMT " (BP %" PRIu32 ")",
+				address, breakpoint->unique_id);
+			return ERROR_TARGET_DUPLICATE_BREAKPOINT;
 
 		}
 		breakpoint_p = &breakpoint->next;
@@ -194,202 +181,316 @@ int hybrid_breakpoint_add_internal(struct target *target, uint32_t address, uint
 	(*breakpoint_p)->asid = asid;
 	(*breakpoint_p)->length = length;
 	(*breakpoint_p)->type = type;
-	(*breakpoint_p)->set = 0;
+	(*breakpoint_p)->is_set = false;
 	(*breakpoint_p)->orig_instr = malloc(length);
 	(*breakpoint_p)->next = NULL;
 	(*breakpoint_p)->unique_id = bpwp_unique_id++;
 
 
 	retval = target_add_hybrid_breakpoint(target, *breakpoint_p);
-	if (retval != ERROR_OK)
-	{
-		LOG_ERROR("could not add breakpoint");
+	if (retval != ERROR_OK) {
+		LOG_TARGET_ERROR(target, "could not add breakpoint");
 		free((*breakpoint_p)->orig_instr);
 		free(*breakpoint_p);
 		*breakpoint_p = NULL;
 		return retval;
 	}
-	LOG_DEBUG("added %s Hybrid breakpoint at address 0x%8.8" PRIx32 " of length 0x%8.8x, (BPID: %d)",
-			breakpoint_type_strings[(*breakpoint_p)->type],
-			(*breakpoint_p)->address, (*breakpoint_p)->length,
-			(*breakpoint_p)->unique_id);
+	LOG_TARGET_DEBUG(target,
+		"added %s Hybrid breakpoint at address " TARGET_ADDR_FMT " of length 0x%8.8x, (BPID: %" PRIu32 ")",
+		breakpoint_type_strings[(*breakpoint_p)->type],
+		(*breakpoint_p)->address,
+		(*breakpoint_p)->length,
+		(*breakpoint_p)->unique_id);
 
 	return ERROR_OK;
 }
 
-
-
-int breakpoint_add(struct target *target, uint32_t address, uint32_t length, enum breakpoint_type type)
+int breakpoint_add(struct target *target,
+	target_addr_t address,
+	uint32_t length,
+	enum breakpoint_type type)
 {
-
-	int retval = ERROR_OK;
-	if (target->smp)
-	{
+	if (target->smp) {
 		struct target_list *head;
-		struct target *curr;
-		head = target->head;
-		while(head != (struct target_list*)NULL)
-		{
-			curr = head->target;
-			retval = breakpoint_add_internal(curr, address,length, type);
-			if (retval != ERROR_OK) return retval;
-			head = head->next;
+
+		if (type == BKPT_SOFT) {
+			head = list_first_entry(target->smp_targets, struct target_list, lh);
+			return breakpoint_add_internal(head->target, address, length, type);
 		}
-		return retval;
-	}
-	else
-		return(breakpoint_add_internal(target, address, length, type));
 
+		foreach_smp_target(head, target->smp_targets) {
+			struct target *curr = head->target;
+			int retval = breakpoint_add_internal(curr, address, length, type);
+			if (retval != ERROR_OK)
+				return retval;
+		}
+
+		return ERROR_OK;
+	} else {
+		return breakpoint_add_internal(target, address, length, type);
+	}
 }
-int context_breakpoint_add(struct target *target, uint32_t asid, uint32_t length, enum breakpoint_type type)
-{
 
-	int retval = ERROR_OK;
-	if (target->smp)
-	{
+int context_breakpoint_add(struct target *target,
+	uint32_t asid,
+	uint32_t length,
+	enum breakpoint_type type)
+{
+	if (target->smp) {
 		struct target_list *head;
-		struct target *curr;
-		head = target->head;
-		while(head != (struct target_list*)NULL)
-		{
-			curr = head->target;
-			retval = context_breakpoint_add_internal(curr, asid,length, type);
-			if (retval != ERROR_OK) return retval;
-			head = head->next;
+
+		foreach_smp_target(head, target->smp_targets) {
+			struct target *curr = head->target;
+			int retval = context_breakpoint_add_internal(curr, asid, length, type);
+			if (retval != ERROR_OK)
+				return retval;
 		}
-		return retval;
-	}
-	else
-		return(context_breakpoint_add_internal(target, asid, length, type));
 
+		return ERROR_OK;
+	} else {
+		return context_breakpoint_add_internal(target, asid, length, type);
+	}
 }
-int hybrid_breakpoint_add(struct target *target, uint32_t address, uint32_t asid, uint32_t length, enum breakpoint_type type)
-{
 
-	int retval = ERROR_OK;
-	if (target->smp)
-	{
+int hybrid_breakpoint_add(struct target *target,
+	target_addr_t address,
+	uint32_t asid,
+	uint32_t length,
+	enum breakpoint_type type)
+{
+	if (target->smp) {
 		struct target_list *head;
-		struct target *curr;
-		head = target->head;
-		while(head != (struct target_list*)NULL)
-		{
-			curr = head->target;
-			retval = hybrid_breakpoint_add_internal(curr, address, asid, length, type);
-			if (retval != ERROR_OK) return retval;
-			head = head->next;
+
+		foreach_smp_target(head, target->smp_targets) {
+			struct target *curr = head->target;
+			int retval = hybrid_breakpoint_add_internal(curr, address, asid, length, type);
+			if (retval != ERROR_OK)
+				return retval;
 		}
-		return retval;
-	}
-	else
-		return(hybrid_breakpoint_add_internal(target, address, asid, length, type));
 
+		return ERROR_OK;
+	} else
+		return hybrid_breakpoint_add_internal(target, address, asid, length, type);
 }
 
 /* free up a breakpoint */
-static void breakpoint_free(struct target *target, struct breakpoint *breakpoint_to_remove)
+static int breakpoint_free(struct target *target, struct breakpoint *breakpoint_to_remove)
 {
 	struct breakpoint *breakpoint = target->breakpoints;
 	struct breakpoint **breakpoint_p = &target->breakpoints;
 	int retval;
 
-	while (breakpoint)
-	{
+	while (breakpoint) {
 		if (breakpoint == breakpoint_to_remove)
 			break;
 		breakpoint_p = &breakpoint->next;
 		breakpoint = breakpoint->next;
 	}
 
-	if (breakpoint == NULL)
-		return;
+	if (!breakpoint)
+		return ERROR_OK;
 
 	retval = target_remove_breakpoint(target, breakpoint);
+	if (retval != ERROR_OK) {
+		LOG_TARGET_ERROR(target, "could not remove breakpoint #%d on this target",
+						breakpoint->number);
+		return retval;
+	}
 
-	LOG_DEBUG("free BPID: %d --> %d", breakpoint->unique_id, retval);
+	LOG_TARGET_DEBUG(target, "free BPID: %" PRIu32 " --> %d", breakpoint->unique_id, retval);
 	(*breakpoint_p) = breakpoint->next;
 	free(breakpoint->orig_instr);
 	free(breakpoint);
+
+	return ERROR_OK;
 }
 
-void breakpoint_remove_internal(struct target *target, uint32_t address)
+static int breakpoint_remove_internal(struct target *target, target_addr_t address)
 {
 	struct breakpoint *breakpoint = target->breakpoints;
 
-	while (breakpoint)
-	{
-		if ((breakpoint->address == address) && (breakpoint->asid == 0))
-			break;
-		else if ((breakpoint->address == 0) && (breakpoint->asid == address))
-			break;
-		else if ((breakpoint->address == address) && (breakpoint->asid != 0))
+	while (breakpoint) {
+		if ((breakpoint->address == address) ||
+		    (breakpoint->address == 0 && breakpoint->asid == address))
 			break;
 		breakpoint = breakpoint->next;
 	}
 
-	if (breakpoint)
-	{
-		breakpoint_free(target, breakpoint);
+	if (breakpoint) {
+		return breakpoint_free(target, breakpoint);
+	} else {
+		return ERROR_BREAKPOINT_NOT_FOUND;
 	}
-	else
-	{
-		LOG_ERROR("no breakpoint at address 0x%8.8" PRIx32 " found", address);
+}
+
+static int breakpoint_remove_all_internal(struct target *target)
+{
+	LOG_TARGET_DEBUG(target, "Delete all breakpoints");
+
+	struct breakpoint *breakpoint = target->breakpoints;
+	int retval = ERROR_OK;
+
+	while (breakpoint) {
+		struct breakpoint *tmp = breakpoint;
+		breakpoint = breakpoint->next;
+		int status = breakpoint_free(target, tmp);
+		if (status != ERROR_OK)
+			retval = status;
 	}
+
+	return retval;
 }
-void breakpoint_remove(struct target *target, uint32_t address)
+
+int breakpoint_remove(struct target *target, target_addr_t address)
 {
-	if (target->smp)
-	{
+	int retval = ERROR_OK;
+	unsigned int num_found_breakpoints = 0;
+	if (target->smp) {
 		struct target_list *head;
-		struct target *curr;
-		head = target->head;
-		while(head != (struct target_list*)NULL)
-		{
-			curr = head->target;
-			breakpoint_remove_internal(curr, address);
-			head = head->next;
+
+		foreach_smp_target(head, target->smp_targets) {
+			struct target *curr = head->target;
+			int status = breakpoint_remove_internal(curr, address);
+
+			if (status != ERROR_BREAKPOINT_NOT_FOUND) {
+				num_found_breakpoints++;
+
+				if (status != ERROR_OK) {
+					LOG_TARGET_ERROR(curr, "failed to remove breakpoint at address " TARGET_ADDR_FMT, address);
+					retval = status;
+				}
+			}
+		}
+
+	} else {
+		retval = breakpoint_remove_internal(target, address);
+
+		if (retval != ERROR_BREAKPOINT_NOT_FOUND) {
+			num_found_breakpoints++;
+
+			if (retval != ERROR_OK)
+				LOG_TARGET_ERROR(target, "failed to remove breakpoint at address " TARGET_ADDR_FMT, address);
 		}
 	}
-	else  breakpoint_remove_internal(target, address);
+
+	if (num_found_breakpoints == 0) {
+		LOG_TARGET_ERROR(target, "no breakpoint at address " TARGET_ADDR_FMT " found", address);
+		return ERROR_BREAKPOINT_NOT_FOUND;
+	}
+
+	return retval;
 }
 
-void breakpoint_clear_target_internal(struct target *target)
+static int watchpoint_free(struct target *target, struct watchpoint *watchpoint_to_remove)
 {
-	struct breakpoint *breakpoint;
+	struct watchpoint *watchpoint = target->watchpoints;
+	struct watchpoint **watchpoint_p = &target->watchpoints;
+	int retval;
+
+	while (watchpoint) {
+		if (watchpoint == watchpoint_to_remove)
+			break;
+		watchpoint_p = &watchpoint->next;
+		watchpoint = watchpoint->next;
+	}
 
-	LOG_DEBUG("Delete all breakpoints for target: %s",
-			target_name(target));
-	while ((breakpoint = target->breakpoints) != NULL)
-	{
-		breakpoint_free(target, breakpoint);
+	if (!watchpoint)
+		return ERROR_OK;
+	retval = target_remove_watchpoint(target, watchpoint);
+	if (retval != ERROR_OK) {
+		LOG_TARGET_ERROR(target, "could not remove watchpoint #%d on this target",
+						 watchpoint->number);
+		return retval;
 	}
+
+	LOG_TARGET_DEBUG(target, "free WPID: %d --> %d", watchpoint->unique_id, retval);
+	(*watchpoint_p) = watchpoint->next;
+	free(watchpoint);
+
+	return ERROR_OK;
 }
 
-void breakpoint_clear_target(struct target *target)
+static int watchpoint_remove_all_internal(struct target *target)
 {
-	if (target->smp)
-	{
+	struct watchpoint *watchpoint = target->watchpoints;
+	int retval = ERROR_OK;
+
+	while (watchpoint) {
+		struct watchpoint *tmp = watchpoint;
+		watchpoint = watchpoint->next;
+		int status = watchpoint_free(target, tmp);
+		if (status != ERROR_OK)
+			retval = status;
+	}
+
+	return retval;
+}
+
+static int breakpoint_watchpoint_remove_all(struct target *target, enum breakpoint_watchpoint bp_wp)
+{
+	assert(bp_wp == BREAKPOINT || bp_wp == WATCHPOINT);
+	int retval = ERROR_OK;
+	if (target->smp) {
 		struct target_list *head;
-		struct target *curr;
-		head = target->head;
-		while(head != (struct target_list*)NULL)
-		{
-			curr = head->target;
-			breakpoint_clear_target_internal(curr);
-			head = head->next;
+
+		foreach_smp_target(head, target->smp_targets) {
+			struct target *curr = head->target;
+
+			int status = ERROR_OK;
+			if (bp_wp == BREAKPOINT)
+				status = breakpoint_remove_all_internal(curr);
+			else
+				status = watchpoint_remove_all_internal(curr);
+
+			if (status != ERROR_OK)
+				retval = status;
 		}
+	} else {
+		if (bp_wp == BREAKPOINT)
+			retval = breakpoint_remove_all_internal(target);
+		else
+			retval = watchpoint_remove_all_internal(target);
 	}
-	else breakpoint_clear_target_internal(target);
 
+	return retval;
 }
 
+int breakpoint_remove_all(struct target *target)
+{
+	return breakpoint_watchpoint_remove_all(target, BREAKPOINT);
+}
 
-struct breakpoint* breakpoint_find(struct target *target, uint32_t address)
+int watchpoint_remove_all(struct target *target)
+{
+	return breakpoint_watchpoint_remove_all(target, WATCHPOINT);
+}
+
+int breakpoint_clear_target(struct target *target)
+{
+	int retval = ERROR_OK;
+
+	if (target->smp) {
+		struct target_list *head;
+
+		foreach_smp_target(head, target->smp_targets) {
+			struct target *curr = head->target;
+			int status = breakpoint_remove_all_internal(curr);
+
+			if (status != ERROR_OK)
+				retval = status;
+		}
+	} else {
+		retval = breakpoint_remove_all_internal(target);
+	}
+
+	return retval;
+}
+
+struct breakpoint *breakpoint_find(struct target *target, target_addr_t address)
 {
 	struct breakpoint *breakpoint = target->breakpoints;
 
-	while (breakpoint)
-	{
+	while (breakpoint) {
 		if (breakpoint->address == address)
 			return breakpoint;
 		breakpoint = breakpoint->next;
@@ -398,24 +499,23 @@ struct breakpoint* breakpoint_find(struct target *target, uint32_t address)
 	return NULL;
 }
 
-int watchpoint_add(struct target *target, uint32_t address, uint32_t length,
-		enum watchpoint_rw rw, uint32_t value, uint32_t mask)
+static int watchpoint_add_internal(struct target *target, target_addr_t address,
+		uint32_t length, enum watchpoint_rw rw, uint64_t value, uint64_t mask)
 {
 	struct watchpoint *watchpoint = target->watchpoints;
 	struct watchpoint **watchpoint_p = &target->watchpoints;
 	int retval;
-	char *reason;
+	const char *reason;
 
-	while (watchpoint)
-	{
+	while (watchpoint) {
 		if (watchpoint->address == address) {
 			if (watchpoint->length != length
-					|| watchpoint->value != value
-					|| watchpoint->mask != mask
-					|| watchpoint->rw != rw) {
-				LOG_ERROR("address 0x%8.8" PRIx32
-						"already has watchpoint %d",
-						address, watchpoint->unique_id);
+				|| watchpoint->value != value
+				|| watchpoint->mask != mask
+				|| watchpoint->rw != rw) {
+				LOG_TARGET_ERROR(target, "address " TARGET_ADDR_FMT
+					" already has watchpoint %d",
+					address, watchpoint->unique_id);
 				return ERROR_FAIL;
 			}
 
@@ -436,86 +536,145 @@ int watchpoint_add(struct target *target, uint32_t address, uint32_t length,
 
 	retval = target_add_watchpoint(target, *watchpoint_p);
 	switch (retval) {
-	case ERROR_OK:
-		break;
-	case ERROR_TARGET_RESOURCE_NOT_AVAILABLE:
-		reason = "resource not available";
-		goto bye;
-	case ERROR_TARGET_NOT_HALTED:
-		reason = "target running";
-		goto bye;
-	default:
-		reason = "unrecognized error";
+		case ERROR_OK:
+			break;
+		case ERROR_TARGET_RESOURCE_NOT_AVAILABLE:
+			reason = "resource not available";
+			goto bye;
+		case ERROR_TARGET_NOT_HALTED:
+			reason = "target running";
+			goto bye;
+		default:
+			reason = "unrecognized error";
 bye:
-		LOG_ERROR("can't add %s watchpoint at 0x%8.8" PRIx32 ", %s",
+			LOG_TARGET_ERROR(target, "can't add %s watchpoint at " TARGET_ADDR_FMT ", %s",
 				watchpoint_rw_strings[(*watchpoint_p)->rw],
 				address, reason);
-		free (*watchpoint_p);
-		*watchpoint_p = NULL;
-		return retval;
+			free(*watchpoint_p);
+			*watchpoint_p = NULL;
+			return retval;
 	}
 
-	LOG_DEBUG("added %s watchpoint at 0x%8.8" PRIx32
+	LOG_TARGET_DEBUG(target, "added %s watchpoint at " TARGET_ADDR_FMT
 			" of length 0x%8.8" PRIx32 " (WPID: %d)",
-			watchpoint_rw_strings[(*watchpoint_p)->rw],
-			(*watchpoint_p)->address,
-			(*watchpoint_p)->length,
-			(*watchpoint_p)->unique_id);
+		watchpoint_rw_strings[(*watchpoint_p)->rw],
+		(*watchpoint_p)->address,
+		(*watchpoint_p)->length,
+		(*watchpoint_p)->unique_id);
 
 	return ERROR_OK;
 }
 
-static void watchpoint_free(struct target *target, struct watchpoint *watchpoint_to_remove)
+int watchpoint_add(struct target *target, target_addr_t address,
+		uint32_t length, enum watchpoint_rw rw, uint64_t value, uint64_t mask)
 {
-	struct watchpoint *watchpoint = target->watchpoints;
-	struct watchpoint **watchpoint_p = &target->watchpoints;
-	int retval;
+	if (target->smp) {
+		struct target_list *head;
 
-	while (watchpoint)
-	{
-		if (watchpoint == watchpoint_to_remove)
-			break;
-		watchpoint_p = &watchpoint->next;
-		watchpoint = watchpoint->next;
-	}
+		foreach_smp_target(head, target->smp_targets) {
+			struct target *curr = head->target;
+			int retval = watchpoint_add_internal(curr, address, length, rw, value, mask);
+			if (retval != ERROR_OK)
+				return retval;
+		}
 
-	if (watchpoint == NULL)
-		return;
-	retval = target_remove_watchpoint(target, watchpoint);
-	LOG_DEBUG("free WPID: %d --> %d", watchpoint->unique_id, retval);
-	(*watchpoint_p) = watchpoint->next;
-	free(watchpoint);
+		return ERROR_OK;
+	} else {
+		return watchpoint_add_internal(target, address, length, rw, value,
+				mask);
+	}
 }
 
-void watchpoint_remove(struct target *target, uint32_t address)
+static int watchpoint_remove_internal(struct target *target, target_addr_t address)
 {
 	struct watchpoint *watchpoint = target->watchpoints;
 
-	while (watchpoint)
-	{
+	while (watchpoint) {
 		if (watchpoint->address == address)
 			break;
 		watchpoint = watchpoint->next;
 	}
 
-	if (watchpoint)
-	{
-		watchpoint_free(target, watchpoint);
-	}
-	else
-	{
-		LOG_ERROR("no watchpoint at address 0x%8.8" PRIx32 " found", address);
+	if (watchpoint) {
+		return watchpoint_free(target, watchpoint);
+	} else {
+		return ERROR_WATCHPOINT_NOT_FOUND;
 	}
 }
 
-void watchpoint_clear_target(struct target *target)
+int watchpoint_remove(struct target *target, target_addr_t address)
 {
-	struct watchpoint *watchpoint;
+	int retval = ERROR_OK;
+	unsigned int num_found_watchpoints = 0;
+	if (target->smp) {
+		struct target_list *head;
+
+		foreach_smp_target(head, target->smp_targets) {
+			struct target *curr = head->target;
+			int status = watchpoint_remove_internal(curr, address);
+
+			if (status != ERROR_WATCHPOINT_NOT_FOUND) {
+				num_found_watchpoints++;
+
+				if (status != ERROR_OK) {
+					LOG_TARGET_ERROR(curr, "failed to remove watchpoint at address " TARGET_ADDR_FMT, address);
+					retval = status;
+				}
+			}
+		}
+	} else {
+		retval = watchpoint_remove_internal(target, address);
+
+		if (retval != ERROR_WATCHPOINT_NOT_FOUND) {
+			num_found_watchpoints++;
+
+			if (retval != ERROR_OK)
+				LOG_TARGET_ERROR(target, "failed to remove watchpoint at address " TARGET_ADDR_FMT, address);
+		}
+	}
 
+	if (num_found_watchpoints == 0) {
+		LOG_TARGET_ERROR(target, "no watchpoint at address " TARGET_ADDR_FMT " found", address);
+		return ERROR_WATCHPOINT_NOT_FOUND;
+	}
+
+	return retval;
+}
+
+int watchpoint_clear_target(struct target *target)
+{
 	LOG_DEBUG("Delete all watchpoints for target: %s",
-			target_name(target));
-	while ((watchpoint = target->watchpoints) != NULL)
-	{
-		watchpoint_free(target, watchpoint);
+		target_name(target));
+
+	struct watchpoint *watchpoint = target->watchpoints;
+	int retval = ERROR_OK;
+
+	while (watchpoint) {
+		struct watchpoint *tmp = watchpoint;
+		watchpoint = watchpoint->next;
+		int status = watchpoint_free(target, tmp);
+		if (status != ERROR_OK)
+			retval = status;
 	}
+	return retval;
+}
+
+int watchpoint_hit(struct target *target, enum watchpoint_rw *rw,
+		   target_addr_t *address)
+{
+	int retval;
+	struct watchpoint *hit_watchpoint;
+
+	retval = target_hit_watchpoint(target, &hit_watchpoint);
+	if (retval != ERROR_OK)
+		return ERROR_FAIL;
+
+	*rw = hit_watchpoint->rw;
+	*address = hit_watchpoint->address;
+
+	LOG_TARGET_DEBUG(target, "Found hit watchpoint at " TARGET_ADDR_FMT " (WPID: %d)",
+		hit_watchpoint->address,
+		hit_watchpoint->unique_id);
+
+	return ERROR_OK;
 }