review.openocd Code Review - openocd.git/commit

author	Tomas Vanek <vanekt@fbl.cz>
	Fri, 20 Dec 2019 22:56:08 +0000 (23:56 +0100)
committer	Tomas Vanek <vanekt@fbl.cz>
	Sat, 7 Mar 2020 15:30:05 +0000 (15:30 +0000)
commit	a2e822834df52efef5e1bbcb91a6eb1afbf102db
tree	0e5caf3d1daa7dfeb6cabc7f3163d6dd5bbc73f9	tree \| snapshot
parent	4e981bc27c36e696dc8ace3ab4bab534564770c1	commit \| diff

helper/binarybuffer: fix clang static analyzer warnings

Writing bits to an uninitialized buffer generated false warnings.
Zero buffers before setting them by buf_set_u32|64()
(do it only if bit-by-bit copy loop is used,
zeroed buffer is not necessary if a fast path write is used)

Change-Id: I2f7f8ddb45b0cbd08d3e249534fc51f4b5cc6694
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: http://openocd.zylin.com/5383
Tested-by: jenkins
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)

src/flash/nor/jtagspi.c		diff \| blob \| history
src/helper/binarybuffer.h		diff \| blob \| history
src/jtag/core.c		diff \| blob \| history
src/jtag/tcl.c		diff \| blob \| history
src/target/arm_jtag.c		diff \| blob \| history
src/target/avr32_jtag.c		diff \| blob \| history
src/target/esirisc_jtag.c		diff \| blob \| history
src/target/etb.c		diff \| blob \| history
src/target/etm.c		diff \| blob \| history
src/target/ls1_sap.c		diff \| blob \| history
src/target/mips_ejtag.c		diff \| blob \| history
src/target/openrisc/or1k_tap_vjtag.c		diff \| blob \| history
src/target/riscv/riscv-011.c		diff \| blob \| history
src/target/riscv/riscv-013.c		diff \| blob \| history
src/target/riscv/riscv.c		diff \| blob \| history
src/target/xscale.c		diff \| blob \| history