openocd: fix simple cases of NULL comparison 50/6350/3
authorAntonio Borneo <borneo.antonio@gmail.com>
Sat, 3 Jul 2021 16:51:20 +0000 (18:51 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 24 Jul 2021 09:37:49 +0000 (10:37 +0100)
commit08ee7bb982b16742f52cfdc6c649d82ffa2eb177
treea824d376b774499303f00cffb201e35b01830d98
parentb159f5cdedd70fff9309722e927be670845f4df5
openocd: fix simple cases of NULL comparison

There are more than 1000 NULL comparisons to be aligned to the
coding style.
For recurrent NULL comparison it's preferable using trivial
scripts in order to minimize the review effort.

Patch generated automatically with the command:
sed -i PATTERN $(find src/ -type f)
where PATTERN is in the list:
's/(\([a-z][a-z0-9_]*\) == NULL)/(!\1)/g'
's/(\([a-z][a-z0-9_]*->[a-z][a-z0-9_]*\) == NULL)/(!\1)/g'
's/(\([a-z][a-z0-9_]*\.[a-z][a-z0-9_]*\) == NULL)/(!\1)/g'

's/(\([a-z][a-z0-9_]*\) != NULL)/(\1)/g'
's/(\([a-z][a-z0-9_]*->[a-z][a-z0-9_]*\) != NULL)/(\1)/g'
's/(\([a-z][a-z0-9_]*\.[a-z][a-z0-9_]*\) != NULL)/(\1)/g'

's/(NULL == \([a-z][a-z0-9_]*\))/(!\1)/g'
's/(NULL == \([a-z][a-z0-9_]*->[a-z][a-z0-9_]*\))/(!\1)/g'
's/(NULL == \([a-z][a-z0-9_]*\.[a-z][a-z0-9_]*\))/(!\1)/g'

's/(NULL != \([a-z][a-z0-9_]*\))/(\1)/g'
's/(NULL != \([a-z][a-z0-9_]*->[a-z][a-z0-9_]*\))/(\1)/g'
's/(NULL != \([a-z][a-z0-9_]*\.[a-z][a-z0-9_]*\))/(\1)/g'

Change-Id: Ida103e325d6d0600fb69c0b7a1557ee969db4417
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/6350
Tested-by: jenkins
166 files changed:
src/flash/common.c
src/flash/nand/davinci.c
src/flash/nand/fileio.c
src/flash/nand/mx3.c
src/flash/nand/mxc.c
src/flash/nand/s3c24xx.c
src/flash/nand/tcl.c
src/flash/nor/at91sam3.c
src/flash/nor/at91sam4.c
src/flash/nor/at91samd.c
src/flash/nor/atsame5.c
src/flash/nor/avrf.c
src/flash/nor/bluenrg-x.c
src/flash/nor/cc26xx.c
src/flash/nor/cc3220sf.c
src/flash/nor/cfi.c
src/flash/nor/core.c
src/flash/nor/efm32.c
src/flash/nor/faux.c
src/flash/nor/fespi.c
src/flash/nor/jtagspi.c
src/flash/nor/kinetis.c
src/flash/nor/kinetis_ke.c
src/flash/nor/lpcspifi.c
src/flash/nor/mdr.c
src/flash/nor/mrvlqspi.c
src/flash/nor/msp432.c
src/flash/nor/niietcm4.c
src/flash/nor/nrf5.c
src/flash/nor/numicro.c
src/flash/nor/pic32mx.c
src/flash/nor/psoc4.c
src/flash/nor/psoc5lp.c
src/flash/nor/sfdp.c
src/flash/nor/sim3x.c
src/flash/nor/stm32f1x.c
src/flash/nor/stm32f2x.c
src/flash/nor/stm32h7x.c
src/flash/nor/stm32l4x.c
src/flash/nor/stm32lx.c
src/flash/nor/stmqspi.c
src/flash/nor/stmsmi.c
src/flash/nor/str9xpec.c
src/flash/nor/tcl.c
src/flash/nor/virtual.c
src/flash/nor/xcf.c
src/flash/nor/xmc4xxx.c
src/helper/command.c
src/helper/configuration.c
src/helper/jim-nvp.c
src/helper/log.c
src/helper/options.c
src/helper/replacements.c
src/jtag/aice/aice_transport.c
src/jtag/aice/aice_usb.c
src/jtag/commands.c
src/jtag/core.c
src/jtag/drivers/arm-jtag-ew.c
src/jtag/drivers/bitq.c
src/jtag/drivers/buspirate.c
src/jtag/drivers/cmsis_dap.c
src/jtag/drivers/cmsis_dap_usb_bulk.c
src/jtag/drivers/cmsis_dap_usb_hid.c
src/jtag/drivers/driver.c
src/jtag/drivers/ft232r.c
src/jtag/drivers/ftdi.c
src/jtag/drivers/jlink.c
src/jtag/drivers/jtag_dpi.c
src/jtag/drivers/jtag_usb_common.c
src/jtag/drivers/kitprog.c
src/jtag/drivers/libusb_helper.c
src/jtag/drivers/linuxgpiod.c
src/jtag/drivers/mpsse.c
src/jtag/drivers/opendous.c
src/jtag/drivers/openjtag.c
src/jtag/drivers/parport.c
src/jtag/drivers/presto.c
src/jtag/drivers/remote_bitbang.c
src/jtag/drivers/rlink.c
src/jtag/drivers/stlink_usb.c
src/jtag/drivers/ti_icdi_usb.c
src/jtag/drivers/ulink.c
src/jtag/drivers/versaloon/usbtoxxx/usbtoswd.c
src/jtag/drivers/versaloon/usbtoxxx/usbtoxxx.c
src/jtag/drivers/versaloon/versaloon.c
src/jtag/drivers/vsllink.c
src/jtag/drivers/xds110.c
src/jtag/hla/hla_interface.c
src/jtag/hla/hla_layout.c
src/jtag/tcl.c
src/pld/virtex2.c
src/pld/xilinx_bit.c
src/rtos/FreeRTOS.c
src/rtos/ThreadX.c
src/rtos/chibios.c
src/rtos/eCos.c
src/rtos/embKernel.c
src/rtos/hwthread.c
src/rtos/linux.c
src/rtos/mqx.c
src/rtos/nuttx.c
src/rtos/riot.c
src/rtos/rtos.c
src/rtos/uCOS-III.c
src/rtos/zephyr.c
src/server/gdb_server.c
src/server/server.c
src/server/tcl_server.c
src/server/telnet_server.c
src/svf/svf.c
src/target/aarch64.c
src/target/adi_v5_jtag.c
src/target/adi_v5_swd.c
src/target/arc.c
src/target/arm.h
src/target/arm11.c
src/target/arm11_dbgtap.c
src/target/arm7_9_common.c
src/target/arm920t.c
src/target/arm_adi_v5.c
src/target/arm_adi_v5.h
src/target/arm_cti.c
src/target/arm_dap.c
src/target/arm_dpm.c
src/target/arm_jtag.c
src/target/arm_tpiu_swo.c
src/target/armv4_5.c
src/target/armv7a.c
src/target/armv7a_mmu.c
src/target/armv7m.c
src/target/armv8.c
src/target/armv8_dpm.c
src/target/avr32_jtag.c
src/target/avrt.c
src/target/breakpoints.c
src/target/cortex_a.c
src/target/cortex_m.c
src/target/dsp5680xx.c
src/target/esirisc.c
src/target/esirisc_trace.c
src/target/etb.c
src/target/etm.c
src/target/hla_target.c
src/target/image.c
src/target/lakemont.c
src/target/mem_ap.c
src/target/mips32_pracc.c
src/target/mips64_pracc.c
src/target/mips_ejtag.c
src/target/mips_m4k.c
src/target/nds32.c
src/target/nds32.h
src/target/nds32_cmd.c
src/target/openrisc/or1k.c
src/target/openrisc/or1k_du_adv.c
src/target/quark_d20xx.c
src/target/riscv/batch.c
src/target/riscv/riscv.c
src/target/semihosting_common.c
src/target/smp.h
src/target/target.c
src/target/target_request.c
src/target/x86_32_common.c
src/target/xscale.c
src/transport/transport.c
src/xsvf/xsvf.c

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)