Code Review / openocd.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 87e91f4) | patch
Retire jtag_add_dr_out 01/1801/2
authorAndreas Fritiofson <andreas.fritiofson@gmail.com>
Wed, 6 Nov 2013 23:40:50 +0000 (00:40 +0100)
committerSpencer Oliver <spen@spen-soft.co.uk>
Mon, 20 Jan 2014 13:28:26 +0000 (13:28 +0000)
commit63fa73169bd88258ef82f709e79769eacc50f793
tree5f259281041de2aa5d7097db46a64d4175279a96tree | snapshot
parent87e91f4db9bea66a7866261130c6152c0304bc29commit | diff
Retire jtag_add_dr_out

The out only version of jtag_add_dr_scan smells like a bogus optimization
that complicates the minidriver API for questionable gain.

The function was only used by four old ARM targets. Rewrite the callers
to use the generic function and remove all implementations.

Change-Id: I13b643687ee8ed6bc9b6336e7096c34f40ea96af
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/1801
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
12 files changed:
src/jtag/drivers/driver.c diff | blob | history
src/jtag/drivers/minidriver_imp.h diff | blob | history
src/jtag/jtag.h diff | blob | history
src/jtag/minidriver.h diff | blob | history
src/jtag/minidriver/minidriver_imp.h diff | blob | history
src/jtag/minidummy/jtag_minidriver.h diff | blob | history
src/jtag/zy1000/jtag_minidriver.h diff | blob | history
src/jtag/zy1000/zy1000.c diff | blob | history
src/target/arm7tdmi.c diff | blob | history
src/target/arm_jtag.c diff | blob | history
src/target/embeddedice.h diff | blob | history
src/target/xscale.c diff | blob | history
Open On-Chip Debugger

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)