Code Review / openocd.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 35f284f) | patch
target,flash: allow target_free_working_area on NULL area pointer 12/6712/4
authorTomas Vanek <vanekt@fbl.cz>
Thu, 18 Nov 2021 08:37:23 +0000 (09:37 +0100)
committerAntonio Borneo <borneo.antonio@gmail.com>
Fri, 3 Dec 2021 21:59:20 +0000 (21:59 +0000)
commitf735faa9319af324b94e4257444419c8dfec6592
tree1d42acd12cc96d37e19b278d17926c6f2e1e98c3tree | snapshot
parent35f284fe7c51d29768156cfec172152d2539d98acommit | diff
target,flash: allow target_free_working_area on NULL area pointer

Standard C library free() allows NULL pointer as a parameter.

Change target_free_working_area() to conform this convention.

Remove NULL pointer tests before target_free_working_area() calls.

While on it add missing setting pointer to NULL after target_free_working_area().

Change-Id: I7c692ab04a9933398ba5bc614723ad0bdecb87b3
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: https://review.openocd.org/c/openocd/+/6712
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
src/flash/nor/cc26xx.c diff | blob | history
src/flash/nor/cfi.c diff | blob | history
src/flash/nor/fespi.c diff | blob | history
src/flash/nor/msp432.c diff | blob | history
src/flash/nor/npcx.c diff | blob | history
src/flash/nor/psoc6.c diff | blob | history
src/flash/nor/sh_qspi.c diff | blob | history
src/target/riscv/riscv-013.c diff | blob | history
src/target/target.c diff | blob | history
src/target/target.h diff | blob | history
Open On-Chip Debugger

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)