target: fix ordering of arguments to mcr and mrc commands
authorØyvind Harboe <oyvind.harboe@zylin.com>
Mon, 26 Oct 2009 17:57:52 +0000 (18:57 +0100)
committerØyvind Harboe <oyvind.harboe@zylin.com>
Thu, 5 Nov 2009 22:57:49 +0000 (23:57 +0100)
Now matches machine code syntax and old arm11 syntax.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
src/target/target.c

index 9b07df18bde6da8ed400e6650e6d9164f3bb8760..9502490e24271fe59397cdba130e103b2b8f87d5 100644 (file)
@@ -722,25 +722,25 @@ static int arm_cp_check(struct target_s *target, int cpnum, uint32_t op1, uint32
                return ERROR_FAIL;
        }
 
-       if (op1>7)
+       if (op1 > 7)
        {
                LOG_ERROR("Illegal op1");
                return ERROR_FAIL;
        }
 
-       if (op2>7)
+       if (op2 > 7)
        {
                LOG_ERROR("Illegal op2");
                return ERROR_FAIL;
        }
 
-       if (CRn>15)
+       if (CRn > 15)
        {
                LOG_ERROR("Illegal CRn");
                return ERROR_FAIL;
        }
 
-       if (CRm>7)
+       if (CRm > 15)
        {
                LOG_ERROR("Illegal CRm");
                return ERROR_FAIL;
@@ -4899,19 +4899,19 @@ static int jim_mcrmrc(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
        if (e != JIM_OK) {
                return e;
        }
-       op2 = l;
+       CRn = l;
 
        e = Jim_GetLong(interp, argv[4], &l);
        if (e != JIM_OK) {
                return e;
        }
-       CRn = l;
+       CRm = l;
 
        e = Jim_GetLong(interp, argv[5], &l);
        if (e != JIM_OK) {
                return e;
        }
-       CRm = l;
+       op2 = l;
 
        value = 0;
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)