Code Review / openocd.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | patch | inline | side by side (parent: 5b17045)
jtag: fix opendous reset command
authorStefan Mahr <stefan.mahr@sphairon.com>
Wed, 27 Jun 2012 22:53:54 +0000 (00:53 +0200)
committerFreddie Chopin <freddie.chopin@gmail.com>
Wed, 11 Jul 2012 08:18:00 +0000 (08:18 +0000)
This cast to uint16_t is not (host) endianess save.
Depending on compiler usb_out_buffer[1] may be undefined.

Change-Id: If686e5d5da39541329c340bbdef472ee7ab0281c
Signed-off-by: Stefan Mahr <stefan.mahr@sphairon.com>
Reviewed-on: http://openocd.zylin.com/732
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-by: Freddie Chopin <freddie.chopin@gmail.com>
src/jtag/drivers/opendous.c patch | blob | history

diff --git a/src/jtag/drivers/opendous.c b/src/jtag/drivers/opendous.c
index 0bb6da66f36de252a526178907e6436f6d2a7439..1b74bd5a492715d8766a4b8e2e20670a0d243310 100644 (file)
--- a/src/jtag/drivers/opendous.c
+++ b/src/jtag/drivers/opendous.c
@@ -465,7 +465,8 @@ void opendous_simple_command(uint8_t command, uint8_t _data)
 
        DEBUG_JTAG_IO("0x%02x 0x%02x", command, _data);
 
 
        DEBUG_JTAG_IO("0x%02x 0x%02x", command, _data);
 
-       usb_out_buffer[0] = (uint16_t) 2;
+       usb_out_buffer[0] = 2;
+       usb_out_buffer[1] = 0;
        usb_out_buffer[2] = command;
        usb_out_buffer[3] = _data;
 
        usb_out_buffer[2] = command;
        usb_out_buffer[3] = _data;
 
Open On-Chip Debugger

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)