checkpatch: disable extern and switch indent checks
authorSpencer Oliver <spen@spen-soft.co.uk>
Fri, 16 Dec 2011 10:04:43 +0000 (10:04 +0000)
committerSpencer Oliver <spen@spen-soft.co.uk>
Fri, 16 Dec 2011 10:39:43 +0000 (10:39 +0000)
We allow extern's in c files so disable checkpatch checks.

Change-Id: Ia649585cd70ec45289c4edaf26c1fd773a140db4
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/284
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
tools/scripts/checkpatch.pl

index 1089c5113446afcb18e2fb27ae1ade4e6c7a0cbc..703fa06c6ecf1f6cf4dc96f307d6654fc9e0118d 100755 (executable)
@@ -1823,26 +1823,26 @@ sub process {
 
 # Check for switch () and associated case and default
 # statements should be at the same indent.
-               if ($line=~/\bswitch\s*\(.*\)/) {
-                       my $err = '';
-                       my $sep = '';
-                       my @ctx = ctx_block_outer($linenr, $realcnt);
-                       shift(@ctx);
-                       for my $ctx (@ctx) {
-                               my ($clen, $cindent) = line_stats($ctx);
-                               if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
-                                                       $indent != $cindent) {
-                                       $err .= "$sep$ctx\n";
-                                       $sep = '';
-                               } else {
-                                       $sep = "[...]\n";
-                               }
-                       }
-                       if ($err ne '') {
-                               ERROR("SWITCH_CASE_INDENT_LEVEL",
-                                     "switch and case should be at the same indent\n$hereline$err");
-                       }
-               }
+#              if ($line=~/\bswitch\s*\(.*\)/) {
+#                      my $err = '';
+#                      my $sep = '';
+#                      my @ctx = ctx_block_outer($linenr, $realcnt);
+#                      shift(@ctx);
+#                      for my $ctx (@ctx) {
+#                              my ($clen, $cindent) = line_stats($ctx);
+#                              if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
+#                                                      $indent != $cindent) {
+#                                      $err .= "$sep$ctx\n";
+#                                      $sep = '';
+#                              } else {
+#                                      $sep = "[...]\n";
+#                              }
+#                      }
+#                      if ($err ne '') {
+#                              ERROR("SWITCH_CASE_INDENT_LEVEL",
+#                                    "switch and case should be at the same indent\n$hereline$err");
+#                      }
+#              }
 
 # if/while/etc brace do not go on next line, unless defining a do while loop,
 # or if that brace on the next line is for something else
@@ -3088,34 +3088,34 @@ sub process {
                }
 
 # check for new externs in .c files.
-               if ($realfile =~ /\.c$/ && defined $stat &&
-                   $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
-               {
-                       my $function_name = $1;
-                       my $paren_space = $2;
-
-                       my $s = $stat;
-                       if (defined $cond) {
-                               substr($s, 0, length($cond), '');
-                       }
-                       if ($s =~ /^\s*;/ &&
-                           $function_name ne 'uninitialized_var')
-                       {
-                               WARN("AVOID_EXTERNS",
-                                    "externs should be avoided in .c files\n" .  $herecurr);
-                       }
-
-                       if ($paren_space =~ /\n/) {
-                               WARN("FUNCTION_ARGUMENTS",
-                                    "arguments for function declarations should follow identifier\n" . $herecurr);
-                       }
-
-               } elsif ($realfile =~ /\.c$/ && defined $stat &&
-                   $stat =~ /^.\s*extern\s+/)
-               {
-                       WARN("AVOID_EXTERNS",
-                            "externs should be avoided in .c files\n" .  $herecurr);
-               }
+#              if ($realfile =~ /\.c$/ && defined $stat &&
+#                  $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
+#              {
+#                      my $function_name = $1;
+#                      my $paren_space = $2;
+#
+#                      my $s = $stat;
+#                      if (defined $cond) {
+#                              substr($s, 0, length($cond), '');
+#                      }
+#                      if ($s =~ /^\s*;/ &&
+#                          $function_name ne 'uninitialized_var')
+#                      {
+#                              WARN("AVOID_EXTERNS",
+#                                   "externs should be avoided in .c files\n" .  $herecurr);
+#                      }
+#
+#                      if ($paren_space =~ /\n/) {
+#                              WARN("FUNCTION_ARGUMENTS",
+#                                   "arguments for function declarations should follow identifier\n" . $herecurr);
+#                      }
+#
+#              } elsif ($realfile =~ /\.c$/ && defined $stat &&
+#                  $stat =~ /^.\s*extern\s+/)
+#              {
+#                      WARN("AVOID_EXTERNS",
+#                           "externs should be avoided in .c files\n" .  $herecurr);
+#              }
 
 # checks for new __setup's
                if ($rawline =~ /\b__setup\("([^"]*)"/) {

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)