fix flash/nand name parsing
authorZachary T Welch <zw@superlucidity.net>
Fri, 20 Nov 2009 02:11:30 +0000 (18:11 -0800)
committerZachary T Welch <zw@superlucidity.net>
Fri, 20 Nov 2009 15:10:55 +0000 (07:10 -0800)
Start driver.num check from end, and make sure the numeric part is
actually a number.  Fix problems trying to parse bank names.

src/flash/common.c

index 253ed9d875b4dfda15bd1df21a2da2b60782b41b..072e6912fd45079dff8ca4d76270fd9993233991 100644 (file)
 
 unsigned get_flash_name_index(const char *name)
 {
-       const char *index = strchr(name, '.');
+       const char *index = strrchr(name, '.');
        if (NULL == index)
                return 0;
+       if (index[1] < '0' || index[1] > '9')
+               return ~0U;
        unsigned requested;
        int retval = parse_uint(index + 1, &requested);
        // detect parsing error by forcing past end of bank list

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)