xscale_reg_t -> struct xscale_reg
authorZachary T Welch <zw@superlucidity.net>
Fri, 13 Nov 2009 16:45:40 +0000 (08:45 -0800)
committerZachary T Welch <zw@superlucidity.net>
Fri, 13 Nov 2009 19:58:12 +0000 (11:58 -0800)
Remove misleading typedef and redundant suffix from struct xscale_reg.

src/target/xscale.c
src/target/xscale.h

index 99453b440819d1be5d0216de24cbcad3eca1048a..552b2ff1d7637fdbf9a474a719ec2904ebebed89 100644 (file)
@@ -106,7 +106,7 @@ static char *const xscale_reg_list[] =
        "XSCALE_TXRXCTRL",
 };
 
-static const xscale_reg_t xscale_reg_arch_info[] =
+static const struct xscale_reg xscale_reg_arch_info[] =
 {
        {XSCALE_MAINID, NULL},
        {XSCALE_CACHETYPE, NULL},
@@ -2365,7 +2365,7 @@ static int xscale_remove_watchpoint(struct target_s *target, struct watchpoint *
 
 static int xscale_get_reg(reg_t *reg)
 {
-       xscale_reg_t *arch_info = reg->arch_info;
+       struct xscale_reg *arch_info = reg->arch_info;
        target_t *target = arch_info->target;
        struct xscale_common *xscale = target_to_xscale(target);
 
@@ -2410,7 +2410,7 @@ static int xscale_get_reg(reg_t *reg)
 
 static int xscale_set_reg(reg_t *reg, uint8_t* buf)
 {
-       xscale_reg_t *arch_info = reg->arch_info;
+       struct xscale_reg *arch_info = reg->arch_info;
        target_t *target = arch_info->target;
        struct xscale_common *xscale = target_to_xscale(target);
        uint32_t value = buf_get_u32(buf, 0, 32);
@@ -2456,7 +2456,7 @@ static int xscale_write_dcsr_sw(target_t *target, uint32_t value)
 {
        struct xscale_common *xscale = target_to_xscale(target);
        reg_t *dcsr = &xscale->reg_cache->reg_list[XSCALE_DCSR];
-       xscale_reg_t *dcsr_arch_info = dcsr->arch_info;
+       struct xscale_reg *dcsr_arch_info = dcsr->arch_info;
 
        /* send CP write request (command 0x41) */
        xscale_send_u32(target, 0x41);
@@ -2822,9 +2822,9 @@ static void xscale_build_reg_cache(target_t *target)
        struct xscale_common *xscale = target_to_xscale(target);
        struct armv4_5_common_s *armv4_5 = &xscale->armv4_5_common;
        struct reg_cache **cache_p = register_get_last_cache_p(&target->reg_cache);
-       xscale_reg_t *arch_info = malloc(sizeof(xscale_reg_arch_info));
+       struct xscale_reg *arch_info = malloc(sizeof(xscale_reg_arch_info));
        int i;
-       int num_regs = sizeof(xscale_reg_arch_info) / sizeof(xscale_reg_t);
+       int num_regs = sizeof(xscale_reg_arch_info) / sizeof(struct xscale_reg);
 
        (*cache_p) = armv4_5_build_reg_cache(target, armv4_5);
        armv4_5->core_cache = (*cache_p);
index 63655ffbe9cdb4bfaf18e11b7f1bbb3d4ac0dcb8..6fb0bf518274b9f6742268e03548ff354341df87 100644 (file)
@@ -138,11 +138,11 @@ target_to_xscale(struct target_s *target)
                        armv4_5_common);
 }
 
-typedef struct xscale_reg_s
+struct xscale_reg
 {
        int dbg_handler_number;
        target_t *target;
-} xscale_reg_t;
+};
 
 enum
 {

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)