adi_v5_cmsis_dap.c: Simplify debugging output 38/2138/4
authorAndrey Smirnov <andrew.smirnov@gmail.com>
Wed, 18 Jun 2014 21:41:00 +0000 (23:41 +0200)
committerAndreas Fritiofson <andreas.fritiofson@gmail.com>
Sat, 28 Jun 2014 09:31:10 +0000 (09:31 +0000)
Name of the function is already a part of the LOG_DEBUG macro, so
there's no need to include it in the string itself.

Change-Id: I18c3d5b746e9106d55104e490ccf5bc5e85cc380
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/2138
Tested-by: jenkins
src/target/adi_v5_cmsis_dap.c

index 9b591464394c18925d4f68887e48a2df81511c82..9028c9d5935768df0ddcb95d45ccefb4062a5377 100644 (file)
@@ -56,7 +56,7 @@ extern struct jtag_interface *jtag_interface;
 
 static int cmsis_dap_clear_sticky_errors(struct adiv5_dap *dap)
 {
 
 static int cmsis_dap_clear_sticky_errors(struct adiv5_dap *dap)
 {
-       LOG_DEBUG("CMSIS-ADI: %s", __func__);
+       LOG_DEBUG(" ");
 
        const struct swd_driver *swd = jtag_interface->swd;
        assert(swd);
 
        const struct swd_driver *swd = jtag_interface->swd;
        assert(swd);
@@ -67,7 +67,7 @@ static int cmsis_dap_clear_sticky_errors(struct adiv5_dap *dap)
 
 static int cmsis_dap_queue_ap_abort(struct adiv5_dap *dap, uint8_t *ack)
 {
 
 static int cmsis_dap_queue_ap_abort(struct adiv5_dap *dap, uint8_t *ack)
 {
-       LOG_DEBUG("CMSIS-ADI: %s", __func__);
+       LOG_DEBUG(" ");
 
        const struct swd_driver *swd = jtag_interface->swd;
        assert(swd);
 
        const struct swd_driver *swd = jtag_interface->swd;
        assert(swd);
@@ -78,7 +78,7 @@ static int cmsis_dap_queue_ap_abort(struct adiv5_dap *dap, uint8_t *ack)
 
 static int cmsis_dap_queue_dp_read(struct adiv5_dap *dap, unsigned reg, uint32_t *data)
 {
 
 static int cmsis_dap_queue_dp_read(struct adiv5_dap *dap, unsigned reg, uint32_t *data)
 {
-       LOG_DEBUG("CMSIS-ADI: cmsis_dap_queue_dp_read %d", reg);
+       LOG_DEBUG("reg = %d", reg);
 
        int retval = jtag_interface->swd->read_reg(
                        (CMSIS_CMD_DP | CMSIS_CMD_READ | CMSIS_CMD_A32(reg)), data);
 
        int retval = jtag_interface->swd->read_reg(
                        (CMSIS_CMD_DP | CMSIS_CMD_READ | CMSIS_CMD_A32(reg)), data);
@@ -91,7 +91,7 @@ static int cmsis_dap_queue_dp_read(struct adiv5_dap *dap, unsigned reg, uint32_t
 
 static int (cmsis_dap_queue_dp_write)(struct adiv5_dap *dap, unsigned reg, uint32_t data)
 {
 
 static int (cmsis_dap_queue_dp_write)(struct adiv5_dap *dap, unsigned reg, uint32_t data)
 {
-       LOG_DEBUG("CMSIS-ADI: cmsis_dap_queue_dp_write %d 0x%08" PRIx32, reg, data);
+       LOG_DEBUG("reg = %d, data = 0x%08" PRIx32, reg, data);
 
        /* setting the ORUNDETECT bit causes issues for some targets,
         * disable until we find out why */
 
        /* setting the ORUNDETECT bit causes issues for some targets,
         * disable until we find out why */
@@ -129,7 +129,7 @@ static int (cmsis_dap_queue_ap_read)(struct adiv5_dap *dap, unsigned reg, uint32
        if (retval != ERROR_OK)
                return retval;
 
        if (retval != ERROR_OK)
                return retval;
 
-       LOG_DEBUG("CMSIS-ADI: cmsis_dap_queue_ap_read %d", reg);
+       LOG_DEBUG("reg = %d", reg);
 
        retval = jtag_interface->swd->read_reg(
                        (CMSIS_CMD_AP | CMSIS_CMD_READ | CMSIS_CMD_A32(reg)), data);
 
        retval = jtag_interface->swd->read_reg(
                        (CMSIS_CMD_AP | CMSIS_CMD_READ | CMSIS_CMD_A32(reg)), data);
@@ -153,7 +153,7 @@ static int (cmsis_dap_queue_ap_write)(struct adiv5_dap *dap, unsigned reg, uint3
        if (retval != ERROR_OK)
                return retval;
 
        if (retval != ERROR_OK)
                return retval;
 
-       LOG_DEBUG("CMSIS-ADI: cmsis_dap_queue_ap_write %d 0x%08" PRIx32, reg, data);
+       LOG_DEBUG("reg = %d, data = 0x%08" PRIx32, reg, data);
 
        retval = jtag_interface->swd->write_reg(
                        (CMSIS_CMD_AP | CMSIS_CMD_WRITE | CMSIS_CMD_A32(reg)), data);
 
        retval = jtag_interface->swd->write_reg(
                        (CMSIS_CMD_AP | CMSIS_CMD_WRITE | CMSIS_CMD_A32(reg)), data);
@@ -240,7 +240,7 @@ static const struct command_registration cmsis_dap_handlers[] = {
 
 static int cmsis_dap_select(struct command_context *ctx)
 {
 
 static int cmsis_dap_select(struct command_context *ctx)
 {
-       LOG_DEBUG("CMSIS-ADI: cmsis_dap_select");
+       LOG_DEBUG(" ");
 
        int retval = register_commands(ctx, NULL, cmsis_dap_handlers);
 
 
        int retval = register_commands(ctx, NULL, cmsis_dap_handlers);
 
@@ -275,7 +275,7 @@ static int cmsis_dap_init(struct command_context *ctx)
        uint32_t idcode;
        int status;
 
        uint32_t idcode;
        int status;
 
-       LOG_DEBUG("CMSIS-ADI: cmsis_dap_init");
+       LOG_DEBUG("CMSIS-ADI init");
 
        /* Force the DAP's ops vector for CMSIS-DAP mode.
         * messy - is there a better way? */
 
        /* Force the DAP's ops vector for CMSIS-DAP mode.
         * messy - is there a better way? */

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)