mips4k: fix big-endian hosts and host alignment problems
authorØyvind Harboe <oyvind.harboe@zylin.com>
Tue, 28 Jun 2011 16:22:32 +0000 (18:22 +0200)
committerØyvind Harboe <oyvind.harboe@zylin.com>
Tue, 28 Jun 2011 16:22:32 +0000 (18:22 +0200)
the code was making assumptions about the endianness of the host.

src/target/mips_m4k.c

index 03c996941e0c54e8381cda7a151575bf4e85707a..9b4e1a45875fe43b02d3cb79aa4f62cdd3f41631 100644 (file)
@@ -877,11 +877,11 @@ static int mips_m4k_read_memory(struct target *target, uint32_t address,
                switch(size)
                {
                case 4:
-                       t32 = *(uint32_t*)&buffer[i];
+                       t32 = le_to_h_u32(&buffer[i]);
                        target_buffer_set_u32(target,&buffer[i], t32);
                        break;
                case 2:
-                       t16 = *(uint16_t*)&buffer[i];
+                       t16 = le_to_h_u16(&buffer[i]);
                        target_buffer_set_u16(target,&buffer[i], t16);
                        break;
                }
@@ -930,11 +930,11 @@ static int mips_m4k_write_memory(struct target *target, uint32_t address,
                {
                case 4:
                        t32 = target_buffer_get_u32(target,&buffer[i]);
-                       *(uint32_t*)&t[i] = t32;
+                       h_u32_to_le(&t[i], t32);
                        break;
                case 2:
                        t16 = target_buffer_get_u16(target,&buffer[i]);
-                       *(uint16_t*)&t[i] = t16;
+                       h_u16_to_le(&t[i], t16);
                        break;
                }
        }
@@ -1074,7 +1074,7 @@ static int mips_m4k_bulk_write_memory(struct target *target, uint32_t address,
        for(i = 0; i < (count*4); i += 4)
        {
                t32 = target_buffer_get_u32(target,&buffer[i]);
-               *(uint32_t*)&t[i] = t32;
+               h_u32_to_le(&t[i], t32);
        }
        
        retval = mips32_pracc_fastdata_xfer(ejtag_info, mips32->fast_data_area, write_t, address,

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)