target/esp32s2: check xtensa_poll return value

Although scan build couldn't catch, return value overwritten
without checking.

Signed-off-by: Erhan Kurubas <erhan.kurubas@espressif.com>
Change-Id: I02b10002b03640604315047e8a8a639824724c16
Reviewed-on: https://review.openocd.org/c/openocd/+/7247
Tested-by: jenkins
Reviewed-by: Ian Thompson <ianst@cadence.com>
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

diff --git a/src/target/espressif/esp32s2.c b/src/target/espressif/esp32s2.c
index 62d1ddb1d44c8bd9818fa43bd18bb1c92f58ded9..64fa690570233a57fd9e2ca5269f3628314f4e73 100644 (file)
--- a/src/target/espressif/esp32s2.c
+++ b/src/target/espressif/esp32s2.c
@@ -402,6 +402,8 @@ static int esp32s2_poll(struct target *target)
 {
        enum target_state old_state = target->state;
        int ret = esp_xtensa_poll(target);
+       if (ret != ERROR_OK)
+               return ret;
 
        if (old_state != TARGET_HALTED && target->state == TARGET_HALTED) {
                /* Call any event callbacks that are applicable */