hooks for multithreading. Disable nagle
authoroharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Wed, 26 Mar 2008 13:18:23 +0000 (13:18 +0000)
committeroharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Wed, 26 Mar 2008 13:18:23 +0000 (13:18 +0000)
git-svn-id: svn://svn.berlios.de/openocd/trunk@524 b42882b7-edfa-0310-969c-e2dbd0fdcd60

src/openocd.c
src/server/server.c

index 604a3c5b07e79f320e856447003027713f53eab6..bc4dc50f3e1b1eb44d007bc145cdc9d83ae3a2d9 100644 (file)
@@ -64,6 +64,17 @@ void exit_handler(void)
                jtag->quit();
 }
 
+/* implementations of OpenOCD that uses multithreading needs to lock OpenOCD while calling
+ * OpenOCD fn's. No-op in vanilla OpenOCD
+ */
+void lockBigLock()
+{
+}
+void unlockBigLock()
+{
+}
+
+
 int main(int argc, char *argv[])
 {
        /* initialize commandline interface */
index 8c4fd7d2978ad41c152cc9ee4298fb47e2378102..33bf00cf218907256daa8b962ae5ab0c8aa9fc2f 100644 (file)
@@ -37,6 +37,9 @@
 #include <sys/types.h>
 #include <fcntl.h>
 #include <signal.h>
+#ifndef _WIN32
+#include <netinet/tcp.h>
+#endif
 
 service_t *services = NULL;
 
@@ -49,6 +52,9 @@ int add_connection(service_t *service, command_context_t *cmd_ctx)
        unsigned int address_size;
        connection_t *c, **p;
        int retval;
+#ifndef _WIN32
+       int flag=1;
+#endif
        
        c = malloc(sizeof(connection_t));
        c->fd = -1;
@@ -60,7 +66,32 @@ int add_connection(service_t *service, command_context_t *cmd_ctx)
        c->next = NULL;
 
        address_size = sizeof(c->sin);
+#ifndef _WIN32
+       int segsize=65536;
+       setsockopt(service->fd, IPPROTO_TCP, TCP_MAXSEG,  &segsize, sizeof(int));
+       int window_size = 128 * 1024;   
+
+       /* These setsockopt()s must happen before the accept() */
+
+       setsockopt(service->fd, SOL_SOCKET, SO_SNDBUF,
+                (char *) &window_size, sizeof(window_size));
+
+       setsockopt(service->fd, SOL_SOCKET, SO_RCVBUF,
+                (char *) &window_size, sizeof(window_size));
+       
+#endif
        c->fd = accept(service->fd, (struct sockaddr *)&service->sin, &address_size);
+#ifndef _WIN32
+       // This increases performance dramatically for e.g. GDB load which
+       // does not have a sliding window protocol.
+    retval=setsockopt(c->fd,            /* socket affected */
+                            IPPROTO_TCP,     /* set option at TCP level */
+                            TCP_NODELAY,     /* name of option */
+                            (char *) &flag,  /* the cast is historical
+                                                    cruft */
+                            sizeof(int));    /* length of option value */
+    setsockopt(c->fd, IPPROTO_TCP, TCP_MAXSEG,  &segsize, sizeof(int));
+#endif 
                                
                                
        LOG_INFO("accepting '%s' connection from %i", service->name, c->sin.sin_port);
@@ -221,6 +252,9 @@ int remove_services()
        return ERROR_OK;
 }
 
+extern void lockBigLock();
+extern void unlockBigLock();
+
 int server_loop(command_context_t *command_context)
 {
        service_t *service;
@@ -237,6 +271,13 @@ int server_loop(command_context_t *command_context)
        if (signal(SIGPIPE, SIG_IGN) == SIG_ERR)
                LOG_ERROR("couldn't set SIGPIPE to SIG_IGN");
 #endif
+
+       // This function is reentrant(workaround for configuration problems)
+       static int lockCount=0;
+       if (lockCount++==0)
+       {
+               lockBigLock();
+       }
        
        /* do regular tasks after at most 10ms */
        tv.tv_sec = 0;
@@ -275,12 +316,17 @@ int server_loop(command_context_t *command_context)
                }
                
 #ifndef _WIN32
+#ifndef BUILD_ECOSBOARD
                /* add STDIN to read_fds */
                FD_SET(fileno(stdin), &read_fds);
+#endif
 #endif
 
+               // Only while we're sleeping we'll let others run
+               unlockBigLock();
                retval = select(fd_max + 1, &read_fds, NULL, NULL, &tv);
-               
+               lockBigLock();
+
                if (retval == -1)
                {
 #ifdef _WIN32
@@ -363,6 +409,7 @@ int server_loop(command_context_t *command_context)
                }
                
 #ifndef _WIN32
+#ifndef BUILD_ECOSBOARD
                if (FD_ISSET(fileno(stdin), &read_fds))
                {
                        if (getc(stdin) == 'x')
@@ -370,6 +417,7 @@ int server_loop(command_context_t *command_context)
                                shutdown_openocd = 1;
                        }
                }
+#endif
 #else
                MSG msg;
                while (PeekMessage(&msg,NULL,0,0,PM_REMOVE))
@@ -379,6 +427,10 @@ int server_loop(command_context_t *command_context)
                }
 #endif
        }
+       if (--lockCount==0)
+       {
+               unlockBigLock();
+       }
        
        return ERROR_OK;
 }

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)