target/breakpoints: make internal functions static 88/4888/2
authorTomas Vanek <vanekt@fbl.cz>
Thu, 7 Feb 2019 13:17:03 +0000 (14:17 +0100)
committerTomas Vanek <vanekt@fbl.cz>
Tue, 12 Mar 2019 06:43:49 +0000 (06:43 +0000)
While on it add two missing new lines.

Change-Id: I0d54740479bc462b734f91686f0931824796b598
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: http://openocd.zylin.com/4888
Tested-by: jenkins
Reviewed-by: Marc Schink <openocd-dev@marcschink.de>
src/target/breakpoints.c

index 94e8a823d07fdb225e8b3f0aed68fbf5a72added..7ad19425630f818b2accf2a01312a06080872b17 100644 (file)
@@ -41,7 +41,7 @@ static const char * const watchpoint_rw_strings[] = {
 /* monotonic counter/id-number for breakpoints and watch points */
 static int bpwp_unique_id;
 
-int breakpoint_add_internal(struct target *target,
+static int breakpoint_add_internal(struct target *target,
        target_addr_t address,
        uint32_t length,
        enum breakpoint_type type)
@@ -106,7 +106,7 @@ fail:
        return ERROR_OK;
 }
 
-int context_breakpoint_add_internal(struct target *target,
+static int context_breakpoint_add_internal(struct target *target,
        uint32_t asid,
        uint32_t length,
        enum breakpoint_type type)
@@ -158,7 +158,7 @@ int context_breakpoint_add_internal(struct target *target,
        return ERROR_OK;
 }
 
-int hybrid_breakpoint_add_internal(struct target *target,
+static int hybrid_breakpoint_add_internal(struct target *target,
        target_addr_t address,
        uint32_t asid,
        uint32_t length,
@@ -241,6 +241,7 @@ int breakpoint_add(struct target *target,
        } else
                return breakpoint_add_internal(target, address, length, type);
 }
+
 int context_breakpoint_add(struct target *target,
        uint32_t asid,
        uint32_t length,
@@ -262,6 +263,7 @@ int context_breakpoint_add(struct target *target,
        } else
                return context_breakpoint_add_internal(target, asid, length, type);
 }
+
 int hybrid_breakpoint_add(struct target *target,
        target_addr_t address,
        uint32_t asid,
@@ -310,7 +312,7 @@ static void breakpoint_free(struct target *target, struct breakpoint *breakpoint
        free(breakpoint);
 }
 
-int breakpoint_remove_internal(struct target *target, target_addr_t address)
+static int breakpoint_remove_internal(struct target *target, target_addr_t address)
 {
        struct breakpoint *breakpoint = target->breakpoints;
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)