jtag: tcl: show error message when attempting manual "drscan" on a bypassed tap

To perform any meaningful manipulations with DR the corresponding IR should
be set to a relevant instruction, not BYPASS, so warn the user accordingly.

Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Change-Id: I42580ecd75ae824a4145f6f17f0df9bcf825b50f
Reviewed-on: https://review.openocd.org/c/openocd/+/7654
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Tested-by: jenkins

diff --git a/src/jtag/tcl.c b/src/jtag/tcl.c
index 395439039215980fa6905cc971ae041cc1e9192f..934b603524170eb225bd9bc28fcf19ccaf732a8a 100644 (file)
--- a/src/jtag/tcl.c
+++ b/src/jtag/tcl.c
@@ -116,6 +116,11 @@ COMMAND_HANDLER(handle_jtag_command_drscan)
                return ERROR_COMMAND_ARGUMENT_INVALID;
        }
 
+       if (tap->bypass) {
+               command_print(CMD, "Can't execute as the selected tap is in BYPASS");
+               return ERROR_FAIL;
+       }
+
        tap_state_t endstate = TAP_IDLE;
        if (CMD_ARGC > 3 && !strcmp("-endstate", CMD_ARGV[CMD_ARGC - 2])) {
                const char *state_name = CMD_ARGV[CMD_ARGC - 1];