pld/virtex2: check error propagated by virtex2_read_stat()

Commit dd9137dc0e0c ("pld/virtex2: add missing error checks") adds
checks on the return value of several functions, allowing also
virtex2_read_stat() to propagate such returned values.
This triggers an error with clang, as it is now able to identify a
possible execution path that makes uninitialized the variable
status.

Check for the returned value of virtex2_read_stat() before using
the variable status and propagate the returned value.
While there, drop a useless empty string.

Change-Id: I7a23d3f904d4e07cdb6f6dfdf1179889b6b8afb8
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7657
Reviewed-by: Daniel Anselmi <danselmi@gmx.ch>
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>

diff --git a/src/pld/virtex2.c b/src/pld/virtex2.c
index 3c174ae59427536931b0425bd4e6146b7bb1b60a..fd0725a63ada988a38eecc15b32ce5c7240f3779 100644 (file)
--- a/src/pld/virtex2.c
+++ b/src/pld/virtex2.c
@@ -241,9 +241,13 @@ COMMAND_HANDLER(virtex2_handle_read_stat_command)
                return ERROR_FAIL;
        }
 
-       virtex2_read_stat(device, &status);
+       int retval = virtex2_read_stat(device, &status);
+       if (retval != ERROR_OK) {
+               command_print(CMD, "cannot read virtex2 status register");
+               return retval;
+       }
 
-       command_print(CMD, "virtex2 status register: 0x%8.8" PRIx32 "", status);
+       command_print(CMD, "virtex2 status register: 0x%8.8" PRIx32, status);
 
        return ERROR_OK;
 }