tcl: replace $TARGETNAME with $_TARGETNAME 79/2779/2
authorRadek Dostal <radek.dostal@streamunlimited.com>
Thu, 21 May 2015 16:12:39 +0000 (18:12 +0200)
committerSpencer Oliver <spen@spen-soft.co.uk>
Thu, 6 Aug 2015 12:07:49 +0000 (13:07 +0100)
code polishing to be consistent with other scripts

Change-Id: Ib52a92f48df9d2bdf543792b856e33aa04dbebe3
Signed-off-by: Radek Dostal <radek.dostal@streamunlimited.com>
Reviewed-on: http://openocd.zylin.com/2779
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
tcl/board/tp-link_tl-mr3020.cfg
tcl/target/ar71xx.cfg
tcl/target/atheros_ar9331.cfg

index 0498d60c2a4bc890876fb5985a18d6655a74ae7a..b7d8d5b6150f57354e226cdca88d122f1ea5bab9 100644 (file)
@@ -34,11 +34,11 @@ proc ar9331_ddr1_init {} {
                                ;# Each bit represents a cycle of valid data.
 }
 
                                ;# Each bit represents a cycle of valid data.
 }
 
-$TARGETNAME configure -event reset-init {
+$_TARGETNAME configure -event reset-init {
        ar9331_25mhz_pll_init
        sleep 1
        ar9331_ddr1_init
 }
 
 set ram_boot_address 0xa0000000
        ar9331_25mhz_pll_init
        sleep 1
        ar9331_ddr1_init
 }
 
 set ram_boot_address 0xa0000000
-$TARGETNAME configure -work-area-phys 0xa1FFE000 -work-area-size 0x1000
+$_TARGETNAME configure -work-area-phys 0xa1FFE000 -work-area-size 0x1000
index 3ac61d94638c855382f804bb6f2ee9f4310870d6..196b048685c77df1f77007d00b95faaee33885d6 100644 (file)
@@ -10,10 +10,10 @@ set CHIPNAME ar71xx
 
 jtag newtap $CHIPNAME cpu -irlen 5 -ircapture 0x1 -irmask 0x1f -expected-id 1
 
 
 jtag newtap $CHIPNAME cpu -irlen 5 -ircapture 0x1 -irmask 0x1f -expected-id 1
 
-set TARGETNAME $CHIPNAME.cpu
-target create $TARGETNAME mips_m4k -endian big -chain-position $TARGETNAME
+set _TARGETNAME $CHIPNAME.cpu
+target create $_TARGETNAME mips_m4k -endian big -chain-position $_TARGETNAME
 
 
-$TARGETNAME configure -event reset-halt-post {
+$_TARGETNAME configure -event reset-halt-post {
        #setup PLL to lowest common denominator 300/300/150 setting
        mww 0xb8050000 0x000f40a3       ;# reset val + CPU:3 DDR:3 AHB:0
        mww 0xb8050000 0x800f40a3       ;# send to PLL
        #setup PLL to lowest common denominator 300/300/150 setting
        mww 0xb8050000 0x000f40a3       ;# reset val + CPU:3 DDR:3 AHB:0
        mww 0xb8050000 0x800f40a3       ;# send to PLL
@@ -22,7 +22,7 @@ $TARGETNAME configure -event reset-halt-post {
        mww 0xb8050008 3                ;# set reset_switch and clock_switch (resets SoC)
 }
 
        mww 0xb8050008 3                ;# set reset_switch and clock_switch (resets SoC)
 }
 
-$TARGETNAME configure -event reset-init {
+$_TARGETNAME configure -event reset-init {
        #complete pll initialization
        mww 0xb8050000 0x800f0080       ;# set sw_update bit
        mww 0xb8050008 0                ;# clear reset_switch bit
        #complete pll initialization
        mww 0xb8050000 0x800f0080       ;# set sw_update bit
        mww 0xb8050008 0                ;# clear reset_switch bit
@@ -50,7 +50,7 @@ $TARGETNAME configure -event reset-init {
 }
 
 # setup working area somewhere in RAM
 }
 
 # setup working area somewhere in RAM
-$TARGETNAME configure -work-area-phys 0xa0600000 -work-area-size 0x20000
+$_TARGETNAME configure -work-area-phys 0xa0600000 -work-area-size 0x20000
 
 # serial SPI capable flash
 # flash bank <driver> <base> <size> <chip_width> <bus_width>
 
 # serial SPI capable flash
 # flash bank <driver> <base> <size> <chip_width> <bus_width>
index 17503c78fca9acb93631cd334a1bbec9f426c541..c5609bb1d35b2f62aa34caa565b69a4215d7cf71 100644 (file)
@@ -12,5 +12,5 @@ if { [info exists CPUTAPID] } {
 
 jtag newtap $_CHIPNAME cpu -irlen 5 -expected-id $_CPUTAPID
 
 
 jtag newtap $_CHIPNAME cpu -irlen 5 -expected-id $_CPUTAPID
 
-set TARGETNAME $_CHIPNAME.cpu
-target create $TARGETNAME mips_m4k -endian big -chain-position $TARGETNAME
+set _TARGETNAME $_CHIPNAME.cpu
+target create $_TARGETNAME mips_m4k -endian big -chain-position $_TARGETNAME

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)